106917 2013-01-15 09:52:20 -0800 [GTK] Fix build error on GTK due to r139665 2013-01-15 10:35:36 -0800 1 1 1 Unclassified WebKit ANGLE 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 michael webkit-unassigned dino mrobinson mvujovic webkit.review.bot oldest_to_newest 807390 0 michael 2013-01-15 09:52:20 -0800 Commit <http://svn.webkit.org/repository/webkit/trunk@139665> added the new files VariablePacker.cpp and VariablePacker.h but failed to add these files to Source/WebCore/GNUmakefile.list.am. WebKitGTK+ currently fails to build due to this omission. 807393 1 182795 michael 2013-01-15 09:55:21 -0800 Created attachment 182795 Patch 807396 2 182796 michael 2013-01-15 09:56:58 -0800 Created attachment 182796 Patch 807402 3 mvujovic 2013-01-15 10:01:28 -0800 Thanks for the fix! It looks good to me. Would you like to commit it? (As it's a build fix, I don't think you need a review from Dean.) 807442 4 182796 webkit.review.bot 2013-01-15 10:35:32 -0800 Comment on attachment 182796 Patch Clearing flags on attachment: 182796 Committed r139755: <http://trac.webkit.org/changeset/139755> 807443 5 webkit.review.bot 2013-01-15 10:35:36 -0800 All reviewed patches have been landed. Closing bug. 182795 2013-01-15 09:55:21 -0800 2013-01-15 09:56:58 -0800 Patch gtk-fix-build.patch text/plain 929 michael RnJvbTogTWljaGFlbCBQcnVldHQgPG1pY2hhZWxANjhrLm9yZz4KRGF0ZTogVHVlLCAxNSBKYW4g MjAxMyAwOTo0NTowMCAtMDgwMApTdWJqZWN0OiBbR1RLXSBGaXggYnVpbGQgYWZ0ZXIgcjEzOTY2 NQoKLS0tCiBTb3VyY2UvV2ViQ29yZS9HTlVtYWtlZmlsZS5saXN0LmFtIHwgICAgMiArKwogMSBm aWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L0dOVW1ha2VmaWxlLmxpc3QuYW0gYi9Tb3VyY2UvV2ViQ29yZS9HTlVtYWtlZmlsZS5saXN0LmFt CmluZGV4IGRhZDFmODUuLjZjODkxOGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0dOVW1h a2VmaWxlLmxpc3QuYW0KKysrIGIvU291cmNlL1dlYkNvcmUvR05VbWFrZWZpbGUubGlzdC5hbQpA QCAtNjM0OCw2ICs2MzQ4LDggQEAgd2ViY29yZV9zb3VyY2VzICs9IFwKIAlTb3VyY2UvVGhpcmRQ YXJ0eS9BTkdMRS9zcmMvY29tcGlsZXIvU2hIYW5kbGUuaCBcCiAJU291cmNlL1RoaXJkUGFydHkv QU5HTEUvc3JjL2NvbXBpbGVyL1N5bWJvbFRhYmxlLmNwcCBcCiAJU291cmNlL1RoaXJkUGFydHkv QU5HTEUvc3JjL2NvbXBpbGVyL1N5bWJvbFRhYmxlLmggXAorCVNvdXJjZS9UaGlyZFBhcnR5L0FO R0xFL3NyYy9jb21waWxlci9WYXJpYWJsZVBhY2tlci5jcHAgXAorCVNvdXJjZS9UaGlyZFBhcnR5 L0FOR0xFL3NyYy9jb21waWxlci9WYXJpYWJsZVBhY2tlci5oIFwKIAlTb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9zcmMvY29tcGlsZXIvVmVyc2lvbkdMU0wuY3BwIFwKIAlTb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9zcmMvY29tcGlsZXIvVmVyc2lvbkdMU0wuaCBcCiAJU291cmNlL1RoaXJkUGFydHkv QU5HTEUvc3JjL2NvbXBpbGVyL3RpbWluZy9SZXN0cmljdEZyYWdtZW50U2hhZGVyVGltaW5nLmNw cCBcCi0tIAoxLjcuOS41Cgo= 182796 2013-01-15 09:56:58 -0800 2013-01-15 10:35:32 -0800 Patch gtk-fix-build.patch text/plain 1509 michael RnJvbTogTWljaGFlbCBQcnVldHQgPG1pY2hhZWxANjhrLm9yZz4KRGF0ZTogVHVlLCAxNSBKYW4g MjAxMyAwOTo0NTowMCAtMDgwMApTdWJqZWN0OiBbR1RLXSBGaXggYnVpbGQgYWZ0ZXIgcjEzOTY2 NQoKLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgIHwgICAgOSArKysrKysr KysKIFNvdXJjZS9XZWJDb3JlL0dOVW1ha2VmaWxlLmxpc3QuYW0gfCAgICAyICsrCiAyIGZpbGVz IGNoYW5nZWQsIDExIGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWU5ZTQxNC4uNDgxMzEx OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEzLTAxLTE1ICBNaWNoYWVsIFBydWV0 dCAgPG1pY2hhZWxANjhrLm9yZz4KKworICAgICAgICBbR1RLXSBGaXggYnVpbGQgYWZ0ZXIgcjEz OTY2NQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA2 OTE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBH TlVtYWtlZmlsZS5saXN0LmFtOgorCiAyMDEzLTAxLTE0ICBNaWNoYWVsIFBydWV0dCAgPG1pY2hh ZWxANjhrLm9yZz4KIAogICAgICAgICBbSlNDXSBJbmRleGVkREI6IERlYWN0aXZhdGUgbmV3IHRy YW5zYWN0aW9ucyB3aGVuIGV4aXRpbmcgc2NyaXB0IGNvbnRleHRzCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9HTlVtYWtlZmlsZS5saXN0LmFtIGIvU291cmNlL1dlYkNvcmUvR05VbWFrZWZp bGUubGlzdC5hbQppbmRleCBkYWQxZjg1Li42Yzg5MThhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9HTlVtYWtlZmlsZS5saXN0LmFtCisrKyBiL1NvdXJjZS9XZWJDb3JlL0dOVW1ha2VmaWxl Lmxpc3QuYW0KQEAgLTYzNDgsNiArNjM0OCw4IEBAIHdlYmNvcmVfc291cmNlcyArPSBcCiAJU291 cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2NvbXBpbGVyL1NoSGFuZGxlLmggXAogCVNvdXJjZS9U aGlyZFBhcnR5L0FOR0xFL3NyYy9jb21waWxlci9TeW1ib2xUYWJsZS5jcHAgXAogCVNvdXJjZS9U aGlyZFBhcnR5L0FOR0xFL3NyYy9jb21waWxlci9TeW1ib2xUYWJsZS5oIFwKKwlTb3VyY2UvVGhp cmRQYXJ0eS9BTkdMRS9zcmMvY29tcGlsZXIvVmFyaWFibGVQYWNrZXIuY3BwIFwKKwlTb3VyY2Uv VGhpcmRQYXJ0eS9BTkdMRS9zcmMvY29tcGlsZXIvVmFyaWFibGVQYWNrZXIuaCBcCiAJU291cmNl L1RoaXJkUGFydHkvQU5HTEUvc3JjL2NvbXBpbGVyL1ZlcnNpb25HTFNMLmNwcCBcCiAJU291cmNl L1RoaXJkUGFydHkvQU5HTEUvc3JjL2NvbXBpbGVyL1ZlcnNpb25HTFNMLmggXAogCVNvdXJjZS9U aGlyZFBhcnR5L0FOR0xFL3NyYy9jb21waWxlci90aW1pbmcvUmVzdHJpY3RGcmFnbWVudFNoYWRl clRpbWluZy5jcHAgXAotLSAKMS43LjkuNQoK