106888 2013-01-15 04:02:49 -0800 Fullscreen element should not share styles with its siblings 2013-01-15 20:12:43 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 charles.wei charles.wei allan.jensen cmarcelo jer.noble kling koivisto macpherson menard mfeil ojan.autocc rwlbuis staikos webkit.review.bot oldest_to_newest 807174 0 charles.wei 2013-01-15 04:02:49 -0800 We try to share RenderStyle for elements with it's siblings if they have the same style. But We should not share styles if the element is in fullscreen mode. 807175 1 182734 charles.wei 2013-01-15 04:05:28 -0800 Created attachment 182734 Patch 807924 2 182734 staikos 2013-01-15 18:56:38 -0800 Comment on attachment 182734 Patch Verified correct. Review interface seems to truncate the testcase but saw the patch and it looks fine. 807930 3 182734 webkit.review.bot 2013-01-15 19:04:23 -0800 Comment on attachment 182734 Patch Clearing flags on attachment: 182734 Committed r139824: <http://trac.webkit.org/changeset/139824> 807931 4 webkit.review.bot 2013-01-15 19:04:27 -0800 All reviewed patches have been landed. Closing bug. 807999 5 182734 simon.fraser 2013-01-15 20:12:43 -0800 Comment on attachment 182734 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182734&action=review > Source/WebCore/ChangeLog:6 > + https://bugs.webkit.org/show_bug.cgi?id=106888 > + > + Reviewed by NOBODY (OOPS!). This is missing an explanation of the bug and what you did to fix it. 182734 2013-01-15 04:05:28 -0800 2013-01-15 20:12:43 -0800 Patch bug-106888-20130115201729.patch text/plain 3673 charles.wei U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5NzE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWVlMGI1NDNkMjQ4MWNj ZTc2ZmMwNTE4NDBlMTBmYjhmZjVkMDU3YS4uNDFlNDdmYmY0MjFmMjg2OGE3NGExM2NhZTVlNWMx ZTllOWRkMGM4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAxLTE1ICBDaGFy bGVzIFdlaSAgPGNoYXJsZXMud2VpQHRvcmNobW9iaWxlLmNvbS5jbj4KKworICAgICAgICBGdWxs c2NyZWVuIGVsZW1lbnQgc2hvdWxkIG5vdCBzaGFyZSBzdHlsZXMgd2l0aCBpdCdzIHNpYmxpbmdz LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA2ODg4 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdDog ZnVsbHNjcmVlbi9mdWxsLXNjcmVlbi1uby1zdHlsZS1zaGFyaW5nLmh0bWwKKworICAgICAgICAq IGNzcy9TdHlsZVJlc29sdmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlN0eWxlUmVzb2x2ZXI6 OmNhblNoYXJlU3R5bGVXaXRoRWxlbWVudCk6CisKIDIwMTMtMDEtMTQgIERpbWEgR29yYmlrICA8 ZGdvcmJpa0BhcHBsZS5jb20+CiAKICAgICAgICAgSW1wbGVtZW50IElEIHNlbGVjdG9yIG1hdGNo aW5nIGZvciB0aGUgV2ViVlRUIDo6Y3VlIHBzZXVkbyBlbGVtZW50CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5 bGVSZXNvbHZlci5jcHAKaW5kZXggNTBhZDYxNmZkOGQ5OTk3NmQwODdiMzQyYWRiODg0MDJiYzM3 ZWVjZC4uNDc1MzUyOGZmNDkzMzExOWRiNGU3NzhhODQ3NTY4MDkwZGFjMDg1NyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVzb2x2ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2Nzcy9TdHlsZVJlc29sdmVyLmNwcApAQCAtMTI0NSw2ICsxMjQ1LDEwIEBAIGJvb2wgU3R5 bGVSZXNvbHZlcjo6Y2FuU2hhcmVTdHlsZVdpdGhFbGVtZW50KFN0eWxlZEVsZW1lbnQqIGVsZW1l bnQpIGNvbnN0CiAgICAgICAgIHJldHVybiBmYWxzZTsKICNlbmRpZgogCisjaWYgRU5BQkxFKEZV TExTQ1JFRU5fQVBJKQorICAgIGlmIChlbGVtZW50ID09IGVsZW1lbnQtPmRvY3VtZW50KCktPndl YmtpdEN1cnJlbnRGdWxsU2NyZWVuRWxlbWVudCgpIHx8IG1fZWxlbWVudCA9PSBtX2VsZW1lbnQt PmRvY3VtZW50KCktPndlYmtpdEN1cnJlbnRGdWxsU2NyZWVuRWxlbWVudCgpKQorICAgICAgICBy ZXR1cm4gZmFsc2U7CisjZW5kaWYKICAgICByZXR1cm4gdHJ1ZTsKIH0KIApkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDhhMTI1 OTljOThmZmU3Mzk3ZWE2MTZhYWVmODM0MDJlZTBmNGE0YzAuLjFhMTM0NTJkNjcwZTYwMTM5NzNm N2M3NGRiMDcxYjczNjcyYmFkYzIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZwor KysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMy0wMS0xNSAg Q2hhcmxlcyBXZWkgIDxjaGFybGVzLndlaUB0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAg RnVsbHNjcmVlbiBlbGVtZW50IHNob3VsZCBub3Qgc2hhcmUgc3R5bGVzIHdpdGggaXQncyBzaWJs aW5ncy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw Njg4OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog ZnVsbHNjcmVlbi9mdWxsLXNjcmVlbi1uby1zdHlsZS1zaGFyaW5nLWV4cGVjdGVkLnR4dDogQWRk ZWQuCisgICAgICAgICogZnVsbHNjcmVlbi9mdWxsLXNjcmVlbi1uby1zdHlsZS1zaGFyaW5nLmh0 bWw6IEFkZGVkLgorCiAyMDEzLTAxLTE0ICBEb21pbmljIENvb25leSAgPGRvbWluaWNjQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBbQ2hyb21pdW1dIFVucmV2aWV3ZWQgZ2FyZGVuaW5nLgpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvZnVsbHNjcmVlbi9mdWxsLXNjcmVlbi1uby1zdHlsZS1zaGFy aW5nLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Z1bGxzY3JlZW4vZnVsbC1zY3JlZW4tbm8t c3R5bGUtc2hhcmluZy1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMTUzOTk2MGFjZmZjZmI5NGU4 NmI4NzUzMTdmNzVjZDA1M2YzM2MzOAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Z1 bGxzY3JlZW4vZnVsbC1zY3JlZW4tbm8tc3R5bGUtc2hhcmluZy1leHBlY3RlZC50eHQKQEAgLTAs MCArMSwzIEBACitFVkVOVCh3ZWJraXRmdWxsc2NyZWVuY2hhbmdlKSBURVNUKHZpZGVvMi5jbGll bnRXaWR0aD09ZG9jdW1lbnQuYm9keS5jbGllbnRXaWR0aCkgT0sKK0VORCBPRiBURVNUCisKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2Z1bGxzY3JlZW4vZnVsbC1zY3JlZW4tbm8tc3R5bGUtc2hh cmluZy5odG1sIGIvTGF5b3V0VGVzdHMvZnVsbHNjcmVlbi9mdWxsLXNjcmVlbi1uby1zdHlsZS1z aGFyaW5nLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZmJlZmJiZjI5Mjc5NTNkMTM0ZjgyNzA2NmE4NzI5NWZl ZTJhOTVkMAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Z1bGxzY3JlZW4vZnVsbC1z Y3JlZW4tbm8tc3R5bGUtc2hhcmluZy5odG1sCkBAIC0wLDAgKzEsMTcgQEAKKzxib2R5PgorICAg IDx2aWRlbyBpZD0idmlkZW8xIiB3aWR0aD0iMSI+PC92aWRlbz4KKyAgICA8dmlkZW8gaWQ9InZp ZGVvMiIgd2lkdGg9IjEiPjwvdmlkZW8+CisgICAgPHNjcmlwdCBzcmM9ImZ1bGwtc2NyZWVuLXRl c3QuanMiPjwvc2NyaXB0PgorICAgIDxzY3JpcHQgc3JjPS4uL21lZGlhL21lZGlhLWZpbGUuanM+ PC9zY3JpcHQ+CisgICAgPHNjcmlwdD4KKyAgICAgICAgdmFyIHZpZGVvMiA9IGRvY3VtZW50Lmdl dEVsZW1lbnRCeUlkKCd2aWRlbzInKTsKKyAgICAgICAgLy8gQmFpbCBvdXQgZWFybHkgaWYgdGhl IGZ1bGwgc2NyZWVuIEFQSSBpcyBub3QgZW5hYmxlZCBvciBpcyBtaXNzaW5nOgorICAgICAgICBp ZiAoRWxlbWVudC5wcm90b3R5cGUud2Via2l0UmVxdWVzdEZ1bGxTY3JlZW4gPT0gdW5kZWZpbmVk KSB7CisgICAgICAgICAgICBsb2dSZXN1bHQoZmFsc2UsICJFbGVtZW50LnByb3RvdHlwZS53ZWJr aXRSZXF1ZXN0RnVsbFNjcmVlbiA9PSB1bmRlZmluZWQiKTsKKyAgICAgICAgICAgIGVuZFRlc3Qo KTsKKyAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgIHdhaXRGb3JFdmVudFRlc3RBbmRFbmQo ZG9jdW1lbnQsICd3ZWJraXRmdWxsc2NyZWVuY2hhbmdlJywgInZpZGVvMi5jbGllbnRXaWR0aD09 ZG9jdW1lbnQuYm9keS5jbGllbnRXaWR0aCIpOworICAgICAgICAgICAgcnVuV2l0aEtleURvd24o ZnVuY3Rpb24oKXt2aWRlbzIud2Via2l0UmVxdWVzdEZ1bGxTY3JlZW4oKX0pOworICAgICAgICB9 CisgICAgPC9zY3JpcHQ+Cis8L2JvZHk+Cg==