106887 2013-01-15 03:44:33 -0800 [CSS] Rename the enum, from "ETextAlignLast" to "TextAlignLast" 2013-01-15 05:33:19 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dw.im dw.im cmarcelo eric jchaffraix macpherson menard ojan.autocc webkit.review.bot oldest_to_newest 807169 0 dw.im 2013-01-15 03:44:33 -0800 Regarding the discussion with Julien and Alexis, I want to rename the enum, ETextAlignLast. - https://bugs.webkit.org/show_bug.cgi?id=100058#c5, - https://bugs.webkit.org/show_bug.cgi?id=100058#c13, 807193 1 182738 dw.im 2013-01-15 04:43:04 -0800 Created attachment 182738 Patch 807203 2 182738 menard 2013-01-15 04:58:32 -0800 Comment on attachment 182738 Patch LGTM 807206 3 dw.im 2013-01-15 05:04:17 -0800 (In reply to comment #2) > (From update of attachment 182738 [details]) > LGTM Thanks for the review. 807213 4 182738 webkit.review.bot 2013-01-15 05:33:16 -0800 Comment on attachment 182738 Patch Clearing flags on attachment: 182738 Committed r139734: <http://trac.webkit.org/changeset/139734> 807214 5 webkit.review.bot 2013-01-15 05:33:19 -0800 All reviewed patches have been landed. Closing bug. 182738 2013-01-15 04:43:04 -0800 2013-01-15 05:33:16 -0800 Patch bug-106887-20130115144007.patch text/plain 7021 dw.im U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5NzMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTNiODU3NWFlM2I5MTI5 ZDc3NWQ2ODgwYzU0MjVlOGViNmNjNTRmZi4uZGU3OTJiODA2NjRhNjg1ZTIyMmQ2NmNmNjNkM2Zk OTU2MmYzNzY4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTAxLTE1ICBEb25n d29vIEpvc2h1YSBJbSAgPGR3LmltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtDU1NdIFJlbmFt ZSB0aGUgZW51bSwgZnJvbSAiRVRleHRBbGlnbkxhc3QiIHRvICJUZXh0QWxpZ25MYXN0IgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA2ODg3CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3Rz IGFyZSBhZGRlZCBzaW5jZSB0aGVyZSBpcyBubyBiZWhhdmlvciBjaGFuZ2VzLgorCisgICAgICAg ICogY3NzL0NTU1ByaW1pdGl2ZVZhbHVlTWFwcGluZ3MuaDoKKyAgICAgICAgKFdlYkNvcmU6OkNT U1ByaW1pdGl2ZVZhbHVlOjpDU1NQcmltaXRpdmVWYWx1ZSk6CisgICAgICAgIChXZWJDb3JlOjpD U1NQcmltaXRpdmVWYWx1ZTo6b3BlcmF0b3IgVGV4dEFsaWduTGFzdCk6CisgICAgICAgICogY3Nz L1N0eWxlQnVpbGRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTdHlsZUJ1aWxkZXI6OlN0eWxl QnVpbGRlcik6CisgICAgICAgICogcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlLmg6CisgICAg ICAgICogcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlQ29uc3RhbnRzLmg6CisgICAgICAgICog cmVuZGVyaW5nL3N0eWxlL1N0eWxlUmFyZUluaGVyaXRlZERhdGEuaDoKKyAgICAgICAgKFN0eWxl UmFyZUluaGVyaXRlZERhdGEpOgorCiAyMDEzLTAxLTE1ICBUb21teSBXaWRlbmZseWNodCAgPHRv bW15d0Bnb29nbGUuY29tPgogCiAgICAgICAgIE1lZGlhU3RyZWFtIEFQSTogRml4aW5nIGNyYXNo aW5nIGJ1ZyBpbiBNZWRpYVN0cmVhbQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NT U1ByaW1pdGl2ZVZhbHVlTWFwcGluZ3MuaCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcmltaXRp dmVWYWx1ZU1hcHBpbmdzLmgKaW5kZXggZmVhM2Y2ZDEwMjQxZGUzY2Y1ZmViOWNkZThlNDZhNGU5 ZmFiODkxZi4uMmY2ZjhkOGMzNWM3OWJkY2I2MDEwYmFmMTE1NmMxODBjNTI0NmQwYyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ByaW1pdGl2ZVZhbHVlTWFwcGluZ3MuaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUHJpbWl0aXZlVmFsdWVNYXBwaW5ncy5oCkBAIC0yMjM4 LDcgKzIyMzgsNyBAQCB0ZW1wbGF0ZTw+IGlubGluZSBDU1NQcmltaXRpdmVWYWx1ZTo6b3BlcmF0 b3IgRVRleHRBbGlnbigpIGNvbnN0CiB9CiAKICNpZiBFTkFCTEUoQ1NTM19URVhUKQotdGVtcGxh dGU8PiBpbmxpbmUgQ1NTUHJpbWl0aXZlVmFsdWU6OkNTU1ByaW1pdGl2ZVZhbHVlKEVUZXh0QWxp Z25MYXN0IGUpCit0ZW1wbGF0ZTw+IGlubGluZSBDU1NQcmltaXRpdmVWYWx1ZTo6Q1NTUHJpbWl0 aXZlVmFsdWUoVGV4dEFsaWduTGFzdCBlKQogICAgIDogQ1NTVmFsdWUoUHJpbWl0aXZlQ2xhc3Mp CiB7CiAgICAgbV9wcmltaXRpdmVVbml0VHlwZSA9IENTU19JREVOVDsKQEAgLTIyNjcsNyArMjI2 Nyw3IEBAIHRlbXBsYXRlPD4gaW5saW5lIENTU1ByaW1pdGl2ZVZhbHVlOjpDU1NQcmltaXRpdmVW YWx1ZShFVGV4dEFsaWduTGFzdCBlKQogICAgIH0KIH0KIAotdGVtcGxhdGU8PiBpbmxpbmUgQ1NT UHJpbWl0aXZlVmFsdWU6Om9wZXJhdG9yIEVUZXh0QWxpZ25MYXN0KCkgY29uc3QKK3RlbXBsYXRl PD4gaW5saW5lIENTU1ByaW1pdGl2ZVZhbHVlOjpvcGVyYXRvciBUZXh0QWxpZ25MYXN0KCkgY29u c3QKIHsKICAgICBzd2l0Y2ggKG1fdmFsdWUuaWRlbnQpIHsKICAgICBjYXNlIENTU1ZhbHVlQXV0 bzoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZUJ1aWxkZXIuY3BwIGIvU291 cmNlL1dlYkNvcmUvY3NzL1N0eWxlQnVpbGRlci5jcHAKaW5kZXggZWNlOGMyMmEzNWE4MDZkNTJm YThkZGQwNGQ0YmZlNjQ2MDUxYjlhNS4uMzQ0YTg1ZWJjNDU3NjU4OGM0YzdiY2U4ZGZkYWZjMjBh NTFlZmI1YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlQnVpbGRlci5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlQnVpbGRlci5jcHAKQEAgLTE5MjIsNyArMTky Miw3IEBAIFN0eWxlQnVpbGRlcjo6U3R5bGVCdWlsZGVyKCkKICNpZiBFTkFCTEUoQ1NTM19URVhU KQogICAgIHNldFByb3BlcnR5SGFuZGxlcihDU1NQcm9wZXJ0eVdlYmtpdFRleHREZWNvcmF0aW9u TGluZSwgQXBwbHlQcm9wZXJ0eVRleHREZWNvcmF0aW9uOjpjcmVhdGVIYW5kbGVyKCkpOwogICAg IHNldFByb3BlcnR5SGFuZGxlcihDU1NQcm9wZXJ0eVdlYmtpdFRleHREZWNvcmF0aW9uU3R5bGUs IEFwcGx5UHJvcGVydHlEZWZhdWx0PFRleHREZWNvcmF0aW9uU3R5bGUsICZSZW5kZXJTdHlsZTo6 dGV4dERlY29yYXRpb25TdHlsZSwgVGV4dERlY29yYXRpb25TdHlsZSwgJlJlbmRlclN0eWxlOjpz ZXRUZXh0RGVjb3JhdGlvblN0eWxlLCBUZXh0RGVjb3JhdGlvblN0eWxlLCAmUmVuZGVyU3R5bGU6 OmluaXRpYWxUZXh0RGVjb3JhdGlvblN0eWxlPjo6Y3JlYXRlSGFuZGxlcigpKTsKLSAgICBzZXRQ cm9wZXJ0eUhhbmRsZXIoQ1NTUHJvcGVydHlXZWJraXRUZXh0QWxpZ25MYXN0LCBBcHBseVByb3Bl cnR5RGVmYXVsdDxFVGV4dEFsaWduTGFzdCwgJlJlbmRlclN0eWxlOjp0ZXh0QWxpZ25MYXN0LCBF VGV4dEFsaWduTGFzdCwgJlJlbmRlclN0eWxlOjpzZXRUZXh0QWxpZ25MYXN0LCBFVGV4dEFsaWdu TGFzdCwgJlJlbmRlclN0eWxlOjppbml0aWFsVGV4dEFsaWduTGFzdD46OmNyZWF0ZUhhbmRsZXIo KSk7CisgICAgc2V0UHJvcGVydHlIYW5kbGVyKENTU1Byb3BlcnR5V2Via2l0VGV4dEFsaWduTGFz dCwgQXBwbHlQcm9wZXJ0eURlZmF1bHQ8VGV4dEFsaWduTGFzdCwgJlJlbmRlclN0eWxlOjp0ZXh0 QWxpZ25MYXN0LCBUZXh0QWxpZ25MYXN0LCAmUmVuZGVyU3R5bGU6OnNldFRleHRBbGlnbkxhc3Qs IFRleHRBbGlnbkxhc3QsICZSZW5kZXJTdHlsZTo6aW5pdGlhbFRleHRBbGlnbkxhc3Q+OjpjcmVh dGVIYW5kbGVyKCkpOwogI2VuZGlmIC8vIENTUzNfVEVYVAogICAgIHNldFByb3BlcnR5SGFuZGxl cihDU1NQcm9wZXJ0eVRleHRJbmRlbnQsIEFwcGx5UHJvcGVydHlMZW5ndGg8JlJlbmRlclN0eWxl Ojp0ZXh0SW5kZW50LCAmUmVuZGVyU3R5bGU6OnNldFRleHRJbmRlbnQsICZSZW5kZXJTdHlsZTo6 aW5pdGlhbFRleHRJbmRlbnQ+OjpjcmVhdGVIYW5kbGVyKCkpOwogICAgIHNldFByb3BlcnR5SGFu ZGxlcihDU1NQcm9wZXJ0eVRleHRPdmVyZmxvdywgQXBwbHlQcm9wZXJ0eURlZmF1bHQ8VGV4dE92 ZXJmbG93LCAmUmVuZGVyU3R5bGU6OnRleHRPdmVyZmxvdywgVGV4dE92ZXJmbG93LCAmUmVuZGVy U3R5bGU6OnNldFRleHRPdmVyZmxvdywgVGV4dE92ZXJmbG93LCAmUmVuZGVyU3R5bGU6OmluaXRp YWxUZXh0T3ZlcmZsb3c+OjpjcmVhdGVIYW5kbGVyKCkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuaAppbmRleCBjZTk0ZjJmYTI2MGJmZTBiZjQ1NGJlMDMz YTUxOGUxMGZkMGQzNTg5Li44MTg4MDgxNTkwYWRiMGUwOTYxMTZjZmMyYTE2YzdkZmEyYzEwN2Ji IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUu aAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuaApAQCAt NTYzLDcgKzU2Myw3IEBAIHB1YmxpYzoKICAgICBFVGV4dERlY29yYXRpb24gdGV4dERlY29yYXRp b24oKSBjb25zdCB7IHJldHVybiBzdGF0aWNfY2FzdDxFVGV4dERlY29yYXRpb24+KHZpc3VhbC0+ dGV4dERlY29yYXRpb24pOyB9CiAjaWYgRU5BQkxFKENTUzNfVEVYVCkKICAgICBUZXh0RGVjb3Jh dGlvblN0eWxlIHRleHREZWNvcmF0aW9uU3R5bGUoKSBjb25zdCB7IHJldHVybiBzdGF0aWNfY2Fz dDxUZXh0RGVjb3JhdGlvblN0eWxlPihyYXJlTm9uSW5oZXJpdGVkRGF0YS0+bV90ZXh0RGVjb3Jh dGlvblN0eWxlKTsgfQotICAgIEVUZXh0QWxpZ25MYXN0IHRleHRBbGlnbkxhc3QoKSBjb25zdCB7 IHJldHVybiBzdGF0aWNfY2FzdDxFVGV4dEFsaWduTGFzdD4ocmFyZUluaGVyaXRlZERhdGEtPm1f dGV4dEFsaWduTGFzdCk7IH0KKyAgICBUZXh0QWxpZ25MYXN0IHRleHRBbGlnbkxhc3QoKSBjb25z dCB7IHJldHVybiBzdGF0aWNfY2FzdDxUZXh0QWxpZ25MYXN0PihyYXJlSW5oZXJpdGVkRGF0YS0+ bV90ZXh0QWxpZ25MYXN0KTsgfQogI2Vsc2UKICAgICBUZXh0RGVjb3JhdGlvblN0eWxlIHRleHRE ZWNvcmF0aW9uU3R5bGUoKSBjb25zdCB7IHJldHVybiBUZXh0RGVjb3JhdGlvblN0eWxlU29saWQ7 IH0KICNlbmRpZiAvLyBDU1MzX1RFWFQKQEAgLTExMDIsNyArMTEwMiw3IEBAIHB1YmxpYzoKICAg ICB2b2lkIHNldFRleHREZWNvcmF0aW9uKEVUZXh0RGVjb3JhdGlvbiB2KSB7IFNFVF9WQVIodmlz dWFsLCB0ZXh0RGVjb3JhdGlvbiwgdik7IH0KICNpZiBFTkFCTEUoQ1NTM19URVhUKQogICAgIHZv aWQgc2V0VGV4dERlY29yYXRpb25TdHlsZShUZXh0RGVjb3JhdGlvblN0eWxlIHYpIHsgU0VUX1ZB UihyYXJlTm9uSW5oZXJpdGVkRGF0YSwgbV90ZXh0RGVjb3JhdGlvblN0eWxlLCB2KTsgfQotICAg IHZvaWQgc2V0VGV4dEFsaWduTGFzdChFVGV4dEFsaWduTGFzdCB2KSB7IFNFVF9WQVIocmFyZUlu aGVyaXRlZERhdGEsIG1fdGV4dEFsaWduTGFzdCwgdik7IH0KKyAgICB2b2lkIHNldFRleHRBbGln bkxhc3QoVGV4dEFsaWduTGFzdCB2KSB7IFNFVF9WQVIocmFyZUluaGVyaXRlZERhdGEsIG1fdGV4 dEFsaWduTGFzdCwgdik7IH0KICNlbmRpZiAvLyBDU1MzX1RFWFQKICAgICB2b2lkIHNldERpcmVj dGlvbihUZXh0RGlyZWN0aW9uIHYpIHsgaW5oZXJpdGVkX2ZsYWdzLl9kaXJlY3Rpb24gPSB2OyB9 CiAgICAgdm9pZCBzZXRMaW5lSGVpZ2h0KExlbmd0aCBzcGVjaWZpZWRMaW5lSGVpZ2h0KTsKQEAg LTE1NjAsNyArMTU2MCw3IEBAIHB1YmxpYzoKICAgICBzdGF0aWMgRVRleHREZWNvcmF0aW9uIGlu aXRpYWxUZXh0RGVjb3JhdGlvbigpIHsgcmV0dXJuIFRETk9ORTsgfQogI2lmIEVOQUJMRShDU1Mz X1RFWFQpCiAgICAgc3RhdGljIFRleHREZWNvcmF0aW9uU3R5bGUgaW5pdGlhbFRleHREZWNvcmF0 aW9uU3R5bGUoKSB7IHJldHVybiBUZXh0RGVjb3JhdGlvblN0eWxlU29saWQ7IH0KLSAgICBzdGF0 aWMgRVRleHRBbGlnbkxhc3QgaW5pdGlhbFRleHRBbGlnbkxhc3QoKSB7IHJldHVybiBUZXh0QWxp Z25MYXN0QXV0bzsgfQorICAgIHN0YXRpYyBUZXh0QWxpZ25MYXN0IGluaXRpYWxUZXh0QWxpZ25M YXN0KCkgeyByZXR1cm4gVGV4dEFsaWduTGFzdEF1dG87IH0KICNlbmRpZiAvLyBDU1MzX1RFWFQK ICAgICBzdGF0aWMgZmxvYXQgaW5pdGlhbFpvb20oKSB7IHJldHVybiAxLjBmOyB9CiAgICAgc3Rh dGljIGludCBpbml0aWFsT3V0bGluZU9mZnNldCgpIHsgcmV0dXJuIDA7IH0KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9SZW5kZXJTdHlsZUNvbnN0YW50cy5oIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlQ29uc3RhbnRzLmgKaW5k ZXggZmYwMGM5NTAyNzhjMzMyMDFjMGFmOTJkOGFiNjU5N2U4ZWM5N2ZmNS4uZTdjMTA4ZjQ4MmIy ZTNjMTk4NWRkYTliZDA3MDcwOGY3OTk5MjJkYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlQ29uc3RhbnRzLmgKKysrIGIvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlQ29uc3RhbnRzLmgKQEAgLTM1NSw3ICszNTUs NyBAQCBlbnVtIFRleHREZWNvcmF0aW9uU3R5bGUgewogfTsKIAogI2lmIEVOQUJMRShDU1MzX1RF WFQpCi1lbnVtIEVUZXh0QWxpZ25MYXN0IHsKK2VudW0gVGV4dEFsaWduTGFzdCB7CiAgICAgVGV4 dEFsaWduTGFzdEF1dG8sIFRleHRBbGlnbkxhc3RTdGFydCwgVGV4dEFsaWduTGFzdEVuZCwgVGV4 dEFsaWduTGFzdExlZnQsIFRleHRBbGlnbkxhc3RSaWdodCwgVGV4dEFsaWduTGFzdENlbnRlciwg VGV4dEFsaWduTGFzdEp1c3RpZnkKIH07CiAjZW5kaWYgLy8gQ1NTM19URVhUCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvU3R5bGVSYXJlSW5oZXJpdGVkRGF0YS5o IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1N0eWxlUmFyZUluaGVyaXRlZERhdGEu aAppbmRleCBlM2I4YjEzZWFlMTA2MjE3ZmQxMjZlZDU0MmZjYzBmYjE3MmQ1Njk2Li5iMjI4MWY3 NzI5NzA3ZjdjMTNiNDU5OWFhNzZkZjBiNTllOWU3M2FjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvc3R5bGUvU3R5bGVSYXJlSW5oZXJpdGVkRGF0YS5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9TdHlsZVJhcmVJbmhlcml0ZWREYXRhLmgKQEAgLTEx Nyw3ICsxMTcsNyBAQCBwdWJsaWM6CiAgICAgdW5zaWduZWQgbV9pbWFnZVJlc29sdXRpb25TbmFw IDogMTsgLy8gSW1hZ2VSZXNvbHV0aW9uU25hcAogI2VuZGlmCiAjaWYgRU5BQkxFKENTUzNfVEVY VCkKLSAgICB1bnNpZ25lZCBtX3RleHRBbGlnbkxhc3QgOiAzOyAvLyBFVGV4dEFsaWduTGFzdAor ICAgIHVuc2lnbmVkIG1fdGV4dEFsaWduTGFzdCA6IDM7IC8vIFRleHRBbGlnbkxhc3QKICNlbmRp ZiAvLyBDU1MzX1RFWFQKICAgICB1bnNpZ25lZCBtX3J1YnlQb3NpdGlvbiA6IDE7IC8vIFJ1YnlQ b3NpdGlvbgogCg==