106884 2013-01-15 01:22:09 -0800 [CoordinatedGraphics] Deadlock when running abspos-child-container-changes-from-relative-to-static.html 2017-04-27 00:33:20 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified REOPENED P2 Normal --- 107442 107443 1 d-r webkit-unassigned andersca benjamin cdumez cmarcelo dglazkov jturcotte kalyan.kondapally kenneth laszlo.gombos mikhail.pozdnyakov noam ostap73 rafael.lobo sam tmpsantos webkit.review.bot yael zeno oldest_to_newest 807101 0 d-r 2013-01-15 01:22:09 -0800 When running $ run-webkit-tests -2 --efl --release fast/block on my Ubuntu 12.04 Installation, on a Dell XPS 3800 with GL configuration as follows: OpenGL vendor string: Intel Open Source Technology Center OpenGL renderer string: Mesa DRI Intel(R) Sandybridge Desktop OpenGL version string: 3.0 Mesa 9.0 OpenGL shading language version string: 1.30 Tests start to stall after about 8 seconds, or 320 test cases. And I start to see "Timed out waiting for repaint" in the test runner dumps of the single runs. 807115 1 d-r 2013-01-15 01:43:04 -0800 I should mention, this is with subpixel layout enabled. Will try without. 807181 2 d-r 2013-01-15 04:19:27 -0800 (In reply to comment #1) > I should mention, this is with subpixel layout enabled. Will try without. That doesn't make a difference, current trunk shows the same issues, in Debug as well as Release. That's on an Ubuntu 12.10 64bit system. 807204 3 d-r 2013-01-15 05:02:53 -0800 Mhm, much easier, just: $ run-webkit-tests -2 --efl --debug fast/block/abspos-child-container-changes-from-relative-to-static.html fails to repaint for me. 807219 4 d-r 2013-01-15 05:52:53 -0800 When running fast/block/abspos-child-container-changes-from-relative-to-static.html WebKitTestRunner forces a repaint on the WebProcess but we end up in a deadlock and WTR detects a repaint failure in dumpPixelsAndCompareWithExpected. As far as I can see it, this happens because, first CoordinatedLayerTreeHost::forceRepaintAsync is called, which then calls scheduleLayerFlush() - after this timer fires: performScheduledLayerFlush() is called, but here: m_waitingForUIProcess is true and the method returns early, while the UIProcess is waiting for the WebProcess. 807236 5 182751 d-r 2013-01-15 06:18:04 -0800 Created attachment 182751 Patch 807238 6 cdumez 2013-01-15 06:25:22 -0800 FYI, I could not reproduce the issue on my machine. I tried: Tools/Scripts/run-webkit-tests --debug --efl -2 fast/block/abspos-child-container-changes-from-relative-to-static.html 807240 7 d-r 2013-01-15 06:29:30 -0800 (In reply to comment #6) > FYI, I could not reproduce the issue on my machine. I tried: > Tools/Scripts/run-webkit-tests --debug --efl -2 fast/block/abspos-child-container-changes-from-relative-to-static.html It was 100% reproducible on my machine - maybe timing differences in Ubuntu 12.10 vs. 12.04. 807243 8 cdumez 2013-01-15 06:31:29 -0800 I think we should use [CoordinatedGraphics] tag instead of [EFL]. Otherwise, the patch makes sense to me. 807245 9 182755 d-r 2013-01-15 06:38:57 -0800 Created attachment 182755 Patch v2, updated bug title. 807286 10 182755 noam 2013-01-15 07:41:13 -0800 Comment on attachment 182755 Patch v2, updated bug title. This is fine with me but I don't get to review patches in WebKit2 anymore. Please find a WebKit2 owner. 807293 11 182772 d-r 2013-01-15 07:44:32 -0800 Created attachment 182772 Patch v3, grammar in ChangeLog fixed. 807313 12 tmpsantos 2013-01-15 08:04:45 -0800 (In reply to comment #10) > (From update of attachment 182755 [details]) > This is fine with me but I don't get to review patches in WebKit2 anymore. Please find a WebKit2 owner. Doesn't it fit into the "trivial" category? http://lists.webkit.org/pipermail/webkit-dev/2013-January/023263.html 807337 13 182772 webkit.review.bot 2013-01-15 08:34:51 -0800 Comment on attachment 182772 Patch v3, grammar in ChangeLog fixed. Attachment 182772 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15841996 New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html 807339 14 d-r 2013-01-15 08:40:06 -0800 (In reply to comment #13) > (From update of attachment 182772 [details]) > Attachment 182772 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/15841996 > > New failing tests: > inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html I think that's an artifact, I am changing WebKit2 code that's not run by Chromium tests and the previous two EWS runs showed green. 807627 15 182772 benjamin 2013-01-15 13:15:43 -0800 Comment on attachment 182772 Patch v3, grammar in ChangeLog fixed. Sure, if No'am says okay :) 807631 16 d-r 2013-01-15 13:21:21 -0800 (In reply to comment #15) > (From update of attachment 182772 [details]) > Sure, if No'am says okay :) Thanks, Benjamin. 807650 17 182772 webkit.review.bot 2013-01-15 13:41:53 -0800 Comment on attachment 182772 Patch v3, grammar in ChangeLog fixed. Clearing flags on attachment: 182772 Committed r139781: <http://trac.webkit.org/changeset/139781> 807651 18 webkit.review.bot 2013-01-15 13:41:59 -0800 All reviewed patches have been landed. Closing bug. 808343 19 d-r 2013-01-16 06:47:15 -0800 I still needed http://cgit.freedesktop.org/xorg/xserver/patch/?id=65642ccb78aa2d4c4e17b9ac42e4ef625c4a6e8b to my xvfb package in order to be able to generate pixel results. 808348 20 cdumez 2013-01-16 06:56:43 -0800 (In reply to comment #19) > I still needed http://cgit.freedesktop.org/xorg/xserver/patch/?id=65642ccb78aa2d4c4e17b9ac42e4ef625c4a6e8b to my xvfb package in order to be able to generate pixel results. Has this bug been reported against Ubuntu so that they consider applying the patch to their package? 808353 21 d-r 2013-01-16 07:06:06 -0800 (In reply to comment #20) > (In reply to comment #19) > > I still needed http://cgit.freedesktop.org/xorg/xserver/patch/?id=65642ccb78aa2d4c4e17b9ac42e4ef625c4a6e8b to my xvfb package in order to be able to generate pixel results. > > Has this bug been reported against Ubuntu so that they consider applying the patch to their package? Yes, just now, https://bugs.launchpad.net/ubuntu/+source/xorg-server/+bug/1100312 810820 22 rafael.lobo 2013-01-18 10:46:10 -0800 (In reply to comment #4) > When running fast/block/abspos-child-container-changes-from-relative-to-static.html WebKitTestRunner forces a repaint on the WebProcess but we end up in a deadlock and WTR detects a repaint failure in dumpPixelsAndCompareWithExpected. > > As far as I can see it, this happens because, first > CoordinatedLayerTreeHost::forceRepaintAsync is called, > which then calls scheduleLayerFlush() - after this timer fires: > performScheduledLayerFlush() is called, but here: > m_waitingForUIProcess is true and the method returns early, while the UIProcess is waiting for the WebProcess. This timeout was happening on other ports like Qt? 810904 23 rafael.lobo 2013-01-18 11:58:00 -0800 I believe this is a wrong fix for a EFL specific problem. UIProcess can expect the callback to arrive at some time, but it should never really wait for it (on CoordinatedGraphics). UIProcess has to keep up with its main loop so things like "viewNeedsDisplay" will be processed and then unlock the WebProcess to do the render of next frame. Once the next frame is rendered and the flush happens on WebProcess side, then the callback will be sent back to UIProcess. This is the only way to guarantee that the rendered frame is the one after the forceRepaint was requested. We've been observing some flakyness on our API tests after this patch and then I've observed TestController::platformRunUntil of EFL: if (timeout == m_noTimeout) { // Never timeout if we are debugging or not meant to timeout. while (!condition) { ecore_main_loop_iterate(); sleep(1); } return; } This sleep seems to be the source of the problem. You should keep up the main loop running in a non-blocking way, like Qt does. Could we rollout this change or make the proper fix soon? 810912 24 noam 2013-01-18 12:07:34 -0800 I think you are right. Dominik? 811957 25 d-r 2013-01-21 02:14:52 -0800 (In reply to comment #24) > I think you are right. > Dominik? Agree that it has a different root cause. I can look into rolling out and doing an EFL fix later on today - thanks Rafael for pointing this out. If you wanna roll out earlier, feel free to go ahead and CC me on the rollout patch. 812067 26 cdumez 2013-01-21 05:50:19 -0800 (In reply to comment #23) > I believe this is a wrong fix for a EFL specific problem. UIProcess can expect the callback to arrive at some time, but it should never really wait for it (on CoordinatedGraphics). UIProcess has to keep up with its main loop so things like "viewNeedsDisplay" will be processed and then unlock the WebProcess to do the render of next frame. Once the next frame is rendered and the flush happens on WebProcess side, then the callback will be sent back to UIProcess. This is the only way to guarantee that the rendered frame is the one after the forceRepaint was requested. > > We've been observing some flakyness on our API tests after this patch and then I've observed TestController::platformRunUntil of EFL: > > if (timeout == m_noTimeout) { > // Never timeout if we are debugging or not meant to timeout. > while (!condition) { > ecore_main_loop_iterate(); > sleep(1); > } > return; > } > > This sleep seems to be the source of the problem. You should keep up the main loop running in a non-blocking way, like Qt does. Could we rollout this change or make the proper fix soon? I'm removing the sleep() instruction in Bug 107442. I would like this fix to land before we roll out. 812078 27 webkit.review.bot 2013-01-21 06:06:11 -0800 Re-opened since this is blocked by bug 107443 812090 28 jturcotte 2013-01-21 06:23:29 -0800 (In reply to comment #23) > This sleep seems to be the source of the problem. You should keep up the main loop running in a non-blocking way, like Qt does. Could we rollout this change or make the proper fix soon? Very nice catch! 812091 29 cdumez 2013-01-21 06:24:14 -0800 Closing since it should be fixed by Bug 107442 (dependency). 182751 2013-01-15 06:18:04 -0800 2013-01-15 06:38:49 -0800 Patch bug-106884-20130115161503.patch text/plain 2241 d-r U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5NzMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYWMxMTZmNGU2YzA2MjQw ZWZmOWI2ZTc1M2E1MTYzMTg4OTdiZWZhMy4uMGZlNDViYzJhYjk5MTk4MDI5MzIxOGJjNzU1NDg2 ODE4NTcyNjZkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAxLTE1ICBEb21p bmlrIFLDtnR0c2NoZXMgIDxkb21pbmlrLnJvdHRzY2hlc0BpbnRlbC5jb20+CisKKyAgICAgICAg W0VGTF0gQ29vcmRpbmF0ZWQgR3JhcGhpY3MgRGVhZGxvY2sgd2hlbiBydW5uaW5nIGFic3Bvcy1j aGlsZC1jb250YWluZXItY2hhbmdlcy1mcm9tLXJlbGF0aXZlLXRvLXN0YXRpYy5odG1sCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDY4ODQKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBuZWVkIHRvIHJl dHVybiBmYWxzZSBpZiBtX3dhaXRpbmdGb3JVSVByb2Nlc3MgaXMgdHJ1ZSBzaW5jZSBvdGhlcndp c2UKKyAgICAgICAgd2UnbGwgbm90IHJlYWxseSByZXBhaW50IGluIHBlcmZvcm1TY2hlZHVsZWRM YXllckZsdXNoKCkgYW5kIHRoZQorICAgICAgICBVSSBwcm9jZXNzIHdpbGwgd2FpdCBmb3JldmVy LiBSZXR1cm5pbmcgZmFsc2UgbGVhZHMgZXhlY3V0aW5nIHRoZSBsYXllciBmbHVzaAorICAgICAg ICBzeW5jaHJvbm91c2x5IGFuZCBpbW1lZGlhdGVseSwgdGhlbiBhY2tub3dsZWRnaW5nIHRoZQor ICAgICAgICBjYWxsYmFjayB0byB0aGUgV2ViUHJvY2VzcyAtIHdoaWNoIHJlc29sdmVzIHRoZSBk ZWFkbG9jay4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBo aWNzL0Nvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkNvb3Jk aW5hdGVkTGF5ZXJUcmVlSG9zdDo6Zm9yY2VSZXBhaW50QXN5bmMpOiBSZXR1cm4gZmFsc2UgaW4g b3JkZXIgdG8gdHJpZ2dlciBhIHN5bmNocm9ub3VzIHJlcGFpbnQgaWYgbV93YWl0aW5nRm9yVUlQ cm9jZXNzIGlzIHRydWUuCisKIDIwMTMtMDEtMTQgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUu Y29tPgogCiAgICAgICAgIFtBTkdMRV0gVXBkYXRlIEFOR0xFIGluIFdlYktpdApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3Mv Q29vcmRpbmF0ZWRMYXllclRyZWVIb3N0LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdC5jcHAK aW5kZXggNzk3YWVlMzUyYjBlYjA4MzI0ZjU4Y2E5YjNmZDIyZmJmNWNhZjk2YS4uOGZiYjU3ZjIx MWZmMmNjNGI5MjA3MjMzMGRlM2Y4Nzg3OWUxNzkzZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRMYXll clRyZWVIb3N0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29v cmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZExheWVyVHJlZUhvc3QuY3BwCkBAIC0yMDQsNiAr MjA0LDEwIEBAIHZvaWQgQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0Ojpmb3JjZVJlcGFpbnQoKQog CiBib29sIENvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdDo6Zm9yY2VSZXBhaW50QXN5bmModWludDY0 X3QgY2FsbGJhY2tJRCkKIHsKKyAgICAvLyBBdm9pZCBkZWFkbG9ja3Mgd2hlbiB0aGUgVUkgcHJv Y2VzcyBoYXMgcmVxdWVzdGVkIGEgZm9yY2VSZXBhaW50IGJ5IGZhbGxpbmcgYmFjayB0byBhIHN5 bmNocm9ub3VzIHJlcGFpbnQsIHNlZSBjYWxsZXIgV2ViUGFnZTo6Zm9yY2VSZXBhaW50LgorICAg IGlmIChtX3dhaXRpbmdGb3JVSVByb2Nlc3MpCisgICAgICAgIHJldHVybiBmYWxzZTsKKwogICAg IC8vIFdlIGV4cGVjdCB0aGUgVUkgcHJvY2VzcyB0byBub3QgcmVxdWlyZSBhIG5ldyByZXBhaW50 IHVudGlsIHRoZSBwcmV2aW91cyBvbmUgaGFzIGZpbmlzaGVkLgogICAgIEFTU0VSVCghbV9mb3Jj ZVJlcGFpbnRBc3luY0NhbGxiYWNrSUQpOwogICAgIG1fZm9yY2VSZXBhaW50QXN5bmNDYWxsYmFj a0lEID0gY2FsbGJhY2tJRDsK 182755 2013-01-15 06:38:57 -0800 2013-01-15 07:44:23 -0800 Patch v2, updated bug title. bug-106884-20130115163556.patch text/plain 2236 d-r U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5NzMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYWMxMTZmNGU2YzA2MjQw ZWZmOWI2ZTc1M2E1MTYzMTg4OTdiZWZhMy4uMmMyMjY2YzY5MzZiMzZlZDk0YzJhOGI5Mjk0ODJk YjMxNmVhMjUwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAxLTE1ICBEb21p bmlrIFLDtnR0c2NoZXMgIDxkb21pbmlrLnJvdHRzY2hlc0BpbnRlbC5jb20+CisKKyAgICAgICAg W0Nvb3JkaW5hdGVkR3JhcGhpY3NdIERlYWRsb2NrIHdoZW4gcnVubmluZyBhYnNwb3MtY2hpbGQt Y29udGFpbmVyLWNoYW5nZXMtZnJvbS1yZWxhdGl2ZS10by1zdGF0aWMuaHRtbAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA2ODg0CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgbmVlZCB0byByZXR1cm4g ZmFsc2UgaWYgbV93YWl0aW5nRm9yVUlQcm9jZXNzIGlzIHRydWUgc2luY2Ugb3RoZXJ3aXNlCisg ICAgICAgIHdlJ2xsIG5vdCByZWFsbHkgcmVwYWludCBpbiBwZXJmb3JtU2NoZWR1bGVkTGF5ZXJG bHVzaCgpIGFuZCB0aGUKKyAgICAgICAgVUkgcHJvY2VzcyB3aWxsIHdhaXQgZm9yZXZlci4gUmV0 dXJuaW5nIGZhbHNlIGxlYWRzIGV4ZWN1dGluZyB0aGUgbGF5ZXIgZmx1c2gKKyAgICAgICAgc3lu Y2hyb25vdXNseSBhbmQgaW1tZWRpYXRlbHksIHRoZW4gYWNrbm93bGVkZ2luZyB0aGUKKyAgICAg ICAgY2FsbGJhY2sgdG8gdGhlIFdlYlByb2Nlc3MgLSB3aGljaCByZXNvbHZlcyB0aGUgZGVhZGxv Y2suCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9D b29yZGluYXRlZExheWVyVHJlZUhvc3QuY3BwOgorICAgICAgICAoV2ViS2l0OjpDb29yZGluYXRl ZExheWVyVHJlZUhvc3Q6OmZvcmNlUmVwYWludEFzeW5jKTogUmV0dXJuIGZhbHNlIGluIG9yZGVy IHRvIHRyaWdnZXIgYSBzeW5jaHJvbm91cyByZXBhaW50IGlmIG1fd2FpdGluZ0ZvclVJUHJvY2Vz cyBpcyB0cnVlLgorCiAyMDEzLTAxLTE0ICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4K IAogICAgICAgICBbQU5HTEVdIFVwZGF0ZSBBTkdMRSBpbiBXZWJLaXQKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3Jk aW5hdGVkTGF5ZXJUcmVlSG9zdC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBh Z2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZExheWVyVHJlZUhvc3QuY3BwCmluZGV4 IDc5N2FlZTM1MmIwZWIwODMyNGY1OGNhOWIzZmQyMmZiZjVjYWY5NmEuLjhmYmI1N2YyMTFmZjJj YzRiOTIwNzIzMzBkZTNmODc4NzllMTc5M2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkTGF5ZXJUcmVl SG9zdC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5h dGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0LmNwcApAQCAtMjA0LDYgKzIwNCwx MCBAQCB2b2lkIENvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdDo6Zm9yY2VSZXBhaW50KCkKIAogYm9v bCBDb29yZGluYXRlZExheWVyVHJlZUhvc3Q6OmZvcmNlUmVwYWludEFzeW5jKHVpbnQ2NF90IGNh bGxiYWNrSUQpCiB7CisgICAgLy8gQXZvaWQgZGVhZGxvY2tzIHdoZW4gdGhlIFVJIHByb2Nlc3Mg aGFzIHJlcXVlc3RlZCBhIGZvcmNlUmVwYWludCBieSBmYWxsaW5nIGJhY2sgdG8gYSBzeW5jaHJv bm91cyByZXBhaW50LCBzZWUgY2FsbGVyIFdlYlBhZ2U6OmZvcmNlUmVwYWludC4KKyAgICBpZiAo bV93YWl0aW5nRm9yVUlQcm9jZXNzKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKICAgICAvLyBX ZSBleHBlY3QgdGhlIFVJIHByb2Nlc3MgdG8gbm90IHJlcXVpcmUgYSBuZXcgcmVwYWludCB1bnRp bCB0aGUgcHJldmlvdXMgb25lIGhhcyBmaW5pc2hlZC4KICAgICBBU1NFUlQoIW1fZm9yY2VSZXBh aW50QXN5bmNDYWxsYmFja0lEKTsKICAgICBtX2ZvcmNlUmVwYWludEFzeW5jQ2FsbGJhY2tJRCA9 IGNhbGxiYWNrSUQ7Cg== 182772 2013-01-15 07:44:32 -0800 2013-01-15 13:41:53 -0800 Patch v3, grammar in ChangeLog fixed. bug-106884-20130115174130.patch text/plain 2239 d-r U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5NzMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYWMxMTZmNGU2YzA2MjQw ZWZmOWI2ZTc1M2E1MTYzMTg4OTdiZWZhMy4uZjY3OWZhYzY0ZWRiZmM4ZmZhNjE5NzMxZGUwMTg0 NWRlMDgzYzVkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAxLTE1ICBEb21p bmlrIFLDtnR0c2NoZXMgIDxkb21pbmlrLnJvdHRzY2hlc0BpbnRlbC5jb20+CisKKyAgICAgICAg W0Nvb3JkaW5hdGVkR3JhcGhpY3NdIERlYWRsb2NrIHdoZW4gcnVubmluZyBhYnNwb3MtY2hpbGQt Y29udGFpbmVyLWNoYW5nZXMtZnJvbS1yZWxhdGl2ZS10by1zdGF0aWMuaHRtbAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA2ODg0CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgbmVlZCB0byByZXR1cm4g ZmFsc2UgaWYgbV93YWl0aW5nRm9yVUlQcm9jZXNzIGlzIHRydWUgc2luY2Ugb3RoZXJ3aXNlCisg ICAgICAgIHdlJ2xsIG5vdCByZWFsbHkgcmVwYWludCBpbiBwZXJmb3JtU2NoZWR1bGVkTGF5ZXJG bHVzaCgpIGFuZCB0aGUKKyAgICAgICAgVUkgcHJvY2VzcyB3aWxsIHdhaXQgZm9yZXZlci4gUmV0 dXJuaW5nIGZhbHNlIGxlYWRzIHRvIGV4ZWN1dGluZyB0aGUgbGF5ZXIgZmx1c2gKKyAgICAgICAg c3luY2hyb25vdXNseSBhbmQgaW1tZWRpYXRlbHksIHRoZW4gYWNrbm93bGVkZ2luZyB0aGUKKyAg ICAgICAgY2FsbGJhY2sgdG8gdGhlIFdlYlByb2Nlc3MgLSB3aGljaCByZXNvbHZlcyB0aGUgZGVh ZGxvY2suCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGlj cy9Db29yZGluYXRlZExheWVyVHJlZUhvc3QuY3BwOgorICAgICAgICAoV2ViS2l0OjpDb29yZGlu YXRlZExheWVyVHJlZUhvc3Q6OmZvcmNlUmVwYWludEFzeW5jKTogUmV0dXJuIGZhbHNlIGluIG9y ZGVyIHRvIHRyaWdnZXIgYSBzeW5jaHJvbm91cyByZXBhaW50IGlmIG1fd2FpdGluZ0ZvclVJUHJv Y2VzcyBpcyB0cnVlLgorCiAyMDEzLTAxLTE0ICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNv bT4KIAogICAgICAgICBbQU5HTEVdIFVwZGF0ZSBBTkdMRSBpbiBXZWJLaXQKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL0Nv b3JkaW5hdGVkTGF5ZXJUcmVlSG9zdC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dl YlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZExheWVyVHJlZUhvc3QuY3BwCmlu ZGV4IDc5N2FlZTM1MmIwZWIwODMyNGY1OGNhOWIzZmQyMmZiZjVjYWY5NmEuLjhmYmI1N2YyMTFm ZjJjYzRiOTIwNzIzMzBkZTNmODc4NzllMTc5M2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkTGF5ZXJU cmVlSG9zdC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3Jk aW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0LmNwcApAQCAtMjA0LDYgKzIw NCwxMCBAQCB2b2lkIENvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdDo6Zm9yY2VSZXBhaW50KCkKIAog Ym9vbCBDb29yZGluYXRlZExheWVyVHJlZUhvc3Q6OmZvcmNlUmVwYWludEFzeW5jKHVpbnQ2NF90 IGNhbGxiYWNrSUQpCiB7CisgICAgLy8gQXZvaWQgZGVhZGxvY2tzIHdoZW4gdGhlIFVJIHByb2Nl c3MgaGFzIHJlcXVlc3RlZCBhIGZvcmNlUmVwYWludCBieSBmYWxsaW5nIGJhY2sgdG8gYSBzeW5j aHJvbm91cyByZXBhaW50LCBzZWUgY2FsbGVyIFdlYlBhZ2U6OmZvcmNlUmVwYWludC4KKyAgICBp ZiAobV93YWl0aW5nRm9yVUlQcm9jZXNzKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKICAgICAv LyBXZSBleHBlY3QgdGhlIFVJIHByb2Nlc3MgdG8gbm90IHJlcXVpcmUgYSBuZXcgcmVwYWludCB1 bnRpbCB0aGUgcHJldmlvdXMgb25lIGhhcyBmaW5pc2hlZC4KICAgICBBU1NFUlQoIW1fZm9yY2VS ZXBhaW50QXN5bmNDYWxsYmFja0lEKTsKICAgICBtX2ZvcmNlUmVwYWludEFzeW5jQ2FsbGJhY2tJ RCA9IGNhbGxiYWNrSUQ7Cg==