<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>106880</bug_id>
          
          <creation_ts>2013-01-15 01:02:33 -0800</creation_ts>
          <short_desc>[Qt] Fix ImageDiff&apos;s image format conversion</short_desc>
          <delta_ts>2013-01-15 01:35:25 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Andras Becsi">abecsi</reporter>
          <assigned_to name="Andras Becsi">abecsi</assigned_to>
          <cc>ossy</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>807077</commentid>
    <comment_count>0</comment_count>
    <who name="Andras Becsi">abecsi</who>
    <bug_when>2013-01-15 01:02:33 -0800</bug_when>
    <thetext>[Qt] Fix ImageDiff&apos;s image format conversion</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>807080</commentid>
    <comment_count>1</comment_count>
      <attachid>182716</attachid>
    <who name="Andras Becsi">abecsi</who>
    <bug_when>2013-01-15 01:05:05 -0800</bug_when>
    <thetext>Created attachment 182716
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>807081</commentid>
    <comment_count>2</comment_count>
    <who name="Andras Becsi">abecsi</who>
    <bug_when>2013-01-15 01:06:38 -0800</bug_when>
    <thetext>(In reply to comment #1)
&gt; Created an attachment (id=182716) [details]
&gt; Patch

Ossy, could you check if this alters the results on the bot?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>807107</commentid>
    <comment_count>3</comment_count>
      <attachid>182716</attachid>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2013-01-15 01:31:01 -0800</bug_when>
    <thetext>Comment on attachment 182716
Patch

Nice catch. :) There aren&apos;t too many faiing tests 
on the pixel bot, so it&apos;s safe to land it now.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>807111</commentid>
    <comment_count>4</comment_count>
      <attachid>182716</attachid>
    <who name="Andras Becsi">abecsi</who>
    <bug_when>2013-01-15 01:35:20 -0800</bug_when>
    <thetext>Comment on attachment 182716
Patch

Clearing flags on attachment: 182716

Committed r139727: &lt;http://trac.webkit.org/changeset/139727&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>807112</commentid>
    <comment_count>5</comment_count>
    <who name="Andras Becsi">abecsi</who>
    <bug_when>2013-01-15 01:35:25 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>182716</attachid>
            <date>2013-01-15 01:05:05 -0800</date>
            <delta_ts>2013-01-15 01:35:20 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-106880-20130115100206.patch</filename>
            <type>text/plain</type>
            <size>1634</size>
            <attacher name="Andras Becsi">abecsi</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5NzE5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZmIxNGI2ZDEwNmY1ODc4N2QwNjgyZWZjZjQ1NzFjZDgz
MDJiOGY2MS4uNGM0Nzg3MGNjOTcwNjcyZDYyMjU0ZGEzYzIxZWQ4MWMyNmFiYWUyYSAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3
IEBACisyMDEzLTAxLTE1ICBBbmRyYXMgQmVjc2kgIDxhbmRyYXMuYmVjc2lAZGlnaWEuY29tPgor
CisgICAgICAgIFtRdF0gRml4IEltYWdlRGlmZidzIGltYWdlIGZvcm1hdCBjb252ZXJzaW9uCisg
ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDY4ODAKKwor
ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBCZXNpZGVzIGFj
dHVhbGx5IGRvaW5nIHRoZSBjb252ZXJzaW9uIHRoaXMgYWxzbyBzaWxlbmNlcyB0aGUgc3VzcGlj
aW91cyB3YXJuaW5nOgorICAgICAgICAiaWdub3JpbmcgcmV0dXJuIHZhbHVlIG9mIGZ1bmN0aW9u
IGRlY2xhcmVkIHdpdGggd2Fybl91bnVzZWRfcmVzdWx0IGF0dHJpYnV0ZSIuCisKKyAgICAgICAg
KiBJbWFnZURpZmYvcXQvSW1hZ2VEaWZmLmNwcDoKKyAgICAgICAgKG1haW4pOiBRSW1hZ2U6OmNv
bnZlcnRUb0Zvcm1hdCwgY29udHJhcnkgdG8gdGhlIGFzc3VtZWQgYmVoYXZpb3VyLCByZXR1cm5z
IGEKKyAgICAgICAgY29weSBvZiB0aGUgaW1hZ2UgaW4gdGhlIGdpdmVuIGZvcm1hdCBhbmQgZG9l
cyBub3QgYWx0ZXIgdGhlIGltYWdlIGl0c2VsZi4KKwogMjAxMy0wMS0xNCAgRGlyayBQcmFua2Ug
IDxkcHJhbmtlQGNocm9taXVtLm9yZz4KIAogICAgICAgICBucnd0OiBzdHViIG91dCBzaG93X3Jl
c3VsdHNfaHRtbCBmb3IgbW9jayBwb3J0cwpkaWZmIC0tZ2l0IGEvVG9vbHMvSW1hZ2VEaWZmL3F0
L0ltYWdlRGlmZi5jcHAgYi9Ub29scy9JbWFnZURpZmYvcXQvSW1hZ2VEaWZmLmNwcAppbmRleCA1
MzdiNjNkNzAxNGE1NjMwODY3NGI2OTFmNDFiMTNmYmJlZjk3YWYzLi5jZWEyYjEzMzAyM2NhNzQx
MTc2ZmM1MzJhY2ZjMjcwZDI2Njk3MDlmIDEwMDY0NAotLS0gYS9Ub29scy9JbWFnZURpZmYvcXQv
SW1hZ2VEaWZmLmNwcAorKysgYi9Ub29scy9JbWFnZURpZmYvcXQvSW1hZ2VEaWZmLmNwcApAQCAt
NzAsNyArNzAsNyBAQCBpbnQgbWFpbihpbnQgYXJnYywgY2hhciogYXJndltdKQogICAgICAgICAg
ICAgICAgIC8vIENvbnZlcnQgaW50byBRSW1hZ2UKICAgICAgICAgICAgICAgICBRSW1hZ2UgZGVj
b2RlZEltYWdlOwogICAgICAgICAgICAgICAgIGRlY29kZWRJbWFnZS5sb2FkRnJvbURhdGEoZGF0
YS5kYXRhKCksICJQTkciKTsKLSAgICAgICAgICAgICAgICBkZWNvZGVkSW1hZ2UuY29udmVydFRv
Rm9ybWF0KFFJbWFnZTo6Rm9ybWF0X0FSR0IzMik7CisgICAgICAgICAgICAgICAgZGVjb2RlZElt
YWdlID0gZGVjb2RlZEltYWdlLmNvbnZlcnRUb0Zvcm1hdChRSW1hZ2U6OkZvcm1hdF9BUkdCMzIp
OwogCiAgICAgICAgICAgICAgICAgLy8gUGxhY2UgaXQgaW4gdGhlIHJpZ2h0IHBsYWNlCiAgICAg
ICAgICAgICAgICAgaWYgKGFjdHVhbEltYWdlLmlzTnVsbCgpKQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>