<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>106836</bug_id>
          
          <creation_ts>2013-01-14 15:49:43 -0800</creation_ts>
          <short_desc>[chromium] Enable `update-webkit --chromium --ninja` on windows</short_desc>
          <delta_ts>2013-01-14 17:02:13 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>104434</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Nico Weber">thakis</reporter>
          <assigned_to name="Nico Weber">thakis</assigned_to>
          <cc>dbates</cc>
    
    <cc>eric</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>806693</commentid>
    <comment_count>0</comment_count>
    <who name="Nico Weber">thakis</who>
    <bug_when>2013-01-14 15:49:43 -0800</bug_when>
    <thetext>[chromium] Enable `update-webkit --chromium --ninja` on windows</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>806695</commentid>
    <comment_count>1</comment_count>
      <attachid>182641</attachid>
    <who name="Nico Weber">thakis</who>
    <bug_when>2013-01-14 15:50:38 -0800</bug_when>
    <thetext>Created attachment 182641
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>806712</commentid>
    <comment_count>2</comment_count>
    <who name="Nico Weber">thakis</who>
    <bug_when>2013-01-14 15:58:28 -0800</bug_when>
    <thetext>(Note that this only enables manual opt-in to ninja, it doesn&apos;t change any defaults.)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>806753</commentid>
    <comment_count>3</comment_count>
      <attachid>182641</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2013-01-14 16:31:13 -0800</bug_when>
    <thetext>Comment on attachment 182641
Patch

HOT.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>806785</commentid>
    <comment_count>4</comment_count>
      <attachid>182641</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-01-14 17:02:09 -0800</bug_when>
    <thetext>Comment on attachment 182641
Patch

Clearing flags on attachment: 182641

Committed r139689: &lt;http://trac.webkit.org/changeset/139689&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>806786</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-01-14 17:02:13 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>182641</attachid>
            <date>2013-01-14 15:50:38 -0800</date>
            <delta_ts>2013-01-14 17:02:08 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-106836-20130114154739.patch</filename>
            <type>text/plain</type>
            <size>2292</size>
            <attacher name="Nico Weber">thakis</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5NjIyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYWVmN2UzZmRiNThhODFhMDEyZGY1NWM1YjhkMjA4OWVm
ZDk4MWRlNy4uMzUxY2VmNTAxMjgxYWRmMTZmN2EyNWE5MjZlNDVjNWY4YjllMzdjNSAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4
IEBACisyMDEzLTAxLTE0ICBOaWNvIFdlYmVyICA8dGhha2lzQGNocm9taXVtLm9yZz4KKworICAg
ICAgICBbY2hyb21pdW1dIEVuYWJsZSBgdXBkYXRlLXdlYmtpdCAtLWNocm9taXVtIC0tbmluamFg
IG9uIHdpbmRvd3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTEwNjgzNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg
ICAgIEFmdGVyIHJ1bm5pbmcgdGhpcywgYnVpbGQtd2Via2l0IC0tY2hyb21pdW0gd2lsbCB1c2Ug
bmluamEgdG8gYnVpbGQuCisgICAgICAgIEFwcGFyZW50bHkgdGhlcmUgYXJlIHNvbWUgbWlub3Ig
aXNzdWVzIHdpdGggdGhhdCBzdGlsbCwgc28gaXQncworICAgICAgICBub3QgcXVpdGUgcmVhZHkg
Zm9yIHVzZSB5ZXQuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdGRpcnMucG06CisgICAgICAg
IChkZXRlcm1pbmVJc0Nocm9taXVtTmluamEpOgorICAgICAgICAoYnVpbGRDaHJvbWl1bSk6CisK
IDIwMTMtMDEtMTQgIEFuZHJleSBMdXNobmlrb3YgIDxsdXNobmlrb3ZAY2hyb21pdW0ub3JnPgog
CiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IGRldnRvb2xzIGZyb250LWVuZCBkb2Vzbid0IGhhdmUg
Zm9jdXMgaW4gVGVzdFNoZWxsCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMu
cG0gYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KaW5kZXggNTE4ZDcxMWQ5ZjI3YjVjZTlm
OTViNjczZmJhYjRlYTMxM2Q1ODE2Yy4uYTljMTEwYTU5YTZkYjc4MjBmYTQ4MmU4YTZhYTQ3Y2Rl
ZTI4YzZmOSAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCisrKyBiL1Rv
b2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQpAQCAtMTIyMCw3ICsxMjIwLDEyIEBAIHN1YiBkZXRl
cm1pbmVJc0Nocm9taXVtTmluamEoKQogICAgICAgICAgICRzdGF0TWFrZSA9IHN0YXQoJ01ha2Vm
aWxlLmNocm9taXVtJyktPm10aW1lOwogICAgICAgICB9CiAKLSAgICAgICAgJGhhc1VwVG9EYXRl
TmluamFidWlsZCA9ICRzdGF0TmluamEgPiAkc3RhdFhjb2RlICYmICRzdGF0TmluamEgPiAkc3Rh
dE1ha2U7CisgICAgICAgIG15ICRzdGF0VmlzdWFsU3R1ZGlvID0gMDsKKyAgICAgICAgaWYgKC1l
ICdTb3VyY2UvV2ViS2l0L2Nocm9taXVtL0FsbC5zbG4nKSB7CisgICAgICAgICAgJHN0YXRWaXN1
YWxTdHVkaW8gPSBzdGF0KCdTb3VyY2UvV2ViS2l0L2Nocm9taXVtL0FsbC5zbG4nKS0+bXRpbWU7
CisgICAgICAgIH0KKworICAgICAgICAkaGFzVXBUb0RhdGVOaW5qYWJ1aWxkID0gJHN0YXROaW5q
YSA+ICRzdGF0WGNvZGUgJiYgJHN0YXROaW5qYSA+ICRzdGF0TWFrZSAmJiAkc3RhdE5pbmphID4g
JHN0YXRWaXN1YWxTdHVkaW87CiAgICAgfQogICAgICRpc0Nocm9taXVtTmluamEgPSAkaGFzVXBU
b0RhdGVOaW5qYWJ1aWxkOwogfQpAQCAtMjU1Miw3ICsyNTU3LDcgQEAgc3ViIGJ1aWxkQ2hyb21p
dW0oJEApCiAgICAgaWYgKGlzRGFyd2luKCkgJiYgIWlzQ2hyb21pdW1BbmRyb2lkKCkgJiYgIWlz
Q2hyb21pdW1NYWNNYWtlKCkgJiYgIWlzQ2hyb21pdW1OaW5qYSgpKSB7CiAgICAgICAgICMgTWFj
IGJ1aWxkIC0gYnVpbGRzIHRoZSByb290IHhjb2RlIHByb2plY3QuCiAgICAgICAgICRyZXN1bHQg
PSBidWlsZFhDb2RlUHJvamVjdCgiU291cmNlL1dlYktpdC9jaHJvbWl1bS9BbGwiLCAkY2xlYW4s
ICItY29uZmlndXJhdGlvbiIsIGNvbmZpZ3VyYXRpb24oKSwgQG9wdGlvbnMpOwotICAgIH0gZWxz
aWYgKGlzQ3lnd2luKCkgfHwgaXNXaW5kb3dzKCkpIHsKKyAgICB9IGVsc2lmICgoaXNDeWd3aW4o
KSB8fCBpc1dpbmRvd3MoKSkgJiYgIWlzQ2hyb21pdW1OaW5qYSgpKSB7CiAgICAgICAgICMgV2lu
ZG93cyBidWlsZCAtIGJ1aWxkcyB0aGUgcm9vdCB2aXN1YWwgc3R1ZGlvIHNvbHV0aW9uLgogICAg
ICAgICAkcmVzdWx0ID0gYnVpbGRDaHJvbWl1bVZpc3VhbFN0dWRpb1Byb2plY3QoIlNvdXJjZS9X
ZWJLaXQvY2hyb21pdW0vQWxsLnNsbiIsICRjbGVhbik7CiAgICAgfSBlbHNpZiAoaXNDaHJvbWl1
bU5pbmphKCkpIHsK
</data>

          </attachment>
      

    </bug>

</bugzilla>