106824 2013-01-14 13:39:52 -0800 [BlackBerry] FCC appears when switching search engine providers 2013-01-14 14:42:42 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 otcheung webkit-unassigned mifenton rwlbuis tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 806574 0 otcheung 2013-01-14 13:39:52 -0800 FCC is invoked when we switch search engine providers 806596 1 182624 otcheung 2013-01-14 13:57:55 -0800 Created attachment 182624 Patch 806608 2 182624 rwlbuis 2013-01-14 14:11:40 -0800 Comment on attachment 182624 Patch LGTM. 806643 3 182624 webkit.review.bot 2013-01-14 14:42:38 -0800 Comment on attachment 182624 Patch Clearing flags on attachment: 182624 Committed r139667: <http://trac.webkit.org/changeset/139667> 806644 4 webkit.review.bot 2013-01-14 14:42:42 -0800 All reviewed patches have been landed. Closing bug. 182624 2013-01-14 13:57:55 -0800 2013-01-14 14:42:38 -0800 Patch bug-106824-20130114165456.patch text/plain 3197 otcheung U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5NjU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCAyMDYxODUxNzJlYzk4ODgwYjQ1ZDUyYmJkMzMwOWFlOTdiNjUyYmU2Li41NDg5YWZmM2I4 N2ZmYWFiMTZhMDZjYTk3YjJhMzBmNzA4MmQyNGUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyNyBAQAorMjAxMy0wMS0xNCAgT3R0byBEZXJlayBDaGV1bmcgIDxv dGNoZXVuZ0ByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBGQ0MgYXBwZWFycyB3aGVu IHN3aXRjaGluZyBzZWFyY2ggZW5naW5lIHByb3ZpZGVycworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA2ODI0CisKKyAgICAgICAgTWFnbmlmeWluZyBn bGFzcyBhcHBlYXJzIHdoZW4gc3dpdGNoaW5nIHNlYXJjaCBlbmdpbmUgcHJvdmlkZXJzCisKKyAg ICAgICAgUFIgMjc5MTc4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisg ICAgICAgIEludGVybmFsIFJldmlld2VkIGJ5IE1pa2UgRmVudG9uLgorCisgICAgICAgIFdlIG5l ZWQgdG8gbWFrZSBzdXJlIGZhdGZpbmdlciBpcyB0b3VjaGluZyBhIHRleHRmaWVsZCB3aGVuIHdl IHRlbGwgbm90aWZ5Q2FyZXRDaGFuZ2VkCisgICAgICAgIHRvIHNob3cgdGhlIEZDQy4KKworICAg ICAgICBUaGlzIGJlaGF2aW91ciBpcyBhY2NpZGVudGFsbHkgcmVncmVzc2VkIGluIHRoZSBmaXgg aW4gUFIgMjY3MTc3LCBjYXVzaW5nIHRoZSBGQ0MgdG8gc2hvdworICAgICAgICB3aGVuIHRoZSB1 c2VyIHRvdWNoZXMgYW4gZWxlbWVudCB0aGF0IGlzIG5vdCBhIHRleHRmaWVsZCBhbmQgY2hhbmdl cyB0aGUgY2FyZXQgaW4gdGhlIGlucHV0YmFyLi4KKworICAgICAgICBUZXN0ZWQgdGhhdCB0aGUg YmVoYXZpb3VyIGluIDI2NzE3NyBpc24ndCByZXByb2R1Y2libGUgYW5kIHRoZSBGQ0MgaXNuJ3Qg aW52b2tlZCB3aGVuIHdlIHN3aXRjaAorICAgICAgICBzZWFyY2ggZW5naW5lIHByb3ZpZGVycy4K KworICAgICAgICAqIFdlYktpdFN1cHBvcnQvU2VsZWN0aW9uSGFuZGxlci5jcHA6CisgICAgICAg IChCbGFja0JlcnJ5OjpXZWJLaXQ6OlNlbGVjdGlvbkhhbmRsZXI6OmNhcmV0UG9zaXRpb25DaGFu Z2VkKToKKwogMjAxMy0wMS0xNCAgSmFja3kgSmlhbmcgIDx6aGFqaWFuZ0ByaW0uY29tPgogCiAg ICAgICAgIFtCbGFja0JlcnJ5XSBab29tIGlzIHN0aWxsIHBvc3NpYmxlIHdoZW4gdXNlci1zY2Fs YWJsZT1ubwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBv cnQvU2VsZWN0aW9uSGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0 U3VwcG9ydC9TZWxlY3Rpb25IYW5kbGVyLmNwcAppbmRleCA4ODM3MGFkNDk4Zjk0ODQ3ZTcyNTAz NDdiZGUzN2RhNzYxYzJmZDM2Li41Nzg1YTM5MDNmM2UxMzk3YzhjMGE2ZmE4MjRlMGJhYjIyOTQx MTAxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9T ZWxlY3Rpb25IYW5kbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0 U3VwcG9ydC9TZWxlY3Rpb25IYW5kbGVyLmNwcApAQCAtMTAyOCwxMiArMTAyOCwxNCBAQCB2b2lk IFNlbGVjdGlvbkhhbmRsZXI6OmNhcmV0UG9zaXRpb25DaGFuZ2VkKGJvb2wgdXNlclRvdWNoVHJp Z2dlcmVkKQogewogICAgIFNlbGVjdGlvbkxvZyhQbGF0Zm9ybTo6TG9nTGV2ZWxJbmZvLCAiU2Vs ZWN0aW9uSGFuZGxlcjo6Y2FyZXRQb3NpdGlvbkNoYW5nZWQiKTsKIAorICAgIGJvb2wgaXNGYXRG aW5nZXJPblRleHRGaWVsZCA9IHVzZXJUb3VjaFRyaWdnZXJlZCAmJiBtX3dlYlBhZ2UtPm1fdG91 Y2hFdmVudEhhbmRsZXItPmxhc3RGYXRGaW5nZXJzUmVzdWx0KCkuaXNUZXh0SW5wdXQoKTsKKwog ICAgIFdlYkNvcmU6OkludFJlY3QgY2FyZXRMb2NhdGlvbjsKICAgICAvLyBJZiB0aGUgaW5wdXQg ZmllbGQgaXMgbm90IGFjdGl2ZSwgd2UgbXVzdCBiZSB0dXJuaW5nIG9mZiB0aGUgY2FyZXQuCiAg ICAgaWYgKCFtX3dlYlBhZ2UtPm1faW5wdXRIYW5kbGVyLT5pc0lucHV0TW9kZSgpICYmIG1fY2Fy ZXRBY3RpdmUpIHsKICAgICAgICAgbV9jYXJldEFjdGl2ZSA9IGZhbHNlOwogICAgICAgICAvLyBT ZW5kIGFuIGVtcHR5IGNhcmV0IGNoYW5nZSB0byB0dXJuIG9mZiB0aGUgY2FyZXQuCi0gICAgICAg IG1fd2ViUGFnZS0+bV9jbGllbnQtPm5vdGlmeUNhcmV0Q2hhbmdlZChjYXJldExvY2F0aW9uLCB1 c2VyVG91Y2hUcmlnZ2VyZWQpOworICAgICAgICBtX3dlYlBhZ2UtPm1fY2xpZW50LT5ub3RpZnlD YXJldENoYW5nZWQoY2FyZXRMb2NhdGlvbiwgaXNGYXRGaW5nZXJPblRleHRGaWVsZCk7CiAgICAg ICAgIHJldHVybjsKICAgICB9CiAKQEAgLTEwNzQsNyArMTA3Niw3IEBAIHZvaWQgU2VsZWN0aW9u SGFuZGxlcjo6Y2FyZXRQb3NpdGlvbkNoYW5nZWQoYm9vbCB1c2VyVG91Y2hUcmlnZ2VyZWQpCiAg ICAgICAgIFBsYXRmb3JtOjpJbnRSZWN0KG5vZGVCb3VuZGluZ0JveCkudG9TdHJpbmcoKS5jX3N0 cigpLAogICAgICAgICBtX3dlYlBhZ2UtPm1faW5wdXRIYW5kbGVyLT5lbGVtZW50VGV4dCgpLmlz RW1wdHkoKSA/ICIsIGVtcHR5IHRleHQgZmllbGQiIDogIiIpOwogCi0gICAgbV93ZWJQYWdlLT5t X2NsaWVudC0+bm90aWZ5Q2FyZXRDaGFuZ2VkKGNhcmV0TG9jYXRpb24sIHVzZXJUb3VjaFRyaWdn ZXJlZCwgaXNTaW5nbGVMaW5lSW5wdXQsIG5vZGVCb3VuZGluZ0JveCwgbV93ZWJQYWdlLT5tX2lu cHV0SGFuZGxlci0+ZWxlbWVudFRleHQoKS5pc0VtcHR5KCkpOworICAgIG1fd2ViUGFnZS0+bV9j bGllbnQtPm5vdGlmeUNhcmV0Q2hhbmdlZChjYXJldExvY2F0aW9uLCBpc0ZhdEZpbmdlck9uVGV4 dEZpZWxkLCBpc1NpbmdsZUxpbmVJbnB1dCwgbm9kZUJvdW5kaW5nQm94LCBtX3dlYlBhZ2UtPm1f aW5wdXRIYW5kbGVyLT5lbGVtZW50VGV4dCgpLmlzRW1wdHkoKSk7CiB9CiAKIGJvb2wgU2VsZWN0 aW9uSGFuZGxlcjo6c2VsZWN0aW9uQ29udGFpbnMoY29uc3QgV2ViQ29yZTo6SW50UG9pbnQmIHBv aW50KQo=