106816 2013-01-14 12:31:20 -0800 Switch AudioDestinationChromium over to new createAudioDevice() method 2013-01-16 19:10:33 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 crogers crogers eric.carlson feature-media-reviews jamesr leviw webkit.review.bot oldest_to_newest 806524 0 crogers 2013-01-14 12:31:20 -0800 Switch AudioDestinationChromium over to new createAudioDevice() method 806525 1 182612 crogers 2013-01-14 12:33:08 -0800 Created attachment 182612 Patch 806645 2 182612 webkit.review.bot 2013-01-14 14:44:06 -0800 Comment on attachment 182612 Patch Rejecting attachment 182612 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: t-commit-queue Parsed 2 diffs from patch file(s). patching file Source/WebKit/chromium/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/chromium/src/AudioDestinationChromium.cpp Hunk #1 FAILED at 66. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/chromium/src/AudioDestinationChromium.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'James Robinson']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/15853704 806700 3 crogers 2013-01-14 15:52:17 -0800 Committed r139678: <http://trac.webkit.org/changeset/139678> 806823 4 leviw 2013-01-14 17:33:26 -0800 Reverted in r139695. Triggered a bunch of WebAudio crashes: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=webaudio%2Faudiochannelmerger-basic.html%2Cwebaudio%2Fbiquad-getFrequencyResponse.html%2Cwebaudio%2Faudiobuffersource-channels.html%2Cwebaudio%2Fdynamicscompressor-basic.html%2Cwebaudio%2Fmediaelementaudiosourcenode.html%2Cwebaudio%2Fpannernode-basic.html%2Cwebaudio%2Fbiquadfilternode-basic.html%2Cwebaudio%2Fconvolver-setBuffer-null.html%2Cwebaudio%2Faudionode.html%2Cwebaudio%2Fmediastreamaudiosourcenode.html 808983 5 crogers 2013-01-16 19:10:33 -0800 Committed r139951: <http://trac.webkit.org/changeset/139951> 182612 2013-01-14 12:33:08 -0800 2013-01-14 14:44:06 -0800 Patch bug-106816-20130114123008.patch text/plain 1757 crogers U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5Mzc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDU5ZTAxMWM1MGQyZWNhMjRkOGZiMjk2ZDY4YTVhMmExZDE2MTgwNWIuLjc3ZDUxNWYwNjFhYjRk YjA2ZGViYmM4YjA1ZTE3ZTJkMTgzNzQ4NjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTMtMDEtMTQgIENocmlzIFJvZ2VycyAgPGNyb2dlcnNAZ29vZ2xl LmNvbT4KKworICAgICAgICBTd2l0Y2ggQXVkaW9EZXN0aW5hdGlvbkNocm9taXVtIG92ZXIgdG8g bmV3IGNyZWF0ZUF1ZGlvRGV2aWNlKCkgbWV0aG9kCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDY4MTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHNyYy9BdWRpb0Rlc3RpbmF0aW9uQ2hyb21pdW0uY3Bw OgorICAgICAgICAoV2ViQ29yZTo6QXVkaW9EZXN0aW5hdGlvbkNocm9taXVtOjpBdWRpb0Rlc3Rp bmF0aW9uQ2hyb21pdW0pOgorCiAyMDEzLTAxLTEwICBEYW4gQmVhbSAgPGRiZWFtQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBJbXBsZW1lbnQgQXV0b2NvbXBsZXRlRXJyb3JFdmVudCNyZWFzb24K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0F1ZGlvRGVzdGluYXRpb25D aHJvbWl1bS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9BdWRpb0Rlc3RpbmF0aW9u Q2hyb21pdW0uY3BwCmluZGV4IGY1YzVhMjk0YTU0NjRiYzY3NTdiZmNmNTk3MWRiM2U2NGVlNDIz MWQuLmJhNzRjZDg5NGFhM2U5ZmQwMzBiYTBlODUwNjI1ZGQ0NDdlOWFmNDcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0F1ZGlvRGVzdGluYXRpb25DaHJvbWl1bS5jcHAK KysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQXVkaW9EZXN0aW5hdGlvbkNocm9taXVt LmNwcApAQCAtNjYsOCArNjYsNyBAQCBBdWRpb0Rlc3RpbmF0aW9uQ2hyb21pdW06OkF1ZGlvRGVz dGluYXRpb25DaHJvbWl1bShBdWRpb0lPQ2FsbGJhY2smIGNhbGxiYWNrLCB1bgogICAgIGlmICht X2NhbGxiYWNrQnVmZmVyU2l6ZSArIHJlbmRlckJ1ZmZlclNpemUgPiBmaWZvU2l6ZSkKICAgICAg ICAgcmV0dXJuOwogCi0gICAgLy8gRklYTUU6IHN3aXRjaCB0byBuZXcgQVBJICh3aXRoIGlucHV0 IGNoYW5uZWxzKSBvbmNlIGNocm9taXVtIHN1cHBvcnRzIGl0LgotICAgIG1fYXVkaW9EZXZpY2Ug PSBhZG9wdFB0cihXZWJLaXQ6OlBsYXRmb3JtOjpjdXJyZW50KCktPmNyZWF0ZUF1ZGlvRGV2aWNl KG1fY2FsbGJhY2tCdWZmZXJTaXplLCBudW1iZXJPZk91dHB1dENoYW5uZWxzLCBzYW1wbGVSYXRl LCB0aGlzKSk7CisgICAgbV9hdWRpb0RldmljZSA9IGFkb3B0UHRyKFdlYktpdDo6UGxhdGZvcm06 OmN1cnJlbnQoKS0+Y3JlYXRlQXVkaW9EZXZpY2UobV9jYWxsYmFja0J1ZmZlclNpemUsIG51bWJl ck9mSW5wdXRDaGFubmVscywgbnVtYmVyT2ZPdXRwdXRDaGFubmVscywgc2FtcGxlUmF0ZSwgdGhp cykpOwogICAgIEFTU0VSVChtX2F1ZGlvRGV2aWNlKTsKIAogICAgIC8vIENyZWF0ZSBhIEZJRk8g dG8gaGFuZGxlIHRoZSBwb3NzaWJpbGl0eSBvZiB0aGUgY2FsbGJhY2sgc2l6ZQo=