106807 2013-01-14 10:34:05 -0800 [REGRESSION] Dev Tools popup for Workers forgets sizes/shows tiny in top left 2013-01-21 02:25:26 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 yurys yurys apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 806454 0 yurys 2013-01-14 10:34:05 -0800 Upstreaming Chromium bug report http://code.google.com/p/chromium/issues/detail?id=167952 : Version 26.0.1373.0 canary OS: OSX 10.8.2, Windows 7 What steps will reproduce the problem? 1. Have a page with a Web Worker 2. Open dev tools, select Sources -> Workers -> click the worker 3. The Developer Tools popup will have all its sizing information set to 0 and appear in the top left corner really small 4. Resize the popup, resize all the sidebars [5. Close the popup and reopen via the Workers pane - it will have been reset to the top left corner] What is the expected output? What do you see instead? The window opens at a reasonable size the first time and upon repeated openings remembers its size. 806456 1 182600 yurys 2013-01-14 10:35:51 -0800 Created attachment 182600 Patch 806489 2 182600 pfeldman 2013-01-14 11:36:17 -0800 Comment on attachment 182600 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182600&action=review > Source/WebCore/inspector/front-end/WorkerManager.js:177 > + var workerInspectorWindow = window.open(url, undefined, "location=0,width=" + width + ",height=" + height); Why doesn't platform manage the preferred size? 806493 3 182600 webkit.review.bot 2013-01-14 11:45:21 -0800 Comment on attachment 182600 Patch Clearing flags on attachment: 182600 Committed r139634: <http://trac.webkit.org/changeset/139634> 806494 4 webkit.review.bot 2013-01-14 11:45:25 -0800 All reviewed patches have been landed. Closing bug. 807075 5 yurys 2013-01-15 01:00:37 -0800 (In reply to comment #2) > (From update of attachment 182600 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=182600&action=review > > > Source/WebCore/inspector/front-end/WorkerManager.js:177 > > + var workerInspectorWindow = window.open(url, undefined, "location=0,width=" + width + ",height=" + height); > > Why doesn't platform manage the preferred size? It provides something like 100x100 by default which is too small for inspector. 182600 2013-01-14 10:35:51 -0800 2013-01-21 02:25:26 -0800 Patch bug-106807-20130114223251.patch text/plain 3519 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5NjAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjdlYmVlZjJkMzk5ZTU1 MGNlNzk2YzhiYjgzNDg4MWNjNGMxMTgyNS4uOGVlNTNjMDVkZmE3NDZmNmIzMWIyM2YyY2Q4YmEw OTM1M2E1ZjE5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAxLTE0ICBZdXJ5 IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtSRUdSRVNTSU9O XSBEZXYgVG9vbHMgcG9wdXAgZm9yIFdvcmtlcnMgZm9yZ2V0cyBzaXplcy9zaG93cyB0aW55IGlu IHRvcCBsZWZ0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMDY4MDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBPcGVuIGRlZGljYXRlZCB3b3JrZXIgaW5zcGVjdG9yIDYwMHg2MDAgYnkgZGVmYXVsdCBhbmQg cmVtZW1iZXIgaXRzIHNpemUKKyAgICAgICAgYWZ0ZXIgcmVzaXppbmcuCisKKyAgICAgICAgKiBp bnNwZWN0b3IvZnJvbnQtZW5kL1NldHRpbmdzLmpzOgorICAgICAgICAqIGluc3BlY3Rvci9mcm9u dC1lbmQvV29ya2VyTWFuYWdlci5qczoKKwogMjAxMy0wMS0xNCAgS2VudGFybyBIYXJhICA8aGFy YWtlbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW1Y4XSBQYXNzIGFuIElzb2xhdGUgdG8gYXNz b2NpYXRlT2JqZWN0V2l0aFdyYXBwZXIoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9TZXR0aW5ncy5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvU2V0dGluZ3MuanMKaW5kZXggMmViMzI0NjViMzAwMWVkMGJkOTRjM2Q0MTM5Mzg0 ZmRkODYyNWI5ZS4uODNmNWZiOTI4NDIyZTE1YWY0OGI3ZjE3MWExNTIyZDY4YmRiYTk1ZiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TZXR0aW5ncy5qcwor KysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NldHRpbmdzLmpzCkBAIC0x MTUsNiArMTE1LDggQEAgV2ViSW5zcGVjdG9yLlNldHRpbmdzID0gZnVuY3Rpb24oKQogICAgIHRo aXMuc2hvd01ldHJpY3NSdWxlcnMgPSB0aGlzLmNyZWF0ZVNldHRpbmcoInNob3dNZXRyaWNzUnVs ZXJzIiwgZmFsc2UpOwogICAgIHRoaXMuZW11bGF0ZWRDU1NNZWRpYSA9IHRoaXMuY3JlYXRlU2V0 dGluZygiZW11bGF0ZWRDU1NNZWRpYSIsICJwcmludCIpOwogICAgIHRoaXMuc2hvd1Rvb2xiYXJJ Y29ucyA9IHRoaXMuY3JlYXRlU2V0dGluZygic2hvd1Rvb2xiYXJJY29ucyIsIGZhbHNlKTsKKyAg ICB0aGlzLndvcmtlckluc3BlY3RvcldpZHRoID0gdGhpcy5jcmVhdGVTZXR0aW5nKCJ3b3JrZXJJ bnNwZWN0b3JXaWR0aCIsIDYwMCk7CisgICAgdGhpcy53b3JrZXJJbnNwZWN0b3JIZWlnaHQgPSB0 aGlzLmNyZWF0ZVNldHRpbmcoIndvcmtlckluc3BlY3RvckhlaWdodCIsIDYwMCk7CiAKICAgICAv LyBJZiB0aGVyZSBhcmUgdG9vIG1hbnkgYnJlYWtwb2ludHMgaW4gYSBzdG9yYWdlLCBpdCBpcyBs aWtlbHkgZHVlIHRvIGEgcmVjZW50IGJ1ZyB0aGF0IGNhdXNlZAogICAgIC8vIHBlcmlvZGljYWwg YnJlYWtwb2ludHMgZHVwbGljYXRpb24gbGVhZGluZyB0byBpbnNwZWN0b3Igc2xvd25lc3MuCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1dvcmtlck1hbmFn ZXIuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1dvcmtlck1hbmFnZXIu anMKaW5kZXggMTQ5ZTg4MTIzMjhlMWEyZjgzMTcxZTUyZjNlMWRlYjE5ZTExYzdlMS4uYjZlMjgz N2Q0MTAyNTYyMzVkY2Q5OGUxZjIwZWY0YTczMTQ0ZTlkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Xb3JrZXJNYW5hZ2VyLmpzCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvV29ya2VyTWFuYWdlci5qcwpAQCAtMTcxLDggKzE3 MSwxMSBAQCBXZWJJbnNwZWN0b3IuV29ya2VyTWFuYWdlci5wcm90b3R5cGUgPSB7CiAgICAgICAg ICAgICB1cmwgKz0gIiZ3b3JrZXJQYXVzZWQ9dHJ1ZSI7CiAgICAgICAgIHVybCA9IHVybC5yZXBs YWNlKCJkb2NrZWQ9dHJ1ZSYiLCAiIik7CiAgICAgICAgIHVybCArPSBoYXNoOworICAgICAgICB2 YXIgd2lkdGggPSBXZWJJbnNwZWN0b3Iuc2V0dGluZ3Mud29ya2VySW5zcGVjdG9yV2lkdGguZ2V0 KCk7CisgICAgICAgIHZhciBoZWlnaHQgPSBXZWJJbnNwZWN0b3Iuc2V0dGluZ3Mud29ya2VySW5z cGVjdG9ySGVpZ2h0LmdldCgpOwogICAgICAgICAvLyBTZXQgbG9jYXRpb249MCBqdXN0IHRvIG1h a2Ugc3VyZSB0aGUgZnJvbnQtZW5kIHdpbGwgYmUgb3BlbmVkIGluIGEgc2VwYXJhdGUgd2luZG93 LCBub3QgaW4gbmV3IHRhYi4KLSAgICAgICAgdmFyIHdvcmtlckluc3BlY3RvcldpbmRvdyA9IHdp bmRvdy5vcGVuKHVybCwgdW5kZWZpbmVkLCAibG9jYXRpb249MCIpOworICAgICAgICB2YXIgd29y a2VySW5zcGVjdG9yV2luZG93ID0gd2luZG93Lm9wZW4odXJsLCB1bmRlZmluZWQsICJsb2NhdGlv bj0wLHdpZHRoPSIgKyB3aWR0aCArICIsaGVpZ2h0PSIgKyBoZWlnaHQpOworICAgICAgICB3b3Jr ZXJJbnNwZWN0b3JXaW5kb3cuYWRkRXZlbnRMaXN0ZW5lcigicmVzaXplIiwgdGhpcy5fb25Xb3Jr ZXJJbnNwZWN0b3JSZXNpemUuYmluZCh0aGlzLCB3b3JrZXJJbnNwZWN0b3JXaW5kb3cpLCBmYWxz ZSk7CiAgICAgICAgIHRoaXMuX3dvcmtlcklkVG9XaW5kb3dbd29ya2VySWRdID0gd29ya2VySW5z cGVjdG9yV2luZG93OwogICAgICAgICB3b3JrZXJJbnNwZWN0b3JXaW5kb3cuYWRkRXZlbnRMaXN0 ZW5lcigiYmVmb3JldW5sb2FkIiwgdGhpcy5fd29ya2VySW5zcGVjdG9yQ2xvc2luZy5iaW5kKHRo aXMsIHdvcmtlcklkKSwgdHJ1ZSk7CiAKQEAgLTIwNCw2ICsyMDcsMTMgQEAgV2ViSW5zcGVjdG9y Lldvcmtlck1hbmFnZXIucHJvdG90eXBlID0gewogICAgICAgICB9CiAgICAgfSwKIAorICAgIF9v bldvcmtlckluc3BlY3RvclJlc2l6ZTogZnVuY3Rpb24od29ya2VySW5zcGVjdG9yV2luZG93KQor ICAgIHsKKyAgICAgICAgdmFyIGRvYyA9IHdvcmtlckluc3BlY3RvcldpbmRvdy5kb2N1bWVudDsK KyAgICAgICAgV2ViSW5zcGVjdG9yLnNldHRpbmdzLndvcmtlckluc3BlY3RvcldpZHRoLnNldChk b2Mud2lkdGgpOworICAgICAgICBXZWJJbnNwZWN0b3Iuc2V0dGluZ3Mud29ya2VySW5zcGVjdG9y SGVpZ2h0LnNldChkb2MuaGVpZ2h0KTsKKyAgICB9LAorCiAgICAgX3dvcmtlckluc3BlY3RvckNs b3Npbmc6IGZ1bmN0aW9uKHdvcmtlcklkLCBldmVudCkKICAgICB7CiAgICAgICAgIGlmIChldmVu dC50YXJnZXQubG9jYXRpb24uaHJlZiA9PT0gImFib3V0OmJsYW5rIikK