106800 2013-01-14 09:00:10 -0800 [V8] Make an Isolate parameter mandatory in SerializedScriptValue methods 2014-12-16 00:48:15 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 806397 0 haraken 2013-01-14 09:00:10 -0800 SerializedScriptValue methods are used by both V8 bindings and WebCore. So they should support both an Isolate-version method and an non-Isolate version method. There are two ways to accomplish that: [1] Use an optional Isolate parameter. [2] Implement two versions and delegate the non-Isolate version method to the Isolate version method. I would prefer the approach [2], because I'd like to statically make sure that we never passe a 0 Isolate. If we take the approach [1], we need to insert ASSERT(isolate) here and there. 806400 1 182588 haraken 2013-01-14 09:01:45 -0800 Created attachment 182588 Patch 806412 2 182588 abarth 2013-01-14 09:28:09 -0800 Comment on attachment 182588 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182588&action=review Ok, but we should be able to remove the non-isolate version of many of these methods once we've updated all the callers. (Notice that the JSC versions pass an ExecState.) > Source/WebCore/ChangeLog:10 > + SerializedScriptValue methods are used by both V8 bindings > + and WebCore. So they should support both an Isolate-version > + method and an non-Isolate version method. The JSC version needs an ExecState, which plays a similar roll to the isolate in the V8 version. > Source/WebCore/ChangeLog:20 > + make sure that we never passe a 0 Isolate. If we take the approach passe -> pass 807218 3 182588 haraken 2013-01-15 05:52:43 -0800 Comment on attachment 182588 Patch Landed in r139735. 807230 4 haraken 2013-01-15 06:05:40 -0800 (In reply to comment #2) > Ok, but we should be able to remove the non-isolate version of many of these methods once we've updated all the callers. (Notice that the JSC versions pass an ExecState.) Yes. Given that these methods can be called from WebCore with a ScriptState parameter, one way to solve the problem would be to implement a mechanism to retrieve an Isolate from a ScriptState. JSC already implemented it (i.e. toJS(toRef(ScriptState*) gives us an ExecState). 807557 5 abarth 2013-01-15 12:22:12 -0800 Yeah, I think we're going to want to keep the Isolate in the ScriptState for a bunch of other cases as well. 1055937 6 burg 2014-12-16 00:48:15 -0800 Closing some V8-related work items. 182588 2013-01-14 09:01:45 -0800 2013-01-15 05:52:43 -0800 Patch bug-106800-20130114175845.patch text/plain 9410 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5NjEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzE5NDYxMTc4ZDIxZmNh ODc3MGFlY2IwNDRjMTA2OWU2N2JmOWI2Yy4uZWM1NGFhN2UwYjk2N2ZkM2U1ZDY0MzA4OWM1NmFl ZjExMzU5YWFkZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDQyIEBACiAyMDEzLTAxLTE0ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBbVjhdIE1ha2UgYW4g SXNvbGF0ZSBwYXJhbWV0ZXIgbWFuZGF0b3J5IGluIFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZSBtZXRo b2RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDY4 MDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTZXJp YWxpemVkU2NyaXB0VmFsdWUgbWV0aG9kcyBhcmUgdXNlZCBieSBib3RoIFY4IGJpbmRpbmdzCisg ICAgICAgIGFuZCBXZWJDb3JlLiBTbyB0aGV5IHNob3VsZCBzdXBwb3J0IGJvdGggYW4gSXNvbGF0 ZS12ZXJzaW9uCisgICAgICAgIG1ldGhvZCBhbmQgYW4gbm9uLUlzb2xhdGUgdmVyc2lvbiBtZXRo b2QuCisKKyAgICAgICAgVGhlcmUgYXJlIHR3byB3YXlzIHRvIGFjY29tcGxpc2ggdGhhdDoKKwor ICAgICAgICBbMV0gVXNlIGFuIG9wdGlvbmFsIElzb2xhdGUgcGFyYW1ldGVyLgorCisgICAgICAg IFsyXSBJbXBsZW1lbnQgdHdvIHZlcnNpb25zIGFuZCBkZWxlZ2F0ZSB0aGUgbm9uLUlzb2xhdGUK KyAgICAgICAgdmVyc2lvbiBtZXRob2QgdG8gdGhlIElzb2xhdGUgdmVyc2lvbiBtZXRob2QuCisK KyAgICAgICAgSSB3b3VsZCBwcmVmZXIgdGhlIGFwcHJvYWNoIFsyXSwgYmVjYXVzZSBJJ2QgbGlr ZSB0byBzdGF0aWNhbGx5CisgICAgICAgIG1ha2Ugc3VyZSB0aGF0IHdlIG5ldmVyIHBhc3NlIGEg MCBJc29sYXRlLiBJZiB3ZSB0YWtlIHRoZSBhcHByb2FjaAorICAgICAgICBbMV0sIHdlIG5lZWQg dG8gaW5zZXJ0IEFTU0VSVChpc29sYXRlKSBoZXJlIGFuZCB0aGVyZS4KKworICAgICAgICBUaGlz IHBhdGNoIGltcGxlbWVudHMgdGhlIGFwcHJvYWNoIFsyXS4KKworICAgICAgICBObyB0ZXN0cy4g Tm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgICogYmluZGluZ3MvdjgvU2VyaWFsaXpl ZFNjcmlwdFZhbHVlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNlcmlhbGl6ZWRTY3JpcHRWYWx1 ZTo6Y3JlYXRlKToKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6U2VyaWFs aXplZFNjcmlwdFZhbHVlOjpudWxsVmFsdWUpOgorICAgICAgICAoV2ViQ29yZTo6U2VyaWFsaXpl ZFNjcmlwdFZhbHVlOjp1bmRlZmluZWRWYWx1ZSk6CisgICAgICAgIChXZWJDb3JlOjpTZXJpYWxp emVkU2NyaXB0VmFsdWU6OmJvb2xlYW5WYWx1ZSk6CisgICAgICAgIChXZWJDb3JlOjpTZXJpYWxp emVkU2NyaXB0VmFsdWU6Om51bWJlclZhbHVlKToKKyAgICAgICAgKFdlYkNvcmU6OlNlcmlhbGl6 ZWRTY3JpcHRWYWx1ZTo6U2VyaWFsaXplZFNjcmlwdFZhbHVlKToKKyAgICAgICAgKiBiaW5kaW5n cy92OC9TZXJpYWxpemVkU2NyaXB0VmFsdWUuaDoKKyAgICAgICAgKFNlcmlhbGl6ZWRTY3JpcHRW YWx1ZSk6CisKKzIwMTMtMDEtMTQgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3Jn PgorCiAgICAgICAgIFtWOF0gQWRkIG1faXNvbGF0ZSB0byBTY3JpcHRDb250cm9sbGVyLCBXb3Jr ZXJTY3JpcHRDb250cm9sbGVyIGFuZCBWOERPTVdpbmRvd1NoZWxsCiAgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDY3NzEKIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2VyaWFsaXplZFNjcmlwdFZhbHVlLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NlcmlhbGl6ZWRTY3JpcHRWYWx1ZS5jcHAKaW5kZXggODk2 NDFlNzZmYWExZWRlMzYyMWU2ZDg2ZGJlMDNlNjY0NDFkMDMzZC4uZTUxNTlkZTRlNmVmMWNiZWMz ZGNiYzkzNWNkOTY3Njk5NDQ5MDIxOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvdjgvU2VyaWFsaXplZFNjcmlwdFZhbHVlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy92OC9TZXJpYWxpemVkU2NyaXB0VmFsdWUuY3BwCkBAIC0yMjMxLDE0ICsyMjMxLDIxIEBA IHByaXZhdGU6CiAKIH0gLy8gbmFtZXNwYWNlCiAKLVBhc3NSZWZQdHI8U2VyaWFsaXplZFNjcmlw dFZhbHVlPiBTZXJpYWxpemVkU2NyaXB0VmFsdWU6OmNyZWF0ZSh2ODo6SGFuZGxlPHY4OjpWYWx1 ZT4gdmFsdWUsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgTWVzc2FnZVBvcnRBcnJheSogbWVzc2FnZVBvcnRzLCBBcnJheUJ1 ZmZlckFycmF5KiBhcnJheUJ1ZmZlcnMsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYm9vbCYgZGlkVGhyb3csCi0gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg djg6Oklzb2xhdGUqIGlzb2xhdGUpCitQYXNzUmVmUHRyPFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZT4g U2VyaWFsaXplZFNjcmlwdFZhbHVlOjpjcmVhdGUodjg6OkhhbmRsZTx2ODo6VmFsdWU+IHZhbHVl LCBNZXNzYWdlUG9ydEFycmF5KiBtZXNzYWdlUG9ydHMsIEFycmF5QnVmZmVyQXJyYXkqIGFycmF5 QnVmZmVycywgYm9vbCYgZGlkVGhyb3cpCit7CisgICAgcmV0dXJuIGNyZWF0ZSh2YWx1ZSwgbWVz c2FnZVBvcnRzLCBhcnJheUJ1ZmZlcnMsIGRpZFRocm93LCB2ODo6SXNvbGF0ZTo6R2V0Q3VycmVu dCgpKTsKK30KKworUGFzc1JlZlB0cjxTZXJpYWxpemVkU2NyaXB0VmFsdWU+IFNlcmlhbGl6ZWRT Y3JpcHRWYWx1ZTo6Y3JlYXRlKHY4OjpIYW5kbGU8djg6OlZhbHVlPiB2YWx1ZSwgTWVzc2FnZVBv cnRBcnJheSogbWVzc2FnZVBvcnRzLCBBcnJheUJ1ZmZlckFycmF5KiBhcnJheUJ1ZmZlcnMsIGJv b2wmIGRpZFRocm93LCB2ODo6SXNvbGF0ZSogaXNvbGF0ZSkKIHsKICAgICByZXR1cm4gYWRvcHRS ZWYobmV3IFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZSh2YWx1ZSwgbWVzc2FnZVBvcnRzLCBhcnJheUJ1 ZmZlcnMsIGRpZFRocm93LCBpc29sYXRlKSk7CiB9CiAKK1Bhc3NSZWZQdHI8U2VyaWFsaXplZFNj cmlwdFZhbHVlPiBTZXJpYWxpemVkU2NyaXB0VmFsdWU6OmNyZWF0ZSh2ODo6SGFuZGxlPHY4OjpW YWx1ZT4gdmFsdWUpCit7CisgICAgcmV0dXJuIGNyZWF0ZSh2YWx1ZSwgdjg6Oklzb2xhdGU6Okdl dEN1cnJlbnQoKSk7Cit9CisKIFBhc3NSZWZQdHI8U2VyaWFsaXplZFNjcmlwdFZhbHVlPiBTZXJp YWxpemVkU2NyaXB0VmFsdWU6OmNyZWF0ZSh2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gdmFsdWUsIHY4 OjpJc29sYXRlKiBpc29sYXRlKQogewogICAgIGJvb2wgZGlkVGhyb3c7CkBAIC0yMjY0LDYgKzIy NzEsMTEgQEAgUGFzc1JlZlB0cjxTZXJpYWxpemVkU2NyaXB0VmFsdWU+IFNlcmlhbGl6ZWRTY3Jp cHRWYWx1ZTo6Y3JlYXRlRnJvbVdpcmVCeXRlcyhjb24KICAgICByZXR1cm4gY3JlYXRlRnJvbVdp cmUoU3RyaW5nOjphZG9wdChidWZmZXIpKTsKIH0KIAorUGFzc1JlZlB0cjxTZXJpYWxpemVkU2Ny aXB0VmFsdWU+IFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZTo6Y3JlYXRlKGNvbnN0IFN0cmluZyYgZGF0 YSkKK3sKKyAgICByZXR1cm4gY3JlYXRlKGRhdGEsIHY4OjpJc29sYXRlOjpHZXRDdXJyZW50KCkp OworfQorCiBQYXNzUmVmUHRyPFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZT4gU2VyaWFsaXplZFNjcmlw dFZhbHVlOjpjcmVhdGUoY29uc3QgU3RyaW5nJiBkYXRhLCB2ODo6SXNvbGF0ZSogaXNvbGF0ZSkK IHsKICAgICBXcml0ZXIgd3JpdGVyKGlzb2xhdGUpOwpAQCAtMjI3Nyw2ICsyMjg5LDExIEBAIFBh c3NSZWZQdHI8U2VyaWFsaXplZFNjcmlwdFZhbHVlPiBTZXJpYWxpemVkU2NyaXB0VmFsdWU6OmNy ZWF0ZSgpCiAgICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBTZXJpYWxpemVkU2NyaXB0VmFsdWUoKSk7 CiB9CiAKK1Bhc3NSZWZQdHI8U2VyaWFsaXplZFNjcmlwdFZhbHVlPiBTZXJpYWxpemVkU2NyaXB0 VmFsdWU6Om51bGxWYWx1ZSgpCit7CisgICAgcmV0dXJuIG51bGxWYWx1ZSh2ODo6SXNvbGF0ZTo6 R2V0Q3VycmVudCgpKTsKK30KKwogUGFzc1JlZlB0cjxTZXJpYWxpemVkU2NyaXB0VmFsdWU+IFNl cmlhbGl6ZWRTY3JpcHRWYWx1ZTo6bnVsbFZhbHVlKHY4OjpJc29sYXRlKiBpc29sYXRlKQogewog ICAgIFdyaXRlciB3cml0ZXIoaXNvbGF0ZSk7CkBAIC0yMjg1LDYgKzIzMDIsMTEgQEAgUGFzc1Jl ZlB0cjxTZXJpYWxpemVkU2NyaXB0VmFsdWU+IFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZTo6bnVsbFZh bHVlKHY4OjpJc29sYXRlKgogICAgIHJldHVybiBhZG9wdFJlZihuZXcgU2VyaWFsaXplZFNjcmlw dFZhbHVlKHdpcmVEYXRhKSk7CiB9CiAKK1Bhc3NSZWZQdHI8U2VyaWFsaXplZFNjcmlwdFZhbHVl PiBTZXJpYWxpemVkU2NyaXB0VmFsdWU6OnVuZGVmaW5lZFZhbHVlKCkKK3sKKyAgICByZXR1cm4g dW5kZWZpbmVkVmFsdWUodjg6Oklzb2xhdGU6OkdldEN1cnJlbnQoKSk7Cit9CisKIFBhc3NSZWZQ dHI8U2VyaWFsaXplZFNjcmlwdFZhbHVlPiBTZXJpYWxpemVkU2NyaXB0VmFsdWU6OnVuZGVmaW5l ZFZhbHVlKHY4OjpJc29sYXRlKiBpc29sYXRlKQogewogICAgIFdyaXRlciB3cml0ZXIoaXNvbGF0 ZSk7CkBAIC0yMjkzLDYgKzIzMTUsMTEgQEAgUGFzc1JlZlB0cjxTZXJpYWxpemVkU2NyaXB0VmFs dWU+IFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZTo6dW5kZWZpbmVkVmFsdWUodjg6Oklzb2wKICAgICBy ZXR1cm4gYWRvcHRSZWYobmV3IFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZSh3aXJlRGF0YSkpOwogfQog CitQYXNzUmVmUHRyPFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZT4gU2VyaWFsaXplZFNjcmlwdFZhbHVl Ojpib29sZWFuVmFsdWUoYm9vbCB2YWx1ZSkKK3sKKyAgICByZXR1cm4gYm9vbGVhblZhbHVlKHZh bHVlLCB2ODo6SXNvbGF0ZTo6R2V0Q3VycmVudCgpKTsKK30KKwogUGFzc1JlZlB0cjxTZXJpYWxp emVkU2NyaXB0VmFsdWU+IFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZTo6Ym9vbGVhblZhbHVlKGJvb2wg dmFsdWUsIHY4OjpJc29sYXRlKiBpc29sYXRlKQogewogICAgIFdyaXRlciB3cml0ZXIoaXNvbGF0 ZSk7CkBAIC0yMzA0LDYgKzIzMzEsMTEgQEAgUGFzc1JlZlB0cjxTZXJpYWxpemVkU2NyaXB0VmFs dWU+IFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZTo6Ym9vbGVhblZhbHVlKGJvb2wgdmFsdWUKICAgICBy ZXR1cm4gYWRvcHRSZWYobmV3IFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZSh3aXJlRGF0YSkpOwogfQog CitQYXNzUmVmUHRyPFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZT4gU2VyaWFsaXplZFNjcmlwdFZhbHVl OjpudW1iZXJWYWx1ZShkb3VibGUgdmFsdWUpCit7CisgICAgcmV0dXJuIG51bWJlclZhbHVlKHZh bHVlLCB2ODo6SXNvbGF0ZTo6R2V0Q3VycmVudCgpKTsKK30KKwogUGFzc1JlZlB0cjxTZXJpYWxp emVkU2NyaXB0VmFsdWU+IFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZTo6bnVtYmVyVmFsdWUoZG91Ymxl IHZhbHVlLCB2ODo6SXNvbGF0ZSogaXNvbGF0ZSkKIHsKICAgICBXcml0ZXIgd3JpdGVyKGlzb2xh dGUpOwpAQCAtMjM4MywxMCArMjQxNSw3IEBAIFBhc3NPd25QdHI8U2VyaWFsaXplZFNjcmlwdFZh bHVlOjpBcnJheUJ1ZmZlckNvbnRlbnRzQXJyYXk+IFNlcmlhbGl6ZWRTY3JpcHRWYWx1CiAgICAg cmV0dXJuIGNvbnRlbnRzLnJlbGVhc2UoKTsKIH0KIAotU2VyaWFsaXplZFNjcmlwdFZhbHVlOjpT ZXJpYWxpemVkU2NyaXB0VmFsdWUodjg6OkhhbmRsZTx2ODo6VmFsdWU+IHZhbHVlLCAKLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIE1lc3NhZ2VQb3J0QXJyYXkq IG1lc3NhZ2VQb3J0cywgQXJyYXlCdWZmZXJBcnJheSogYXJyYXlCdWZmZXJzLAotICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYm9vbCYgZGlkVGhyb3csCi0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB2ODo6SXNvbGF0ZSogaXNv bGF0ZSkKK1NlcmlhbGl6ZWRTY3JpcHRWYWx1ZTo6U2VyaWFsaXplZFNjcmlwdFZhbHVlKHY4OjpI YW5kbGU8djg6OlZhbHVlPiB2YWx1ZSwgTWVzc2FnZVBvcnRBcnJheSogbWVzc2FnZVBvcnRzLCBB cnJheUJ1ZmZlckFycmF5KiBhcnJheUJ1ZmZlcnMsIGJvb2wmIGRpZFRocm93LCB2ODo6SXNvbGF0 ZSogaXNvbGF0ZSkKICAgICA6IG1fZXh0ZXJuYWxseUFsbG9jYXRlZE1lbW9yeSgwKQogewogICAg IGRpZFRocm93ID0gZmFsc2U7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92 OC9TZXJpYWxpemVkU2NyaXB0VmFsdWUuaCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Nl cmlhbGl6ZWRTY3JpcHRWYWx1ZS5oCmluZGV4IGQyNzc5OGY0MWE5Zjk0ODE1MjY3OTlkNWM0ZjI0 YjE3YTFkZmRhYTMuLmEyMTk1OTViZTc1ODYwN2M0OGM5MjVjYTBiMTczOTE2ZDgwOTczODUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NlcmlhbGl6ZWRTY3JpcHRWYWx1 ZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NlcmlhbGl6ZWRTY3JpcHRWYWx1 ZS5oCkBAIC01MiwxOSArNTIsMjQgQEAgcHVibGljOgogICAgIC8vIGJlIHRocm93biB1c2luZyB2 ODo6VGhyb3dFeGNlcHRpb24oKSwgYW5kIHNldHMgfGRpZFRocm93fC4gSW4gdGhpcyBjYXNlCiAg ICAgLy8gdGhlIGNhbGxlciBtdXN0IG5vdCBpbnZva2UgYW55IFY4IG9wZXJhdGlvbnMgdW50aWwg Y29udHJvbCByZXR1cm5zIHRvCiAgICAgLy8gVjguIFdoZW4gc2VyaWFsaXphdGlvbiBpcyBzdWNj ZXNzZnVsLCB8ZGlkVGhyb3d8IGlzIGZhbHNlLgotICAgIHN0YXRpYyBQYXNzUmVmUHRyPFNlcmlh bGl6ZWRTY3JpcHRWYWx1ZT4gY3JlYXRlKHY4OjpIYW5kbGU8djg6OlZhbHVlPiwKLSAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBNZXNzYWdlUG9ydEFy cmF5KiwgQXJyYXlCdWZmZXJBcnJheSosCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgYm9vbCYgZGlkVGhyb3csIHY4OjpJc29sYXRlKiA9IDApOwot ICAgIHN0YXRpYyBQYXNzUmVmUHRyPFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZT4gY3JlYXRlKHY4OjpI YW5kbGU8djg6OlZhbHVlPiwgdjg6Oklzb2xhdGUqID0gMCk7Ci0gICAgc3RhdGljIFBhc3NSZWZQ dHI8U2VyaWFsaXplZFNjcmlwdFZhbHVlPiBjcmVhdGVGcm9tV2lyZShjb25zdCBTdHJpbmcmIGRh dGEpOwotICAgIHN0YXRpYyBQYXNzUmVmUHRyPFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZT4gY3JlYXRl RnJvbVdpcmVCeXRlcyhjb25zdCBWZWN0b3I8dWludDhfdD4mIGRhdGEpOwotICAgIHN0YXRpYyBQ YXNzUmVmUHRyPFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZT4gY3JlYXRlKGNvbnN0IFN0cmluZyYgZGF0 YSwgdjg6Oklzb2xhdGUqID0gMCk7CisgICAgc3RhdGljIFBhc3NSZWZQdHI8U2VyaWFsaXplZFNj cmlwdFZhbHVlPiBjcmVhdGUodjg6OkhhbmRsZTx2ODo6VmFsdWU+LCBNZXNzYWdlUG9ydEFycmF5 KiwgQXJyYXlCdWZmZXJBcnJheSosIGJvb2wmKTsKKyAgICBzdGF0aWMgUGFzc1JlZlB0cjxTZXJp YWxpemVkU2NyaXB0VmFsdWU+IGNyZWF0ZSh2ODo6SGFuZGxlPHY4OjpWYWx1ZT4sIE1lc3NhZ2VQ b3J0QXJyYXkqLCBBcnJheUJ1ZmZlckFycmF5KiwgYm9vbCYsIHY4OjpJc29sYXRlKik7CisgICAg c3RhdGljIFBhc3NSZWZQdHI8U2VyaWFsaXplZFNjcmlwdFZhbHVlPiBjcmVhdGUodjg6OkhhbmRs ZTx2ODo6VmFsdWU+KTsKKyAgICBzdGF0aWMgUGFzc1JlZlB0cjxTZXJpYWxpemVkU2NyaXB0VmFs dWU+IGNyZWF0ZSh2ODo6SGFuZGxlPHY4OjpWYWx1ZT4sIHY4OjpJc29sYXRlKik7CisgICAgc3Rh dGljIFBhc3NSZWZQdHI8U2VyaWFsaXplZFNjcmlwdFZhbHVlPiBjcmVhdGVGcm9tV2lyZShjb25z dCBTdHJpbmcmKTsKKyAgICBzdGF0aWMgUGFzc1JlZlB0cjxTZXJpYWxpemVkU2NyaXB0VmFsdWU+ IGNyZWF0ZUZyb21XaXJlQnl0ZXMoY29uc3QgVmVjdG9yPHVpbnQ4X3Q+Jik7CisgICAgc3RhdGlj IFBhc3NSZWZQdHI8U2VyaWFsaXplZFNjcmlwdFZhbHVlPiBjcmVhdGUoY29uc3QgU3RyaW5nJik7 CisgICAgc3RhdGljIFBhc3NSZWZQdHI8U2VyaWFsaXplZFNjcmlwdFZhbHVlPiBjcmVhdGUoY29u c3QgU3RyaW5nJiwgdjg6Oklzb2xhdGUqKTsKICAgICBzdGF0aWMgUGFzc1JlZlB0cjxTZXJpYWxp emVkU2NyaXB0VmFsdWU+IGNyZWF0ZSgpOwogCi0gICAgc3RhdGljIFBhc3NSZWZQdHI8U2VyaWFs aXplZFNjcmlwdFZhbHVlPiBudWxsVmFsdWUodjg6Oklzb2xhdGUqID0gMCk7Ci0gICAgc3RhdGlj IFBhc3NSZWZQdHI8U2VyaWFsaXplZFNjcmlwdFZhbHVlPiB1bmRlZmluZWRWYWx1ZSh2ODo6SXNv bGF0ZSogPSAwKTsKLSAgICBzdGF0aWMgUGFzc1JlZlB0cjxTZXJpYWxpemVkU2NyaXB0VmFsdWU+ IGJvb2xlYW5WYWx1ZShib29sIHZhbHVlLCB2ODo6SXNvbGF0ZSogPSAwKTsKLSAgICBzdGF0aWMg UGFzc1JlZlB0cjxTZXJpYWxpemVkU2NyaXB0VmFsdWU+IG51bWJlclZhbHVlKGRvdWJsZSB2YWx1 ZSwgdjg6Oklzb2xhdGUqID0gMCk7CisgICAgc3RhdGljIFBhc3NSZWZQdHI8U2VyaWFsaXplZFNj cmlwdFZhbHVlPiBudWxsVmFsdWUoKTsKKyAgICBzdGF0aWMgUGFzc1JlZlB0cjxTZXJpYWxpemVk U2NyaXB0VmFsdWU+IG51bGxWYWx1ZSh2ODo6SXNvbGF0ZSopOworICAgIHN0YXRpYyBQYXNzUmVm UHRyPFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZT4gdW5kZWZpbmVkVmFsdWUoKTsKKyAgICBzdGF0aWMg UGFzc1JlZlB0cjxTZXJpYWxpemVkU2NyaXB0VmFsdWU+IHVuZGVmaW5lZFZhbHVlKHY4OjpJc29s YXRlKik7CisgICAgc3RhdGljIFBhc3NSZWZQdHI8U2VyaWFsaXplZFNjcmlwdFZhbHVlPiBib29s ZWFuVmFsdWUoYm9vbCk7CisgICAgc3RhdGljIFBhc3NSZWZQdHI8U2VyaWFsaXplZFNjcmlwdFZh bHVlPiBib29sZWFuVmFsdWUoYm9vbCwgdjg6Oklzb2xhdGUqKTsKKyAgICBzdGF0aWMgUGFzc1Jl ZlB0cjxTZXJpYWxpemVkU2NyaXB0VmFsdWU+IG51bWJlclZhbHVlKGRvdWJsZSk7CisgICAgc3Rh dGljIFBhc3NSZWZQdHI8U2VyaWFsaXplZFNjcmlwdFZhbHVlPiBudW1iZXJWYWx1ZShkb3VibGUs IHY4OjpJc29sYXRlKik7CiAKICAgICBzdGF0aWMgdWludDMyX3Qgd2lyZUZvcm1hdFZlcnNpb24o KTsKIAo=