106791 2013-01-14 06:58:12 -0800 MediaStream API: Rename the [add|remove]Track callbacks to [add|remove]RemoteTrack for clarity 2013-01-15 12:48:46 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 56459 1 tommyw tommyw abarth eric.carlson feature-media-reviews hta webkit.review.bot oldest_to_newest 806330 0 tommyw 2013-01-14 06:58:12 -0800 MediaStream API: Rename the [add|remove]Track callbacks to [add|remove]RemoteTrack for clarity 806331 1 182570 tommyw 2013-01-14 06:59:08 -0800 Created attachment 182570 Patch 807562 2 182570 abarth 2013-01-15 12:26:16 -0800 Comment on attachment 182570 Patch ok 807593 3 182570 webkit.review.bot 2013-01-15 12:48:42 -0800 Comment on attachment 182570 Patch Clearing flags on attachment: 182570 Committed r139775: <http://trac.webkit.org/changeset/139775> 807594 4 webkit.review.bot 2013-01-15 12:48:46 -0800 All reviewed patches have been landed. Closing bug. 182570 2013-01-14 06:59:08 -0800 2013-01-15 12:48:42 -0800 Patch bug-106791-20130114155608.patch text/plain 4776 tommyw U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5NjExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTUwNDRjZWY4OGRkMWMx MjZhMmQzZjlkODg0OTA0MGU4MzVlNzc2Ny4uZTE3NmM4YTVmNTM2OTNhZmRjYzIxNTBlMjQ3OTE3 ZGIwYjg2NjU4YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDEzLTAxLTE0ICBUb21t eSBXaWRlbmZseWNodCAgPHRvbW15d0Bnb29nbGUuY29tPgogCisgICAgICAgIE1lZGlhU3RyZWFt IEFQSTogUmVuYW1lIHRoZSBbYWRkfHJlbW92ZV1UcmFjayBjYWxsYmFja3MgdG8gW2FkZHxyZW1v dmVdUmVtb3RlVHJhY2sgZm9yIGNsYXJpdHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEwNjc5MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIE5vIHRlc3RzIG5lZWRlZC4KKworICAgICAgICAqIE1vZHVsZXMv bWVkaWFzdHJlYW0vTWVkaWFTdHJlYW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFTdHJl YW06OmFkZFJlbW90ZVRyYWNrKToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhU3RyZWFtOjpyZW1v dmVSZW1vdGVUcmFjayk6CisgICAgICAgICogTW9kdWxlcy9tZWRpYXN0cmVhbS9NZWRpYVN0cmVh bS5oOgorICAgICAgICAqIHBsYXRmb3JtL21lZGlhc3RyZWFtL01lZGlhU3RyZWFtQ2VudGVyLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhU3RyZWFtQ2VudGVyOjphZGRNZWRpYVN0cmVhbVRy YWNrKToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhU3RyZWFtQ2VudGVyOjpyZW1vdmVNZWRpYVN0 cmVhbVRyYWNrKToKKyAgICAgICAgKiBwbGF0Zm9ybS9tZWRpYXN0cmVhbS9NZWRpYVN0cmVhbURl c2NyaXB0b3IuaDoKKyAgICAgICAgKE1lZGlhU3RyZWFtRGVzY3JpcHRvckNsaWVudCk6CisKKzIw MTMtMDEtMTQgIFRvbW15IFdpZGVuZmx5Y2h0ICA8dG9tbXl3QGdvb2dsZS5jb20+CisKICAgICAg ICAgTWVkaWFTdHJlYW0gQVBJOiBVcGRhdGUgdGhlIHRyYWNrIGFjY2Vzc29ycyBvbiBNZWRpYVN0 cmVhbSB0byBtYXRjaCB0aGUgbGF0ZXN0IHNwZWNpZmljYXRpb24KICAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNjY2MAogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL01lZGlhU3RyZWFtLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vTWVkaWFTdHJlYW0uY3BwCmluZGV4IGMxNTkwNDIz MzI3MTAyMTJkNGE5NGY0Y2JhYzFmZjBmNDA1MjRmOTkuLjc5NTU0NzJlMDdhMjBiMmRlNmI4ODBm ODQ4MWQ4MDhlZjJmMGVkMmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVk aWFzdHJlYW0vTWVkaWFTdHJlYW0uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVk aWFzdHJlYW0vTWVkaWFTdHJlYW0uY3BwCkBAIC0yNTQsNyArMjU0LDcgQEAgRXZlbnRUYXJnZXRE YXRhKiBNZWRpYVN0cmVhbTo6ZW5zdXJlRXZlbnRUYXJnZXREYXRhKCkKICAgICByZXR1cm4gJm1f ZXZlbnRUYXJnZXREYXRhOwogfQogCi12b2lkIE1lZGlhU3RyZWFtOjphZGRUcmFjayhNZWRpYVN0 cmVhbUNvbXBvbmVudCogY29tcG9uZW50KQordm9pZCBNZWRpYVN0cmVhbTo6YWRkUmVtb3RlVHJh Y2soTWVkaWFTdHJlYW1Db21wb25lbnQqIGNvbXBvbmVudCkKIHsKICAgICBpZiAoZW5kZWQoKSkK ICAgICAgICAgcmV0dXJuOwpAQCAtMjcyLDcgKzI3Miw3IEBAIHZvaWQgTWVkaWFTdHJlYW06OmFk ZFRyYWNrKE1lZGlhU3RyZWFtQ29tcG9uZW50KiBjb21wb25lbnQpCiAgICAgc2NoZWR1bGVEaXNw YXRjaEV2ZW50KE1lZGlhU3RyZWFtVHJhY2tFdmVudDo6Y3JlYXRlKGV2ZW50TmFtZXMoKS5hZGR0 cmFja0V2ZW50LCBmYWxzZSwgZmFsc2UsIHRyYWNrKSk7CiB9CiAKLXZvaWQgTWVkaWFTdHJlYW06 OnJlbW92ZVRyYWNrKE1lZGlhU3RyZWFtQ29tcG9uZW50KiBjb21wb25lbnQpCit2b2lkIE1lZGlh U3RyZWFtOjpyZW1vdmVSZW1vdGVUcmFjayhNZWRpYVN0cmVhbUNvbXBvbmVudCogY29tcG9uZW50 KQogewogICAgIGlmIChlbmRlZCgpKQogICAgICAgICByZXR1cm47CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL01lZGlhU3RyZWFtLmggYi9Tb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL01lZGlhU3RyZWFtLmgKaW5kZXggZjQ5YjdmNzY0MjQx ODlhMTE1NWM2ZjhjODJkOGZlNDEyNGM1ODRmMC4uOWU3NGZjMDNiNWYzODYyYzBmZWMzNjc3NDFk NTllNzU5Mjg2ZjNiNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0 cmVhbS9NZWRpYVN0cmVhbS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJl YW0vTWVkaWFTdHJlYW0uaApAQCAtOTUsOCArOTUsOCBAQCBwcml2YXRlOgogICAgIHZpcnR1YWwg dm9pZCBkZXJlZkV2ZW50VGFyZ2V0KCkgT1ZFUlJJREUgeyBkZXJlZigpOyB9CiAKICAgICAvLyBN ZWRpYVN0cmVhbURlc2NyaXB0b3JDbGllbnQKLSAgICB2aXJ0dWFsIHZvaWQgYWRkVHJhY2soTWVk aWFTdHJlYW1Db21wb25lbnQqKSBPVkVSUklERTsKLSAgICB2aXJ0dWFsIHZvaWQgcmVtb3ZlVHJh Y2soTWVkaWFTdHJlYW1Db21wb25lbnQqKSBPVkVSUklERTsKKyAgICB2aXJ0dWFsIHZvaWQgYWRk UmVtb3RlVHJhY2soTWVkaWFTdHJlYW1Db21wb25lbnQqKSBPVkVSUklERTsKKyAgICB2aXJ0dWFs IHZvaWQgcmVtb3ZlUmVtb3RlVHJhY2soTWVkaWFTdHJlYW1Db21wb25lbnQqKSBPVkVSUklERTsK IAogICAgIHZvaWQgc2NoZWR1bGVEaXNwYXRjaEV2ZW50KFBhc3NSZWZQdHI8RXZlbnQ+KTsKICAg ICB2b2lkIHNjaGVkdWxlZEV2ZW50VGltZXJGaXJlZChUaW1lcjxNZWRpYVN0cmVhbT4qKTsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL01lZGlhU3RyZWFt Q2VudGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL01lZGlhU3Ry ZWFtQ2VudGVyLmNwcAppbmRleCBkZWEyYzQ3OTY3ZjBkMjlkMzI5M2E2MTBmYjk0YmM4M2RhYTg3 OGQ5Li5jNTdmZWZhNmNiZGE3Y2FlMzQ5ZWJkM2ZjNTc3ODI1ZDU4OGMwMjEyIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9NZWRpYVN0cmVhbUNlbnRlci5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vTWVkaWFTdHJlYW1D ZW50ZXIuY3BwCkBAIC02MCwxNCArNjAsMTQgQEAgdm9pZCBNZWRpYVN0cmVhbUNlbnRlcjo6YWRk TWVkaWFTdHJlYW1UcmFjayhNZWRpYVN0cmVhbURlc2NyaXB0b3IqIHN0cmVhbURlc2NyaXAKIHsK ICAgICBNZWRpYVN0cmVhbURlc2NyaXB0b3JDbGllbnQqIGNsaWVudCA9IHN0cmVhbURlc2NyaXB0 b3ItPmNsaWVudCgpOwogICAgIGlmIChjbGllbnQpCi0gICAgICAgIGNsaWVudC0+YWRkVHJhY2so Y29tcG9uZW50KTsKKyAgICAgICAgY2xpZW50LT5hZGRSZW1vdGVUcmFjayhjb21wb25lbnQpOwog fQogCiB2b2lkIE1lZGlhU3RyZWFtQ2VudGVyOjpyZW1vdmVNZWRpYVN0cmVhbVRyYWNrKE1lZGlh U3RyZWFtRGVzY3JpcHRvciogc3RyZWFtRGVzY3JpcHRvciwgTWVkaWFTdHJlYW1Db21wb25lbnQq IGNvbXBvbmVudCkKIHsKICAgICBNZWRpYVN0cmVhbURlc2NyaXB0b3JDbGllbnQqIGNsaWVudCA9 IHN0cmVhbURlc2NyaXB0b3ItPmNsaWVudCgpOwogICAgIGlmIChjbGllbnQpCi0gICAgICAgIGNs aWVudC0+cmVtb3ZlVHJhY2soY29tcG9uZW50KTsKKyAgICAgICAgY2xpZW50LT5yZW1vdmVSZW1v dGVUcmFjayhjb21wb25lbnQpOwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9NZWRpYVN0cmVhbURlc2Ny aXB0b3IuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL01lZGlhU3RyZWFt RGVzY3JpcHRvci5oCmluZGV4IDE0M2ZmM2Y3MzgyODNkM2IzZTEwMjg2Y2UxNDExZjYzZDk5ZjM3 OGEuLmU1NThiMTNiMDRkMTQxNDAzNWM5YWVlMTRkODg4YzU2ODQxOWNiOGMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL01lZGlhU3RyZWFtRGVzY3JpcHRv ci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL01lZGlhU3RyZWFt RGVzY3JpcHRvci5oCkBAIC00NSw4ICs0NSw4IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIH5NZWRp YVN0cmVhbURlc2NyaXB0b3JDbGllbnQoKSB7IH0KIAogICAgIHZpcnR1YWwgdm9pZCBzdHJlYW1F bmRlZCgpID0gMDsKLSAgICB2aXJ0dWFsIHZvaWQgYWRkVHJhY2soTWVkaWFTdHJlYW1Db21wb25l bnQqKSA9IDA7Ci0gICAgdmlydHVhbCB2b2lkIHJlbW92ZVRyYWNrKE1lZGlhU3RyZWFtQ29tcG9u ZW50KikgPSAwOworICAgIHZpcnR1YWwgdm9pZCBhZGRSZW1vdGVUcmFjayhNZWRpYVN0cmVhbUNv bXBvbmVudCopID0gMDsKKyAgICB2aXJ0dWFsIHZvaWQgcmVtb3ZlUmVtb3RlVHJhY2soTWVkaWFT dHJlYW1Db21wb25lbnQqKSA9IDA7CiB9OwogCiBjbGFzcyBNZWRpYVN0cmVhbURlc2NyaXB0b3Ig OiBwdWJsaWMgUmVmQ291bnRlZDxNZWRpYVN0cmVhbURlc2NyaXB0b3I+IHsK