106790 2013-01-14 06:45:49 -0800 [V8] Remove a --es5_readonly flag from V8 initialization and address duplicated code 2013-01-22 09:15:57 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 prybin webkit-unassigned abarth arv haraken japhet webkit.review.bot oldest_to_newest 806325 0 prybin 2013-01-14 06:45:49 -0800 Group common code from 2 similar V8 initialize methods. 806362 1 182579 prybin 2013-01-14 08:13:02 -0800 Created attachment 182579 Patch 806367 2 182579 haraken 2013-01-14 08:16:32 -0800 Comment on attachment 182579 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182579&action=review > Source/WebCore/bindings/v8/V8Initializer.cpp:-128 > - // FIXME: Remove the following 2 lines when V8 default has changed. > - const char es5ReadonlyFlag[] = "--es5_readonly"; > - v8::V8::SetFlagsFromString(es5ReadonlyFlag, sizeof(es5ReadonlyFlag)); What's the rationale for removing the lines? Has V8 default has changed? 806370 3 prybin 2013-01-14 08:21:18 -0800 > > Source/WebCore/bindings/v8/V8Initializer.cpp:-128 > > - // FIXME: Remove the following 2 lines when V8 default has changed. > > - const char es5ReadonlyFlag[] = "--es5_readonly"; > > - v8::V8::SetFlagsFromString(es5ReadonlyFlag, sizeof(es5ReadonlyFlag)); > > What's the rationale for removing the lines? Has V8 default has changed? Exactly. See http://code.google.com/p/v8/source/detail?r=12415 806374 4 182579 haraken 2013-01-14 08:26:51 -0800 Comment on attachment 182579 Patch OK. - Please wait for arv's comment before landing. - Please add the V8 change URL to your ChangeLog. - Change the bug title to "[V8] Remove a --es5_readonly flag from V8 initialization", because that is the main point of this change. 806384 5 182584 prybin 2013-01-14 08:43:50 -0800 Created attachment 182584 Patch 806385 6 182584 haraken 2013-01-14 08:44:45 -0800 Comment on attachment 182584 Patch OK, thanks. Let's wait for arv. 806387 7 prybin 2013-01-14 08:45:50 -0800 > - Please add the V8 change URL to your ChangeLog. Done > - Change the bug title to "[V8] Remove a --es5_readonly flag from V8 initialization", because that is the main point of this change. Done (but this wasn't main intent though :) 809308 8 prybin 2013-01-17 06:42:06 -0800 (In reply to comment #6) > (From update of attachment 182584 [details]) > OK, thanks. Let's wait for arv. arv is not in office until 22rd according to his mail robot. Is there anything we could do without waiting until 22rd? Is there any particular concern you meant? Is it ok to ask my colleagues to review this instead? yurys, vsevik, loislo or pfeldmand probably could do it. 809310 9 182584 haraken 2013-01-17 06:47:13 -0800 Comment on attachment 182584 Patch I asked Andreas (the author of the V8 patch) if it's safe to remove the flag from V8 binding. He is saying OK. 809458 10 182584 webkit.review.bot 2013-01-17 10:36:10 -0800 Comment on attachment 182584 Patch Clearing flags on attachment: 182584 Committed r139990: <http://trac.webkit.org/changeset/139990> 809459 11 webkit.review.bot 2013-01-17 10:36:13 -0800 All reviewed patches have been landed. Closing bug. 813082 12 arv 2013-01-22 09:15:57 -0800 Thanks 182579 2013-01-14 08:13:02 -0800 2013-01-14 08:43:45 -0800 Patch bug-106790-20130114201002.patch text/plain 3635 prybin U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5NjEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTUwNDRjZWY4OGRkMWMx MjZhMmQzZjlkODg0OTA0MGU4MzVlNzc2Ny4uNjJhNTliZDc4Njg0ODY0N2EwODgwNWZmMzAyNGJm MzlmOWVmYzYzNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAxLTE0ICBQZXRl ciBSeWJpbiAgPHBldGVyLnJ5YmluQGdtYWlsLmNvbT4KKworICAgICAgICBSZWZhY3RvciBWOCBp bml0aWFsaXplIG1ldGhvZHMgYSBiaXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEwNjc5MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIENvdXBsZSBvZiBzdGF0ZW1lbnRzIGFyZSBtb3ZlZCB0byBhIG5ld2x5 IGNyZWF0ZWQgbWV0aG9kLiBPbGQgZmxhZyBzZXR0ZXIgaXMgcmVtb3ZlZAorICAgICAgICBhY2Nv cmRpbmcgdG8gRklYTUUuCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOEluaXRpYWxpemVyLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OmluaXRpYWxpemVWOENvbW1vbik6IG5ld2x5IGNyZWF0ZWQg bWV0aG9kCisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKFdlYkNvcmU6OlY4SW5pdGlhbGl6 ZXI6OmluaXRpYWxpemVNYWluVGhyZWFkSWZOZWVkZWQpOgorICAgICAgICAoV2ViQ29yZTo6VjhJ bml0aWFsaXplcjo6aW5pdGlhbGl6ZVdvcmtlcik6CisKIDIwMTMtMDEtMTQgIFRvbW15IFdpZGVu Zmx5Y2h0ICA8dG9tbXl3QGdvb2dsZS5jb20+CiAKICAgICAgICAgTWVkaWFTdHJlYW0gQVBJOiBV cGRhdGUgdGhlIHRyYWNrIGFjY2Vzc29ycyBvbiBNZWRpYVN0cmVhbSB0byBtYXRjaCB0aGUgbGF0 ZXN0IHNwZWNpZmljYXRpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4 L1Y4SW5pdGlhbGl6ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhJbml0aWFs aXplci5jcHAKaW5kZXggNzY4YzJiOGUzNTYyMTcwZDliOTM5YzcwNDUyMjcxMDE2MzZkNTY0Yy4u NzZlOGVkNGE1ZDg2Zjg2OGE5Nzg3NzNjZWVlZWM2ZWE3ZmE2ZGNiMyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhJbml0aWFsaXplci5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvdjgvVjhJbml0aWFsaXplci5jcHAKQEAgLTEwMyw2ICsxMDMsMTMgQEAg c3RhdGljIHZvaWQgZmFpbGVkQWNjZXNzQ2hlY2tDYWxsYmFja0luTWFpblRocmVhZCh2ODo6TG9j YWw8djg6Ok9iamVjdD4gaG9zdCwgdjgKICAgICB0YXJnZXRXaW5kb3ctPnByaW50RXJyb3JNZXNz YWdlKHRhcmdldFdpbmRvdy0+Y3Jvc3NEb21haW5BY2Nlc3NFcnJvck1lc3NhZ2UoYWN0aXZlRE9N V2luZG93KEJpbmRpbmdTdGF0ZTo6aW5zdGFuY2UoKSkpKTsKIH0KIAorc3RhdGljIHZvaWQgaW5p dGlhbGl6ZVY4Q29tbW9uKCkKK3sKKyAgICB2ODo6Vjg6OkFkZEdDUHJvbG9ndWVDYWxsYmFjayhW OEdDQ29udHJvbGxlcjo6Z2NQcm9sb2d1ZSk7CisgICAgdjg6OlY4OjpBZGRHQ0VwaWxvZ3VlQ2Fs bGJhY2soVjhHQ0NvbnRyb2xsZXI6OmdjRXBpbG9ndWUpOworICAgIHY4OjpWODo6SWdub3JlT3V0 T2ZNZW1vcnlFeGNlcHRpb24oKTsKK30KKwogdm9pZCBWOEluaXRpYWxpemVyOjppbml0aWFsaXpl TWFpblRocmVhZElmTmVlZGVkKHY4OjpJc29sYXRlKiBpc29sYXRlKQogewogICAgIEFTU0VSVChp c01haW5UaHJlYWQoKSk7CkBAIC0xMTIsMjAgKzExOSwxNSBAQCB2b2lkIFY4SW5pdGlhbGl6ZXI6 OmluaXRpYWxpemVNYWluVGhyZWFkSWZOZWVkZWQodjg6Oklzb2xhdGUqIGlzb2xhdGUpCiAgICAg ICAgIHJldHVybjsKICAgICBpbml0aWFsaXplZCA9IHRydWU7CiAKLSAgICB2ODo6Vjg6Oklnbm9y ZU91dE9mTWVtb3J5RXhjZXB0aW9uKCk7CisgICAgaW5pdGlhbGl6ZVY4Q29tbW9uKCk7CisKICAg ICB2ODo6Vjg6OlNldEZhdGFsRXJyb3JIYW5kbGVyKHJlcG9ydEZhdGFsRXJyb3JJbk1haW5UaHJl YWQpOwotICAgIHY4OjpWODo6QWRkR0NQcm9sb2d1ZUNhbGxiYWNrKFY4R0NDb250cm9sbGVyOjpn Y1Byb2xvZ3VlKTsKLSAgICB2ODo6Vjg6OkFkZEdDRXBpbG9ndWVDYWxsYmFjayhWOEdDQ29udHJv bGxlcjo6Z2NFcGlsb2d1ZSk7CiAgICAgdjg6OlY4OjpBZGRNZXNzYWdlTGlzdGVuZXIobWVzc2Fn ZUhhbmRsZXJJbk1haW5UaHJlYWQpOwogICAgIHY4OjpWODo6U2V0RmFpbGVkQWNjZXNzQ2hlY2tD YWxsYmFja0Z1bmN0aW9uKGZhaWxlZEFjY2Vzc0NoZWNrQ2FsbGJhY2tJbk1haW5UaHJlYWQpOwog I2lmIEVOQUJMRShKQVZBU0NSSVBUX0RFQlVHR0VSKQogICAgIFNjcmlwdFByb2ZpbGVyOjppbml0 aWFsaXplKCk7CiAjZW5kaWYKICAgICBWOFBlcklzb2xhdGVEYXRhOjplbnN1cmVJbml0aWFsaXpl ZChpc29sYXRlKTsKLQotICAgIC8vIEZJWE1FOiBSZW1vdmUgdGhlIGZvbGxvd2luZyAyIGxpbmVz IHdoZW4gVjggZGVmYXVsdCBoYXMgY2hhbmdlZC4KLSAgICBjb25zdCBjaGFyIGVzNVJlYWRvbmx5 RmxhZ1tdID0gIi0tZXM1X3JlYWRvbmx5IjsKLSAgICB2ODo6Vjg6OlNldEZsYWdzRnJvbVN0cmlu ZyhlczVSZWFkb25seUZsYWcsIHNpemVvZihlczVSZWFkb25seUZsYWcpKTsKIH0KIAogc3RhdGlj IHZvaWQgcmVwb3J0RmF0YWxFcnJvckluV29ya2VyKGNvbnN0IGNoYXIqIGxvY2F0aW9uLCBjb25z dCBjaGFyKiBtZXNzYWdlKQpAQCAtMTU4LDE3ICsxNjAsMTEgQEAgc3RhdGljIGNvbnN0IGludCBr V29ya2VyTWF4U3RhY2tTaXplID0gNTAwICogMTAyNDsKIAogdm9pZCBWOEluaXRpYWxpemVyOjpp bml0aWFsaXplV29ya2VyKHY4OjpJc29sYXRlKiBpc29sYXRlKQogeworICAgIGluaXRpYWxpemVW OENvbW1vbigpOworCiAgICAgdjg6OlY4OjpBZGRNZXNzYWdlTGlzdGVuZXIobWVzc2FnZUhhbmRs ZXJJbldvcmtlcik7Ci0gICAgdjg6OlY4OjpJZ25vcmVPdXRPZk1lbW9yeUV4Y2VwdGlvbigpOwog ICAgIHY4OjpWODo6U2V0RmF0YWxFcnJvckhhbmRsZXIocmVwb3J0RmF0YWxFcnJvckluV29ya2Vy KTsKIAotICAgIHY4OjpWODo6QWRkR0NQcm9sb2d1ZUNhbGxiYWNrKFY4R0NDb250cm9sbGVyOjpn Y1Byb2xvZ3VlKTsKLSAgICB2ODo6Vjg6OkFkZEdDRXBpbG9ndWVDYWxsYmFjayhWOEdDQ29udHJv bGxlcjo6Z2NFcGlsb2d1ZSk7Ci0KLSAgICAvLyBGSVhNRTogUmVtb3ZlIHRoZSBmb2xsb3dpbmcg MiBsaW5lcyB3aGVuIFY4IGRlZmF1bHQgaGFzIGNoYW5nZWQuCi0gICAgY29uc3QgY2hhciBlczVS ZWFkb25seUZsYWdbXSA9ICItLWVzNV9yZWFkb25seSI7Ci0gICAgdjg6OlY4OjpTZXRGbGFnc0Zy b21TdHJpbmcoZXM1UmVhZG9ubHlGbGFnLCBzaXplb2YoZXM1UmVhZG9ubHlGbGFnKSk7Ci0KICAg ICB2ODo6UmVzb3VyY2VDb25zdHJhaW50cyByZXNvdXJjZUNvbnN0cmFpbnRzOwogICAgIHVpbnQz Ml90IGhlcmU7CiAgICAgcmVzb3VyY2VDb25zdHJhaW50cy5zZXRfc3RhY2tfbGltaXQoJmhlcmUg LSBrV29ya2VyTWF4U3RhY2tTaXplIC8gc2l6ZW9mKHVpbnQzMl90KikpOwo= 182584 2013-01-14 08:43:50 -0800 2013-01-17 10:36:09 -0800 Patch bug-106790-20130114204050.patch text/plain 3753 prybin U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5NjEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTUwNDRjZWY4OGRkMWMx MjZhMmQzZjlkODg0OTA0MGU4MzVlNzc2Ny4uNTEwMmYzYWIyN2NmMDRjYzllYmZjYjIyNjNjMTVi OWQxMzk1MmY1MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAxLTE0ICBQZXRl ciBSeWJpbiAgPHBldGVyLnJ5YmluQGdtYWlsLmNvbT4KKworICAgICAgICBbVjhdIFJlbW92ZSBh IC0tZXM1X3JlYWRvbmx5IGZsYWcgZnJvbSBWOCBpbml0aWFsaXphdGlvbiBhbmQgYWRkcmVzcyBk dXBsaWNhdGVkIGNvZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEwNjc5MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIENvdXBsZSBvZiBzdGF0ZW1lbnRzIGFyZSBtb3ZlZCB0byBhIG5ld2x5IGNyZWF0ZWQg bWV0aG9kLiBPbGQgVjggZmxhZyBzZXR0ZXIgaXMgcmVtb3ZlZAorICAgICAgICBhY2NvcmRpbmcg dG8gRklYTUUgYW5kIHBlciBWOCBjaGFuZ2UgaHR0cDovL2NvZGUuZ29vZ2xlLmNvbS9wL3Y4L3Nv dXJjZS9kZXRhaWw/cj0xMjQxNQorCisgICAgICAgICogYmluZGluZ3MvdjgvVjhJbml0aWFsaXpl ci5jcHA6CisgICAgICAgIChXZWJDb3JlOjppbml0aWFsaXplVjhDb21tb24pOiBuZXdseSBjcmVh dGVkIG1ldGhvZAorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgIChXZWJDb3JlOjpWOEluaXRp YWxpemVyOjppbml0aWFsaXplTWFpblRocmVhZElmTmVlZGVkKToKKyAgICAgICAgKFdlYkNvcmU6 OlY4SW5pdGlhbGl6ZXI6OmluaXRpYWxpemVXb3JrZXIpOgorCiAyMDEzLTAxLTE0ICBUb21teSBX aWRlbmZseWNodCAgPHRvbW15d0Bnb29nbGUuY29tPgogCiAgICAgICAgIE1lZGlhU3RyZWFtIEFQ STogVXBkYXRlIHRoZSB0cmFjayBhY2Nlc3NvcnMgb24gTWVkaWFTdHJlYW0gdG8gbWF0Y2ggdGhl IGxhdGVzdCBzcGVjaWZpY2F0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy92OC9WOEluaXRpYWxpemVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4SW5p dGlhbGl6ZXIuY3BwCmluZGV4IDc2OGMyYjhlMzU2MjE3MGQ5YjkzOWM3MDQ1MjI3MTAxNjM2ZDU2 NGMuLjc2ZThlZDRhNWQ4NmY4NjhhOTc4NzczY2VlZWVjNmVhN2ZhNmRjYjMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4SW5pdGlhbGl6ZXIuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4SW5pdGlhbGl6ZXIuY3BwCkBAIC0xMDMsNiArMTAzLDEz IEBAIHN0YXRpYyB2b2lkIGZhaWxlZEFjY2Vzc0NoZWNrQ2FsbGJhY2tJbk1haW5UaHJlYWQodjg6 OkxvY2FsPHY4OjpPYmplY3Q+IGhvc3QsIHY4CiAgICAgdGFyZ2V0V2luZG93LT5wcmludEVycm9y TWVzc2FnZSh0YXJnZXRXaW5kb3ctPmNyb3NzRG9tYWluQWNjZXNzRXJyb3JNZXNzYWdlKGFjdGl2 ZURPTVdpbmRvdyhCaW5kaW5nU3RhdGU6Omluc3RhbmNlKCkpKSk7CiB9CiAKK3N0YXRpYyB2b2lk IGluaXRpYWxpemVWOENvbW1vbigpCit7CisgICAgdjg6OlY4OjpBZGRHQ1Byb2xvZ3VlQ2FsbGJh Y2soVjhHQ0NvbnRyb2xsZXI6OmdjUHJvbG9ndWUpOworICAgIHY4OjpWODo6QWRkR0NFcGlsb2d1 ZUNhbGxiYWNrKFY4R0NDb250cm9sbGVyOjpnY0VwaWxvZ3VlKTsKKyAgICB2ODo6Vjg6Oklnbm9y ZU91dE9mTWVtb3J5RXhjZXB0aW9uKCk7Cit9CisKIHZvaWQgVjhJbml0aWFsaXplcjo6aW5pdGlh bGl6ZU1haW5UaHJlYWRJZk5lZWRlZCh2ODo6SXNvbGF0ZSogaXNvbGF0ZSkKIHsKICAgICBBU1NF UlQoaXNNYWluVGhyZWFkKCkpOwpAQCAtMTEyLDIwICsxMTksMTUgQEAgdm9pZCBWOEluaXRpYWxp emVyOjppbml0aWFsaXplTWFpblRocmVhZElmTmVlZGVkKHY4OjpJc29sYXRlKiBpc29sYXRlKQog ICAgICAgICByZXR1cm47CiAgICAgaW5pdGlhbGl6ZWQgPSB0cnVlOwogCi0gICAgdjg6OlY4OjpJ Z25vcmVPdXRPZk1lbW9yeUV4Y2VwdGlvbigpOworICAgIGluaXRpYWxpemVWOENvbW1vbigpOwor CiAgICAgdjg6OlY4OjpTZXRGYXRhbEVycm9ySGFuZGxlcihyZXBvcnRGYXRhbEVycm9ySW5NYWlu VGhyZWFkKTsKLSAgICB2ODo6Vjg6OkFkZEdDUHJvbG9ndWVDYWxsYmFjayhWOEdDQ29udHJvbGxl cjo6Z2NQcm9sb2d1ZSk7Ci0gICAgdjg6OlY4OjpBZGRHQ0VwaWxvZ3VlQ2FsbGJhY2soVjhHQ0Nv bnRyb2xsZXI6OmdjRXBpbG9ndWUpOwogICAgIHY4OjpWODo6QWRkTWVzc2FnZUxpc3RlbmVyKG1l c3NhZ2VIYW5kbGVySW5NYWluVGhyZWFkKTsKICAgICB2ODo6Vjg6OlNldEZhaWxlZEFjY2Vzc0No ZWNrQ2FsbGJhY2tGdW5jdGlvbihmYWlsZWRBY2Nlc3NDaGVja0NhbGxiYWNrSW5NYWluVGhyZWFk KTsKICNpZiBFTkFCTEUoSkFWQVNDUklQVF9ERUJVR0dFUikKICAgICBTY3JpcHRQcm9maWxlcjo6 aW5pdGlhbGl6ZSgpOwogI2VuZGlmCiAgICAgVjhQZXJJc29sYXRlRGF0YTo6ZW5zdXJlSW5pdGlh bGl6ZWQoaXNvbGF0ZSk7Ci0KLSAgICAvLyBGSVhNRTogUmVtb3ZlIHRoZSBmb2xsb3dpbmcgMiBs aW5lcyB3aGVuIFY4IGRlZmF1bHQgaGFzIGNoYW5nZWQuCi0gICAgY29uc3QgY2hhciBlczVSZWFk b25seUZsYWdbXSA9ICItLWVzNV9yZWFkb25seSI7Ci0gICAgdjg6OlY4OjpTZXRGbGFnc0Zyb21T dHJpbmcoZXM1UmVhZG9ubHlGbGFnLCBzaXplb2YoZXM1UmVhZG9ubHlGbGFnKSk7CiB9CiAKIHN0 YXRpYyB2b2lkIHJlcG9ydEZhdGFsRXJyb3JJbldvcmtlcihjb25zdCBjaGFyKiBsb2NhdGlvbiwg Y29uc3QgY2hhciogbWVzc2FnZSkKQEAgLTE1OCwxNyArMTYwLDExIEBAIHN0YXRpYyBjb25zdCBp bnQga1dvcmtlck1heFN0YWNrU2l6ZSA9IDUwMCAqIDEwMjQ7CiAKIHZvaWQgVjhJbml0aWFsaXpl cjo6aW5pdGlhbGl6ZVdvcmtlcih2ODo6SXNvbGF0ZSogaXNvbGF0ZSkKIHsKKyAgICBpbml0aWFs aXplVjhDb21tb24oKTsKKwogICAgIHY4OjpWODo6QWRkTWVzc2FnZUxpc3RlbmVyKG1lc3NhZ2VI YW5kbGVySW5Xb3JrZXIpOwotICAgIHY4OjpWODo6SWdub3JlT3V0T2ZNZW1vcnlFeGNlcHRpb24o KTsKICAgICB2ODo6Vjg6OlNldEZhdGFsRXJyb3JIYW5kbGVyKHJlcG9ydEZhdGFsRXJyb3JJbldv cmtlcik7CiAKLSAgICB2ODo6Vjg6OkFkZEdDUHJvbG9ndWVDYWxsYmFjayhWOEdDQ29udHJvbGxl cjo6Z2NQcm9sb2d1ZSk7Ci0gICAgdjg6OlY4OjpBZGRHQ0VwaWxvZ3VlQ2FsbGJhY2soVjhHQ0Nv bnRyb2xsZXI6OmdjRXBpbG9ndWUpOwotCi0gICAgLy8gRklYTUU6IFJlbW92ZSB0aGUgZm9sbG93 aW5nIDIgbGluZXMgd2hlbiBWOCBkZWZhdWx0IGhhcyBjaGFuZ2VkLgotICAgIGNvbnN0IGNoYXIg ZXM1UmVhZG9ubHlGbGFnW10gPSAiLS1lczVfcmVhZG9ubHkiOwotICAgIHY4OjpWODo6U2V0Rmxh Z3NGcm9tU3RyaW5nKGVzNVJlYWRvbmx5RmxhZywgc2l6ZW9mKGVzNVJlYWRvbmx5RmxhZykpOwot CiAgICAgdjg6OlJlc291cmNlQ29uc3RyYWludHMgcmVzb3VyY2VDb25zdHJhaW50czsKICAgICB1 aW50MzJfdCBoZXJlOwogICAgIHJlc291cmNlQ29uc3RyYWludHMuc2V0X3N0YWNrX2xpbWl0KCZo ZXJlIC0ga1dvcmtlck1heFN0YWNrU2l6ZSAvIHNpemVvZih1aW50MzJfdCopKTsK