106775 2013-01-14 02:58:39 -0800 [GTK] Fix baseline positioning issue by updating Freetype 2013-12-08 02:57:35 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 d-r zan alex gustavo mrobinson zan oldest_to_newest 806206 0 d-r 2013-01-14 02:58:39 -0800 Analogously to bug 106774, I'd recommend updating freetype from 2.4.2 in jhbuild to > 2.4.6, ideally 2.4.11. 844087 1 zan 2013-02-28 08:04:44 -0800 Since mimicking bug #106774 seems to be desired, is enabling subpixel layout required along with updating Freetype? 844088 2 zan 2013-02-28 08:06:32 -0800 (Enabling subpixel layout on GTK is covered by bug #94792.) 847528 3 d-r 2013-03-05 03:45:16 -0800 (In reply to comment #1) > Since mimicking bug #106774 seems to be desired, is enabling subpixel layout required along with updating Freetype? It's not required, but in my opinion it makes sense to do the rebaselining for both changes in one effort. That said, I would recommend to wait until Freetype's next release. I am expecting http://git.savannah.gnu.org/cgit/freetype/freetype2.git/commit/?id=e0469372be3870a5ad60b2c4586e9c281357bd28 to have a (positive) effect on baseline positioning. The commit fixes a rounding issue for smaller font sizes by emulating what Windows GDI is doing. 876064 4 198187 zan 2013-04-15 14:23:00 -0700 Created attachment 198187 Patch 876068 5 zan 2013-04-15 14:27:01 -0700 (In reply to comment #4) > Created an attachment (id=198187) [details] > Patch This bumps the Freetype dependency to 2.4.11. All the rebaselining will be at first done in a GitHub branch and possibly landed over a low-traffic period (probably in weekend time). The e0469372be patch (comment #3) is at the moment not included but will be tested on the branch to see if the reduction in required rebaselining is worth including the patch separately and applying it over 2.4.11 or if it is better to wait for the 2.4.12 release. 878286 6 198821 zan 2013-04-19 00:43:49 -0700 Created attachment 198821 Patch 878287 7 zan 2013-04-19 01:00:06 -0700 (In reply to comment #6) > Created an attachment (id=198821) [details] > Patch Now includes the e0469372be Freetype patch. That patch doesn't really reduce the amount of baselines, but still needs an enormous amount of rebaselining if applying it on a rebaselined subpixel-enabled setup, so I'd like to include this patch before Freetype 2.4.12 is released. 878786 8 198821 zan 2013-04-20 12:21:42 -0700 Comment on attachment 198821 Patch Clearing flags on attachment: 198821 Committed r148794: <http://trac.webkit.org/changeset/148794> 878787 9 zan 2013-04-20 12:21:49 -0700 All reviewed patches have been landed. Closing bug. 198187 2013-04-15 14:23:00 -0700 2013-04-19 00:43:45 -0700 Patch bug-106775-20130415232235.patch text/plain 2063 zan SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE0ODQ2NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDEzLTA0LTE1ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNv bT4KKworICAgICAgICBbR1RLXSBGaXggYmFzZWxpbmUgcG9zaXRpb25pbmcgaXNzdWUgYnkgdXBk YXRpbmcgRnJlZXR5cGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEwNjc3NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogZ3RrL2poYnVpbGQubW9kdWxlczogQnVtcCB0aGUgRnJlZXR5cGUgSmhidWlsZCBk ZXBlbmRlbmN5IHRvIDIuNC4xMS4KKwogMjAxMy0wNC0xNSAgUnlvc3VrZSBOaXdhICA8cm5pd2FA d2Via2l0Lm9yZz4KIAogICAgICAgICBXS1IgZ2V0cyBzdHVjayB3aGVuIHRoZXJlIGFyZSBtYW55 IG1lcmdlcwpJbmRleDogVG9vbHMvZ3RrL2poYnVpbGQubW9kdWxlcwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBU b29scy9ndGsvamhidWlsZC5tb2R1bGVzCShyZXZpc2lvbiAxNDg0NjYpCisrKyBUb29scy9ndGsv amhidWlsZC5tb2R1bGVzCSh3b3JraW5nIGNvcHkpCkBAIC01MSw2ICs1MSw4IEBACiAgICAgICBo cmVmPSJmdHA6Ly94bWxzb2Z0Lm9yZyIvPgogICA8cmVwb3NpdG9yeSB0eXBlPSJnaXQiIG5hbWU9 ImdzdHJlYW1lciIKICAgICAgIGhyZWY9ImdpdDovL2Fub25naXQuZnJlZWRlc2t0b3Aub3JnL2dp dC9nc3RyZWFtZXIvIi8+CisgIDxyZXBvc2l0b3J5IHR5cGU9InRhcmJhbGwiIG5hbWU9InNhdmFu bmFoLmdudS5vcmciCisgICAgICBocmVmPSJodHRwOi8vZG93bmxvYWQuc2F2YW5uYWguZ251Lm9y Zy9yZWxlYXNlcy8iLz4KIAogICA8YXV0b3Rvb2xzIGlkPSJtYWtlIiBhdXRvZ2VuLXNoPSJjb25m aWd1cmUiPgogICAgIDxicmFuY2ggcmVwbz0iZnRwLmdudS5vcmciCkBAIC04OCwxMSArOTAsMTMg QEAKICAgICA8YnJhbmNoIHJlcG89ImdpdGh1Yi5jb20iIG1vZHVsZT0ibXJvYmluc29uL3dlYmtp dGd0ay10ZXN0LWZvbnRzLmdpdCIgY2hlY2tvdXRkaXI9IndlYmtpdGd0ay10ZXN0LWZvbnRzIiB0 YWc9IjAuMC40Ii8+CiAgIDwvYXV0b3Rvb2xzPgogCi0gIDx0YXJiYWxsIGlkPSJmcmVldHlwZTYi PgotICAgIDxzb3VyY2UgaHJlZj0iZG93bmxvYWQuc2F2YW5uYWguZ251Lm9yZy9yZWxlYXNlcy9m cmVldHlwZS9mcmVldHlwZS0yLjQuMi50YXIuYnoyIiB2ZXJzaW9uPSIyLjQuMiIKLSAgICAgICAg ICAgIGhhc2g9InNoYTI1Njo5YTk4N2FlZjhjNTBkOWJjZmRmZGM5ZjAxMmY4YmQwZGU2MDk1Y2Mx YTU1MjRlNjJjMWEwMzdkZWI4ZGFjYmZlIgotICAgICAgICAgICAgbWQ1c3VtPSI2NDdlZThlZDI2 NmY5YTQxMTdjOGQwYTQ4NTViM2QzZSIvPgotICA8L3RhcmJhbGw+CisgIDxhdXRvdG9vbHMgaWQ9 ImZyZWV0eXBlNiIgYXV0b2dlbi1zaD0iY29uZmlndXJlIj4KKyAgICA8YnJhbmNoIG1vZHVsZT0i ZnJlZXR5cGUvZnJlZXR5cGUtMi40LjExLnRhci5iejIiIHZlcnNpb249IjIuNC4xMSIKKyAgICAg ICAgICAgIHJlcG89InNhdmFubmFoLmdudS5vcmciCisgICAgICAgICAgICBoYXNoPSJzaGEyNTY6 ZWY5ZDBiY2I2NDY0N2Q5ZTUxMjVkYzc1MzRkN2NhMzcxYzk4MzEwZmVjODc2NzdjNDEwZjM5N2Y3 MWZmYmUzZiIKKyAgICAgICAgICAgIG1kNXN1bT0iYjkzNDM1NDg4OTQyNDg2YzhkMGNhMjJlOGY3 NjgwMzQiPgorICAgIDwvYnJhbmNoPgorICA8L2F1dG90b29scz4KIAogICA8YXV0b3Rvb2xzIGlk PSJoYXJmYnV6eiIgYXV0b2dlbi1zaD0iY29uZmlndXJlIj4KICAgICA8YnJhbmNoIG1vZHVsZT0i c29mdHdhcmUvaGFyZmJ1enovcmVsZWFzZS9oYXJmYnV6ei0wLjkuMTQudGFyLmJ6MiIgdmVyc2lv bj0iMC45LjE0Igo= 198821 2013-04-19 00:43:49 -0700 2013-04-20 12:21:42 -0700 Patch bug-106775-20130419094318.patch text/plain 4807 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4NzIzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZGM3N2E1OTMyOTI3MDk4NDlhYTg0YWRlMmQwMGU4ZDYy MGI4ZTI3Ni4uZWU1M2RjYTg5ZGI5MDY3ZWE3Mzk3Y2FjMDRjMzRlOTg1NmY0NmRiMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEzLTA0LTE5ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKwor ICAgICAgICBbR1RLXSBGaXggYmFzZWxpbmUgcG9zaXRpb25pbmcgaXNzdWUgYnkgdXBkYXRpbmcg RnJlZXR5cGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEwNjc3NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogZ3RrL2poYnVpbGQubW9kdWxlczogQnVtcCB0aGUgRnJlZXR5cGUgSmhidWlsZCBkZXBlbmRl bmN5IHRvIDIuNC4xMS4KKyAgICAgICAgKiBndGsvcGF0Y2hlcy9mcmVldHlwZTYtMi40LjExLXRy dWV0eXBlLWZvbnQtaGVpZ2h0LWZpeC5wYXRjaDogQWRkZWQuIFRoaXMgaXMgdGhlIEZyZWV0eXBl CisgICAgICAgIHBhdGNoIChjb21taXR0ZWQgYXMgZTA0NjkzNzIpIHRoYXQgZml4ZXMgcm91bmRp bmcgaXNzdWVzIGZvciBzbWFsbGVyIGZvbnRzLiBJdCBpcyBib3VuZCB0byBiZSBpbmNsdWRlZAor ICAgICAgICBpbiB0aGUgMi40LjEyIHJlbGVhc2Ugb2YgRnJlZXR5cGUgKG5vdCByZWxlYXNlZCB5 ZXQpIGJ1dCBpcyBwcm92aWRlZCBoZXJlIGFzIGl0cyBlZmZlY3Qgb24gYmFzZWxpbmVzIGlzCisg ICAgICAgIGNvbnNpZGVyZWQgcG9zaXRpdmUgYW5kIHdpbGwgcmVkdWNlIHRoZSBhbW91dCBvZiBm dXR1cmUgcmViYXNlbGluaW5nLgorCiAyMDEzLTA0LTE4ICBYdWVmZWkgUmVuICA8eHJlbkBibGFj a2JlcnJ5LmNvbT4KIAogICAgICAgICByZW1vdmUgYnVpbGQgd2FybmluZyh1bnVzZWQgcGFyYW1l dGVyKQpkaWZmIC0tZ2l0IGEvVG9vbHMvZ3RrL2poYnVpbGQubW9kdWxlcyBiL1Rvb2xzL2d0ay9q aGJ1aWxkLm1vZHVsZXMKaW5kZXggNDhjODdhM2MwMWZkYWNlNGUwY2U3ZmRlNDc4NThjZmRlMTU1 YzE5MC4uNGNkODMzMTAxMTlmNGI0Mzk3YjgxZGJjZmM3YTk2NTNlMmM5N2U5ZCAxMDA2NDQKLS0t IGEvVG9vbHMvZ3RrL2poYnVpbGQubW9kdWxlcworKysgYi9Ub29scy9ndGsvamhidWlsZC5tb2R1 bGVzCkBAIC01MSw2ICs1MSw4IEBACiAgICAgICBocmVmPSJmdHA6Ly94bWxzb2Z0Lm9yZyIvPgog ICA8cmVwb3NpdG9yeSB0eXBlPSJnaXQiIG5hbWU9ImdzdHJlYW1lciIKICAgICAgIGhyZWY9Imdp dDovL2Fub25naXQuZnJlZWRlc2t0b3Aub3JnL2dpdC9nc3RyZWFtZXIvIi8+CisgIDxyZXBvc2l0 b3J5IHR5cGU9InRhcmJhbGwiIG5hbWU9InNhdmFubmFoLmdudS5vcmciCisgICAgICBocmVmPSJo dHRwOi8vZG93bmxvYWQuc2F2YW5uYWguZ251Lm9yZy9yZWxlYXNlcy8iLz4KIAogICA8YXV0b3Rv b2xzIGlkPSJtYWtlIiBhdXRvZ2VuLXNoPSJjb25maWd1cmUiPgogICAgIDxicmFuY2ggcmVwbz0i ZnRwLmdudS5vcmciCkBAIC04OCwxMSArOTAsMTQgQEAKICAgICA8YnJhbmNoIHJlcG89ImdpdGh1 Yi5jb20iIG1vZHVsZT0ibXJvYmluc29uL3dlYmtpdGd0ay10ZXN0LWZvbnRzLmdpdCIgY2hlY2tv dXRkaXI9IndlYmtpdGd0ay10ZXN0LWZvbnRzIiB0YWc9IjAuMC40Ii8+CiAgIDwvYXV0b3Rvb2xz PgogCi0gIDx0YXJiYWxsIGlkPSJmcmVldHlwZTYiPgotICAgIDxzb3VyY2UgaHJlZj0iZG93bmxv YWQuc2F2YW5uYWguZ251Lm9yZy9yZWxlYXNlcy9mcmVldHlwZS9mcmVldHlwZS0yLjQuMi50YXIu YnoyIiB2ZXJzaW9uPSIyLjQuMiIKLSAgICAgICAgICAgIGhhc2g9InNoYTI1Njo5YTk4N2FlZjhj NTBkOWJjZmRmZGM5ZjAxMmY4YmQwZGU2MDk1Y2MxYTU1MjRlNjJjMWEwMzdkZWI4ZGFjYmZlIgot ICAgICAgICAgICAgbWQ1c3VtPSI2NDdlZThlZDI2NmY5YTQxMTdjOGQwYTQ4NTViM2QzZSIvPgot ICA8L3RhcmJhbGw+CisgIDxhdXRvdG9vbHMgaWQ9ImZyZWV0eXBlNiIgYXV0b2dlbi1zaD0iY29u ZmlndXJlIj4KKyAgICA8YnJhbmNoIG1vZHVsZT0iZnJlZXR5cGUvZnJlZXR5cGUtMi40LjExLnRh ci5iejIiIHZlcnNpb249IjIuNC4xMSIKKyAgICAgICAgICAgIHJlcG89InNhdmFubmFoLmdudS5v cmciCisgICAgICAgICAgICBoYXNoPSJzaGEyNTY6ZWY5ZDBiY2I2NDY0N2Q5ZTUxMjVkYzc1MzRk N2NhMzcxYzk4MzEwZmVjODc2NzdjNDEwZjM5N2Y3MWZmYmUzZiIKKyAgICAgICAgICAgIG1kNXN1 bT0iYjkzNDM1NDg4OTQyNDg2YzhkMGNhMjJlOGY3NjgwMzQiPgorICAgICAgPHBhdGNoIGZpbGU9 ImZyZWV0eXBlNi0yLjQuMTEtdHJ1ZXR5cGUtZm9udC1oZWlnaHQtZml4LnBhdGNoIiBzdHJpcD0i MSIvPgorICAgIDwvYnJhbmNoPgorICA8L2F1dG90b29scz4KIAogICA8YXV0b3Rvb2xzIGlkPSJo YXJmYnV6eiIgYXV0b2dlbi1zaD0iY29uZmlndXJlIj4KICAgICA8YnJhbmNoIG1vZHVsZT0ic29m dHdhcmUvaGFyZmJ1enovcmVsZWFzZS9oYXJmYnV6ei0wLjkuMTQudGFyLmJ6MiIgdmVyc2lvbj0i MC45LjE0IgpkaWZmIC0tZ2l0IGEvVG9vbHMvZ3RrL3BhdGNoZXMvZnJlZXR5cGU2LTIuNC4xMS10 cnVldHlwZS1mb250LWhlaWdodC1maXgucGF0Y2ggYi9Ub29scy9ndGsvcGF0Y2hlcy9mcmVldHlw ZTYtMi40LjExLXRydWV0eXBlLWZvbnQtaGVpZ2h0LWZpeC5wYXRjaApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4wZmZl NzZiNGVmMDIxOGM3MWUxNjczMGM4ZDQwNmNiNTNkZTdhMDFhCi0tLSAvZGV2L251bGwKKysrIGIv VG9vbHMvZ3RrL3BhdGNoZXMvZnJlZXR5cGU2LTIuNC4xMS10cnVldHlwZS1mb250LWhlaWdodC1m aXgucGF0Y2gKQEAgLTAsMCArMSwzOSBAQAorRnJvbSBlMDQ2OTM3MmJlMzg3MGE1YWQ2MGIyYzQ1 ODZlOWMyODEzNTdiZDI4IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQorRnJvbTogV2VybmVyIExl bWJlcmcgPHdsQGdudS5vcmc+CitEYXRlOiBUdWUsIDIyIEphbiAyMDEzIDEwOjA3OjA3ICswMDAw CitTdWJqZWN0OiBbdHJ1ZXR5cGVdIEZpeCBmb250IGhlaWdodC4KKworKiBzcmMvdHJ1ZXR5cGUv dHRvYmpzLmMgKHR0X3NpemVfcmVzZXQpOiBUaGUgV2luZG93cyByZW5kZXJpbmcKK2VuZ2luZSB1 c2VzIHJvdW5kZWQgdmFsdWVzIG9mIHRoZSBhc2NlbmRlciBhbmQgZGVzY2VuZGVyIHRvIGNvbXB1 dGUKK3RoZSBUcnVlVHlwZSBmb250IGhlaWdodC4KKy0tLQorZGlmZiAtLWdpdCBhL3NyYy90cnVl dHlwZS90dG9ianMuYyBiL3NyYy90cnVldHlwZS90dG9ianMuYworaW5kZXggYzYxYjIxOC4uNTkw YjY2YyAxMDA2NDQKKy0tLSBhL3NyYy90cnVldHlwZS90dG9ianMuYworKysrIGIvc3JjL3RydWV0 eXBlL3R0b2Jqcy5jCitAQCAtNCw3ICs0LDcgQEAKKyAvKiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAqLworIC8q ICAgIE9iamVjdHMgbWFuYWdlciAoYm9keSkuICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICovCisgLyogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKi8KKy0vKiAgQ29weXJpZ2h0 IDE5OTYtMjAxMiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAqLworKy8qICBDb3B5cmlnaHQgMTk5Ni0yMDEzICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICovCisgLyogIERhdmlkIFR1cm5lciwgUm9iZXJ0 IFdpbGhlbG0sIGFuZCBXZXJuZXIgTGVtYmVyZy4gICAgICAgICAgICAgICAgICAgICAgKi8KKyAv KiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAqLworIC8qICBUaGlzIGZpbGUgaXMgcGFydCBvZiB0aGUgRnJlZVR5 cGUgcHJvamVjdCwgYW5kIG1heSBvbmx5IGJlIHVzZWQsICAgICAgICovCitAQCAtMTE3NywxMSAr MTE3NywxMiBAQAorICAgICAgICAgRlRfUElYX1JPVU5EKCBGVF9NdWxGaXgoIGZhY2UtPnJvb3Qu YXNjZW5kZXIsIG1ldHJpY3MtPnlfc2NhbGUgKSApOworICAgICAgIG1ldHJpY3MtPmRlc2NlbmRl ciA9CisgICAgICAgICBGVF9QSVhfUk9VTkQoIEZUX011bEZpeCggZmFjZS0+cm9vdC5kZXNjZW5k ZXIsIG1ldHJpY3MtPnlfc2NhbGUgKSApOworLSAgICAgIG1ldHJpY3MtPmhlaWdodCA9CistICAg ICAgICBGVF9QSVhfUk9VTkQoIEZUX011bEZpeCggZmFjZS0+cm9vdC5oZWlnaHQsIG1ldHJpY3Mt Pnlfc2NhbGUgKSApOworICAgICAgIG1ldHJpY3MtPm1heF9hZHZhbmNlID0KKyAgICAgICAgIEZU X1BJWF9ST1VORCggRlRfTXVsRml4KCBmYWNlLT5yb290Lm1heF9hZHZhbmNlX3dpZHRoLAorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG1ldHJpY3MtPnhfc2NhbGUgKSApOworKwor KyAgICAgIC8qIHRoZSBoZWlnaHQgaXMgZGVyaXZlZCBmcm9tIHJvdW5kZWQgdmFsdWVzICovCisr ICAgICAgbWV0cmljcy0+aGVpZ2h0ID0gbWV0cmljcy0+YXNjZW5kZXIgLSBtZXRyaWNzLT5kZXNj ZW5kZXI7CisgICAgIH0KKyAKKyAgICAgLyogY29tcHV0ZSBuZXcgdHJhbnNmb3JtYXRpb24gKi8K Ky0tCitjZ2l0IHYwLjkuMC4yCg==