106758 2013-01-14 00:20:26 -0800 [EFL] [WebGL] Minor cleanup in PlatformContext. 2013-01-15 00:56:29 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 kalyan.kondapally kalyan.kondapally dino laszlo.gombos lucas.de.marchi noam webkit.review.bot zeno oldest_to_newest 806126 0 kalyan.kondapally 2013-01-14 00:20:26 -0800 We currently have different implementations of CurrentContextWrapper for EGL and GLX. This seems unnecessary and could be cleaned up to have a single implementation. (adding ifdef for the code related to querying current context.) 806158 1 182527 kalyan.kondapally 2013-01-14 01:29:57 -0800 Created attachment 182527 patch 807068 2 182527 webkit.review.bot 2013-01-15 00:56:26 -0800 Comment on attachment 182527 patch Clearing flags on attachment: 182527 Committed r139724: <http://trac.webkit.org/changeset/139724> 807069 3 webkit.review.bot 2013-01-15 00:56:29 -0800 All reviewed patches have been landed. Closing bug. 182527 2013-01-14 01:29:57 -0800 2013-01-15 00:56:26 -0800 patch currentcontextwrapper.patch text/plain 6023 kalyan.kondapally ZGlmZiAtLWdpdCBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCmluZGV4IGQ3YTNlMWEuLjkzNjk4OWQgMTAwNjQ0Ci0tLSBTb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDEz LTAxLTEzICBLb25kYXBhbGx5IEthbHlhbiAgPGthbHlhbi5rb25kYXBhbGx5QGludGVsLmNvbT4K KworICAgICAgICBbRUZMXSBbV2ViR0xdIE1pbm9yIGNsZWFudXAgaW4gUGxhdGZvcm1Db250ZXh0 LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA2NzU4 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgY3Vy cmVudGx5IGhhdmUgZGlmZmVyZW50IGltcGxlbWVudGF0aW9ucyBvZiBDdXJyZW50Q29udGV4dFdy YXBwZXIgZm9yIEVHTCBhbmQgR0xYLgorICAgICAgICBUaGlzIHBhdGNoIGNsZWFucyB1cCB0aGUg Y29kZSB0byB1c2Ugc2FtZSBpbXBsZW1lbnRhdGlvbiBmb3IgYm90aCB0aGUgYmFja2VuZHMuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR0xQbGF0Zm9ybUNvbnRleHQuY3Bw OgorICAgICAgICAoR0xDdXJyZW50Q29udGV4dFdyYXBwZXIpOgorICAgICAgICAoV2ViQ29yZTo6 R0xDdXJyZW50Q29udGV4dFdyYXBwZXI6OkdMQ3VycmVudENvbnRleHRXcmFwcGVyKToKKyAgICAg ICAgKFdlYkNvcmU6OkdMQ3VycmVudENvbnRleHRXcmFwcGVyOjp+R0xDdXJyZW50Q29udGV4dFdy YXBwZXIpOgorCisgICAgICAgIENvbW1vbiBpbXBsZW1lbnRhdGlvbiBmb3IgYm90aCBFR0wgYW5k IEdMWC4KKyAgICAgICAgKFdlYkNvcmU6OmNyZWF0ZU9mZlNjcmVlbkNvbnRleHQpOgorICAgICAg ICAoV2ViQ29yZTo6R0xQbGF0Zm9ybUNvbnRleHQ6OmNyZWF0ZUNvbnRleHQpOgorICAgICAgICAq IHBsYXRmb3JtL2dyYXBoaWNzL3N1cmZhY2VzL2VnbC9FR0xDb250ZXh0LmNwcDoKKyAgICAgICAg KiBwbGF0Zm9ybS9ncmFwaGljcy9zdXJmYWNlcy9lZ2wvRUdMQ29udGV4dC5oOgorICAgICAgICAq IHBsYXRmb3JtL2dyYXBoaWNzL3N1cmZhY2VzL2dseC9HTFhDb250ZXh0Lmg6CisKKyAgICAgICAg UmVtb3ZlZCBjb2RlIHJlbGF0ZWQgdG8gQ3VycmVudENvbnRleHRXcmFwcGVyLgorCiAyMDEzLTAx LTExICBLb25kYXBhbGx5IEthbHlhbiAgPGthbHlhbi5rb25kYXBhbGx5QGludGVsLmNvbT4KCmRp ZmYgLS1naXQgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dMUGxhdGZv cm1Db250ZXh0LmNwcCBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR0xQ bGF0Zm9ybUNvbnRleHQuY3BwCmluZGV4IDU5MjNkNjYuLjRkNDQwZjggMTAwNjQ0Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR0xQbGF0Zm9ybUNvbnRleHQuY3Bw CisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR0xQbGF0Zm9ybUNv bnRleHQuY3BwCkBAIC0zNiw2ICszNiwxMCBAQAogCiAjaW5jbHVkZSAiTm90SW1wbGVtZW50ZWQu aCIKIAorI2lmIEhBVkUoR0xYKQorI2luY2x1ZGUgPEdML2dseC5oPgorI2VuZGlmCisKIG5hbWVz cGFjZSBXZWJDb3JlIHsKIAogI2lmIFVTRShPUEVOR0xfRVNfMikKQEAgLTQ1LDIzICs0OSwzMSBA QCBzdGF0aWMgUEZOR0xHRVRHUkFQSElDU1JFU0VUU1RBVFVTQVJCUFJPQyBnbEdldEdyYXBoaWNz UmVzZXRTdGF0dXMgPSAwOwogI2VuZGlmCiBzdGF0aWMgR0xQbGF0Zm9ybUNvbnRleHQqIG1fY3Vy cmVudENvbnRleHQgPSAwOwogCi1zdGF0aWMgUGFzc093blB0cjxHTFBsYXRmb3JtQ29udGV4dD4g Y3JlYXRlT2ZmU2NyZWVuQ29udGV4dCgpCi17Ci0jaWYgVVNFKEdMWCkKLSAgICByZXR1cm4gYWRv cHRQdHIobmV3IEdMWE9mZlNjcmVlbkNvbnRleHQoKSk7CitjbGFzcyBHTEN1cnJlbnRDb250ZXh0 V3JhcHBlciA6IHB1YmxpYyBHTFBsYXRmb3JtQ29udGV4dCB7CisKK3B1YmxpYzoKKyAgICBHTEN1 cnJlbnRDb250ZXh0V3JhcHBlcigpCisgICAgICAgIDogR0xQbGF0Zm9ybUNvbnRleHQoKQorICAg IHsKKyAgICAgICAgLy8gRklYTUU6OiBUaGlzIGlzIGEgd29ya2Fyb3VuZCB1bnRpbCBzdXBwb3J0 IHRvIGJ1aWxkIGV2YXMgd2l0aCBFR0wgaGFzIGJlZW4gYWRkZWQuCisjaWYgVVNFKEdMWCkgfHwg UExBVEZPUk0oRUZMKQorICAgICAgICBtX2NvbnRleHRIYW5kbGUgPSBnbFhHZXRDdXJyZW50Q29u dGV4dCgpOwogI2VsaWYgVVNFKEVHTCkKLSAgICByZXR1cm4gYWRvcHRQdHIobmV3IEVHTE9mZlNj cmVlbkNvbnRleHQoKSk7CisgICAgICAgIG1fY29udGV4dEhhbmRsZSA9IGVnbEdldEN1cnJlbnRD b250ZXh0KCk7CiAjZW5kaWYKKyAgICAgICAgaWYgKG1fY29udGV4dEhhbmRsZSkKKyAgICAgICAg ICAgIG1fY3VycmVudENvbnRleHQgPSB0aGlzOworICAgIH0KIAotICAgIHJldHVybiBudWxscHRy OwotfQorICAgIHZpcnR1YWwgfkdMQ3VycmVudENvbnRleHRXcmFwcGVyKCkgeyB9Cit9OwogCi1z dGF0aWMgUGFzc093blB0cjxHTFBsYXRmb3JtQ29udGV4dD4gY3JlYXRlQ3VycmVudENvbnRleHRX cmFwcGVyKCkKK3N0YXRpYyBQYXNzT3duUHRyPEdMUGxhdGZvcm1Db250ZXh0PiBjcmVhdGVPZmZT Y3JlZW5Db250ZXh0KCkKIHsKICNpZiBVU0UoR0xYKQotICAgIHJldHVybiBhZG9wdFB0cihuZXcg R0xYQ3VycmVudENvbnRleHRXcmFwcGVyKCkpOworICAgIHJldHVybiBhZG9wdFB0cihuZXcgR0xY T2ZmU2NyZWVuQ29udGV4dCgpKTsKICNlbGlmIFVTRShFR0wpCi0gICAgcmV0dXJuIGFkb3B0UHRy KG5ldyBFR0xDdXJyZW50Q29udGV4dFdyYXBwZXIoKSk7CisgICAgcmV0dXJuIGFkb3B0UHRyKG5l dyBFR0xPZmZTY3JlZW5Db250ZXh0KCkpOwogI2VuZGlmCiAKICAgICByZXR1cm4gbnVsbHB0cjsK QEAgLTEwNCwxMiArMTE2LDEyIEBAIFBhc3NPd25QdHI8R0xQbGF0Zm9ybUNvbnRleHQ+IEdMUGxh dGZvcm1Db250ZXh0OjpjcmVhdGVDb250ZXh0KEdyYXBoaWNzQ29udGV4dDNECiAKICAgICBzd2l0 Y2ggKHJlbmRlclN0eWxlKSB7CiAgICAgY2FzZSBHcmFwaGljc0NvbnRleHQzRDo6UmVuZGVyT2Zm c2NyZWVuOgotICAgICAgICBpZiAoT3duUHRyPEdMUGxhdGZvcm1Db250ZXh0PiBnbHhDb250ZXh0 ID0gY3JlYXRlT2ZmU2NyZWVuQ29udGV4dCgpKQotICAgICAgICAgICAgcmV0dXJuIGdseENvbnRl eHQucmVsZWFzZSgpOworICAgICAgICBpZiAoT3duUHRyPEdMUGxhdGZvcm1Db250ZXh0PiBjb250 ZXh0ID0gY3JlYXRlT2ZmU2NyZWVuQ29udGV4dCgpKQorICAgICAgICAgICAgcmV0dXJuIGNvbnRl eHQucmVsZWFzZSgpOwogICAgICAgICBicmVhazsKICAgICBjYXNlIEdyYXBoaWNzQ29udGV4dDNE OjpSZW5kZXJUb0N1cnJlbnRHTENvbnRleHQ6Ci0gICAgICAgIGlmIChPd25QdHI8R0xQbGF0Zm9y bUNvbnRleHQ+IGdseENvbnRleHQgPSBjcmVhdGVDdXJyZW50Q29udGV4dFdyYXBwZXIoKSkKLSAg ICAgICAgICAgIHJldHVybiBnbHhDb250ZXh0LnJlbGVhc2UoKTsKKyAgICAgICAgaWYgKE93blB0 cjxHTFBsYXRmb3JtQ29udGV4dD4gY29udGV4dCA9IGFkb3B0UHRyKG5ldyBHTEN1cnJlbnRDb250 ZXh0V3JhcHBlcigpKSkKKyAgICAgICAgICAgIHJldHVybiBjb250ZXh0LnJlbGVhc2UoKTsKICAg ICAgICAgYnJlYWs7CiAgICAgY2FzZSBHcmFwaGljc0NvbnRleHQzRDo6UmVuZGVyRGlyZWN0bHlU b0hvc3RXaW5kb3c6CiAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwpkaWZmIC0tZ2l0IFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3N1cmZhY2VzL2VnbC9FR0xDb250ZXh0LmNw cCBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9zdXJmYWNlcy9lZ2wvRUdMQ29udGV4 dC5jcHAKaW5kZXggM2MwMmJiNC4uNzg5YjY5YiAxMDA2NDQKLS0tIFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3N1cmZhY2VzL2VnbC9FR0xDb250ZXh0LmNwcAorKysgU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc3VyZmFjZXMvZWdsL0VHTENvbnRleHQuY3BwCkBAIC0z MCwxMCArMzAsNiBAQAogCiAjaW5jbHVkZSA8d3RmL3RleHQvV1RGU3RyaW5nLmg+CiAKLSNpZiBI QVZFKEdMWCkKLSNpbmNsdWRlIDxHTC9nbHguaD4KLSNlbmRpZgotCiBuYW1lc3BhY2UgV2ViQ29y ZSB7CiAKIHN0YXRpYyBjb25zdCBFR0xpbnQgY29udGV4dEF0dHJpYnV0ZXNbXSA9IHsKQEAgLTY1 LDE3ICs2MSw2IEBAIHN0YXRpYyBib29sIGlzUm9idXN0bmVzc0V4dFN1cHBvcnRlZChFR0xEaXNw bGF5IGRpc3BsYXkpCiAgICAgcmV0dXJuIGlzUm9idXN0bmVzc0V4dGVuc2lvblN1cHBvcnRlZDsK IH0KIAotRUdMQ3VycmVudENvbnRleHRXcmFwcGVyOjpFR0xDdXJyZW50Q29udGV4dFdyYXBwZXIo KQotICAgIDogR0xQbGF0Zm9ybUNvbnRleHQoKQotewotfQotCi0vLyBGSVhNRTogVGhpcyBpcyBh IHRlbXBvcmFyeSB3b3JrYXJvdW5kIHVudGlsIHdlIGFyZSBhYmxlIHRvIGJ1aWxkIGV2YXMgd2l0 aCBFR0wgc3VwcG9ydC4KLVBsYXRmb3JtQ29udGV4dCBFR0xDdXJyZW50Q29udGV4dFdyYXBwZXI6 OmhhbmRsZSgpIGNvbnN0Ci17Ci0gICAgcmV0dXJuIGdsWEdldEN1cnJlbnRDb250ZXh0KCk7Ci19 Ci0KIEVHTE9mZlNjcmVlbkNvbnRleHQ6OkVHTE9mZlNjcmVlbkNvbnRleHQoKQogICAgIDogR0xQ bGF0Zm9ybUNvbnRleHQoKQogICAgICwgbV9kaXNwbGF5KDApCmRpZmYgLS1naXQgU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc3VyZmFjZXMvZWdsL0VHTENvbnRleHQuaCBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9zdXJmYWNlcy9lZ2wvRUdMQ29udGV4dC5oCmluZGV4 IDVhOTVhMTguLmVlMTMyY2MgMTAwNjQ0Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9zdXJmYWNlcy9lZ2wvRUdMQ29udGV4dC5oCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9zdXJmYWNlcy9lZ2wvRUdMQ29udGV4dC5oCkBAIC0zMiwxNCArMzIsNiBAQAog CiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLWNsYXNzIEVHTEN1cnJlbnRDb250ZXh0V3JhcHBlciA6 IHB1YmxpYyBHTFBsYXRmb3JtQ29udGV4dCB7Ci0KLXB1YmxpYzoKLSAgICBFR0xDdXJyZW50Q29u dGV4dFdyYXBwZXIoKTsKLSAgICB2aXJ0dWFsIFBsYXRmb3JtQ29udGV4dCBoYW5kbGUoKSBjb25z dCBPVkVSUklERTsKLSAgICB2aXJ0dWFsIH5FR0xDdXJyZW50Q29udGV4dFdyYXBwZXIoKSB7IH0K LX07Ci0KIGNsYXNzIEVHTE9mZlNjcmVlbkNvbnRleHQgOiBwdWJsaWMgR0xQbGF0Zm9ybUNvbnRl eHQgewogCiBwdWJsaWM6CmRpZmYgLS1naXQgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3Mvc3VyZmFjZXMvZ2x4L0dMWENvbnRleHQuaCBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9zdXJmYWNlcy9nbHgvR0xYQ29udGV4dC5oCmluZGV4IDc3NTAyZjAuLmNiZGUwZWYgMTAw NjQ0Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9zdXJmYWNlcy9nbHgvR0xY Q29udGV4dC5oCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9zdXJmYWNlcy9n bHgvR0xYQ29udGV4dC5oCkBAIC0zMiwxOCArMzIsNiBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7 CiAKLWNsYXNzIEdMWEN1cnJlbnRDb250ZXh0V3JhcHBlciA6IHB1YmxpYyBHTFBsYXRmb3JtQ29u dGV4dCB7Ci0KLXB1YmxpYzoKLSAgICBHTFhDdXJyZW50Q29udGV4dFdyYXBwZXIoKQotICAgICAg ICA6IEdMUGxhdGZvcm1Db250ZXh0KCkKLSAgICB7Ci0gICAgICAgIG1fY29udGV4dEhhbmRsZSA9 IGdsWEdldEN1cnJlbnRDb250ZXh0KCk7Ci0gICAgfQotCi0gICAgdmlydHVhbCB+R0xYQ3VycmVu dENvbnRleHRXcmFwcGVyKCkgeyB9Ci19OwotCiBjbGFzcyBHTFhPZmZTY3JlZW5Db250ZXh0IDog cHVibGljIEdMUGxhdGZvcm1Db250ZXh0IHsKIAogcHVibGljOgo=