106753 2013-01-13 21:26:22 -0800 DFG phases that store per-node information should store it in Node itself rather than using a secondary vector 2013-01-13 23:01:34 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff oliver sam oldest_to_newest 806066 0 fpizlo 2013-01-13 21:26:22 -0800 This is a prerequisite for getting rid of NodeIndex. 806069 1 182504 fpizlo 2013-01-13 21:28:33 -0800 Created attachment 182504 the patch 806071 2 182504 ggaren 2013-01-13 21:31:11 -0800 Comment on attachment 182504 the patch r=me 806099 3 fpizlo 2013-01-13 23:01:34 -0800 Landed in http://trac.webkit.org/changeset/139586 182504 2013-01-13 21:28:33 -0800 2013-01-13 21:31:11 -0800 the patch node.patch text/plain 6536 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTM5NTgyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBA CisyMDEzLTAxLTEzICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg REZHIHBoYXNlcyB0aGF0IHN0b3JlIHBlci1ub2RlIGluZm9ybWF0aW9uIHNob3VsZCBzdG9yZSBp dCBpbiBOb2RlIGl0c2VsZiByYXRoZXIgdGhhbiB1c2luZyBhIHNlY29uZGFyeSB2ZWN0b3IKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNjc1MworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZGZnL0RGR0Fi c3RyYWN0U3RhdGUuY3BwOgorICAgICAgICAoSlNDOjpERkc6OkFic3RyYWN0U3RhdGU6OkFic3Ry YWN0U3RhdGUpOgorICAgICAgICAoSlNDOjpERkc6OkFic3RyYWN0U3RhdGU6OmJlZ2luQmFzaWNC bG9jayk6CisgICAgICAgIChKU0M6OkRGRzo6QWJzdHJhY3RTdGF0ZTo6ZHVtcCk6CisgICAgICAg ICogZGZnL0RGR0Fic3RyYWN0U3RhdGUuaDoKKyAgICAgICAgKEpTQzo6REZHOjpBYnN0cmFjdFN0 YXRlOjpmb3JOb2RlKToKKyAgICAgICAgKEFic3RyYWN0U3RhdGUpOgorICAgICAgICAqIGRmZy9E RkdDRkdTaW1wbGlmaWNhdGlvblBoYXNlLmNwcDoKKyAgICAgICAgKiBkZmcvREZHQ1NFUGhhc2Uu Y3BwOgorICAgICAgICAoSlNDOjpERkc6OkNTRVBoYXNlOjpDU0VQaGFzZSk6CisgICAgICAgIChK U0M6OkRGRzo6Q1NFUGhhc2U6OnBlcmZvcm1TdWJzdGl0dXRpb24pOgorICAgICAgICAoSlNDOjpE Rkc6OkNTRVBoYXNlOjpzZXRSZXBsYWNlbWVudCk6CisgICAgICAgIChDU0VQaGFzZSk6CisgICAg ICAgICogZGZnL0RGR05vZGUuaDoKKyAgICAgICAgKE5vZGUpOgorCiAyMDEzLTAxLTEyICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQg YnVpbGQgZml4LgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBYnN0cmFjdFN0 YXRlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0Fic3Ry YWN0U3RhdGUuY3BwCShyZXZpc2lvbiAxMzk1NTQpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUv ZGZnL0RGR0Fic3RyYWN0U3RhdGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00Miw3ICs0Miw2IEBA IEFic3RyYWN0U3RhdGU6OkFic3RyYWN0U3RhdGUoR3JhcGgmIGdyYXAKICAgICAsIG1fdmFyaWFi bGVzKG1fY29kZUJsb2NrLT5udW1QYXJhbWV0ZXJzKCksIGdyYXBoLm1fbG9jYWxWYXJzKQogICAg ICwgbV9ibG9jaygwKQogewotICAgIG1fbm9kZXMucmVzaXplKGdyYXBoLnNpemUoKSk7CiB9CiAK IEFic3RyYWN0U3RhdGU6On5BYnN0cmFjdFN0YXRlKCkgeyB9CkBAIC01NSwxMiArNTQsOCBAQCB2 b2lkIEFic3RyYWN0U3RhdGU6OmJlZ2luQmFzaWNCbG9jayhCYXNpCiAgICAgQVNTRVJUKGJhc2lj QmxvY2stPnZhcmlhYmxlc0F0VGFpbC5udW1iZXJPZkxvY2FscygpID09IGJhc2ljQmxvY2stPnZh bHVlc0F0VGFpbC5udW1iZXJPZkxvY2FscygpKTsKICAgICBBU1NFUlQoYmFzaWNCbG9jay0+dmFy aWFibGVzQXRIZWFkLm51bWJlck9mTG9jYWxzKCkgPT0gYmFzaWNCbG9jay0+dmFyaWFibGVzQXRU YWlsLm51bWJlck9mTG9jYWxzKCkpOwogICAgIAotICAgIC8vIFRoaXMgaXMgdXN1YWxseSBhIG5v LW9wLCBidXQgaXQgaXMgcG9zc2libGUgdGhhdCB0aGUgZ3JhcGggaGFzIGdyb3duIHNpbmNlIHRo ZQotICAgIC8vIGFic3RyYWN0IHN0YXRlIHdhcyBsYXN0IHVzZWQuCi0gICAgbV9ub2Rlcy5yZXNp emUobV9ncmFwaC5zaXplKCkpOwotICAgIAogICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgYmFz aWNCbG9jay0+c2l6ZSgpOyBpKyspCi0gICAgICAgIG1fbm9kZXNbYmFzaWNCbG9jay0+YXQoaSld LmNsZWFyKCk7CisgICAgICAgIGZvck5vZGUoYmFzaWNCbG9jay0+YXQoaSkpLmNsZWFyKCk7CiAK ICAgICBtX3ZhcmlhYmxlcyA9IGJhc2ljQmxvY2stPnZhbHVlc0F0SGVhZDsKICAgICBtX2hhdmVT dHJ1Y3R1cmVzID0gZmFsc2U7CkBAIC0yMDMxLDcgKzIwMjYsNyBAQCB2b2lkIEFic3RyYWN0U3Rh dGU6OmR1bXAoUHJpbnRTdHJlYW0mIG91CiAgICAgYm9vbCBmaXJzdCA9IHRydWU7CiAgICAgZm9y IChzaXplX3QgaSA9IDA7IGkgPCBtX2Jsb2NrLT5zaXplKCk7ICsraSkgewogICAgICAgICBOb2Rl SW5kZXggaW5kZXggPSBtX2Jsb2NrLT5hdChpKTsKLSAgICAgICAgQWJzdHJhY3RWYWx1ZSYgdmFs dWUgPSBtX25vZGVzW2luZGV4XTsKKyAgICAgICAgQWJzdHJhY3RWYWx1ZSYgdmFsdWUgPSBmb3JO b2RlKGluZGV4KTsKICAgICAgICAgaWYgKHZhbHVlLmlzQ2xlYXIoKSkKICAgICAgICAgICAgIGNv bnRpbnVlOwogICAgICAgICBpZiAoZmlyc3QpCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUv ZGZnL0RGR0Fic3RyYWN0U3RhdGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENv cmUvZGZnL0RGR0Fic3RyYWN0U3RhdGUuaAkocmV2aXNpb24gMTM5NTU0KQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL2RmZy9ERkdBYnN0cmFjdFN0YXRlLmgJKHdvcmtpbmcgY29weSkKQEAgLTk5 LDcgKzk5LDcgQEAgcHVibGljOgogICAgIAogICAgIEFic3RyYWN0VmFsdWUmIGZvck5vZGUoTm9k ZUluZGV4IG5vZGVJbmRleCkKICAgICB7Ci0gICAgICAgIHJldHVybiBtX25vZGVzW25vZGVJbmRl eF07CisgICAgICAgIHJldHVybiBtX2dyYXBoW25vZGVJbmRleF0udmFsdWU7CiAgICAgfQogICAg IAogICAgIEFic3RyYWN0VmFsdWUmIGZvck5vZGUoRWRnZSBub2RlVXNlKQpAQCAtMjYyLDcgKzI2 Miw2IEBAIHByaXZhdGU6CiAgICAgQ29kZUJsb2NrKiBtX2NvZGVCbG9jazsKICAgICBHcmFwaCYg bV9ncmFwaDsKICAgICAKLSAgICBWZWN0b3I8QWJzdHJhY3RWYWx1ZSwgNjQ+IG1fbm9kZXM7CiAg ICAgT3BlcmFuZHM8QWJzdHJhY3RWYWx1ZT4gbV92YXJpYWJsZXM7CiAgICAgQmFzaWNCbG9jayog bV9ibG9jazsKICAgICBib29sIG1faGF2ZVN0cnVjdHVyZXM7CkluZGV4OiBTb3VyY2UvSmF2YVNj cmlwdENvcmUvZGZnL0RGR0NGR1NpbXBsaWZpY2F0aW9uUGhhc2UuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQ0ZHU2ltcGxpZmljYXRpb25QaGFzZS5jcHAJ KHJldmlzaW9uIDEzOTU1NCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQ0ZHU2lt cGxpZmljYXRpb25QaGFzZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM0LDYgKzM0LDcgQEAKICNp bmNsdWRlICJERkdJbnNlcnRpb25TZXQuaCIKICNpbmNsdWRlICJERkdQaGFzZS5oIgogI2luY2x1 ZGUgIkRGR1ZhbGlkYXRlLmgiCisjaW5jbHVkZSAiT3BlcmF0aW9ucy5oIgogCiBuYW1lc3BhY2Ug SlNDIHsgbmFtZXNwYWNlIERGRyB7CiAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcv REZHQ1NFUGhhc2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcv REZHQ1NFUGhhc2UuY3BwCShyZXZpc2lvbiAxMzk1NTQpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENv cmUvZGZnL0RGR0NTRVBoYXNlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzksMTEgKzM5LDggQEAg cHVibGljOgogICAgIENTRVBoYXNlKEdyYXBoJiBncmFwaCkKICAgICAgICAgOiBQaGFzZShncmFw aCwgImNvbW1vbiBzdWJleHByZXNzaW9uIGVsaW1pbmF0aW9uIikKICAgICB7Ci0gICAgICAgIC8v IFJlcGxhY2VtZW50cyBhcmUgdXNlZCB0byBpbXBsZW1lbnQgbG9jYWwgY29tbW9uIHN1YmV4cHJl c3Npb24gZWxpbWluYXRpb24uCi0gICAgICAgIG1fcmVwbGFjZW1lbnRzLnJlc2l6ZShtX2dyYXBo LnNpemUoKSk7Ci0gICAgICAgIAogICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgbV9n cmFwaC5zaXplKCk7ICsraSkKLSAgICAgICAgICAgIG1fcmVwbGFjZW1lbnRzW2ldID0gTm9Ob2Rl OworICAgICAgICAgICAgbV9ncmFwaFtpXS5yZXBsYWNlbWVudCA9IE5vTm9kZTsKICAgICAgICAg CiAgICAgICAgIG1fcmVsZXZhbnRUb09TUi5yZXNpemUobV9ncmFwaC5zaXplKCkpOwogICAgIH0K QEAgLTEwMDUsNyArMTAwMiw3IEBAIHByaXZhdGU6CiAgICAgICAgICAgICByZXR1cm47CiAgICAg ICAgIAogICAgICAgICAvLyBDaGVjayBpZiB0aGVyZSBpcyBhbnkgcmVwbGFjZW1lbnQuCi0gICAg ICAgIE5vZGVJbmRleCByZXBsYWNlbWVudCA9IG1fcmVwbGFjZW1lbnRzW2NoaWxkLmluZGV4KCld OworICAgICAgICBOb2RlSW5kZXggcmVwbGFjZW1lbnQgPSBtX2dyYXBoW2NoaWxkLmluZGV4KCld LnJlcGxhY2VtZW50OwogICAgICAgICBpZiAocmVwbGFjZW1lbnQgPT0gTm9Ob2RlKQogICAgICAg ICAgICAgcmV0dXJuOwogICAgICAgICAKQEAgLTEwMTMsNyArMTAxMCw3IEBAIHByaXZhdGU6CiAg ICAgICAgIAogICAgICAgICAvLyBUaGVyZSBpcyBkZWZpbml0ZWx5IGEgcmVwbGFjZW1lbnQuIEFz c2VydCB0aGF0IHRoZSByZXBsYWNlbWVudCBkb2VzIG5vdAogICAgICAgICAvLyBoYXZlIGEgcmVw bGFjZW1lbnQuCi0gICAgICAgIEFTU0VSVChtX3JlcGxhY2VtZW50c1tjaGlsZC5pbmRleCgpXSA9 PSBOb05vZGUpOworICAgICAgICBBU1NFUlQobV9ncmFwaFtjaGlsZC5pbmRleCgpXS5yZXBsYWNl bWVudCA9PSBOb05vZGUpOwogICAgICAgICAKICAgICAgICAgaWYgKGFkZFJlZikKICAgICAgICAg ICAgIG1fZ3JhcGgucmVmKGNoaWxkKTsKQEAgLTEwNjAsNyArMTA1Nyw3IEBAIHByaXZhdGU6CiAg ICAgICAgIGVsaW1pbmF0ZUlycmVsZXZhbnRQaGFudG9tQ2hpbGRyZW4obm9kZSk7CiAgICAgICAg IAogICAgICAgICAvLyBBdCB0aGlzIHBvaW50IHdlIHdpbGwgZWxpbWluYXRlIGFsbCByZWZlcmVu Y2VzIHRvIHRoaXMgbm9kZS4KLSAgICAgICAgbV9yZXBsYWNlbWVudHNbbV9jb21waWxlSW5kZXhd ID0gcmVwbGFjZW1lbnQ7CisgICAgICAgIG1fZ3JhcGhbbV9jb21waWxlSW5kZXhdLnJlcGxhY2Vt ZW50ID0gcmVwbGFjZW1lbnQ7CiAgICAgICAgIAogICAgICAgICBtX2NoYW5nZWQgPSB0cnVlOwog ICAgICAgICAKQEAgLTE0NTksNyArMTQ1Niw2IEBAIHByaXZhdGU6CiAgICAgQmFzaWNCbG9jayog bV9jdXJyZW50QmxvY2s7CiAgICAgTm9kZUluZGV4IG1fY29tcGlsZUluZGV4OwogICAgIHVuc2ln bmVkIG1faW5kZXhJbkJsb2NrOwotICAgIFZlY3RvcjxOb2RlSW5kZXgsIDE2PiBtX3JlcGxhY2Vt ZW50czsKICAgICBGaXhlZEFycmF5PHVuc2lnbmVkLCBMYXN0Tm9kZVR5cGU+IG1fbGFzdFNlZW47 CiAgICAgRmFzdEJpdFZlY3RvciBtX3JlbGV2YW50VG9PU1I7CiAgICAgYm9vbCBtX2NoYW5nZWQ7 IC8vIE9ubHkgdHJhY2tzIGNoYW5nZXMgdGhhdCBoYXZlIGEgc3Vic3RhbnRpdmUgZWZmZWN0IG9u IG90aGVyIG9wdGltaXphdGlvbnMuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RG R05vZGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR05vZGUu aAkocmV2aXNpb24gMTM5NTU0KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdOb2Rl LmgJKHdvcmtpbmcgY29weSkKQEAgLTMyLDYgKzMyLDcgQEAKIAogI2luY2x1ZGUgIkNvZGVCbG9j ay5oIgogI2luY2x1ZGUgIkNvZGVPcmlnaW4uaCIKKyNpbmNsdWRlICJERkdBYnN0cmFjdFZhbHVl LmgiCiAjaW5jbHVkZSAiREZHQWRqYWNlbmN5TGlzdC5oIgogI2luY2x1ZGUgIkRGR0FycmF5TW9k ZS5oIgogI2luY2x1ZGUgIkRGR0NvbW1vbi5oIgpAQCAtMTE5Miw2ICsxMTkzLDExIEBAIHByaXZh dGU6CiAgICAgdW5zaWduZWQgbV9vcEluZm8yOwogICAgIC8vIFRoZSBwcmVkaWN0aW9uIGFzY3Jp YmVkIHRvIHRoaXMgbm9kZSBhZnRlciBwcm9wYWdhdGlvbi4KICAgICBTcGVjdWxhdGVkVHlwZSBt X3ByZWRpY3Rpb247CisKK3B1YmxpYzoKKyAgICAvLyBGaWVsZHMgdXNlZCBieSB2YXJpb3VzIGFu YWx5c2VzLgorICAgIEFic3RyYWN0VmFsdWUgdmFsdWU7CisgICAgTm9kZUluZGV4IHJlcGxhY2Vt ZW50OwogfTsKIAogfSB9IC8vIG5hbWVzcGFjZSBKU0M6OkRGRwo=