106737 2013-01-12 23:50:52 -0800 Make ninja the default build system for build-webkit --chromium on mac 2013-01-21 14:05:51 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 104434 105597 107387 107470 1 thakis thakis dpranke webkit.review.bot oldest_to_newest 805938 0 thakis 2013-01-12 23:50:52 -0800 Like bug 104434, but for chromium/mac. 805940 1 thakis 2013-01-12 23:53:50 -0800 As it turns out, my attempt to make nrwt find the right binary automatically in http://trac.webkit.org/changeset/138294 wasn't quite right: it looks in Source/WebKit/chromium/xcodebuild/Release/DumpRenderTree.app/Contents/MacOS/DumpRenderTree (good) and Source/WebKit/chromium/out/Release/DumpRenderTree.app/Contents/MacOS/DumpRenderTree (bad, should look in out/Release/DumpRenderTree.app/Contents/MacOS/DumpRenderTree instead). Since NRWT is so lasagna-code-y, it's not obvious how to fix that. I'll look at it some. 805942 2 thakis 2013-01-12 23:57:55 -0800 Hey, I think my patch in bug 105597 probably addresses that. I should land it. 805983 3 thakis 2013-01-13 10:08:59 -0800 Looks like this works now, at least with a standalone webkit build. 805985 4 thakis 2013-01-13 10:22:08 -0800 With a standalone build, layout_tests/port/chromium.py's _static_build_path looks in these places: /Users/thakis/src/WebKit/Source/WebKit/chromium/xcodebuild/Release/DumpRenderTree.app/Contents/MacOS/DumpRenderTree /Users/thakis/src/WebKit/Source/WebKit/chromium/out/Release/DumpRenderTree.app/Contents/MacOS/DumpRenderTree /Users/thakis/src/WebKit/xcodebuild/Release/DumpRenderTree.app/Contents/MacOS/DumpRenderTree /Users/thakis/src/WebKit/out/Release/DumpRenderTree.app/Contents/MacOS/DumpRenderTree This includes the two right locations, so things work. In a webkit-in-chromium build, it looks in /Users/thakis/src/chrome/src/xcodebuild/Release/DumpRenderTree.app/Contents/MacOS/DumpRenderTree /Users/thakis/src/chrome/src/out/Release/DumpRenderTree.app/Contents/MacOS/DumpRenderTree /Users/thakis/src/chrome/src/third_party/WebKit/xcodebuild/Release/DumpRenderTree.app/Contents/MacOS/DumpRenderTree /Users/thakis/src/chrome/src/third_party/WebKit/out/Release/DumpRenderTree.app/Contents/MacOS/DumpRenderTree This is _almost_ right, but it doesn't look in third_party/WebKit/Source/WebKit/chromium/xcodebuild. However, that's already the case in trunk and nobody's complaining, so I guess nobody is doing webkit-in-chromium builds _and_ builds with xcodebuild and build-webkit. 805987 5 thakis 2013-01-13 10:35:07 -0800 Filed bug 106745 for the problem in comment 4. 805988 6 182487 thakis 2013-01-13 10:36:59 -0800 Created attachment 182487 Patch 805989 7 thakis 2013-01-13 10:37:39 -0800 I think this should work, but let's wait with landing this until next weekend, to see if there are any problems with the ninja transition on linux. 806587 8 182487 eric 2013-01-14 13:44:53 -0800 Comment on attachment 182487 Patch I wish to buy this product and or service. I might have written this as ! win however. 811470 9 182487 webkit.review.bot 2013-01-19 14:45:50 -0800 Comment on attachment 182487 Patch Clearing flags on attachment: 182487 Committed r140260: <http://trac.webkit.org/changeset/140260> 811471 10 webkit.review.bot 2013-01-19 14:45:54 -0800 All reviewed patches have been landed. Closing bug. 811507 11 webkit.review.bot 2013-01-19 17:26:51 -0800 Re-opened since this is blocked by bug 107387 811550 12 thakis 2013-01-19 20:52:16 -0800 This is blocked on https://code.google.com/p/chromium/issues/detail?id=171146 812357 13 thakis 2013-01-21 13:09:42 -0800 The hyphen stuff should now work. Let's try this again. 812359 14 182487 webkit.review.bot 2013-01-21 13:13:00 -0800 Comment on attachment 182487 Patch Rejecting attachment 182487 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue /mnt/git/webkit-commit-queue/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/16039187 812360 15 183825 thakis 2013-01-21 13:15:53 -0800 Created attachment 183825 Patch for landing 812361 16 183825 thakis 2013-01-21 13:18:16 -0800 Comment on attachment 183825 Patch for landing I fail at webkit-patch 812365 17 183827 thakis 2013-01-21 13:27:53 -0800 Created attachment 183827 Patch for landing 812382 18 183827 webkit.review.bot 2013-01-21 14:05:46 -0800 Comment on attachment 183827 Patch for landing Clearing flags on attachment: 183827 Committed r140360: <http://trac.webkit.org/changeset/140360> 812384 19 webkit.review.bot 2013-01-21 14:05:51 -0800 All reviewed patches have been landed. Closing bug. 182487 2013-01-13 10:36:59 -0800 2013-01-21 13:15:49 -0800 Patch bug-106737-20130113103402.patch text/plain 1063 thakis U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5NTcwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjliNGMwMzMyY2FhOGIwZjUxZWQ5OTM1Y2VmYTgzYTcw ZTU1ZDYyNC4uNWExMGFhNDEzYjRmZWY0YjljMTk5MjgxMjczN2ExYmQ4YmUxZTYxMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDEzLTAxLTEzICBOaWNvIFdlYmVyICA8dGhha2lzQGNocm9taXVtLm9yZz4KKworICAg ICAgICBNYWtlIG5pbmphIHRoZSBkZWZhdWx0IGJ1aWxkIHN5c3RlbSBmb3IgYnVpbGQtd2Via2l0 IC0tY2hyb21pdW0gb24gbWFjCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMDY3MzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFNjcmlwdHMvdXBkYXRlLXdlYmtpdC1jaHJvbWl1bToKKwogMjAxMy0wMS0x MyAgSm9uYXRoYW4gTGl1ICA8bmV0MTQ3QGdtYWlsLmNvbT4KIAogICAgICAgICBGaXggQ09ORklH IG1pc3NpbmcgbGlua19wa2djb25maWcgb24gV2luZG93cwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2Ny aXB0cy91cGRhdGUtd2Via2l0LWNocm9taXVtIGIvVG9vbHMvU2NyaXB0cy91cGRhdGUtd2Via2l0 LWNocm9taXVtCmluZGV4IDk0NGE3NDc5ODIyZWE3N2ExNDI3YjRjMjg0MWYzZWYxY2M3MjcyMTUu LmNjY2QzN2Q5ZmVhNjFkMjE0NDFiY2EzOWM5MTY4YjM4MGI4YjBhMzAgMTAwNzU1Ci0tLSBhL1Rv b2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtpdC1jaHJvbWl1bQorKysgYi9Ub29scy9TY3JpcHRzL3Vw ZGF0ZS13ZWJraXQtY2hyb21pdW0KQEAgLTY2LDcgKzY2LDcgQEAgaWYgKGlzQ2hyb21pdW1BbmRy b2lkKCkpIHsKIH0KIAogbXkgJGZvcmNlID0gMDsKLW15ICR1c2VOaW5qYSA9ICReTyBlcSAibGlu dXgiOworbXkgJHVzZU5pbmphID0gJF5PIGVxICJsaW51eCIgfHwgJF5PIGVxICJkYXJ3aW4iOwog CiBHZXRPcHRpb25zKAogICAnZm9yY2UnID0+IFwkZm9yY2UsCg== 183825 2013-01-21 13:15:53 -0800 2013-01-21 13:27:51 -0800 Patch for landing bug-106737-20130121131257.patch text/plain 28 thakis U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwMjA5Cg== 183827 2013-01-21 13:27:53 -0800 2013-01-21 14:05:46 -0800 Patch for landing bug-106737-20130121132457.patch text/plain 1076 thakis U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwMzUzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjgzZDczNzAwMWMzNDA0ZDBkMjRiN2YxZmZkM2Q2Mjkw M2RhNTZlZC4uZjE2ZjE3Yzc0NzQxYmZiMWNhMzJkMDM4OTVjY2I2NmVjZTMyNTRjNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDEzLTAxLTIxICBOaWNvIFdlYmVyICA8dGhha2lzQGNocm9taXVtLm9yZz4KKworICAg ICAgICBNYWtlIG5pbmphIHRoZSBkZWZhdWx0IGJ1aWxkIHN5c3RlbSBmb3IgYnVpbGQtd2Via2l0 IC0tY2hyb21pdW0gb24gbWFjCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMDY3MzcKKworICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KKwor ICAgICAgICAqIFNjcmlwdHMvdXBkYXRlLXdlYmtpdC1jaHJvbWl1bToKKwogMjAxMy0wMS0yMSAg Q2hyaXN0b3BoZSBEdW1leiAgPGNocmlzdG9waGUuZHVtZXpAaW50ZWwuY29tPgogCiAgICAgICAg IFJlZ3Jlc3Npb24ocjE0MDI2Mik6IENhdXNlcyBhIGxvdCBvZiBmbGFraW5lc3MKZGlmZiAtLWdp dCBhL1Rvb2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtpdC1jaHJvbWl1bSBiL1Rvb2xzL1NjcmlwdHMv dXBkYXRlLXdlYmtpdC1jaHJvbWl1bQppbmRleCA5NDRhNzQ3OTgyMmVhNzdhMTQyN2I0YzI4NDFm M2VmMWNjNzI3MjE1Li5jY2NkMzdkOWZlYTYxZDIxNDQxYmNhMzljOTE2OGIzODBiOGIwYTMwIDEw MDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3VwZGF0ZS13ZWJraXQtY2hyb21pdW0KKysrIGIvVG9v bHMvU2NyaXB0cy91cGRhdGUtd2Via2l0LWNocm9taXVtCkBAIC02Niw3ICs2Niw3IEBAIGlmIChp c0Nocm9taXVtQW5kcm9pZCgpKSB7CiB9CiAKIG15ICRmb3JjZSA9IDA7Ci1teSAkdXNlTmluamEg PSAkXk8gZXEgImxpbnV4IjsKK215ICR1c2VOaW5qYSA9ICReTyBlcSAibGludXgiIHx8ICReTyBl cSAiZGFyd2luIjsKIAogR2V0T3B0aW9ucygKICAgJ2ZvcmNlJyA9PiBcJGZvcmNlLAo=