106736 2013-01-12 21:56:12 -0800 [chromium] Don't archive generated source files. 2013-01-21 17:46:13 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thakis thakis eric rniwa webkit.review.bot oldest_to_newest 805934 0 thakis 2013-01-12 21:56:12 -0800 [chromium] Don't archive generated source files. 805935 1 182480 thakis 2013-01-12 21:57:21 -0800 Created attachment 182480 Patch 805936 2 thakis 2013-01-12 21:57:47 -0800 This is not really necessary, but a bit nicer. 812467 3 182480 eric 2013-01-21 16:48:51 -0800 Comment on attachment 182480 Patch Makes sense. 812468 4 eric 2013-01-21 16:49:05 -0800 I expect this is used by other ports? 812469 5 thakis 2013-01-21 16:50:10 -0800 (In reply to comment #4) > I expect this is used by other ports? Yes, but this bit of diff is in a elif platform == 'chromium': branch. I suppose including a little more context in the diff would've been nice of me, sorry. 812495 6 182480 webkit.review.bot 2013-01-21 17:46:10 -0800 Comment on attachment 182480 Patch Clearing flags on attachment: 182480 Committed r140375: <http://trac.webkit.org/changeset/140375> 812496 7 webkit.review.bot 2013-01-21 17:46:13 -0800 All reviewed patches have been landed. Closing bug. 182480 2013-01-12 21:57:21 -0800 2013-01-21 17:46:10 -0800 Patch bug-106736-20130112215423.patch text/plain 1890 thakis U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5NTU4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMGU1NWY2YzZhNzc1NWM2ZWZlYjFmOTkxODA5YjY2Nzg3 OGMwODkwNy4uNmIzMjk0NWJlN2Y1NmQ3Njg1MmQ5YzM3YTVhYjUyOTQ0YzE3YzRiMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5 IEBACiAyMDEzLTAxLTEyICBOaWNvIFdlYmVyICA8dGhha2lzQGNocm9taXVtLm9yZz4KIAorICAg ICAgICBbY2hyb21pdW1dIERvbid0IGFyY2hpdmUgZ2VuZXJhdGVkIHNvdXJjZSBmaWxlcy4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNjczNgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZXkgc2hvdWxk bid0IGJlIG5lZWRlZCB0byBydW4gdGVzdHMuIFRoZXkgZG9uJ3QgbmVlZCBhIGxvdCBvZiBzcGFj ZSwKKyAgICAgICAgYnV0IGFkZCBtYW55IGxpbmVzIHRvIHRoZSAiZXh0cmFjdGluZyIgc3Rkb3V0 LiBUaGlzIGF0dGVtcHRzIHRvIHJlZHVjZQorICAgICAgICB0aGF0IG5vaXNlIGEgYml0LgorCisg ICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbHQtcHJvZHVjdC1hcmNoaXZlOgorICAgICAg ICAoYXJjaGl2ZUJ1aWx0UHJvZHVjdCk6CisKKzIwMTMtMDEtMTIgIE5pY28gV2ViZXIgIDx0aGFr aXNAY2hyb21pdW0ub3JnPgorCiAgICAgICAgIE1ha2UgbmluamEgdGhlIGRlZmF1bHQgYnVpbGQg c3lzdGVtIG9uIExpbnV4IGZvciBidWlsZC13ZWJraXQgLS1jaHJvbWl1bQogICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0NDM0CiAKZGlmZiAtLWdpdCBh L1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWx0LXByb2R1Y3QtYXJjaGl2ZSBiL1Rvb2xzL0J1 aWxkU2xhdmVTdXBwb3J0L2J1aWx0LXByb2R1Y3QtYXJjaGl2ZQppbmRleCA3ZWY4OGY3YWE4NTg0 ZWRmNGRjM2UwMjNmOWI5ODljOTE4NDY0NTc3Li4yZjAxZGE5YTg1MTk2YTY1YmRiOTY5Yzg2NmRl NjA2Y2ZhMjQyOThhIDEwMDY0NAotLS0gYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsdC1w cm9kdWN0LWFyY2hpdmUKKysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbHQtcHJvZHVj dC1hcmNoaXZlCkBAIC0xNjYsNyArMTY2LDggQEAgZGVmIGFyY2hpdmVCdWlsdFByb2R1Y3QoY29u ZmlndXJhdGlvbiwgcGxhdGZvcm0sIGZ1bGxQbGF0Zm9ybSk6CiAgICAgICAgIHRoaW5EaXJlY3Rv cnkgPSBvcy5wYXRoLmpvaW4oY29uZmlndXJhdGlvbkJ1aWxkRGlyZWN0b3J5LCAidGhpbiIpCiAK ICAgICAgICAgaWdub3JlUGF0dGVybnMgPSBbJy5zdm4nLCAnKi5hJywgJyouZCcsICcqLmRTWU0n LCAnKi5vJywgJyouaWxrJywgJyoubGliJywgJyouaWRiJywKLSAgICAgICAgICAgICAgICAgICAg ICAgICAgJ0J1aWxkTG9nLmh0bScsICcqLm9iaicsICcqLnBkYicsICcqLnBjaCcsICcqLnRsb2cn LCAnKi5sYXN0YnVpbGRzdGF0ZSddCisgICAgICAgICAgICAgICAgICAgICAgICAgICdCdWlsZExv Zy5odG0nLCAnKi5vYmonLCAnKi5wZGInLCAnKi5wY2gnLCAnKi50bG9nJywgJyoubGFzdGJ1aWxk c3RhdGUnLAorICAgICAgICAgICAgICAgICAgICAgICAgICAnKi5oJywgJyouYycsICcqLmNjJywg JyouY3BwJywgJyouc3RhbXAnLCAnKi5uaW5qYSddCiAKICAgICAgICAgaWYgZnVsbFBsYXRmb3Jt IGFuZCBmdWxsUGxhdGZvcm0gPT0gJ2Nocm9taXVtLWFuZHJvaWQnOgogICAgICAgICAgICAgaWdu b3JlUGF0dGVybnMuZXh0ZW5kKFsnKi5zbycsICcqLXVuYWxpZ25lZC5hcGsnLCAnKi11bnNpZ25l ZC5hcGsnXSkK