106699 2013-01-11 14:07:12 -0800 [Qt] Crash in gmail on enabling desktop notifications 2013-01-21 04:35:31 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC Linux RESOLVED FIXED P3 Major --- 88186 103747 107438 0 jingdow allan.jensen allan.jensen jturcotte nowrep oldest_to_newest 805600 0 182414 jingdow 2013-01-11 14:07:12 -0800 Created attachment 182414 gdb trace log QtWebKit version: latest as of today from http://gitorious.org/+qtwebkit-developers/webkit/qtwebkit-23/commits/qtwebkit-2.3-staging Browser: Qupzilla Reproducible: Always Browser crashes by clicking on a link in Gmail Settings "Click here to enable desktop notifications for Gmail". Desktop notifications on my other account was already enabled and working fine. gdb log attached. 805652 1 jingdow 2013-01-11 15:00:51 -0800 I've built qtwebkit with "bool NotificationPresenterClientQt::dumpNotification" set to "true" in /Source/WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.cpp and I get in console output: DESKTOP NOTIFICATION PERMISSION REQUESTED: https://mail.google.com 805658 2 182426 jingdow 2013-01-11 15:04:11 -0800 Created attachment 182426 gdb trace log from QtTestBrowser 805715 3 jingdow 2013-01-11 15:59:59 -0800 Another thing I've noticed. In file /Source/WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.cpp in function void NotificationPresenterClientQt::requestPermission(ScriptExecutionContext* context, PassRefPtr<VoidCallback> callback) I've added two printf commands, like this: printf("Before emited signal\n"); emit toPage(context)->featurePermissionRequested(toFrame(context), QWebPage::Notifications); printf("After emited signal\n"); Upon crash, only the first one gets printed ("Before emited signal"). Probably doesn't mean anything, but just in case... 811096 4 183556 nowrep 2013-01-18 15:24:49 -0800 Created attachment 183556 Check the validity of ptr right before handling callback. 811097 5 183557 nowrep 2013-01-18 15:26:43 -0800 Created attachment 183557 Don't add invalid pointer into to m_callbacks 811111 6 nowrep 2013-01-18 15:42:10 -0800 From w3.org: static void requestPermission(NotificationPermissionCallback callback); There is one parameter to requestPermission method. However, if this method is called without it, the Callback pointer that is passed to NotificationPresenterClientQt will be invalid and finally will lead to this crash. The simple "window.webkitNotifications.requestPermission();" should crash it. I've added two patches, the first checks the validity of callback pointer right before using it, while the second rather prevents adding invalid callback pointer into m_callbacks array. I'd prefer the behavior of the second patch. Both patches fixes the crash and enables desktop notifications on gmail.com 811112 7 jingdow 2013-01-18 15:44:43 -0800 Confirmed, patches fix the problem. 811451 8 allan.jensen 2013-01-19 13:10:38 -0800 N(In reply to comment #7) > Confirmed, patches fix the problem. Nice, looks like it might apply to trunk as well. I will test on Monday. 811999 9 183747 allan.jensen 2013-01-21 03:24:47 -0800 Created attachment 183747 Patch 812030 10 allan.jensen 2013-01-21 04:35:31 -0800 Committed r140322: <http://trac.webkit.org/changeset/140322> 182414 2013-01-11 14:07:12 -0800 2013-01-11 14:07:12 -0800 gdb trace log gdb.log application/octet-stream 2655 jingdow JSBnZGIgcXVwemlsbGEKR05VIGdkYiAoR0RCKSA3LjUuMQpDb3B5cmlnaHQgKEMpIDIwMTIgRnJl ZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBJbmMuCkxpY2Vuc2UgR1BMdjMrOiBHTlUgR1BMIHZlcnNp b24gMyBvciBsYXRlciA8aHR0cDovL2dudS5vcmcvbGljZW5zZXMvZ3BsLmh0bWw+ClRoaXMgaXMg ZnJlZSBzb2Z0d2FyZTogeW91IGFyZSBmcmVlIHRvIGNoYW5nZSBhbmQgcmVkaXN0cmlidXRlIGl0 LgpUaGVyZSBpcyBOTyBXQVJSQU5UWSwgdG8gdGhlIGV4dGVudCBwZXJtaXR0ZWQgYnkgbGF3LiAg VHlwZSAic2hvdyBjb3B5aW5nIgphbmQgInNob3cgd2FycmFudHkiIGZvciBkZXRhaWxzLgpUaGlz IEdEQiB3YXMgY29uZmlndXJlZCBhcyAieDg2XzY0LXVua25vd24tbGludXgtZ251Ii4KRm9yIGJ1 ZyByZXBvcnRpbmcgaW5zdHJ1Y3Rpb25zLCBwbGVhc2Ugc2VlOgo8aHR0cDovL3d3dy5nbnUub3Jn L3NvZnR3YXJlL2dkYi9idWdzLz4uLi4KUmVhZGluZyBzeW1ib2xzIGZyb20gL3Vzci9iaW4vcXVw emlsbGEuLi4obm8gZGVidWdnaW5nIHN5bWJvbHMgZm91bmQpLi4uZG9uZS4KKGdkYikgc3RhcnQK VGVtcG9yYXJ5IGJyZWFrcG9pbnQgMSBhdCAweDQwMjFiMApTdGFydGluZyBwcm9ncmFtOiAvdXNy L2Jpbi9xdXB6aWxsYSAKd2FybmluZzogQ291bGQgbm90IGxvYWQgc2hhcmVkIGxpYnJhcnkgc3lt Ym9scyBmb3IgbGludXgtdmRzby5zby4xLgpEbyB5b3UgbmVlZCAic2V0IHNvbGliLXNlYXJjaC1w YXRoIiBvciAic2V0IHN5c3Jvb3QiPwpbVGhyZWFkIGRlYnVnZ2luZyB1c2luZyBsaWJ0aHJlYWRf ZGIgZW5hYmxlZF0KVXNpbmcgaG9zdCBsaWJ0aHJlYWRfZGIgbGlicmFyeSAiL3Vzci9saWIvbGli dGhyZWFkX2RiLnNvLjEiLgpUcmFjZWJhY2sgKG1vc3QgcmVjZW50IGNhbGwgbGFzdCk6CiAgRmls ZSAiL3Vzci9zaGFyZS9nZGIvYXV0by1sb2FkL3Vzci9saWIvbGliZ29iamVjdC0yLjAuc28uMC4z NDAwLjMtZ2RiLnB5IiwgbGluZSA5LCBpbiA8bW9kdWxlPgogICAgZnJvbSBnb2JqZWN0IGltcG9y dCByZWdpc3RlcgogIEZpbGUgIi91c3Ivc2hhcmUvZ2xpYi0yLjAvZ2RiL2dvYmplY3QucHkiLCBs aW5lIDMsIGluIDxtb2R1bGU+CiAgICBpbXBvcnQgZ2RiLmJhY2t0cmFjZQpJbXBvcnRFcnJvcjog Tm8gbW9kdWxlIG5hbWVkIGJhY2t0cmFjZQoKVGVtcG9yYXJ5IGJyZWFrcG9pbnQgMSwgMHgwMDAw MDAwMDAwNDAyMWIwIGluIG1haW4gKCkKKGdkYikgY29udGludWUKQ29udGludWluZy4KW05ldyBU aHJlYWQgMHg3ZmZmZTE3OGE3MDAgKExXUCA0NDMpXQpbTmV3IFRocmVhZCAweDdmZmZhMGU2Zjcw MCAoTFdQIDQ0NCldClF1cFppbGxhOiA1IGV4dGVuc2lvbnMgbG9hZGVkCmxvYWRlZCB0aGUgR2Vu ZXJpYyBwbHVnaW4gCltOZXcgVGhyZWFkIDB4N2ZmZjlhZTIyNzAwIChMV1AgNDQ1KV0KW05ldyBU aHJlYWQgMHg3ZmZmOTk2ZjE3MDAgKExXUCA0NDYpXQpbTmV3IFRocmVhZCAweDdmZmY5MzYxNjcw MCAoTFdQIDQ0NyldCltOZXcgVGhyZWFkIDB4N2ZmZjkyZTE1NzAwIChMV1AgNDUwKV0KUUZvbnQ6 OnNldFBpeGVsU2l6ZTogUGl4ZWwgc2l6ZSA8PSAwICgwKQpRRm9udDo6c2V0UGl4ZWxTaXplOiBQ aXhlbCBzaXplIDw9IDAgKDApCltOZXcgVGhyZWFkIDB4N2ZmZjg1NmRiNzAwIChMV1AgNDY3KV0K W05ldyBUaHJlYWQgMHg3ZmZmNzhlNmI3MDAgKExXUCA0OTQpXQoKUHJvZ3JhbSByZWNlaXZlZCBz aWduYWwgU0lHU0VHViwgU2VnbWVudGF0aW9uIGZhdWx0LgoweDAwMDA3ZmZmZjU5MTI3NGQgaW4g Pz8gKCkgZnJvbSAvdXNyL2xpYi9saWJRdFdlYktpdC5zby40CihnZGIpIGJ0CiMwICAweDAwMDA3 ZmZmZjU5MTI3NGQgaW4gPz8gKCkgZnJvbSAvdXNyL2xpYi9saWJRdFdlYktpdC5zby40CiMxICAw eDAwMDA3ZmZmZjQ0YzhiOGYgaW4gUU1ldGFPYmplY3Q6OmFjdGl2YXRlKFFPYmplY3QqLCBRTWV0 YU9iamVjdCBjb25zdCosIGludCwgdm9pZCoqKSAoKSBmcm9tIC91c3IvbGliL2xpYlF0Q29yZS5z by40CiMyICAweDAwMDA3ZmZmZjU4Y2NlMzAgaW4gUVdlYlBhZ2U6OmZlYXR1cmVQZXJtaXNzaW9u UmVxdWVzdGVkKFFXZWJGcmFtZSosIFFXZWJQYWdlOjpGZWF0dXJlKSAoKSBmcm9tIC91c3IvbGli L2xpYlF0V2ViS2l0LnNvLjQKIzMgIDB4MDAwMDdmZmZmNTkxMmNhMSBpbiA/PyAoKSBmcm9tIC91 c3IvbGliL2xpYlF0V2ViS2l0LnNvLjQKIzQgIDB4MDAwMDdmZmZmNTllMjZiYiBpbiA/PyAoKSBm cm9tIC91c3IvbGliL2xpYlF0V2ViS2l0LnNvLjQKIzUgIDB4MDAwMDdmZmZmNTk2MmIxNiBpbiA/ PyAoKSBmcm9tIC91c3IvbGliL2xpYlF0V2ViS2l0LnNvLjQKIzYgIDB4MDAwMDdmZmZmNjUxZTY2 YiBpbiA/PyAoKSBmcm9tIC91c3IvbGliL2xpYlF0V2ViS2l0LnNvLjQKIzcgIDB4MDAwMDdmZmZh MGU3MTI2NSBpbiA/PyAoKQojOCAgMHhmZmZmMDAwMDAwMDAwMDAyIGluID8/ICgpCiM5ICAweDAw MDA3ZmZmZjZiZWVkYjMgaW4gPz8gKCkgZnJvbSAvdXNyL2xpYi9saWJRdFdlYktpdC5zby40CiMx MCAweDAwMDAwMDAwMDAwMDAwMDAgaW4gPz8gKCkKKGdkYikgcXVpdApBIGRlYnVnZ2luZyBzZXNz aW9uIGlzIGFjdGl2ZS4KCiAgICAgICAgSW5mZXJpb3IgMSBbcHJvY2VzcyA0MzldIHdpbGwgYmUg a2lsbGVkLgoKUXVpdCBhbnl3YXk/ICh5IG9yIG4pIHkK 182426 2013-01-11 15:04:11 -0800 2013-01-11 15:04:11 -0800 gdb trace log from QtTestBrowser gdb2.log application/octet-stream 2927 jingdow JSBnZGIgLi9RdFRlc3RCcm93c2VyIAp6c2g6IGNvcnJlY3QgJ2dkYicgdG8gJ19nZGInIFtueWFl XT8gbgpHTlUgZ2RiIChHREIpIDcuNS4xCkNvcHlyaWdodCAoQykgMjAxMiBGcmVlIFNvZnR3YXJl IEZvdW5kYXRpb24sIEluYy4KTGljZW5zZSBHUEx2Mys6IEdOVSBHUEwgdmVyc2lvbiAzIG9yIGxh dGVyIDxodHRwOi8vZ251Lm9yZy9saWNlbnNlcy9ncGwuaHRtbD4KVGhpcyBpcyBmcmVlIHNvZnR3 YXJlOiB5b3UgYXJlIGZyZWUgdG8gY2hhbmdlIGFuZCByZWRpc3RyaWJ1dGUgaXQuClRoZXJlIGlz IE5PIFdBUlJBTlRZLCB0byB0aGUgZXh0ZW50IHBlcm1pdHRlZCBieSBsYXcuICBUeXBlICJzaG93 IGNvcHlpbmciCmFuZCAic2hvdyB3YXJyYW50eSIgZm9yIGRldGFpbHMuClRoaXMgR0RCIHdhcyBj b25maWd1cmVkIGFzICJ4ODZfNjQtdW5rbm93bi1saW51eC1nbnUiLgpGb3IgYnVnIHJlcG9ydGlu ZyBpbnN0cnVjdGlvbnMsIHBsZWFzZSBzZWU6CjxodHRwOi8vd3d3LmdudS5vcmcvc29mdHdhcmUv Z2RiL2J1Z3MvPi4uLgpSZWFkaW5nIHN5bWJvbHMgZnJvbSAvaG9tZS9tbGFkZW4vUHJldXppbWFu amEvUXRUZXN0QnJvd3Nlci4uLihubyBkZWJ1Z2dpbmcgc3ltYm9scyBmb3VuZCkuLi5kb25lLgoo Z2RiKSBzdGFydApUZW1wb3JhcnkgYnJlYWtwb2ludCAxIGF0IDB4NDEzZTQwClN0YXJ0aW5nIHBy b2dyYW06IC9ob21lL21sYWRlbi9QcmV1emltYW5qYS9RdFRlc3RCcm93c2VyIAp3YXJuaW5nOiBD b3VsZCBub3QgbG9hZCBzaGFyZWQgbGlicmFyeSBzeW1ib2xzIGZvciBsaW51eC12ZHNvLnNvLjEu CkRvIHlvdSBuZWVkICJzZXQgc29saWItc2VhcmNoLXBhdGgiIG9yICJzZXQgc3lzcm9vdCI/ClRy YWNlYmFjayAobW9zdCByZWNlbnQgY2FsbCBsYXN0KToKICBGaWxlICIvdXNyL3NoYXJlL2dkYi9h dXRvLWxvYWQvdXNyL2xpYi9saWJnb2JqZWN0LTIuMC5zby4wLjM0MDAuMy1nZGIucHkiLCBsaW5l IDksIGluIDxtb2R1bGU+CiAgICBmcm9tIGdvYmplY3QgaW1wb3J0IHJlZ2lzdGVyCiAgRmlsZSAi L3Vzci9zaGFyZS9nbGliLTIuMC9nZGIvZ29iamVjdC5weSIsIGxpbmUgMywgaW4gPG1vZHVsZT4K ICAgIGltcG9ydCBnZGIuYmFja3RyYWNlCkltcG9ydEVycm9yOiBObyBtb2R1bGUgbmFtZWQgYmFj a3RyYWNlCltUaHJlYWQgZGVidWdnaW5nIHVzaW5nIGxpYnRocmVhZF9kYiBlbmFibGVkXQpVc2lu ZyBob3N0IGxpYnRocmVhZF9kYiBsaWJyYXJ5ICIvdXNyL2xpYi9saWJ0aHJlYWRfZGIuc28uMSIu CgpUZW1wb3JhcnkgYnJlYWtwb2ludCAxLCAweDAwMDAwMDAwMDA0MTNlNDAgaW4gbWFpbiAoKQoo Z2RiKSBjb250aW51ZQpDb250aW51aW5nLgpbTmV3IFRocmVhZCAweDdmZmZlMmVhZjcwMCAoTFdQ IDkzNTgpXQpbTmV3IFRocmVhZCAweDdmZmZhMjVhNDcwMCAoTFdQIDkzNTkpXQpsb2FkZWQgdGhl IEdlbmVyaWMgcGx1Z2luIApbTmV3IFRocmVhZCAweDdmZmZhMTEwNzcwMCAoTFdQIDkzNjApXQpb TmV3IFRocmVhZCAweDdmZmY5YmZmZjcwMCAoTFdQIDkzNjEpXQpbTmV3IFRocmVhZCAweDdmZmY5 YjVjZjcwMCAoTFdQIDkzNjIpXQpbTmV3IFRocmVhZCAweDdmZmY5YWRjZTcwMCAoTFdQIDkzNjMp XQpbTmV3IFRocmVhZCAweDdmZmY5OTA4ZTcwMCAoTFdQIDkzNjQpXQpRRm9udDo6c2V0UGl4ZWxT aXplOiBQaXhlbCBzaXplIDw9IDAgKDApClFGb250OjpzZXRQaXhlbFNpemU6IFBpeGVsIHNpemUg PD0gMCAoMCkKW05ldyBUaHJlYWQgMHg3ZmZmN2RlNzU3MDAgKExXUCA5Mzk5KV0KW05ldyBUaHJl YWQgMHg3ZmZmN2QxZjQ3MDAgKExXUCA5NDAwKV0KREVTS1RPUCBOT1RJRklDQVRJT04gUEVSTUlT U0lPTiBSRVFVRVNURUQ6IGh0dHBzOi8vbWFpbC5nb29nbGUuY29tCgpQcm9ncmFtIHJlY2VpdmVk IHNpZ25hbCBTSUdTRUdWLCBTZWdtZW50YXRpb24gZmF1bHQuCjB4MDAwMDdmZmZmNWVkNzc0ZCBp biA/PyAoKSBmcm9tIC91c3IvbGliL2xpYlF0V2ViS2l0LnNvLjQKKGdkYikgYnQKIzAgIDB4MDAw MDdmZmZmNWVkNzc0ZCBpbiA/PyAoKSBmcm9tIC91c3IvbGliL2xpYlF0V2ViS2l0LnNvLjQKIzEg IDB4MDAwMDAwMDAwMDQyNWE2YSBpbiBXZWJQYWdlOjpxdF9zdGF0aWNfbWV0YWNhbGwoUU9iamVj dCosIFFNZXRhT2JqZWN0OjpDYWxsLCBpbnQsIHZvaWQqKikgKCkKIzIgIDB4MDAwMDdmZmZmNDQ1 OGI4ZiBpbiBRTWV0YU9iamVjdDo6YWN0aXZhdGUoUU9iamVjdCosIFFNZXRhT2JqZWN0IGNvbnN0 KiwgaW50LCB2b2lkKiopICgpIGZyb20gL3Vzci9saWIvbGliUXRDb3JlLnNvLjQKIzMgIDB4MDAw MDdmZmZmNWU5MWUzMCBpbiBRV2ViUGFnZTo6ZmVhdHVyZVBlcm1pc3Npb25SZXF1ZXN0ZWQoUVdl YkZyYW1lKiwgUVdlYlBhZ2U6OkZlYXR1cmUpICgpIGZyb20gL3Vzci9saWIvbGliUXRXZWJLaXQu c28uNAojNCAgMHgwMDAwN2ZmZmY1ZWQ3Y2ExIGluID8/ICgpIGZyb20gL3Vzci9saWIvbGliUXRX ZWJLaXQuc28uNAojNSAgMHgwMDAwN2ZmZmY1ZmE3NmJiIGluID8/ICgpIGZyb20gL3Vzci9saWIv bGliUXRXZWJLaXQuc28uNAojNiAgMHgwMDAwN2ZmZmY1ZjI3YjE2IGluID8/ICgpIGZyb20gL3Vz ci9saWIvbGliUXRXZWJLaXQuc28uNAojNyAgMHgwMDAwN2ZmZmY2YWUzNjZiIGluID8/ICgpIGZy b20gL3Vzci9saWIvbGliUXRXZWJLaXQuc28uNAojOCAgMHgwMDAwN2ZmZmEyNWE2MjY1IGluID8/ ICgpCiM5ICAweGZmZmYwMDAwMDAwMDAwMDIgaW4gPz8gKCkKIzEwIDB4MDAwMDdmZmZmNzFiM2Ri MyBpbiA/PyAoKSBmcm9tIC91c3IvbGliL2xpYlF0V2ViS2l0LnNvLjQKIzExIDB4MDAwMDAwMDAw MDAwMDAwMCBpbiA/PyAoKQooZ2RiKSBxdWl0CkEgZGVidWdnaW5nIHNlc3Npb24gaXMgYWN0aXZl LgoKICAgICAgICBJbmZlcmlvciAxIFtwcm9jZXNzIDkzNTRdIHdpbGwgYmUga2lsbGVkLgoKUXVp dCBhbnl3YXk/ICh5IG9yIG4pIHk= 183556 2013-01-18 15:24:49 -0800 2013-01-21 03:24:37 -0800 Check the validity of ptr right before handling callback. notif-requestpermission1.patch text/plain 714 nowrep ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvTm90aWZpY2F0aW9u UHJlc2VudGVyQ2xpZW50UXQuY3BwIGIvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9O b3RpZmljYXRpb25QcmVzZW50ZXJDbGllbnRRdC5jcHAKaW5kZXggNTZlZDBiNC4uZmFhY2U1MSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9Ob3RpZmljYXRpb25Q cmVzZW50ZXJDbGllbnRRdC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9y dC9Ob3RpZmljYXRpb25QcmVzZW50ZXJDbGllbnRRdC5jcHAKQEAgLTM3Niw3ICszNzYsOCBAQCB2 b2lkIE5vdGlmaWNhdGlvblByZXNlbnRlckNsaWVudFF0OjphbGxvd05vdGlmaWNhdGlvbkZvckZy YW1lKEZyYW1lKiBmcmFtZSkKIAogICAgIFFMaXN0PFJlZlB0cjxWb2lkQ2FsbGJhY2s+ID4mIGNh bGxiYWNrcyA9IGl0ZXIudmFsdWUoKS5tX2NhbGxiYWNrczsKICAgICBmb3IgKGludCBpID0gMDsg aSA8IGNhbGxiYWNrcy5zaXplKCk7IGkrKykKLSAgICAgICAgY2FsbGJhY2tzLmF0KGkpLT5oYW5k bGVFdmVudCgpOworICAgICAgICBpZiAoY2FsbGJhY2tzLmF0KGkpKQorICAgICAgICAgICAgY2Fs bGJhY2tzLmF0KGkpLT5oYW5kbGVFdmVudCgpOwogICAgIG1fcGVuZGluZ1Blcm1pc3Npb25SZXF1 ZXN0cy5yZW1vdmUoaXRlci5rZXkoKSk7CiB9CiAK 183557 2013-01-18 15:26:43 -0800 2013-01-21 03:24:39 -0800 Don't add invalid pointer into to m_callbacks notif-requestpermission2.patch text/plain 749 nowrep ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvTm90aWZpY2F0aW9u UHJlc2VudGVyQ2xpZW50UXQuY3BwIGIvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9O b3RpZmljYXRpb25QcmVzZW50ZXJDbGllbnRRdC5jcHAKaW5kZXggNTZlZDBiNC4uMWU1MGM5ZSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9Ob3RpZmljYXRpb25Q cmVzZW50ZXJDbGllbnRRdC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9y dC9Ob3RpZmljYXRpb25QcmVzZW50ZXJDbGllbnRRdC5jcHAKQEAgLTMyMyw3ICszMjMsOCBAQCB2 b2lkIE5vdGlmaWNhdGlvblByZXNlbnRlckNsaWVudFF0OjpyZXF1ZXN0UGVybWlzc2lvbihTY3Jp cHRFeGVjdXRpb25Db250ZXh0KiBjbwogICAgICAgICBSZWZQdHI8Vm9pZENhbGxiYWNrPiBjYiA9 IGNhbGxiYWNrOwogICAgICAgICBDYWxsYmFja3NJbmZvIGluZm87CiAgICAgICAgIGluZm8ubV9m cmFtZSA9IHRvRnJhbWUoY29udGV4dCk7Ci0gICAgICAgIGluZm8ubV9jYWxsYmFja3MuYXBwZW5k KGNiKTsKKyAgICAgICAgaWYgKGNiKQorICAgICAgICAgICAgaW5mby5tX2NhbGxiYWNrcy5hcHBl bmQoY2IpOwogICAgICAgICBtX3BlbmRpbmdQZXJtaXNzaW9uUmVxdWVzdHMuaW5zZXJ0KGNvbnRl eHQsIGluZm8pOwogCiAgICAgICAgIGlmICh0b1BhZ2UoY29udGV4dCkgJiYgdG9GcmFtZShjb250 ZXh0KSkgewo= 183747 2013-01-21 03:24:47 -0800 2013-01-21 04:04:26 -0800 Patch bug-106699-20130121122104.patch text/plain 2092 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwMzE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0 L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IGUwOWU1ZjM3ZDE1 NzcxN2VhODgzZTdlNThkMGE5NzMwYmEwZjIzZmQuLjI4Mjk2OTczZTNkZmMwMDZmZDBiYzA3NThj ZjIwZmNmMTUzZDAxYjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTMtMDEt MjEgIEFsbGFuIFNhbmRmZWxkIEplbnNlbiAgPGFsbGFuLmplbnNlbkBkaWdpYS5jb20+CisKKyAg ICAgICAgW1F0XSBDcmFzaCBpbiBnbWFpbCBvbiBlbmFibGluZyBkZXNrdG9wIG5vdGlmaWNhdGlv bnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNjY5 OQorCisgICAgICAgIFBhdGNoIGJ5IERhdmlkIFJvc2NhLgorICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQcm90ZWN0IGFnYWluc3QgY2FsbGJhY2sgdGhhdCBt YXkgYmUgbnVsbC4gVGhpcyBhbHNvIG1hdGNoZXMgV2ViS2l0MiBiZWhhdmlvdXIuCisKKyAgICAg ICAgKiBXZWJDb3JlU3VwcG9ydC9Ob3RpZmljYXRpb25QcmVzZW50ZXJDbGllbnRRdC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpOb3RpZmljYXRpb25QcmVzZW50ZXJDbGllbnRRdDo6YWxsb3dOb3Rp ZmljYXRpb25Gb3JGcmFtZSk6CisKIDIwMTMtMDEtMTggIFNoaW55YSBLYXdhbmFrYSAgPHNoaW55 YWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEludHJvZHVjZSBpc0hUTUxUZXh0Rm9ybUNvbnRy b2xFbGVtZW50IGFuZCB0b0hUTUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50IGluc3RlYWQgb2YgdG9U ZXh0Rm9ybUNvbnRyb2wKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBv cnQvTm90aWZpY2F0aW9uUHJlc2VudGVyQ2xpZW50UXQuY3BwIGIvU291cmNlL1dlYktpdC9xdC9X ZWJDb3JlU3VwcG9ydC9Ob3RpZmljYXRpb25QcmVzZW50ZXJDbGllbnRRdC5jcHAKaW5kZXggMDY4 NDBjNDU1Yjg4NTA5Mjk2NjE2NDRkZjNjMGM4YjllODY4MzA0NS4uMmYyNWI4OTYwYWE0OGJjNzM0 ZWM0ZmMxMTg5Y2UwMzliY2NhMGVmNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9xdC9XZWJD b3JlU3VwcG9ydC9Ob3RpZmljYXRpb25QcmVzZW50ZXJDbGllbnRRdC5jcHAKKysrIGIvU291cmNl L1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9Ob3RpZmljYXRpb25QcmVzZW50ZXJDbGllbnRRdC5j cHAKQEAgLTM2Nyw4ICszNjcsMTAgQEAgdm9pZCBOb3RpZmljYXRpb25QcmVzZW50ZXJDbGllbnRR dDo6YWxsb3dOb3RpZmljYXRpb25Gb3JGcmFtZShGcmFtZSogZnJhbWUpCiAgICAgICAgIHJldHVy bjsKIAogICAgIFFMaXN0PFJlZlB0cjxWb2lkQ2FsbGJhY2s+ID4mIGNhbGxiYWNrcyA9IGl0ZXIu dmFsdWUoKS5tX2NhbGxiYWNrczsKLSAgICBmb3IgKGludCBpID0gMDsgaSA8IGNhbGxiYWNrcy5z aXplKCk7IGkrKykKLSAgICAgICAgY2FsbGJhY2tzLmF0KGkpLT5oYW5kbGVFdmVudCgpOworICAg IFFfRk9SRUFDSChjb25zdCBSZWZQdHI8Vm9pZENhbGxiYWNrPiYgY2FsbGJhY2ssIGNhbGxiYWNr cykgeworICAgICAgICBpZiAoY2FsbGJhY2spCisgICAgICAgICAgICBjYWxsYmFjay0+aGFuZGxl RXZlbnQoKTsKKyAgICB9CiAgICAgbV9wZW5kaW5nUGVybWlzc2lvblJlcXVlc3RzLnJlbW92ZShp dGVyLmtleSgpKTsKIH0KIApAQCAtMzc5LDcgKzM4MSw2IEBAIHZvaWQgTm90aWZpY2F0aW9uUHJl c2VudGVyQ2xpZW50UXQ6OnNlbmREaXNwbGF5RXZlbnQoTm90aWZpY2F0aW9uV3JhcHBlciogd3Jh cHBlCiAgICAgICAgIHNlbmRFdmVudChub3RpZmljYXRpb24sICJzaG93Iik7CiB9CiAKLQogdm9p ZCBOb3RpZmljYXRpb25QcmVzZW50ZXJDbGllbnRRdDo6c2VuZEV2ZW50KE5vdGlmaWNhdGlvbiog bm90aWZpY2F0aW9uLCBjb25zdCBBdG9taWNTdHJpbmcmIGV2ZW50TmFtZSkKIHsKICAgICBpZiAo bm90aWZpY2F0aW9uLT5zY3JpcHRFeGVjdXRpb25Db250ZXh0KCkpCg==