106698 2013-01-11 14:01:55 -0800 Builder should not be a valid parameter for stats dashboard 2013-01-11 16:43:15 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jparent jparent dpranke ojan webkit.review.bot oldest_to_newest 805596 0 jparent 2013-01-11 14:01:55 -0800 This dashboard displays results for all builders, so builder is not a valid parameter here, as it is for other dashboards. Aka, loading http://test-results.appspot.com/dashboards/aggregate_results.html#builder=WebKit%20Win7 should at least print a warning about invalid parameter. 805623 1 182418 jparent 2013-01-11 14:27:30 -0800 Created attachment 182418 Patch 805643 2 182418 dpranke 2013-01-11 14:57:18 -0800 Comment on attachment 182418 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182418&action=review > Tools/ChangeLog:12 > + Note that the FIXME in dashboard_base about this was acutally wrong - nit: "actually". 805679 3 182432 jparent 2013-01-11 15:26:52 -0800 Created attachment 182432 Patch for landing 805751 4 182432 webkit.review.bot 2013-01-11 16:43:12 -0800 Comment on attachment 182432 Patch for landing Clearing flags on attachment: 182432 Committed r139522: <http://trac.webkit.org/changeset/139522> 805752 5 webkit.review.bot 2013-01-11 16:43:15 -0800 All reviewed patches have been landed. Closing bug. 182418 2013-01-11 14:27:30 -0800 2013-01-11 15:26:50 -0800 Patch bug-106698-20130111142432.patch text/plain 3060 jparent U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5NDkzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTRjMDZjNmM1ZGE2NmI1ZjkwODRiZDdkZTIzZDY4ZjMz OWM0NmIxZS4uNjU2ZTI4YTJiZTAwNWI1Nzc2YTM5OTE5OWI0YTlmNzhhM2M0NWI3NyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4 IEBACisyMDEzLTAxLTExICBKdWxpZSBQYXJlbnQgIDxqcGFyZW50QGNocm9taXVtLm9yZz4KKwor ICAgICAgICBCdWlsZGVyIHNob3VsZCBub3QgYmUgYSB2YWxpZCBwYXJhbWV0ZXIgZm9yIHN0YXRz IGRhc2hib2FyZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTA2Njk4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAg IAorICAgICAgICBTaW5jZSBidWlsZGVyIGlzIGEgZGFzaGJvYXJkIHNwZWNpZmljIHBhcmFtZXRl ciwgZGFzaGJvYXJkX2Jhc2UKKyAgICAgICAgc2hvdWxkIG5vdCBiZSBoYW5kbGluZyBpdCBpbiBo YW5kbGVWYWxpZEhhc2hQYXJhbWV0ZXJXcmFwcGVyLCByYXRoZXIsCisgICAgICAgIGVhY2ggc3Bl Y2lmaWMgZGFzaGJvYXJkIHNob3VsZCBpbiBpdHMgaGFuZGxlVmFsaWRIYXNoUGFyYW1ldGVyIGZ1 bmN0aW9uLgorICAgIAorICAgICAgICBOb3RlIHRoYXQgdGhlIEZJWE1FIGluIGRhc2hib2FyZF9i YXNlIGFib3V0IHRoaXMgd2FzIGFjdXRhbGx5IHdyb25nIC0KKyAgICAgICAgd2UgZG9uJ3Qgd2Fu dCB0byBtb3ZlIGl0IHRvIGdfY3Jvc3NEYXNoYm9hcmRTdGF0ZSwgYmVjYXVzZSBpdCBpc24ndAor ICAgICAgICBhY3R1YWxseSBjcm9zcyBkYXNoYm9hcmQgc3RhdGUuCisgICAgICAgIAorICAgICAg ICBJbiBmYWN0LCBmbGFraW5lc3MgYW5kIHRyZWVtYXAgaGF2ZSB0aGUgY29kZSBpbiAKKyAgICAg ICAgaGFuZGxlVmFsaWRIYXNoUGFyYW1ldGVyLCBidXQgaXQgaXMgY3VycmVudGx5IGRlYWQgY29k ZSBiZWNhdXNlIAorICAgICAgICBkYXNoYm9hcmRfYmFzZSBnZXRzIHRvIGl0IGZpcnN0LgorICAg ICAgICAKKyAgICAgICAgQWRkZWQgdGhlIHByb3BlciBoYW5kbGluZyB0byB0aW1lbGluZV9leHBs b3Jlciwgc2luY2UgYnVpbGRlciBpcworICAgICAgICB2YWxpZCB0aGVyZS4KKworICAgICAgICAq IFRlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvZGFzaGJvYXJkX2Jhc2UuanM6Cisg ICAgICAgICogVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy90aW1lbGluZV9leHBs b3Jlci5odG1sOgorCiAyMDEzLTAxLTExICBQcmF0aWsgU29sYW5raSAgPHBzb2xhbmtpQGFwcGxl LmNvbT4KIAogICAgICAgICBUZXN0UnVubmVyIGxlYWtzIHdoZW4gcnVubmluZyB0ZXN0cwpkaWZm IC0tZ2l0IGEvVG9vbHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9kYXNoYm9h cmRfYmFzZS5qcyBiL1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvZGFz aGJvYXJkX2Jhc2UuanMKaW5kZXggMzUwOTNlMjMwNzZhZWNkY2IxMzU2YmQ1Njg1ZWUxMTI4Y2Yy ZjJmMS4uNWU1NmQ5ZDA1MGE5M2I0YTc5MTUwMDRiZTJiYjU5Y2U5YzNjZmUwMyAxMDA2NDQKLS0t IGEvVG9vbHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9kYXNoYm9hcmRfYmFz ZS5qcworKysgYi9Ub29scy9UZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2Rhc2hi b2FyZF9iYXNlLmpzCkBAIC0xODUsMTIgKzE4NSw2IEBAIGZ1bmN0aW9uIGhhbmRsZVZhbGlkSGFz aFBhcmFtZXRlcldyYXBwZXIoa2V5LCB2YWx1ZSkKICAgICAgICAgICAgIH0pOwogICAgICAgICBy ZXR1cm4gdHJ1ZTsKIAotICAgIC8vIEZJWE1FOiBUaGlzIHNob3VsZCBwcm9iYWJseSBiZSBzdG9y ZWQgb24gZ19jcm9zc0Rhc2hib2FyZFN0YXRlIGxpa2UgZXZlcnl0aGluZyBlbHNlIGluIHRoaXMg ZnVuY3Rpb24uCi0gICAgY2FzZSAnYnVpbGRlcic6Ci0gICAgICAgIHZhbGlkYXRlUGFyYW1ldGVy KGdfY3VycmVudFN0YXRlLCBrZXksIHZhbHVlLAotICAgICAgICAgICAgZnVuY3Rpb24oKSB7IHJl dHVybiB2YWx1ZSBpbiBjdXJyZW50QnVpbGRlcnMoKTsgfSk7Ci0gICAgICAgIHJldHVybiB0cnVl OwotCiAgICAgY2FzZSAndXNlVGVzdERhdGEnOgogICAgIGNhc2UgJ3Nob3dBbGxSdW5zJzoKICAg ICAgICAgZ19jcm9zc0Rhc2hib2FyZFN0YXRlW2tleV0gPSB2YWx1ZSA9PSAndHJ1ZSc7CmRpZmYg LS1naXQgYS9Ub29scy9UZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL3RpbWVsaW5l X2V4cGxvcmVyLmh0bWwgYi9Ub29scy9UZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRz L3RpbWVsaW5lX2V4cGxvcmVyLmh0bWwKaW5kZXggZDRhYThlODU4YjM1ZjcwZTU5ODI3NjFhMjJl NGMwNmQwNGU4M2QzNS4uYWM1ODkxYTVlNDcwMzRlYWFjZGE0Yjk2ZDZhODkxMTIxOTVmYTRlNiAx MDA2NDQKLS0tIGEvVG9vbHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy90aW1l bGluZV9leHBsb3Jlci5odG1sCisrKyBiL1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRh c2hib2FyZHMvdGltZWxpbmVfZXhwbG9yZXIuaHRtbApAQCAtMTUyLDYgKzE1MiwxMCBAQCBmdW5j dGlvbiBpbml0Q3VycmVudEJ1aWxkZXJUZXN0UmVzdWx0cygpCiBmdW5jdGlvbiBoYW5kbGVWYWxp ZEhhc2hQYXJhbWV0ZXIoa2V5LCB2YWx1ZSkKIHsKICAgICBzd2l0Y2goa2V5KSB7CisgICAgY2Fz ZSAnYnVpbGRlcic6CisgICAgICAgIHZhbGlkYXRlUGFyYW1ldGVyKGdfY3VycmVudFN0YXRlLCBr ZXksIHZhbHVlLAorICAgICAgICAgICAgZnVuY3Rpb24oKSB7IHJldHVybiB2YWx1ZSBpbiBjdXJy ZW50QnVpbGRlcnMoKTsgfSk7CisgICAgICAgIHJldHVybiB0cnVlOwogICAgIGNhc2UgJ2J1aWxk VGltZXN0YW1wJzoKICAgICAgICAgZ19jdXJyZW50U3RhdGUuYnVpbGRUaW1lc3RhbXAgPSBwYXJz ZUludCh2YWx1ZSwgMTApOwogICAgICAgICByZXR1cm4gdHJ1ZTsK 182432 2013-01-11 15:26:52 -0800 2013-01-11 16:43:12 -0800 Patch for landing bug-106698-20130111152354.patch text/plain 3057 jparent U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5NDkzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTRjMDZjNmM1ZGE2NmI1ZjkwODRiZDdkZTIzZDY4ZjMz OWM0NmIxZS4uYjQzNDNlNmFlNmZhYmY3Y2RkZjRjMjAyMmVkYzM1NDhhNmNkZGFlZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4 IEBACisyMDEzLTAxLTExICBKdWxpZSBQYXJlbnQgIDxqcGFyZW50QGNocm9taXVtLm9yZz4KKwor ICAgICAgICBCdWlsZGVyIHNob3VsZCBub3QgYmUgYSB2YWxpZCBwYXJhbWV0ZXIgZm9yIHN0YXRz IGRhc2hib2FyZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTA2Njk4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGlyayBQcmFua2UuCisgICAgICAgIAor ICAgICAgICBTaW5jZSBidWlsZGVyIGlzIGEgZGFzaGJvYXJkIHNwZWNpZmljIHBhcmFtZXRlciwg ZGFzaGJvYXJkX2Jhc2UKKyAgICAgICAgc2hvdWxkIG5vdCBiZSBoYW5kbGluZyBpdCBpbiBoYW5k bGVWYWxpZEhhc2hQYXJhbWV0ZXJXcmFwcGVyLCByYXRoZXIsCisgICAgICAgIGVhY2ggc3BlY2lm aWMgZGFzaGJvYXJkIHNob3VsZCBpbiBpdHMgaGFuZGxlVmFsaWRIYXNoUGFyYW1ldGVyIGZ1bmN0 aW9uLgorICAgIAorICAgICAgICBOb3RlIHRoYXQgdGhlIEZJWE1FIGluIGRhc2hib2FyZF9iYXNl IGFib3V0IHRoaXMgd2FzIGFjdHVhbGx5IHdyb25nIC0KKyAgICAgICAgd2UgZG9uJ3Qgd2FudCB0 byBtb3ZlIGl0IHRvIGdfY3Jvc3NEYXNoYm9hcmRTdGF0ZSwgYmVjYXVzZSBpdCBpc24ndAorICAg ICAgICBhY3R1YWxseSBjcm9zcyBkYXNoYm9hcmQgc3RhdGUuCisgICAgICAgIAorICAgICAgICBJ biBmYWN0LCBmbGFraW5lc3MgYW5kIHRyZWVtYXAgaGF2ZSB0aGUgY29kZSBpbiAKKyAgICAgICAg aGFuZGxlVmFsaWRIYXNoUGFyYW1ldGVyLCBidXQgaXQgaXMgY3VycmVudGx5IGRlYWQgY29kZSBi ZWNhdXNlIAorICAgICAgICBkYXNoYm9hcmRfYmFzZSBnZXRzIHRvIGl0IGZpcnN0LgorICAgICAg ICAKKyAgICAgICAgQWRkZWQgdGhlIHByb3BlciBoYW5kbGluZyB0byB0aW1lbGluZV9leHBsb3Jl ciwgc2luY2UgYnVpbGRlciBpcworICAgICAgICB2YWxpZCB0aGVyZS4KKworICAgICAgICAqIFRl c3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvZGFzaGJvYXJkX2Jhc2UuanM6CisgICAg ICAgICogVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy90aW1lbGluZV9leHBsb3Jl ci5odG1sOgorCiAyMDEzLTAxLTExICBQcmF0aWsgU29sYW5raSAgPHBzb2xhbmtpQGFwcGxlLmNv bT4KIAogICAgICAgICBUZXN0UnVubmVyIGxlYWtzIHdoZW4gcnVubmluZyB0ZXN0cwpkaWZmIC0t Z2l0IGEvVG9vbHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9kYXNoYm9hcmRf YmFzZS5qcyBiL1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvZGFzaGJv YXJkX2Jhc2UuanMKaW5kZXggMzUwOTNlMjMwNzZhZWNkY2IxMzU2YmQ1Njg1ZWUxMTI4Y2YyZjJm MS4uNWU1NmQ5ZDA1MGE5M2I0YTc5MTUwMDRiZTJiYjU5Y2U5YzNjZmUwMyAxMDA2NDQKLS0tIGEv VG9vbHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9kYXNoYm9hcmRfYmFzZS5q cworKysgYi9Ub29scy9UZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2Rhc2hib2Fy ZF9iYXNlLmpzCkBAIC0xODUsMTIgKzE4NSw2IEBAIGZ1bmN0aW9uIGhhbmRsZVZhbGlkSGFzaFBh cmFtZXRlcldyYXBwZXIoa2V5LCB2YWx1ZSkKICAgICAgICAgICAgIH0pOwogICAgICAgICByZXR1 cm4gdHJ1ZTsKIAotICAgIC8vIEZJWE1FOiBUaGlzIHNob3VsZCBwcm9iYWJseSBiZSBzdG9yZWQg b24gZ19jcm9zc0Rhc2hib2FyZFN0YXRlIGxpa2UgZXZlcnl0aGluZyBlbHNlIGluIHRoaXMgZnVu Y3Rpb24uCi0gICAgY2FzZSAnYnVpbGRlcic6Ci0gICAgICAgIHZhbGlkYXRlUGFyYW1ldGVyKGdf Y3VycmVudFN0YXRlLCBrZXksIHZhbHVlLAotICAgICAgICAgICAgZnVuY3Rpb24oKSB7IHJldHVy biB2YWx1ZSBpbiBjdXJyZW50QnVpbGRlcnMoKTsgfSk7Ci0gICAgICAgIHJldHVybiB0cnVlOwot CiAgICAgY2FzZSAndXNlVGVzdERhdGEnOgogICAgIGNhc2UgJ3Nob3dBbGxSdW5zJzoKICAgICAg ICAgZ19jcm9zc0Rhc2hib2FyZFN0YXRlW2tleV0gPSB2YWx1ZSA9PSAndHJ1ZSc7CmRpZmYgLS1n aXQgYS9Ub29scy9UZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL3RpbWVsaW5lX2V4 cGxvcmVyLmh0bWwgYi9Ub29scy9UZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL3Rp bWVsaW5lX2V4cGxvcmVyLmh0bWwKaW5kZXggZDRhYThlODU4YjM1ZjcwZTU5ODI3NjFhMjJlNGMw NmQwNGU4M2QzNS4uYWM1ODkxYTVlNDcwMzRlYWFjZGE0Yjk2ZDZhODkxMTIxOTVmYTRlNiAxMDA2 NDQKLS0tIGEvVG9vbHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy90aW1lbGlu ZV9leHBsb3Jlci5odG1sCisrKyBiL1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hi b2FyZHMvdGltZWxpbmVfZXhwbG9yZXIuaHRtbApAQCAtMTUyLDYgKzE1MiwxMCBAQCBmdW5jdGlv biBpbml0Q3VycmVudEJ1aWxkZXJUZXN0UmVzdWx0cygpCiBmdW5jdGlvbiBoYW5kbGVWYWxpZEhh c2hQYXJhbWV0ZXIoa2V5LCB2YWx1ZSkKIHsKICAgICBzd2l0Y2goa2V5KSB7CisgICAgY2FzZSAn YnVpbGRlcic6CisgICAgICAgIHZhbGlkYXRlUGFyYW1ldGVyKGdfY3VycmVudFN0YXRlLCBrZXks IHZhbHVlLAorICAgICAgICAgICAgZnVuY3Rpb24oKSB7IHJldHVybiB2YWx1ZSBpbiBjdXJyZW50 QnVpbGRlcnMoKTsgfSk7CisgICAgICAgIHJldHVybiB0cnVlOwogICAgIGNhc2UgJ2J1aWxkVGlt ZXN0YW1wJzoKICAgICAgICAgZ19jdXJyZW50U3RhdGUuYnVpbGRUaW1lc3RhbXAgPSBwYXJzZUlu dCh2YWx1ZSwgMTApOwogICAgICAgICByZXR1cm4gdHJ1ZTsK