106677 2013-01-11 10:31:15 -0800 Incoming synchronous messages can sometimes arrive out of order 2013-01-11 11:10:09 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca gtk-ews levin+threading webkit-ews webkit.review.bot xan.lopez oldest_to_newest 805379 0 andersca 2013-01-11 10:31:15 -0800 Incoming synchronous messages can sometimes arrive out of order 805398 1 182367 andersca 2013-01-11 10:41:35 -0800 Created attachment 182367 Patch 805407 2 182367 eflews.bot 2013-01-11 10:47:45 -0800 Comment on attachment 182367 Patch Attachment 182367 did not pass efl-ews (efl): Output: http://queues.webkit.org/results/15804445 805409 3 182367 webkit-ews 2013-01-11 10:48:20 -0800 Comment on attachment 182367 Patch Attachment 182367 did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15806447 805418 4 182367 gtk-ews 2013-01-11 10:56:47 -0800 Comment on attachment 182367 Patch Attachment 182367 did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/15802494 805424 5 182367 kling 2013-01-11 11:02:52 -0800 Comment on attachment 182367 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182367&action=review Sweet! r=me > Source/WebKit2/ChangeLog:10 > + the synchronous messages before any pending asynchronous messages on that connection. This breaks FIFO ordering, Comma at end here. 805435 6 andersca 2013-01-11 11:10:09 -0800 Committed r139464: <http://trac.webkit.org/changeset/139464> 182367 2013-01-11 10:41:35 -0800 2013-01-11 11:02:52 -0800 Patch bug-106677-20130111103835.patch text/plain 6949 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5MzQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzM0Y2U5YjI4YjczNTRi OGM2ZmUwNmFmODYzYjI1NDc5YjVlZTBjNi4uNmRlMTA3MGQyZDgzMjFkMjJkNjA5NzQwNGViZmIy MWYxY2VhNTZjMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEzLTAxLTExICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgSW5jb21pbmcgc3lu Y2hyb25vdXMgbWVzc2FnZXMgY2FuIHNvbWV0aW1lcyBhcnJpdmUgb3V0IG9mIG9yZGVyCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDY2NzcKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzEyNzgxMzQ5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEluIGNhc2VzIHdoZXJlIHN5bmNocm9ub3VzIG1lc3NhZ2Vz IGNvbWUgaW4gbW9yZSB0aGFuIG9uZSBjb25uZWN0aW9uIGF0IHRoZSBzYW1lIHRpbWUsIHdlIGNh biBzb21ldGltZXMgZGVsaXZlcgorICAgICAgICB0aGUgc3luY2hyb25vdXMgbWVzc2FnZXMgYmVm b3JlIGFueSBwZW5kaW5nIGFzeW5jaHJvbm91cyBtZXNzYWdlcyBvbiB0aGF0IGNvbm5lY3Rpb24u IFRoaXMgYnJlYWtzIEZJRk8gb3JkZXJpbmcsCisKKyAgICAgICAgRml4IHRoaXMgYnkgc2VwYXJh dGluZyB0aGUgImRpc3BhdGNoIGFsbCBpbmNvbWluZyBzeW5jaHJvbm91cyBtZXNzYWdlcyIgcGhh c2Ugb3V0IGludG8gbXVsdGlwbGUgcGhhc2VzLCBzbyB3ZSdsbAorICAgICAgICBzY2hlZHVsZSBv bmUgY2FsbCBwZXIgY29ubmVjdGlvbiBpbnN0ZWFkIG9mIG9uZSBjYWxsIGZvciBhbGwgY29ubmVj dGlvbnMuCisKKyAgICAgICAgKiBQbGF0Zm9ybS9Db3JlSVBDL0Nvbm5lY3Rpb24uY3BwOgorICAg ICAgICAoQ29ubmVjdGlvbjo6U3luY01lc3NhZ2VTdGF0ZSk6CisgICAgICAgIChDb3JlSVBDOjpD b25uZWN0aW9uOjpTeW5jTWVzc2FnZVN0YXRlOjpTeW5jTWVzc2FnZVN0YXRlKToKKyAgICAgICAg KENvcmVJUEM6OkNvbm5lY3Rpb246OlN5bmNNZXNzYWdlU3RhdGU6OnByb2Nlc3NJbmNvbWluZ01l c3NhZ2UpOgorICAgICAgICAoQ29yZUlQQzo6Q29ubmVjdGlvbjo6U3luY01lc3NhZ2VTdGF0ZTo6 ZGlzcGF0Y2hNZXNzYWdlcyk6CisgICAgICAgIChDb3JlSVBDOjpDb25uZWN0aW9uOjpTeW5jTWVz c2FnZVN0YXRlOjpkaXNwYXRjaE1lc3NhZ2VBbmRSZXNldERpZFNjaGVkdWxlRGlzcGF0Y2hNZXNz YWdlc0ZvckNvbm5lY3Rpb24pOgorICAgICAgICAoQ29yZUlQQzo6Q29ubmVjdGlvbjo6d2FpdEZv clN5bmNSZXBseSk6CisKIDIwMTMtMDEtMTAgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBh cHBsZS5jb20+CiAKICAgICAgICAgRW5zdXJlIHRoYXQgV2ViUGFnZVByb3h5J3Mgbm90aW9uIG9m IHBhZ2VTY2FsZUZhY3RvciBpcyByZXNldCBvbiBkaWRDb21taXRMb2FkCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBDL0Nvbm5lY3Rpb24uY3BwIGIvU291cmNlL1dl YktpdDIvUGxhdGZvcm0vQ29yZUlQQy9Db25uZWN0aW9uLmNwcAppbmRleCAzYjFhNzVkZWZiOWYw Y2Q5MzVlYTc4MmQ1ZTA0MzdlODUwMmNhNjMyLi5iM2M3YzE3M2NhOGE4YzY4ZDZmNjAwMWVjNTRj ZWNlN2FhN2M1MTIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBD L0Nvbm5lY3Rpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvQ29u bmVjdGlvbi5jcHAKQEAgLTMwLDYgKzMwLDcgQEAKICNpbmNsdWRlICJDb3JlSVBDTWVzc2FnZUtp bmRzLmgiCiAjaW5jbHVkZSA8V2ViQ29yZS9SdW5Mb29wLmg+CiAjaW5jbHVkZSA8d3RmL0N1cnJl bnRUaW1lLmg+CisjaW5jbHVkZSA8d3RmL0hhc2hTZXQuaD4KIAogdXNpbmcgbmFtZXNwYWNlIFdl YkNvcmU7CiAKQEAgLTU0LDcgKzU1LDkgQEAgcHVibGljOgogICAgIC8vIHdhaXRpbmcgZm9yIGEg cmVwbHkgdG8gYSBzeW5jaHJvbm91cyBtZXNzYWdlLgogICAgIGJvb2wgcHJvY2Vzc0luY29taW5n TWVzc2FnZShDb25uZWN0aW9uKiwgSW5jb21pbmdNZXNzYWdlJik7CiAKLSAgICB2b2lkIGRpc3Bh dGNoTWVzc2FnZXMoKTsKKyAgICAvLyBEaXNwYXRjaCBwZW5kaW5nIHN5bmMgbWVzc2FnZXMuIGlm IGFsbG93ZWRDb25uZWN0aW9uIGlzIG5vdCBudWxsLCB3aWxsIG9ubHkgZGlzcGF0Y2ggbWVzc2Fn ZXMKKyAgICAvLyBmcm9tIHRoYXQgY29ubmVjdGlvbiBhbmQgcHV0IHRoZSBvdGhlciBtZXNzYWdl cyBiYWNrIGluIHRoZSBxdWV1ZS4KKyAgICB2b2lkIGRpc3BhdGNoTWVzc2FnZXMoQ29ubmVjdGlv biogYWxsb3dlZENvbm5lY3Rpb24pOwogCiBwcml2YXRlOgogICAgIGV4cGxpY2l0IFN5bmNNZXNz YWdlU3RhdGUoUnVuTG9vcCopOwpAQCAtNzIsMTUgKzc1LDE2IEBAIHByaXZhdGU6CiAgICAgICAg IHJldHVybiBzeW5jTWVzc2FnZVN0YXRlTWFwTXV0ZXg7CiAgICAgfQogCi0gICAgdm9pZCBkaXNw YXRjaE1lc3NhZ2VBbmRSZXNldERpZFNjaGVkdWxlRGlzcGF0Y2hNZXNzYWdlc1dvcmsoKTsKKyAg ICB2b2lkIGRpc3BhdGNoTWVzc2FnZUFuZFJlc2V0RGlkU2NoZWR1bGVEaXNwYXRjaE1lc3NhZ2Vz Rm9yQ29ubmVjdGlvbihDb25uZWN0aW9uKik7CiAKICAgICBSdW5Mb29wKiBtX3J1bkxvb3A7CiAg ICAgQmluYXJ5U2VtYXBob3JlIG1fd2FpdEZvclN5bmNSZXBseVNlbWFwaG9yZTsKIAotICAgIC8v IFByb3RlY3RzIG1fZGlkU2NoZWR1bGVEaXNwYXRjaE1lc3NhZ2VzV29yayBhbmQgbV9tZXNzYWdl c1RvRGlzcGF0Y2hXaGlsZVdhaXRpbmdGb3JTeW5jUmVwbHkuCisgICAgLy8gUHJvdGVjdHMgbV9k aWRTY2hlZHVsZURpc3BhdGNoTWVzc2FnZXNXb3JrU2V0IGFuZCBtX21lc3NhZ2VzVG9EaXNwYXRj aFdoaWxlV2FpdGluZ0ZvclN5bmNSZXBseS4KICAgICBNdXRleCBtX211dGV4OwogCi0gICAgYm9v bCBtX2RpZFNjaGVkdWxlRGlzcGF0Y2hNZXNzYWdlc1dvcms7CisgICAgLy8gVGhlIHNldCBvZiBj b25uZWN0aW9ucyBmb3Igd2hpY2ggd2UndmUgc2NoZWR1bGVkIGEgY2FsbCB0byBkaXNwYXRjaE1l c3NhZ2VBbmRSZXNldERpZFNjaGVkdWxlRGlzcGF0Y2hNZXNzYWdlc0ZvckNvbm5lY3Rpb24uCisg ICAgSGFzaFNldDxSZWZQdHI8Q29ubmVjdGlvbj4gPiBtX2RpZFNjaGVkdWxlRGlzcGF0Y2hNZXNz YWdlc1dvcmtTZXQ7CiAKICAgICBzdHJ1Y3QgQ29ubmVjdGlvbkFuZEluY29taW5nTWVzc2FnZSB7 CiAgICAgICAgIFJlZlB0cjxDb25uZWN0aW9uPiBjb25uZWN0aW9uOwpAQCAtMTA3LDcgKzExMSw2 IEBAIFBhc3NSZWZQdHI8Q29ubmVjdGlvbjo6U3luY01lc3NhZ2VTdGF0ZT4gQ29ubmVjdGlvbjo6 U3luY01lc3NhZ2VTdGF0ZTo6Z2V0T3JDcmVhCiAKIENvbm5lY3Rpb246OlN5bmNNZXNzYWdlU3Rh dGU6OlN5bmNNZXNzYWdlU3RhdGUoUnVuTG9vcCogcnVuTG9vcCkKICAgICA6IG1fcnVuTG9vcChy dW5Mb29wKQotICAgICwgbV9kaWRTY2hlZHVsZURpc3BhdGNoTWVzc2FnZXNXb3JrKGZhbHNlKQog ewogfQogCkBAIC0xMzIsMTAgKzEzNSw4IEBAIGJvb2wgQ29ubmVjdGlvbjo6U3luY01lc3NhZ2VT dGF0ZTo6cHJvY2Vzc0luY29taW5nTWVzc2FnZShDb25uZWN0aW9uKiBjb25uZWN0aW9uCiAgICAg ewogICAgICAgICBNdXRleExvY2tlciBsb2NrZXIobV9tdXRleCk7CiAgICAgICAgIAotICAgICAg ICBpZiAoIW1fZGlkU2NoZWR1bGVEaXNwYXRjaE1lc3NhZ2VzV29yaykgewotICAgICAgICAgICAg bV9ydW5Mb29wLT5kaXNwYXRjaChXVEY6OmJpbmQoJlN5bmNNZXNzYWdlU3RhdGU6OmRpc3BhdGNo TWVzc2FnZUFuZFJlc2V0RGlkU2NoZWR1bGVEaXNwYXRjaE1lc3NhZ2VzV29yaywgdGhpcykpOwot ICAgICAgICAgICAgbV9kaWRTY2hlZHVsZURpc3BhdGNoTWVzc2FnZXNXb3JrID0gdHJ1ZTsKLSAg ICAgICAgfQorICAgICAgICBpZiAobV9kaWRTY2hlZHVsZURpc3BhdGNoTWVzc2FnZXNXb3JrU2V0 LmFkZChjb25uZWN0aW9uKS5pc05ld0VudHJ5KQorICAgICAgICAgICAgbV9ydW5Mb29wLT5kaXNw YXRjaChiaW5kKCZTeW5jTWVzc2FnZVN0YXRlOjpkaXNwYXRjaE1lc3NhZ2VBbmRSZXNldERpZFNj aGVkdWxlRGlzcGF0Y2hNZXNzYWdlc0ZvckNvbm5lY3Rpb24sIHRoaXMsIFJlZlB0cjxDb25uZWN0 aW9uPihjb25uZWN0aW9uKSkpOwogCiAgICAgICAgIG1fbWVzc2FnZXNUb0Rpc3BhdGNoV2hpbGVX YWl0aW5nRm9yU3luY1JlcGx5LmFwcGVuZChjb25uZWN0aW9uQW5kSW5jb21pbmdNZXNzYWdlKTsK ICAgICB9CkBAIC0xNDUsNyArMTQ2LDcgQEAgYm9vbCBDb25uZWN0aW9uOjpTeW5jTWVzc2FnZVN0 YXRlOjpwcm9jZXNzSW5jb21pbmdNZXNzYWdlKENvbm5lY3Rpb24qIGNvbm5lY3Rpb24KICAgICBy ZXR1cm4gdHJ1ZTsKIH0KIAotdm9pZCBDb25uZWN0aW9uOjpTeW5jTWVzc2FnZVN0YXRlOjpkaXNw YXRjaE1lc3NhZ2VzKCkKK3ZvaWQgQ29ubmVjdGlvbjo6U3luY01lc3NhZ2VTdGF0ZTo6ZGlzcGF0 Y2hNZXNzYWdlcyhDb25uZWN0aW9uKiBhbGxvd2VkQ29ubmVjdGlvbikKIHsKICAgICBBU1NFUlQo bV9ydW5Mb29wID09IFJ1bkxvb3A6OmN1cnJlbnQoKSk7CiAKQEAgLTE1NiwyMSArMTU3LDM2IEBA IHZvaWQgQ29ubmVjdGlvbjo6U3luY01lc3NhZ2VTdGF0ZTo6ZGlzcGF0Y2hNZXNzYWdlcygpCiAg ICAgICAgIG1fbWVzc2FnZXNUb0Rpc3BhdGNoV2hpbGVXYWl0aW5nRm9yU3luY1JlcGx5LnN3YXAo bWVzc2FnZXNUb0Rpc3BhdGNoV2hpbGVXYWl0aW5nRm9yU3luY1JlcGx5KTsKICAgICB9CiAKKyAg ICBWZWN0b3I8Q29ubmVjdGlvbkFuZEluY29taW5nTWVzc2FnZT4gbWVzc2FnZXNUb1B1dEJhY2s7 CisKICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IG1lc3NhZ2VzVG9EaXNwYXRjaFdoaWxlV2Fp dGluZ0ZvclN5bmNSZXBseS5zaXplKCk7ICsraSkgewogICAgICAgICBDb25uZWN0aW9uQW5kSW5j b21pbmdNZXNzYWdlJiBjb25uZWN0aW9uQW5kSW5jb21pbmdNZXNzYWdlID0gbWVzc2FnZXNUb0Rp c3BhdGNoV2hpbGVXYWl0aW5nRm9yU3luY1JlcGx5W2ldOworCisgICAgICAgIGlmIChhbGxvd2Vk Q29ubmVjdGlvbiAmJiBhbGxvd2VkQ29ubmVjdGlvbiAhPSBjb25uZWN0aW9uQW5kSW5jb21pbmdN ZXNzYWdlLmNvbm5lY3Rpb24pIHsKKyAgICAgICAgICAgIC8vIFRoaXMgaW5jb21pbmcgbWVzc2Fn ZSBiZWxvbmdzIHRvIGFub3RoZXIgY29ubmVjdGlvbiBhbmQgd2UgZG9uJ3Qgd2FudCB0byBkaXNw YXRjaCBpdCBub3cKKyAgICAgICAgICAgIC8vIHNvIG1hcmsgaXQgdG8gYmUgcHV0IGJhY2sgaW4g dGhlIG1lc3NhZ2UgcXVldWUuCisgICAgICAgICAgICBtZXNzYWdlc1RvUHV0QmFjay5hcHBlbmQo Y29ubmVjdGlvbkFuZEluY29taW5nTWVzc2FnZSk7CisgICAgICAgICAgICBjb250aW51ZTsKKyAg ICAgICAgfQorCiAgICAgICAgIGNvbm5lY3Rpb25BbmRJbmNvbWluZ01lc3NhZ2UuY29ubmVjdGlv bi0+ZGlzcGF0Y2hNZXNzYWdlKGNvbm5lY3Rpb25BbmRJbmNvbWluZ01lc3NhZ2UuaW5jb21pbmdN ZXNzYWdlKTsKICAgICB9CisKKyAgICBpZiAoIW1lc3NhZ2VzVG9QdXRCYWNrLmlzRW1wdHkoKSkg eworICAgICAgICBNdXRleExvY2tlciBsb2NrZXIobV9tdXRleCk7CisgICAgICAgIG1fbWVzc2Fn ZXNUb0Rpc3BhdGNoV2hpbGVXYWl0aW5nRm9yU3luY1JlcGx5LmFwcGVuZChtZXNzYWdlc1RvUHV0 QmFjayk7CisgICAgfQogfQogCi12b2lkIENvbm5lY3Rpb246OlN5bmNNZXNzYWdlU3RhdGU6OmRp c3BhdGNoTWVzc2FnZUFuZFJlc2V0RGlkU2NoZWR1bGVEaXNwYXRjaE1lc3NhZ2VzV29yaygpCit2 b2lkIENvbm5lY3Rpb246OlN5bmNNZXNzYWdlU3RhdGU6OmRpc3BhdGNoTWVzc2FnZUFuZFJlc2V0 RGlkU2NoZWR1bGVEaXNwYXRjaE1lc3NhZ2VzRm9yQ29ubmVjdGlvbihDb25uZWN0aW9uKiBjb25u ZWN0aW9uKQogewogICAgIHsKICAgICAgICAgTXV0ZXhMb2NrZXIgbG9ja2VyKG1fbXV0ZXgpOwot ICAgICAgICBBU1NFUlQobV9kaWRTY2hlZHVsZURpc3BhdGNoTWVzc2FnZXNXb3JrKTsKLSAgICAg ICAgbV9kaWRTY2hlZHVsZURpc3BhdGNoTWVzc2FnZXNXb3JrID0gZmFsc2U7CisgICAgICAgIEFT U0VSVChtX2RpZFNjaGVkdWxlRGlzcGF0Y2hNZXNzYWdlc1dvcmtTZXQuY29udGFpbnMoY29ubmVj dGlvbikpOworICAgICAgICBtX2RpZFNjaGVkdWxlRGlzcGF0Y2hNZXNzYWdlc1dvcmtTZXQucmVt b3ZlKGNvbm5lY3Rpb24pOwogICAgIH0KIAotICAgIGRpc3BhdGNoTWVzc2FnZXMoKTsKKyAgICBk aXNwYXRjaE1lc3NhZ2VzKGNvbm5lY3Rpb24pOwogfQogCiBQYXNzUmVmUHRyPENvbm5lY3Rpb24+ IENvbm5lY3Rpb246OmNyZWF0ZVNlcnZlckNvbm5lY3Rpb24oSWRlbnRpZmllciBpZGVudGlmaWVy LCBDbGllbnQqIGNsaWVudCwgUnVuTG9vcCogY2xpZW50UnVuTG9vcCkKQEAgLTQyMSw3ICs0Mzcs NyBAQCBQYXNzT3duUHRyPE1lc3NhZ2VEZWNvZGVyPiBDb25uZWN0aW9uOjp3YWl0Rm9yU3luY1Jl cGx5KHVpbnQ2NF90IHN5bmNSZXF1ZXN0SUQsCiAgICAgYm9vbCB0aW1lZE91dCA9IGZhbHNlOwog ICAgIHdoaWxlICghdGltZWRPdXQpIHsKICAgICAgICAgLy8gRmlyc3QsIGNoZWNrIGlmIHdlIGhh dmUgYW55IG1lc3NhZ2VzIHRoYXQgd2UgbmVlZCB0byBwcm9jZXNzLgotICAgICAgICBtX3N5bmNN ZXNzYWdlU3RhdGUtPmRpc3BhdGNoTWVzc2FnZXMoKTsKKyAgICAgICAgbV9zeW5jTWVzc2FnZVN0 YXRlLT5kaXNwYXRjaE1lc3NhZ2VzKG51bGxwdHIpOwogICAgICAgICAKICAgICAgICAgewogICAg ICAgICAgICAgTXV0ZXhMb2NrZXIgbG9ja2VyKG1fc3luY1JlcGx5U3RhdGVNdXRleCk7Cg==