<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>106669</bug_id>
          
          <creation_ts>2013-01-11 08:51:56 -0800</creation_ts>
          <short_desc>[Qt] Switch to GStreamer 1.0</short_desc>
          <delta_ts>2013-09-05 07:14:55 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Qt</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>106085</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Sebastian Dröge (slomo)">slomo</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abecsi</cc>
    
    <cc>allan.jensen</cc>
    
    <cc>buildbot</cc>
    
    <cc>eric.carlson</cc>
    
    <cc>feature-media-reviews</cc>
    
    <cc>gustavo</cc>
    
    <cc>hausmann</cc>
    
    <cc>kadam</cc>
    
    <cc>laszlo.gombos</cc>
    
    <cc>menard</cc>
    
    <cc>mrobinson</cc>
    
    <cc>ossy</cc>
    
    <cc>pnormand</cc>
    
    <cc>rdieter</cc>
    
    <cc>rniwa</cc>
    
    <cc>sergio</cc>
    
    <cc>slomo</cc>
    
    <cc>vestbo</cc>
    
    <cc>webkit-ews</cc>
    
    <cc>webkit.review.bot</cc>
    
    <cc>zarvai</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>805290</commentid>
    <comment_count>0</comment_count>
    <who name="Sebastian Dröge (slomo)">slomo</who>
    <bug_when>2013-01-11 08:51:56 -0800</bug_when>
    <thetext>+++ This bug was initially created as a clone of Bug #106085 +++</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>805294</commentid>
    <comment_count>1</comment_count>
      <attachid>182351</attachid>
    <who name="Sebastian Dröge (slomo)">slomo</who>
    <bug_when>2013-01-11 08:53:57 -0800</bug_when>
    <thetext>Created attachment 182351
Switch QtWebKit to GStreamer 1.0</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>805297</commentid>
    <comment_count>2</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-01-11 08:57:15 -0800</bug_when>
    <thetext>Attachment 182351 did not pass style-queue:

Failed to run &quot;[&apos;Tools/Scripts/check-webkit-style&apos;, &apos;--diff-files&apos;, u&apos;Source/WebCore/ChangeLog&apos;, u&apos;Source/WebCor...&quot; exit_code: 1
Tools/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>805305</commentid>
    <comment_count>3</comment_count>
      <attachid>182351</attachid>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2013-01-11 09:08:33 -0800</bug_when>
    <thetext>Comment on attachment 182351
Switch QtWebKit to GStreamer 1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=182351&amp;action=review

&gt; Source/WebCore/WebCore.pri:169
&gt; +    DEFINES += GST_API_VERSION=1.0

That one is not needed I think.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>805370</commentid>
    <comment_count>4</comment_count>
      <attachid>182351</attachid>
    <who name="Build Bot">buildbot</who>
    <bug_when>2013-01-11 10:23:26 -0800</bug_when>
    <thetext>Comment on attachment 182351
Switch QtWebKit to GStreamer 1.0

Attachment 182351 did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15809385

New failing tests:
svg/as-image/img-preserveAspectRatio-support-2.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>806261</commentid>
    <comment_count>5</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2013-01-14 05:00:01 -0800</bug_when>
    <thetext>Why we need one more bug report for this bug?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>825461</commentid>
    <comment_count>6</comment_count>
      <attachid>182351</attachid>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2013-02-05 07:22:36 -0800</bug_when>
    <thetext>Comment on attachment 182351
Switch QtWebKit to GStreamer 1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=182351&amp;action=review

r=me with minor changes mentioned inline, but we should wait with landing until bots upgrade.

&gt;&gt; Source/WebCore/ChangeLog:9
&gt;&gt; +	Switch to GStreamer 1.0.
&gt; 
&gt; Line contains tab character.  [whitespace/tab] [5]

Please remove this line.

&gt;&gt; Source/WebCore/WebCore.pri:169
&gt;&gt; +    DEFINES += GST_API_VERSION=1.0
&gt; 
&gt; That one is not needed I think.

I agree, we don&apos;t need it.

&gt;&gt; Tools/ChangeLog:9
&gt;&gt; +	Switch to GStreamer 1.0.
&gt; 
&gt; Line contains tab character.  [whitespace/tab] [5]

Please remove this line.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>825463</commentid>
    <comment_count>7</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2013-02-05 07:23:45 -0800</bug_when>
    <thetext>*** Bug 106085 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>825530</commentid>
    <comment_count>8</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2013-02-05 09:10:28 -0800</bug_when>
    <thetext>The code changed a bit since this patch was uploaded, a rebase will be needed I&apos;m afraid.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>825532</commentid>
    <comment_count>9</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2013-02-05 09:11:12 -0800</bug_when>
    <thetext>(In reply to comment #8)
&gt; The code changed a bit since this patch was uploaded, a rebase will be needed I&apos;m afraid.

It applied and worked for me as is. ;)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>825547</commentid>
    <comment_count>10</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2013-02-05 09:26:03 -0800</bug_when>
    <thetext>Oh right, sorry I was confusing myself with Bug 106085 :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>843067</commentid>
    <comment_count>11</comment_count>
      <attachid>190523</attachid>
    <who name="Allan Sandfeld Jensen">allan.jensen</who>
    <bug_when>2013-02-27 07:55:16 -0800</bug_when>
    <thetext>Created attachment 190523
Patch

Updated version of Sebastian&apos;s patch, but including temporary support for gstreamer 0.10.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>843071</commentid>
    <comment_count>12</comment_count>
      <attachid>190523</attachid>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2013-02-27 08:01:29 -0800</bug_when>
    <thetext>Comment on attachment 190523
Patch

LGTM, r=me. We can remove the temporary support later.

One little nit: Shouldn&apos;t we warn the developers if they still use 0.1 to 
install 1.0 as soon as possible, because 0.1 support will be dropped soon?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>843072</commentid>
    <comment_count>13</comment_count>
      <attachid>190523</attachid>
    <who name="Early Warning System Bot">webkit-ews</who>
    <bug_when>2013-02-27 08:03:11 -0800</bug_when>
    <thetext>Comment on attachment 190523
Patch

Attachment 190523 did not pass qt-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/16768710</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>843073</commentid>
    <comment_count>14</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2013-02-27 08:04:18 -0800</bug_when>
    <thetext>(In reply to comment #13)
&gt; (From update of attachment 190523 [details])
&gt; Attachment 190523 [details] did not pass qt-ews (qt):
&gt; Output: http://webkit-commit-queue.appspot.com/results/16768710

Hmmm ... is it possible if it is an incremental build issue?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>843075</commentid>
    <comment_count>15</comment_count>
      <attachid>190523</attachid>
    <who name="Early Warning System Bot">webkit-ews</who>
    <bug_when>2013-02-27 08:07:39 -0800</bug_when>
    <thetext>Comment on attachment 190523
Patch

Attachment 190523 did not pass qt-wk2-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/16666128</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>843076</commentid>
    <comment_count>16</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2013-02-27 08:10:18 -0800</bug_when>
    <thetext>Ádám or Zoltán, could you test it with clean build on a machine with Gstreamer 1.0?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>843194</commentid>
    <comment_count>17</comment_count>
    <who name="Allan Sandfeld Jensen">allan.jensen</who>
    <bug_when>2013-02-27 10:03:27 -0800</bug_when>
    <thetext>(In reply to comment #14)
&gt; (In reply to comment #13)
&gt; &gt; (From update of attachment 190523 [details] [details])
&gt; &gt; Attachment 190523 [details] [details] did not pass qt-ews (qt):
&gt; &gt; Output: http://webkit-commit-queue.appspot.com/results/16768710
&gt; 
&gt; Hmmm ... is it possible if it is an incremental build issue?

Yes, it doesn&apos;t build incrementally when upgrading from 0.1 to 1.0. The problem is the flags are same since use_gstreamer now implies 1.0</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>843202</commentid>
    <comment_count>18</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2013-02-27 10:07:26 -0800</bug_when>
    <thetext>Yes, it is incremental build issue, Zoltán checked it.

Unfortunately &quot;maybe clean build needed&quot; feature in webkitdris.pm isn&apos;t
perfect for EWS bots. But it will work on the buildbots, so it&apos;s safe
to land it now.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>843207</commentid>
    <comment_count>19</comment_count>
      <attachid>190523</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-02-27 10:20:08 -0800</bug_when>
    <thetext>Comment on attachment 190523
Patch

Clearing flags on attachment: 190523

Committed r144208: &lt;http://trac.webkit.org/changeset/144208&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>925005</commentid>
    <comment_count>20</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2013-09-05 06:55:50 -0700</bug_when>
    <thetext>Can this bug be closed now?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>925016</commentid>
    <comment_count>21</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2013-09-05 07:14:55 -0700</bug_when>
    <thetext>(In reply to comment #20)
&gt; Can this bug be closed now?

Yes.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>182351</attachid>
            <date>2013-01-11 08:53:57 -0800</date>
            <delta_ts>2013-02-05 07:22:36 -0800</delta_ts>
            <desc>Switch QtWebKit to GStreamer 1.0</desc>
            <filename>0002-Switch-QtWebKit-to-GStreamer-1.0.patch</filename>
            <type>text/plain</type>
            <size>3490</size>
            <attacher name="Sebastian Dröge (slomo)">slomo</attacher>
            
              <data encoding="base64">RnJvbSBiMzdlNTgwMmQ0MGY0NTc0YzNmZWIzMjdmZjUyZjg0MzIyNzdkMTdkIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/U2ViYXN0aWFuPTIwRHI9QzM9QjZnZT89IDxz
ZWJhc3RpYW4uZHJvZWdlQGNvbGxhYm9yYS5jby51az4KRGF0ZTogRnJpLCAxMSBKYW4gMjAxMyAx
Nzo1MDoxOSArMDEwMApTdWJqZWN0OiBbUEFUQ0ggMi8yXSBTd2l0Y2ggUXRXZWJLaXQgdG8gR1N0
cmVhbWVyIDEuMAoKLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAg
ICB8ICAgMTAgKysrKysrKysrKwogU291cmNlL1dlYkNvcmUvV2ViQ29yZS5wcmkgICAgICAgICAg
ICAgICAgfCAgICA2ICsrKystLQogVG9vbHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAg
ICAgICAgfCAgIDEwICsrKysrKysrKysKIFRvb2xzL3FtYWtlL21rc3BlY3MvZmVhdHVyZXMvZmVh
dHVyZXMucHJmIHwgICAgMiArLQogNCBmaWxlcyBjaGFuZ2VkLCAyNSBpbnNlcnRpb25zKCspLCAz
IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwOTUxN2Y5Li4zNmJkYzA1IDEwMDY0NAotLS0g
YS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n
CkBAIC0xLDUgKzEsMTUgQEAKIDIwMTMtMDEtMTEgIFNlYmFzdGlhbiBEcsO2Z2UgIDxzZWJhc3Rp
YW4uZHJvZWdlQGNvbGxhYm9yYS5jby51az4KIAorICAgICAgICBTd2l0Y2ggUXRXZWJLaXQgdG8g
R1N0cmVhbWVyIDEuMC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTEwNjY2OS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor
ICAgICAgICAqIFdlYkNvcmUucHJpOgorCVN3aXRjaCB0byBHU3RyZWFtZXIgMS4wLgorCisyMDEz
LTAxLTExICBTZWJhc3RpYW4gRHLDtmdlICA8c2ViYXN0aWFuLmRyb2VnZUBjb2xsYWJvcmEuY28u
dWs+CisKICAgICAgICAgRml4IGNvbXBpbGF0aW9uIG9mIFF0V2ViS2l0IHdpdGggR1N0cmVhbWVy
IDEuMAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA2
MDg1LgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLnByaSBiL1NvdXJjZS9X
ZWJDb3JlL1dlYkNvcmUucHJpCmluZGV4IGE5YTM2YzMuLjU3NTQ3OTQgMTAwNjQ0Ci0tLSBhL1Nv
dXJjZS9XZWJDb3JlL1dlYkNvcmUucHJpCisrKyBiL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUucHJp
CkBAIC0xNjYsNyArMTY2LDkgQEAgZW5hYmxlPyhHQU1FUEFEKSB7CiAKIHVzZT8oR1NUUkVBTUVS
KSB7CiAgICAgREVGSU5FUyArPSBFTkFCTEVfR0xJQl9TVVBQT1JUPTEKLSAgICBQS0dDT05GSUcg
Kz0gZ2xpYi0yLjAgZ2lvLTIuMCBnc3RyZWFtZXItMC4xMCBnc3RyZWFtZXItYXBwLTAuMTAgZ3N0
cmVhbWVyLWJhc2UtMC4xMCBnc3RyZWFtZXItaW50ZXJmYWNlcy0wLjEwIGdzdHJlYW1lci1wYnV0
aWxzLTAuMTAgZ3N0cmVhbWVyLXBsdWdpbnMtYmFzZS0wLjEwIGdzdHJlYW1lci12aWRlby0wLjEw
CisgICAgREVGSU5FUyArPSBHU1RfQVBJX1ZFUlNJT049MS4wCisgICAgREVGSU5FUyArPSBHU1Rf
QVBJX1ZFUlNJT05fMQorICAgIFBLR0NPTkZJRyArPSBnbGliLTIuMCBnaW8tMi4wIGdzdHJlYW1l
ci0xLjAgZ3N0cmVhbWVyLWFwcC0xLjAgZ3N0cmVhbWVyLWJhc2UtMS4wIGdzdHJlYW1lci1wYnV0
aWxzLTEuMCBnc3RyZWFtZXItcGx1Z2lucy1iYXNlLTEuMCBnc3RyZWFtZXItdmlkZW8tMS4wIGdz
dHJlYW1lci1hdWRpby0xLjAKIH0KIAogZW5hYmxlPyhWSURFTykgewpAQCAtMjA4LDcgKzIxMCw3
IEBAIGVuYWJsZT8oV0VCX0FVRElPKSB7CiAgICAgdXNlPyhHU1RSRUFNRVIpIHsKICAgICAgICAg
REVGSU5FUyArPSBXVEZfVVNFX1dFQkFVRElPX0dTVFJFQU1FUj0xCiAgICAgICAgIElOQ0xVREVQ
QVRIICs9ICQkU09VUkNFX0RJUi9wbGF0Zm9ybS9hdWRpby9nc3RyZWFtZXIKLSAgICAgICAgUEtH
Q09ORklHICs9IGdzdHJlYW1lci1hdWRpby0wLjEwIGdzdHJlYW1lci1mZnQtMC4xMAorICAgICAg
ICBQS0dDT05GSUcgKz0gZ3N0cmVhbWVyLWF1ZGlvLTEuMCBnc3RyZWFtZXItZmZ0LTEuMAogICAg
IH0KIH0KIApkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmlu
ZGV4IGJhODJhODYuLjg1ZDMwMGIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U
b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMy0wMS0xMSAgU2ViYXN0aWFuIERy
w7ZnZSAgPHNlYmFzdGlhbi5kcm9lZ2VAY29sbGFib3JhLmNvLnVrPgorCisgICAgICAgIFN3aXRj
aCBRdFdlYktpdCB0byBHU3RyZWFtZXIgMS4wLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA2NjY5LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E
WSAoT09QUyEpLgorCisgICAgICAgICogcW1ha2UvbWtzcGVjcy9mZWF0dXJlcy9mZWF0dXJlcy5w
cmY6CisJU3dpdGNoIHRvIEdTdHJlYW1lciAxLjAuCisKIDIwMTMtMDEtMTEgIFJhcGhhZWwgS3Vi
byBkYSBDb3N0YSAgPHJhcGhhZWwua3Viby5kYS5jb3N0YUBpbnRlbC5jb20+CiAKICAgICAgICAg
VW5yZXZpZXdlZCBqaGJ1aWxkLXJlbGF0ZWQgZml4IGFmdGVyIHIxMzk0MzEuCmRpZmYgLS1naXQg
YS9Ub29scy9xbWFrZS9ta3NwZWNzL2ZlYXR1cmVzL2ZlYXR1cmVzLnByZiBiL1Rvb2xzL3FtYWtl
L21rc3BlY3MvZmVhdHVyZXMvZmVhdHVyZXMucHJmCmluZGV4IDJhMGViNDAuLjkxNGM3MzQgMTAw
NjQ0Ci0tLSBhL1Rvb2xzL3FtYWtlL21rc3BlY3MvZmVhdHVyZXMvZmVhdHVyZXMucHJmCisrKyBi
L1Rvb2xzL3FtYWtlL21rc3BlY3MvZmVhdHVyZXMvZmVhdHVyZXMucHJmCkBAIC0xMTEsNyArMTEx
LDcgQEAgZGVmaW5lVGVzdChkZXRlY3RGZWF0dXJlcykgewogICAgICAgICB9CiAKICAgICB9IGVs
c2U6IGxpbnV4LSogewotICAgICAgICAhY29udGFpbnMoUVRfQ09ORklHLCBuby1wa2ctY29uZmln
KTpwYWNrYWdlc0V4aXN0KCJnbGliLTIuMCBnaW8tMi4wIFwnZ3N0cmVhbWVyLTAuMTAgPj0gMC4x
MC4zMFwnIFwnZ3N0cmVhbWVyLXBsdWdpbnMtYmFzZS0wLjEwID49IDAuMTAuMzBcJyIpIHsKKyAg
ICAgICAgIWNvbnRhaW5zKFFUX0NPTkZJRywgbm8tcGtnLWNvbmZpZyk6cGFja2FnZXNFeGlzdCgi
Z2xpYi0yLjAgZ2lvLTIuMCBnc3RyZWFtZXItMS4wIGdzdHJlYW1lci1wbHVnaW5zLWJhc2UtMS4w
IikgewogICAgICAgICAgICAgV0VCS0lUX0NPTkZJRyArPSB2aWRlbyB1c2VfZ3N0cmVhbWVyCiAg
ICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICBDT05GSUdVUkVfV0FSTklOR1MgKz0gIk1pc3Np
bmcgR0xpYi9HaW8vR1N0cmVhbWVyLCBkaXNhYmxpbmcgbWVkaWEgZWxlbWVudCBzdXBwb3J0Igot
LSAKMS43LjEwLjQKCg==
</data>
<flag name="review"
          id="200321"
          type_id="1"
          status="+"
          setter="ossy"
    />
    <flag name="commit-queue"
          id="200341"
          type_id="3"
          status="-"
          setter="buildbot"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>190523</attachid>
            <date>2013-02-27 07:55:16 -0800</date>
            <delta_ts>2013-02-27 10:20:08 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>Patch</filename>
            <type>text/plain</type>
            <size>3797</size>
            <attacher name="Allan Sandfeld Jensen">allan.jensen</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCA3MGI5MGM5Li4zZTMyYjY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg
QEAKKzIwMTMtMDItMjcgIEFsbGFuIFNhbmRmZWxkIEplbnNlbiAgPGFsbGFuLmplbnNlbkBkaWdp
YS5jb20+CisKKyAgICAgICAgU3dpdGNoIFF0V2ViS2l0IHRvIEdTdHJlYW1lciAxLjAuCisgICAg
ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDY2NjkuCisKKyAg
ICAgICAgT3JpZ2luYWwgcGF0Y2ggYnkgU2ViYXN0aWFuIERyw7ZnZS4KKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJDb3JlLnByaToKKwogMjAxMy0w
Mi0yNyAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUkVHUkVT
U0lPTjogSU5QVVRfTVVMVElQTEVfRklFTERTX1VJOiBDaGFuZ2luZyBDU1MgZGlzcGxheSBwcm9w
ZXJ0eSBvbiBpbnB1dFt0eXBlPWRhdGVdIHVuZXhwZWN0ZWRseSBtYWtlcyBhbm90aGVyIGxpbmUg
Zm9yIDo6LXdlYmtpdC1jYWxlbmRhci1waWNrZXItaW5kaWNhdG9yCmRpZmYgLS1naXQgYS9Tb3Vy
Y2UvV2ViQ29yZS9XZWJDb3JlLnByaSBiL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUucHJpCmluZGV4
IDRiODA2ZDEuLmRlYTAzMjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUucHJp
CisrKyBiL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUucHJpCkBAIC0xNzAsNyArMTcwLDEzIEBAIGVu
YWJsZT8oR0FNRVBBRCkgewogCiB1c2U/KEdTVFJFQU1FUikgewogICAgIERFRklORVMgKz0gV1RG
X1VTRV9HTElCPTEKLSAgICBQS0dDT05GSUcgKz0gZ2xpYi0yLjAgZ2lvLTIuMCBnc3RyZWFtZXIt
MC4xMCBnc3RyZWFtZXItYXBwLTAuMTAgZ3N0cmVhbWVyLWJhc2UtMC4xMCBnc3RyZWFtZXItaW50
ZXJmYWNlcy0wLjEwIGdzdHJlYW1lci1wYnV0aWxzLTAuMTAgZ3N0cmVhbWVyLXBsdWdpbnMtYmFz
ZS0wLjEwIGdzdHJlYW1lci12aWRlby0wLjEwCisgICAgdXNlPyhHU1RSRUFNRVIwMTApIHsKKyAg
ICAgICAgUEtHQ09ORklHICs9IGdsaWItMi4wIGdpby0yLjAgZ3N0cmVhbWVyLTAuMTAgZ3N0cmVh
bWVyLWFwcC0wLjEwIGdzdHJlYW1lci1iYXNlLTAuMTAgZ3N0cmVhbWVyLWludGVyZmFjZXMtMC4x
MCBnc3RyZWFtZXItcGJ1dGlscy0wLjEwIGdzdHJlYW1lci1wbHVnaW5zLWJhc2UtMC4xMCBnc3Ry
ZWFtZXItdmlkZW8tMC4xMAorICAgIH0gZWxzZSB7CisgICAgICAgIERFRklORVMgKz0gR1NUX0FQ
SV9WRVJTSU9OPTEuMAorICAgICAgICBERUZJTkVTICs9IEdTVF9BUElfVkVSU0lPTl8xCisgICAg
ICAgIFBLR0NPTkZJRyArPSBnbGliLTIuMCBnaW8tMi4wIGdzdHJlYW1lci0xLjAgZ3N0cmVhbWVy
LWFwcC0xLjAgZ3N0cmVhbWVyLWJhc2UtMS4wIGdzdHJlYW1lci1wYnV0aWxzLTEuMCBnc3RyZWFt
ZXItcGx1Z2lucy1iYXNlLTEuMCBnc3RyZWFtZXItdmlkZW8tMS4wIGdzdHJlYW1lci1hdWRpby0x
LjAKKyAgICB9CiB9CiAKIGVuYWJsZT8oVklERU8pIHsKQEAgLTIxMiw3ICsyMTgsMTEgQEAgZW5h
YmxlPyhXRUJfQVVESU8pIHsKICAgICB1c2U/KEdTVFJFQU1FUikgewogICAgICAgICBERUZJTkVT
ICs9IFdURl9VU0VfV0VCQVVESU9fR1NUUkVBTUVSPTEKICAgICAgICAgSU5DTFVERVBBVEggKz0g
JCRTT1VSQ0VfRElSL3BsYXRmb3JtL2F1ZGlvL2dzdHJlYW1lcgotICAgICAgICBQS0dDT05GSUcg
Kz0gZ3N0cmVhbWVyLWF1ZGlvLTAuMTAgZ3N0cmVhbWVyLWZmdC0wLjEwCisgICAgICAgIHVzZT8o
R1NUUkVBTUVSMDEwKSB7CisgICAgICAgICAgICBQS0dDT05GSUcgKz0gZ3N0cmVhbWVyLWF1ZGlv
LTAuMTAgZ3N0cmVhbWVyLWZmdC0wLjEwCisgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICBQ
S0dDT05GSUcgKz0gZ3N0cmVhbWVyLWF1ZGlvLTEuMCBnc3RyZWFtZXItZmZ0LTEuMAorICAgICAg
ICB9CiAgICAgfQogfQogCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFu
Z2VMb2cKaW5kZXggNzZhOGNmZC4uZjU2ZTdlNyAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9n
CisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAyLTI3ICBBbGxh
biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgorCisgICAgICAgIFN3
aXRjaCBRdFdlYktpdCB0byBHU3RyZWFtZXIgMS4wLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi
a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA2NjY5LgorCisgICAgICAgIE9yaWdpbmFsIHBhdGNo
IGJ5IFNlYmFzdGlhbiBEcsO2Z2UuCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp
LgorCisgICAgICAgIEJ1aWxkIHdpdGggR1N0cmVhbWVyIDEuMCBpZiBhdmFpbGFibGUsIGJ1dCBz
dXBwb3J0IEdTdHJlYW1lciAwLjEwIAorICAgICAgICB0ZW1wb3JhcmlseSB0byBtYWtlIHVwZ3Jh
ZGluZyBlYXN5IGFuZCB0aGUgcGF0Y2ggc3VpdGFibGUgZm9yIFF0NS4KKworICAgICAgICAqIHFt
YWtlL21rc3BlY3MvZmVhdHVyZXMvZmVhdHVyZXMucHJmOgorCiAyMDEzLTAyLTI3ICBSeW9zdWtl
IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIEJ1aWxkIGZpeCBhZnRlciByMTQ0
MTU1LiBUaGUgcmVwb3J0IHBhZ2UgaXMgbG9jYXRlZCBhdCAvYXBpL3JlcG9ydCwgbm90IC9hcGkv
dGVzdC9yZXBvcnQuCmRpZmYgLS1naXQgYS9Ub29scy9xbWFrZS9ta3NwZWNzL2ZlYXR1cmVzL2Zl
YXR1cmVzLnByZiBiL1Rvb2xzL3FtYWtlL21rc3BlY3MvZmVhdHVyZXMvZmVhdHVyZXMucHJmCmlu
ZGV4IGUzOWMwYzIuLmFjZTAxM2MgMTAwNjQ0Ci0tLSBhL1Rvb2xzL3FtYWtlL21rc3BlY3MvZmVh
dHVyZXMvZmVhdHVyZXMucHJmCisrKyBiL1Rvb2xzL3FtYWtlL21rc3BlY3MvZmVhdHVyZXMvZmVh
dHVyZXMucHJmCkBAIC0xMTMsOCArMTEzLDEwIEBAIGRlZmluZVRlc3QoZGV0ZWN0RmVhdHVyZXMp
IHsKICAgICAgICAgfQogCiAgICAgfSBlbHNlOiBsaW51eC0qIHsKLSAgICAgICAgIWNvbnRhaW5z
KFFUX0NPTkZJRywgbm8tcGtnLWNvbmZpZyk6cGFja2FnZXNFeGlzdCgiZ2xpYi0yLjAgZ2lvLTIu
MCBcJ2dzdHJlYW1lci0wLjEwID49IDAuMTAuMzBcJyBcJ2dzdHJlYW1lci1wbHVnaW5zLWJhc2Ut
MC4xMCA+PSAwLjEwLjMwXCciKSB7CisgICAgICAgICFjb250YWlucyhRVF9DT05GSUcsIG5vLXBr
Zy1jb25maWcpOnBhY2thZ2VzRXhpc3QoImdsaWItMi4wIGdpby0yLjAgZ3N0cmVhbWVyLTEuMCBn
c3RyZWFtZXItcGx1Z2lucy1iYXNlLTEuMCIpIHsKICAgICAgICAgICAgIFdFQktJVF9DT05GSUcg
Kz0gdmlkZW8gdXNlX2dzdHJlYW1lcgorICAgICAgICB9IGVsc2U6IWNvbnRhaW5zKFFUX0NPTkZJ
Rywgbm8tcGtnLWNvbmZpZyk6cGFja2FnZXNFeGlzdCgiZ2xpYi0yLjAgZ2lvLTIuMCBcJ2dzdHJl
YW1lci0wLjEwID49IDAuMTAuMzBcJyBcJ2dzdHJlYW1lci1wbHVnaW5zLWJhc2UtMC4xMCA+PSAw
LjEwLjMwXCciKSB7CisgICAgICAgICAgICBXRUJLSVRfQ09ORklHICs9IHZpZGVvIHVzZV9nc3Ry
ZWFtZXIgdXNlX2dzdHJlYW1lcjAxMAogICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAgQ09O
RklHVVJFX1dBUk5JTkdTICs9ICJNaXNzaW5nIEdMaWIvR2lvL0dTdHJlYW1lciwgZGlzYWJsaW5n
IG1lZGlhIGVsZW1lbnQgc3VwcG9ydCIKICAgICAgICAgfQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>