106668 2013-01-11 08:37:54 -0800 Web Inspector: Make V8 LiveEdit API disabled by default 2013-01-20 10:19:46 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 prybin webkit-unassigned abarth apavlov dglazkov haraken japhet keishi loislo peter+ews pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 805280 0 prybin 2013-01-11 08:37:54 -0800 LiveEdit is a sophisticated routine in V8, and potentially it may have some vulnerabilities. Enable C-level blocks in V8 core, that won't allow LiveEdit code unless actually called LiveEdit command. Related Chromium bug: https://code.google.com/p/chromium/issues/detail?id=159124 805284 1 182349 prybin 2013-01-11 08:41:59 -0800 Created attachment 182349 Patch 805285 2 prybin 2013-01-11 08:42:36 -0800 This is a follow-up for https://bugs.webkit.org/show_bug.cgi?id=104039 805287 3 182349 webkit.review.bot 2013-01-11 08:45:55 -0800 Comment on attachment 182349 Patch Attachment 182349 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15808414 805309 4 vsevik 2013-01-11 09:14:01 -0800 Some thoughts: 1. I would consider setting live_edit_enabled_ to false in Debugger constructor. It might break other existing v8 embedders though. 2. If we don't want to change v8 API in this sense, I would expect to see this in WebCore v8 bindings, where other setLiveEditEnabled calls reside. 805319 5 182349 peter+ews 2013-01-11 09:25:44 -0800 Comment on attachment 182349 Patch Attachment 182349 did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/15811350 805342 6 182358 prybin 2013-01-11 09:53:59 -0800 Created attachment 182358 Patch 805389 7 182358 abarth 2013-01-11 10:36:51 -0800 Comment on attachment 182358 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182358&action=review > Source/WebCore/bindings/v8/V8Initializer.cpp:108 > +// V8 initialization part common for both Document and Worker. This comment doesn't really add anything. Perhaps we should remove it? > Source/WebCore/bindings/v8/V8Initializer.cpp:125 > v8::V8::IgnoreOutOfMemoryException(); This call looks shared by both Document and worker, perhaps we should move it into initializeV8Common as well. (There look to be a couple others that we could share as well.) 805393 8 abarth 2013-01-11 10:39:27 -0800 This seems like something that's better done in V8, but we can do it here if we don't want to change the V8 API in this way. 806376 9 prybin 2013-01-14 08:35:16 -0800 Non-liveedit-related changes are moved into a separate prerequisite change: https://bugs.webkit.org/show_bug.cgi?id=106790 810934 10 183529 prybin 2013-01-18 12:37:50 -0800 Created attachment 183529 Patch 810944 11 prybin 2013-01-18 12:46:49 -0800 Moving the default value into V8 is not quite elegant, because it won't spare us from changes anyway, but would require all other V8 embedders to manually change the default value back without any pay-off for them (you only can use enable/disable, if you wrote the entire debug command dispatcher in C++ like WebKit did). All other comments are addresses. 811321 12 183529 webkit.review.bot 2013-01-18 23:21:21 -0800 Comment on attachment 183529 Patch Rejecting attachment 183529 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/15973076 811322 13 yurys 2013-01-18 23:26:01 -0800 (In reply to comment #12) > (From update of attachment 183529 [details]) > Rejecting attachment 183529 [details] from commit-queue. > > Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue > > /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). > > Full output: http://queues.webkit.org/results/15973076 Peter you'll need to restore "Reviewed by..." line in the ChangeLog in order commit queue to understand it. 811429 14 183629 prybin 2013-01-19 11:07:00 -0800 Created attachment 183629 Patch 811432 15 prybin 2013-01-19 11:10:27 -0800 > Peter you'll need to restore "Reviewed by..." line in the ChangeLog in order commit queue to understand it. Thanks! My bad. Oh bureaucracy!.. :) 811634 16 183629 webkit.review.bot 2013-01-20 10:19:41 -0800 Comment on attachment 183629 Patch Clearing flags on attachment: 183629 Committed r140273: <http://trac.webkit.org/changeset/140273> 811635 17 webkit.review.bot 2013-01-20 10:19:46 -0800 All reviewed patches have been landed. Closing bug. 182349 2013-01-11 08:41:59 -0800 2013-01-11 09:53:53 -0800 Patch bug-106668-20130111203901.patch text/plain 1390 prybin U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5Mzc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDU5ZTAxMWM1MGQyZWNhMjRkOGZiMjk2ZDY4YTVhMmExZDE2MTgwNWIuLjYxNjQ4YmFhMjJkMmQ5 MmQ5ZDBiYmZjNmM0MDYyMjEwN2Q4ZGQ5MTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTMtMDEtMTEgIFBldGVyIFJ5YmluICA8cGV0ZXIucnliaW5AZ21h aWwuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IE1ha2UgVjggTGl2ZUVkaXQgQVBJIGRp c2FibGVkIGJ5IGRlZmF1bHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEwNjY2OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogc3JjL1dlYktpdC5jcHA6CisgICAgICAgIChXZWJLaXQ6OmluaXRpYWxpemUp OiBMaXZlRWRpdCBkaXNhYmxpbmcgc3RhdGVtZW50IGlzIGFkZGVkIHRvIGluaXRpYWxpemluZyBy b3V0aW5lCisKIDIwMTMtMDEtMTAgIERhbiBCZWFtICA8ZGJlYW1AY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIEltcGxlbWVudCBBdXRvY29tcGxldGVFcnJvckV2ZW50I3JlYXNvbgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViS2l0LmNwcCBiL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL1dlYktpdC5jcHAKaW5kZXggMzdkZjUzZGNmMWE1M2M2OGViMjkwMDYyYWJm ODQyNTU0MjZiOTAyYy4uZWU0NDA0YTUzMGQ2NzkwY2JmNGU5YWRiMTVjNTllZmY2YTJlNGUyNiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViS2l0LmNwcAorKysgYi9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJLaXQuY3BwCkBAIC0xMDMsNiArMTAzLDcgQEAg dm9pZCBpbml0aWFsaXplKFdlYktpdFBsYXRmb3JtU3VwcG9ydCogd2ViS2l0UGxhdGZvcm1TdXBw b3J0KQogCiAgICAgdjg6OlY4OjpTZXRFbnRyb3B5U291cmNlKCZnZW5lcmF0ZUVudHJvcHkpOwog ICAgIHY4OjpWODo6SW5pdGlhbGl6ZSgpOworICAgIHY4OjpEZWJ1Zzo6U2V0TGl2ZUVkaXRFbmFi bGVkKGZhbHNlKTsKICAgICBXZWJDb3JlOjpWOFBlcklzb2xhdGVEYXRhOjplbnN1cmVJbml0aWFs aXplZCh2ODo6SXNvbGF0ZTo6R2V0Q3VycmVudCgpKTsKIAogICAgIC8vIGN1cnJlbnRUaHJlYWQg d2lsbCBhbHdheXMgYmUgbm9uLW51bGwgaW4gcHJvZHVjdGlvbiwgYnV0IGNhbiBiZSBudWxsIGlu IENocm9taXVtIHVuaXQgdGVzdHMuCg== 182358 2013-01-11 09:53:59 -0800 2013-01-18 12:37:43 -0800 Patch bug-106668-20130111215100.patch text/plain 2478 prybin U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5Mzc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzNhNjY5ZWY0NGYxNDcw ZTNmZGZhNjU0MjY5NzYzMzBhMDdkMzM3Ni4uYTg0MGI2NDk4M2EyMTFmNTMxZmRmODc1ODgwOTAw YTM3MzBiMzI4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAxLTExICBQZXRl ciBSeWJpbiAgPHBldGVyLnJ5YmluQGdtYWlsLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBNYWtlIFY4IExpdmVFZGl0IEFQSSBkaXNhYmxlZCBieSBkZWZhdWx0CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDY2NjgKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBIHNoYXJlZCBpbml0aWFsaXplIG1l dGhvZCBhZGRlZCB0byBWOEluaXRpYWxpemVyIGJvdGggZm9yIHdvcmtlcnMgYW5kIGRvY3VtZW50 LgorCisgICAgICAgICogYmluZGluZ3MvdjgvVjhJbml0aWFsaXplci5jcHA6CisgICAgICAgIChX ZWJDb3JlKToKKyAgICAgICAgKFdlYkNvcmU6OmluaXRpYWxpemVWOENvbW1vbik6CisgICAgICAg IChXZWJDb3JlOjpWOEluaXRpYWxpemVyOjppbml0aWFsaXplTWFpblRocmVhZElmTmVlZGVkKToK KyAgICAgICAgKFdlYkNvcmU6OlY4SW5pdGlhbGl6ZXI6OmluaXRpYWxpemVXb3JrZXIpOgorCiAy MDEzLTAxLTEwICBEYW4gQmVhbSAgPGRiZWFtQGNocm9taXVtLm9yZz4KIAogICAgICAgICBJbXBs ZW1lbnQgQXV0b2NvbXBsZXRlRXJyb3JFdmVudCNyZWFzb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4SW5pdGlhbGl6ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvdjgvVjhJbml0aWFsaXplci5jcHAKaW5kZXggZmE1OWE0MjYxY2NmOGNiODVjZWM2ZmE5 NGY1OTFhMTk2ZWE4YWI2Yi4uMGMxYmVhNWMwOWMyNTBlOTIzZmE0YTU1ZWIzYjUwNGFjMzFkN2Vm YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhJbml0aWFsaXplci5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhJbml0aWFsaXplci5jcHAKQEAg LTQwLDYgKzQwLDcgQEAKICNpbmNsdWRlICJWOEhpc3RvcnkuaCIKICNpbmNsdWRlICJWOExvY2F0 aW9uLmgiCiAjaW5jbHVkZSAiVjhQZXJDb250ZXh0RGF0YS5oIgorI2luY2x1ZGUgPHY4LWRlYnVn Lmg+CiAjaW5jbHVkZSA8djguaD4KICNpbmNsdWRlIDx3dGYvUmVmUHRyLmg+CiAjaW5jbHVkZSA8 d3RmL3RleHQvV1RGU3RyaW5nLmg+CkBAIC0xMDQsNiArMTA1LDEyIEBAIHN0YXRpYyB2b2lkIGZh aWxlZEFjY2Vzc0NoZWNrQ2FsbGJhY2tJbk1haW5UaHJlYWQodjg6OkxvY2FsPHY4OjpPYmplY3Q+ IGhvc3QsIHY4CiAgICAgdGFyZ2V0V2luZG93LT5wcmludEVycm9yTWVzc2FnZSh0YXJnZXRXaW5k b3ctPmNyb3NzRG9tYWluQWNjZXNzRXJyb3JNZXNzYWdlKGFjdGl2ZURPTVdpbmRvdyhCaW5kaW5n U3RhdGU6Omluc3RhbmNlKCkpKSk7CiB9CiAKKy8vIFY4IGluaXRpYWxpemF0aW9uIHBhcnQgY29t bW9uIGZvciBib3RoIERvY3VtZW50IGFuZCBXb3JrZXIuCitzdGF0aWMgdm9pZCBpbml0aWFsaXpl VjhDb21tb24oKQoreworICAgIHY4OjpEZWJ1Zzo6U2V0TGl2ZUVkaXRFbmFibGVkKGZhbHNlKTsK K30KKwogdm9pZCBWOEluaXRpYWxpemVyOjppbml0aWFsaXplTWFpblRocmVhZElmTmVlZGVkKCkK IHsKICAgICBBU1NFUlQoaXNNYWluVGhyZWFkKCkpOwpAQCAtMTEzLDYgKzEyMCw4IEBAIHZvaWQg VjhJbml0aWFsaXplcjo6aW5pdGlhbGl6ZU1haW5UaHJlYWRJZk5lZWRlZCgpCiAgICAgICAgIHJl dHVybjsKICAgICBpbml0aWFsaXplZCA9IHRydWU7CiAKKyAgICBpbml0aWFsaXplVjhDb21tb24o KTsKKwogICAgIHY4OjpWODo6SWdub3JlT3V0T2ZNZW1vcnlFeGNlcHRpb24oKTsKICAgICB2ODo6 Vjg6OlNldEZhdGFsRXJyb3JIYW5kbGVyKHJlcG9ydEZhdGFsRXJyb3JJbk1haW5UaHJlYWQpOwog ICAgIHY4OjpWODo6QWRkR0NQcm9sb2d1ZUNhbGxiYWNrKFY4R0NDb250cm9sbGVyOjpnY1Byb2xv Z3VlKTsKQEAgLTE1OSw2ICsxNjgsOCBAQCBzdGF0aWMgY29uc3QgaW50IGtXb3JrZXJNYXhTdGFj a1NpemUgPSA1MDAgKiAxMDI0OwogCiB2b2lkIFY4SW5pdGlhbGl6ZXI6OmluaXRpYWxpemVXb3Jr ZXIoKQogeworICAgIGluaXRpYWxpemVWOENvbW1vbigpOworCiAgICAgdjg6OlY4OjpBZGRNZXNz YWdlTGlzdGVuZXIobWVzc2FnZUhhbmRsZXJJbldvcmtlcik7CiAgICAgdjg6OlY4OjpJZ25vcmVP dXRPZk1lbW9yeUV4Y2VwdGlvbigpOwogICAgIHY4OjpWODo6U2V0RmF0YWxFcnJvckhhbmRsZXIo cmVwb3J0RmF0YWxFcnJvckluV29ya2VyKTsK 183529 2013-01-18 12:37:50 -0800 2013-01-19 11:06:53 -0800 Patch bug-106668-20130119003449.patch text/plain 2594 prybin U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwMTc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzI3ODhjZTk0ODU3MjRk NGEzYjM2MzBiOGJmZmFmNGQzNDQyNmQ5NS4uMzdhNzA2MDUzNjcwZGUyZTNlMGE5Zjg3MTI4ZjUx MTcyMTU3NGU3MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAxLTE4ICBQZXRl ciBSeWJpbiAgPHBldGVyLnJ5YmluQGdtYWlsLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBNYWtlIFY4IExpdmVFZGl0IEFQSSBkaXNhYmxlZCBieSBkZWZhdWx0CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDY2NjgKKworICAgICAgICBJbml0 aWFsaXplIG1ldGhvZCBpcyBwYXRjaGVkIGFjY29yZGluZ2x5LgorCisgICAgICAgICogYmluZGlu Z3MvdjgvSmF2YVNjcmlwdENhbGxGcmFtZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpKYXZhU2Ny aXB0Q2FsbEZyYW1lOjpyZXN0YXJ0KTogbWlzc2luZyBlbmFibGUvZGlzYWJsZSBjYWxscyBhZGRl ZCBmb3IgcmVzdGFydAorICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4SW5pdGlhbGl6ZXIuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6aW5pdGlhbGl6ZVY4Q29tbW9uKTogaW5pdGlhbGl6ZXIgbWV0aG9k IHBhdGNoZWQKKwogMjAxMy0wMS0xOCAgVGVycnkgQW5kZXJzb24gIDx0ZGFuZGVyc29uQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBTY3JvbGwgZ2VzdHVyZXMgc2hvdWxkIG5vdCBjcmVhdGUgd2hl ZWwgZXZlbnRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9KYXZhU2Ny aXB0Q2FsbEZyYW1lLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L0phdmFTY3JpcHRD YWxsRnJhbWUuY3BwCmluZGV4IGUyNDFjOGI3MzBjMWQxZTFhNjA2Yzk5ODQwYjAxMWU3NTEwM2Ey MmUuLjMxNTAzNjgxMzE1YjNkYTU4NjUyMmE1YTk0M2Q5YmU3MTI0ZDdlNjIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L0phdmFTY3JpcHRDYWxsRnJhbWUuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L0phdmFTY3JpcHRDYWxsRnJhbWUuY3BwCkBAIC0x MjgsNyArMTI4LDEwIEBAIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBKYXZhU2NyaXB0Q2FsbEZyYW1l OjpldmFsdWF0ZShjb25zdCBTdHJpbmcmIGV4cHJlc3Npb24pCiB2ODo6SGFuZGxlPHY4OjpWYWx1 ZT4gSmF2YVNjcmlwdENhbGxGcmFtZTo6cmVzdGFydCgpCiB7CiAgICAgdjg6OkhhbmRsZTx2ODo6 RnVuY3Rpb24+IHJlc3RhcnRGdW5jdGlvbiA9IHY4OjpIYW5kbGU8djg6OkZ1bmN0aW9uPjo6Q2Fz dChtX2NhbGxGcmFtZS5nZXQoKS0+R2V0KHY4OjpTdHJpbmc6Ok5ld1N5bWJvbCgicmVzdGFydCIp KSk7Ci0gICAgcmV0dXJuIHJlc3RhcnRGdW5jdGlvbi0+Q2FsbChtX2NhbGxGcmFtZS5nZXQoKSwg MCwgMCk7CisgICAgdjg6OkRlYnVnOjpTZXRMaXZlRWRpdEVuYWJsZWQodHJ1ZSk7CisgICAgdjg6 OkhhbmRsZTx2ODo6VmFsdWU+IHJlc3VsdCA9IHJlc3RhcnRGdW5jdGlvbi0+Q2FsbChtX2NhbGxG cmFtZS5nZXQoKSwgMCwgMCk7CisgICAgdjg6OkRlYnVnOjpTZXRMaXZlRWRpdEVuYWJsZWQoZmFs c2UpOworICAgIHJldHVybiByZXN1bHQ7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4SW5pdGlhbGl6ZXIuY3BwIGIv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhJbml0aWFsaXplci5jcHAKaW5kZXggNzZlOGVk NGE1ZDg2Zjg2OGE5Nzg3NzNjZWVlZWM2ZWE3ZmE2ZGNiMy4uM2FkYWY4YjVhZmM2NjJjMGRmZDRh Njg1OTUyZWNmMjk4MjZhYWE2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv djgvVjhJbml0aWFsaXplci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhJ bml0aWFsaXplci5jcHAKQEAgLTQwLDYgKzQwLDcgQEAKICNpbmNsdWRlICJWOEhpc3RvcnkuaCIK ICNpbmNsdWRlICJWOExvY2F0aW9uLmgiCiAjaW5jbHVkZSAiVjhQZXJDb250ZXh0RGF0YS5oIgor I2luY2x1ZGUgPHY4LWRlYnVnLmg+CiAjaW5jbHVkZSA8d3RmL1JlZlB0ci5oPgogI2luY2x1ZGUg PHd0Zi90ZXh0L1dURlN0cmluZy5oPgogCkBAIC0xMDgsNiArMTA5LDggQEAgc3RhdGljIHZvaWQg aW5pdGlhbGl6ZVY4Q29tbW9uKCkKICAgICB2ODo6Vjg6OkFkZEdDUHJvbG9ndWVDYWxsYmFjayhW OEdDQ29udHJvbGxlcjo6Z2NQcm9sb2d1ZSk7CiAgICAgdjg6OlY4OjpBZGRHQ0VwaWxvZ3VlQ2Fs bGJhY2soVjhHQ0NvbnRyb2xsZXI6OmdjRXBpbG9ndWUpOwogICAgIHY4OjpWODo6SWdub3JlT3V0 T2ZNZW1vcnlFeGNlcHRpb24oKTsKKworICAgIHY4OjpEZWJ1Zzo6U2V0TGl2ZUVkaXRFbmFibGVk KGZhbHNlKTsKIH0KIAogdm9pZCBWOEluaXRpYWxpemVyOjppbml0aWFsaXplTWFpblRocmVhZElm TmVlZGVkKHY4OjpJc29sYXRlKiBpc29sYXRlKQo= 183629 2013-01-19 11:07:00 -0800 2013-01-20 10:19:41 -0800 Patch bug-106668-20130119230357.patch text/plain 2633 prybin U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwMTc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzI3ODhjZTk0ODU3MjRk NGEzYjM2MzBiOGJmZmFmNGQzNDQyNmQ5NS4uNDM2ZWM3MTQ5YjA1ODEyZjE1N2FlOGNiYjE5MDMx MmNlYWIwYjNiNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAxLTE4ICBQZXRl ciBSeWJpbiAgPHBldGVyLnJ5YmluQGdtYWlsLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBNYWtlIFY4IExpdmVFZGl0IEFQSSBkaXNhYmxlZCBieSBkZWZhdWx0CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDY2NjgKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbml0aWFsaXplIG1ldGhvZCBpcyBw YXRjaGVkIGFjY29yZGluZ2x5LgorCisgICAgICAgICogYmluZGluZ3MvdjgvSmF2YVNjcmlwdENh bGxGcmFtZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpKYXZhU2NyaXB0Q2FsbEZyYW1lOjpyZXN0 YXJ0KTogbWlzc2luZyBlbmFibGUvZGlzYWJsZSBjYWxscyBhZGRlZCBmb3IgcmVzdGFydAorICAg ICAgICAqIGJpbmRpbmdzL3Y4L1Y4SW5pdGlhbGl6ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 aW5pdGlhbGl6ZVY4Q29tbW9uKTogaW5pdGlhbGl6ZXIgbWV0aG9kIHBhdGNoZWQKKwogMjAxMy0w MS0xOCAgVGVycnkgQW5kZXJzb24gIDx0ZGFuZGVyc29uQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBTY3JvbGwgZ2VzdHVyZXMgc2hvdWxkIG5vdCBjcmVhdGUgd2hlZWwgZXZlbnRzCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9KYXZhU2NyaXB0Q2FsbEZyYW1lLmNwcCBi L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L0phdmFTY3JpcHRDYWxsRnJhbWUuY3BwCmluZGV4 IGUyNDFjOGI3MzBjMWQxZTFhNjA2Yzk5ODQwYjAxMWU3NTEwM2EyMmUuLjMxNTAzNjgxMzE1YjNk YTU4NjUyMmE1YTk0M2Q5YmU3MTI0ZDdlNjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3Y4L0phdmFTY3JpcHRDYWxsRnJhbWUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3Y4L0phdmFTY3JpcHRDYWxsRnJhbWUuY3BwCkBAIC0xMjgsNyArMTI4LDEwIEBAIHY4 OjpIYW5kbGU8djg6OlZhbHVlPiBKYXZhU2NyaXB0Q2FsbEZyYW1lOjpldmFsdWF0ZShjb25zdCBT dHJpbmcmIGV4cHJlc3Npb24pCiB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gSmF2YVNjcmlwdENhbGxG cmFtZTo6cmVzdGFydCgpCiB7CiAgICAgdjg6OkhhbmRsZTx2ODo6RnVuY3Rpb24+IHJlc3RhcnRG dW5jdGlvbiA9IHY4OjpIYW5kbGU8djg6OkZ1bmN0aW9uPjo6Q2FzdChtX2NhbGxGcmFtZS5nZXQo KS0+R2V0KHY4OjpTdHJpbmc6Ok5ld1N5bWJvbCgicmVzdGFydCIpKSk7Ci0gICAgcmV0dXJuIHJl c3RhcnRGdW5jdGlvbi0+Q2FsbChtX2NhbGxGcmFtZS5nZXQoKSwgMCwgMCk7CisgICAgdjg6OkRl YnVnOjpTZXRMaXZlRWRpdEVuYWJsZWQodHJ1ZSk7CisgICAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+ IHJlc3VsdCA9IHJlc3RhcnRGdW5jdGlvbi0+Q2FsbChtX2NhbGxGcmFtZS5nZXQoKSwgMCwgMCk7 CisgICAgdjg6OkRlYnVnOjpTZXRMaXZlRWRpdEVuYWJsZWQoZmFsc2UpOworICAgIHJldHVybiBy ZXN1bHQ7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4SW5pdGlhbGl6ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvdjgvVjhJbml0aWFsaXplci5jcHAKaW5kZXggNzZlOGVkNGE1ZDg2Zjg2OGE5Nzg3NzNj ZWVlZWM2ZWE3ZmE2ZGNiMy4uM2FkYWY4YjVhZmM2NjJjMGRmZDRhNjg1OTUyZWNmMjk4MjZhYWE2 NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhJbml0aWFsaXplci5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhJbml0aWFsaXplci5jcHAKQEAg LTQwLDYgKzQwLDcgQEAKICNpbmNsdWRlICJWOEhpc3RvcnkuaCIKICNpbmNsdWRlICJWOExvY2F0 aW9uLmgiCiAjaW5jbHVkZSAiVjhQZXJDb250ZXh0RGF0YS5oIgorI2luY2x1ZGUgPHY4LWRlYnVn Lmg+CiAjaW5jbHVkZSA8d3RmL1JlZlB0ci5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L1dURlN0cmlu Zy5oPgogCkBAIC0xMDgsNiArMTA5LDggQEAgc3RhdGljIHZvaWQgaW5pdGlhbGl6ZVY4Q29tbW9u KCkKICAgICB2ODo6Vjg6OkFkZEdDUHJvbG9ndWVDYWxsYmFjayhWOEdDQ29udHJvbGxlcjo6Z2NQ cm9sb2d1ZSk7CiAgICAgdjg6OlY4OjpBZGRHQ0VwaWxvZ3VlQ2FsbGJhY2soVjhHQ0NvbnRyb2xs ZXI6OmdjRXBpbG9ndWUpOwogICAgIHY4OjpWODo6SWdub3JlT3V0T2ZNZW1vcnlFeGNlcHRpb24o KTsKKworICAgIHY4OjpEZWJ1Zzo6U2V0TGl2ZUVkaXRFbmFibGVkKGZhbHNlKTsKIH0KIAogdm9p ZCBWOEluaXRpYWxpemVyOjppbml0aWFsaXplTWFpblRocmVhZElmTmVlZGVkKHY4OjpJc29sYXRl KiBpc29sYXRlKQo=