106659 2013-01-11 06:18:48 -0800 [Qt][WK2] plugin tests assert in debug 2013-01-15 03:09:43 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kbalazs kbalazs abecsi cmarcelo menard ossy webkit.review.bot oldest_to_newest 805220 0 kbalazs 2013-01-11 06:18:48 -0800 In PluginProcessProxy::scanPlugin -> ASSERT(lines.size() == 3) 805222 1 182331 kbalazs 2013-01-11 06:26:05 -0800 Created attachment 182331 Patch 805817 2 182331 benjamin 2013-01-11 19:47:17 -0800 Comment on attachment 182331 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182331&action=review > Source/WebKit2/Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:175 > + String result = newLength == oldLength + 1 ? stringBuffer : String(stringBuffer.characters16(), newLength); I think a if() else would read better. I don't really mind either if you keep this. > Source/WebKit2/Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:176 > + ASSERT(result.endsWith(UChar('\n'))); You should not have to cast to UChar here. If you get a warning without the cast, let's fix WTFString instead. > Source/WebKit2/UIProcess/Plugins/qt/PluginProcessProxyQt.cpp:211 > - ASSERT(lines.size() == 3); > + ASSERT(lines.size() == 4 && lines.last().isEmpty()); Looks sane. I trust you on the output. 806213 3 kbalazs 2013-01-14 03:10:05 -0800 Thanks for the quick review! > > > Source/WebKit2/Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:176 > > + ASSERT(result.endsWith(UChar('\n'))); > > You should not have to cast to UChar here. If you get a warning without the cast, let's fix WTFString instead. Hm, I'm not sure about how to do this. Using the UChar version has the implicit assumption that it is a 16 bit string. So, should we allow an LChar version only 8 for bit strings, or both? I would rather postpone this to a follow-up. Landed in http://trac.webkit.org/changeset/139600 182331 2013-01-11 06:26:05 -0800 2013-01-14 03:12:19 -0800 Patch bug-106659-20130111152302.patch text/plain 2913 kbalazs U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5NDM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYmUyMmRkNTMyNWRlZGRj ZDk3NWJkNjMyN2M3NzFlYzYyOGQ2NmFhNi4uOWEzMTk1MzIzZWE4NDZiY2E0ZTMzZjQ2NjFlMmJk ODY3ZTMxODYxZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAxLTExICBCYWxh enMgS2VsZW1lbiAgPGtiYWxhenNAd2Via2l0Lm9yZz4KKworICAgICAgICBbUXRdW1dLMl0gcGx1 Z2luIHRlc3RzIGFzc2VydCBpbiBkZWJ1ZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTA2NjU5CisKKyAgICAgICAgRml4ZWQgdGhlIG1pc3VzZSBvZiBT dHJpbmc6OnNwbGl0LgorCisgICAgICAgICogU2hhcmVkL1BsdWdpbnMvTmV0c2NhcGUveDExL05l dHNjYXBlUGx1Z2luTW9kdWxlWDExLmNwcDoKKyAgICAgICAgKFdlYktpdDo6dHJ1bmNhdGVUb1Np bmdsZUxpbmUpOgorICAgICAgICBBZGQgYW4gYXNzZXJ0IHRvIG1ha2Ugc3VyZSB0aGlzIGZ1bmN0 aW9uIHdvcmtzIHdlbGwuIEkganVzdCB3YWxrZWQgdGhlcmUKKyAgICAgICAgd2hpbGUgZGVidWdn aW5nIHRoZSBidWcsIGFuZCBhbHRob3VnaCBpdCB3YXMgaW5ub2NlbnQsIGFkZGluZyB0aGlzIGFz c2VydGlvbgorICAgICAgICBpcyBsb2dpY2FsLgorICAgICAgICAqIFVJUHJvY2Vzcy9QbHVnaW5z L3F0L1BsdWdpblByb2Nlc3NQcm94eVF0LmNwcDoKKyAgICAgICAgKFdlYktpdDo6UGx1Z2luUHJv Y2Vzc1Byb3h5OjpzY2FuUGx1Z2luKToKKyAgICAgICAgVGhlIEFTU0VSVCB3YXMgd3JvbmcuIFdl IGhhdmUgdGhyZWUgbGluZXMsIGVhY2ggZW5kcyBpbiBhIG5ld2xpbmUsIHNvIHNwbGl0CisgICAg ICAgIHdpdGggYWxsb3dFbXB0eUVudHJpZXM9dHJ1ZSB3aWxsIGRldmlkZSBpdCB0byA0IHN1YnN0 cmluZ3MuCisKIDIwMTMtMDEtMTEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgogCiAgICAgICAgIFtHVEtdIFJlbW92ZSBzdXBwb3J0IGZvciBnbG9iYWwgZXh0ZW5z aW9ucyBpbiBXZWJLaXQyIEdUSysKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9Q bHVnaW5zL05ldHNjYXBlL3gxMS9OZXRzY2FwZVBsdWdpbk1vZHVsZVgxMS5jcHAgYi9Tb3VyY2Uv V2ViS2l0Mi9TaGFyZWQvUGx1Z2lucy9OZXRzY2FwZS94MTEvTmV0c2NhcGVQbHVnaW5Nb2R1bGVY MTEuY3BwCmluZGV4IDYyYjUzZjkwMTg3NzQxY2NlYTBhMmU0NjlmZDIzOGQ1NDFiNGRiODMuLjBm OGIwMmYxMzhmNDkxOWM2OTdkZmVkODlmM2UxZDI5YzRjNDI4OWUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL1NoYXJlZC9QbHVnaW5zL05ldHNjYXBlL3gxMS9OZXRzY2FwZVBsdWdpbk1vZHVs ZVgxMS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL1BsdWdpbnMvTmV0c2NhcGUveDEx L05ldHNjYXBlUGx1Z2luTW9kdWxlWDExLmNwcApAQCAtMTcyLDkgKzE3Miw5IEBAIHN0YXRpYyBT dHJpbmcgdHJ1bmNhdGVUb1NpbmdsZUxpbmUoY29uc3QgU3RyaW5nJiBzdHJpbmcpCiAgICAgfQog ICAgIGJ1ZmZlcltuZXdMZW5ndGgrK10gPSBVQ2hhcignXG4nKTsKIAotICAgIGlmIChuZXdMZW5n dGggPT0gb2xkTGVuZ3RoICsgMSkKLSAgICAgICAgcmV0dXJuIHN0cmluZ0J1ZmZlcjsKLSAgICBy ZXR1cm4gU3RyaW5nKHN0cmluZ0J1ZmZlci5jaGFyYWN0ZXJzMTYoKSwgbmV3TGVuZ3RoKTsKKyAg ICBTdHJpbmcgcmVzdWx0ID0gbmV3TGVuZ3RoID09IG9sZExlbmd0aCArIDEgPyBzdHJpbmdCdWZm ZXIgOiBTdHJpbmcoc3RyaW5nQnVmZmVyLmNoYXJhY3RlcnMxNigpLCBuZXdMZW5ndGgpOworICAg IEFTU0VSVChyZXN1bHQuZW5kc1dpdGgoVUNoYXIoJ1xuJykpKTsKKyAgICByZXR1cm4gcmVzdWx0 OwogfQogCiBib29sIE5ldHNjYXBlUGx1Z2luTW9kdWxlOjpzY2FuUGx1Z2luKGNvbnN0IFN0cmlu ZyYgcGx1Z2luUGF0aCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9QbHVn aW5zL3F0L1BsdWdpblByb2Nlc3NQcm94eVF0LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9QbHVnaW5zL3F0L1BsdWdpblByb2Nlc3NQcm94eVF0LmNwcAppbmRleCA4YjRlMzU5NmZiMjRl YWM1YTk2NDIyMDNkMzZiOGM0OGQ0MDU5ODkyLi5jYjQ4ODRkNGM3ODIyYjE2NjhlNzhjM2ZhODI5 ZDhmNmUyY2Q2MDZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGx1Z2lu cy9xdC9QbHVnaW5Qcm9jZXNzUHJveHlRdC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL1BsdWdpbnMvcXQvUGx1Z2luUHJvY2Vzc1Byb3h5UXQuY3BwCkBAIC0yMDgsNyArMjA4LDcg QEAgYm9vbCBQbHVnaW5Qcm9jZXNzUHJveHk6OnNjYW5QbHVnaW4oY29uc3QgU3RyaW5nJiBwbHVn aW5QYXRoLCBSYXdQbHVnaW5NZXRhRGF0YSYKICAgICAgICAgU3RyaW5nIG91dHB1dChyZWludGVy cHJldF9jYXN0PGNvbnN0IFVDaGFyKj4ob3V0cHV0Qnl0ZXMuY29uc3REYXRhKCkpLCBvdXRwdXRC eXRlcy5zaXplKCkgLyBzaXplb2YoVUNoYXIpKTsKICAgICAgICAgVmVjdG9yPFN0cmluZz4gbGlu ZXM7CiAgICAgICAgIG91dHB1dC5zcGxpdChVQ2hhcignXG4nKSwgdHJ1ZSwgbGluZXMpOwotICAg ICAgICBBU1NFUlQobGluZXMuc2l6ZSgpID09IDMpOworICAgICAgICBBU1NFUlQobGluZXMuc2l6 ZSgpID09IDQgJiYgbGluZXMubGFzdCgpLmlzRW1wdHkoKSk7CiAKICAgICAgICAgcmVzdWx0Lm5h bWUuc3dhcChsaW5lc1swXSk7CiAgICAgICAgIHJlc3VsdC5kZXNjcmlwdGlvbi5zd2FwKGxpbmVz WzFdKTsK