106657 2013-01-11 05:19:23 -0800 [AC] Memory leak in GLXConfigSelector::createConfig() 2013-01-17 10:31:16 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis kenneth noam tonikitoo webkit.review.bot zeno oldest_to_newest 805194 0 naginenis 2013-01-11 05:19:23 -0800 Noticed the following leak in WebCore::GLXConfigSelector::createConfig(). ==15598== 640 bytes in 1 blocks are definitely lost in loss record 5,498 of 5,864 ==15598== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==15598== by 0xCA3E915: XGetVisualInfo (VisUtil.c:78) ==15598== by 0xC7BF2CE: glXGetVisualFromFBConfig (in /usr/lib/x86_64-linux-gnu/mesa/libGL.so.1.2) ==15598== by 0x9DA3A0B: WebCore::GLXConfigSelector::createConfig(int const*) (GLXConfigSelector.h:128) ==15598== by 0x9DA3966: WebCore::GLXConfigSelector::surfaceContextConfig() (GLXConfigSelector.h:98) ==15598== by 0x9DA3297: WebCore::GLXTransportSurface::configuration() (GLXSurface.cpp:71) ==15598== by 0x9DA3132: WebCore::GLXTransportSurface::GLXTransportSurface() (GLXSurface.cpp:49) ==15598== by 0x9DE0255: WebCore::GLPlatformSurface::createTransportSurface() (GLPlatformSurface.cpp:59) ==15598== by 0x9DDB5A0: WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate(WebCore::GraphicsContext3D*, WebCore::HostWindow*, WebCore::GraphicsContext3D::RenderStyle) (GraphicsContext3DPrivate. ==15598== by 0x9DD9520: WebCore::GraphicsContext3D::GraphicsContext3D(WebCore::GraphicsContext3D::Attributes, WebCore::HostWindow*, WebCore::GraphicsContext3D::RenderStyle) (GraphicsContext3DEfl.cpp:66) ==15598== by 0x9DD92CA: WebCore::GraphicsContext3D::create(WebCore::GraphicsContext3D::Attributes, WebCore::HostWindow*, WebCore::GraphicsContext3D::RenderStyle) (GraphicsContext3DEfl.cpp:40) ==15598== by 0x8F0061C: WebCore::WebGLRenderingContext::create(WebCore::HTMLCanvasElement*, WebCore::WebGLContextAttributes*) (WebGLRenderingContext.cpp:430) ==15598== by 0x8E32B71: WebCore::HTMLCanvasElement::getContext(WTF::String const&, WebCore::CanvasContextAttributes*) (HTMLCanvasElement.cpp:202) 805200 1 182326 naginenis 2013-01-11 05:30:57 -0800 Created attachment 182326 Patch 809347 2 182326 laszlo.gombos 2013-01-17 08:21:45 -0800 Comment on attachment 182326 Patch The change looks good to me. This code would read better if we would have a temporary visualInfo variable instead of manipulating the member variable. 809403 3 naginenis 2013-01-17 09:49:07 -0800 (In reply to comment #2) > (From update of attachment 182326 [details]) > The change looks good to me. This code would read better if we would have a temporary visualInfo variable instead of manipulating the member variable. Okay. I will handle this in a separate patch as we discussed on IRC. 809449 4 182326 webkit.review.bot 2013-01-17 10:31:13 -0800 Comment on attachment 182326 Patch Clearing flags on attachment: 182326 Committed r139988: <http://trac.webkit.org/changeset/139988> 809450 5 webkit.review.bot 2013-01-17 10:31:16 -0800 All reviewed patches have been landed. Closing bug. 182326 2013-01-11 05:30:57 -0800 2013-01-17 10:31:13 -0800 Patch 106657.patch text/plain 1450 naginenis ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4NzRiNmIwLi44ZTYyN2U0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTMtMDEtMTEgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBp bnRlbC5jb20+CisKKyAgICAgICAgW0FDXSBNZW1vcnkgbGVhayBpbiBHTFhDb25maWdTZWxlY3Rv cjo6Y3JlYXRlQ29uZmlnKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEwNjY1NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEZyZWUgdGhlIG1lbW9yeSByZXR1cm5lZCBieSBnbFhHZXRWaXN1YWxGcm9tRkJD b25maWcoKSB1c2luZworICAgICAgICBYRnJlZSB0byBhdm9pZCBhIG1lbW9yeSBsZWFrLgorCisg ICAgICAgIE5vIG5ldyB0ZXN0cy4gTm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgICog cGxhdGZvcm0vZ3JhcGhpY3Mvc3VyZmFjZXMvZ2x4L0dMWENvbmZpZ1NlbGVjdG9yLmg6CisgICAg ICAgIChXZWJDb3JlOjpHTFhDb25maWdTZWxlY3Rvcjo6Y3JlYXRlQ29uZmlnKToKKwogMjAxMy0w MS0xMSAgSm9jaGVuIEVpc2luZ2VyICA8am9jaGVuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBD b25uZWN0IFVzZXJHZXN0dXJlSW5kaWNhdG9yIGZvciBtb3VzZWRvd24gYW5kIG1vdXNldXAgZXZl bnRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9zdXJmYWNl cy9nbHgvR0xYQ29uZmlnU2VsZWN0b3IuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL3N1cmZhY2VzL2dseC9HTFhDb25maWdTZWxlY3Rvci5oCmluZGV4IGExYjE0YmUuLjdlMGNm YzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3N1cmZhY2Vz L2dseC9HTFhDb25maWdTZWxlY3Rvci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL3N1cmZhY2VzL2dseC9HTFhDb25maWdTZWxlY3Rvci5oCkBAIC0xMjEsNiArMTIxLDkg QEAgcHJpdmF0ZToKICAgICAgICAgYm9vbCBmb3VuZCA9IGZhbHNlOwogCiAgICAgICAgIGZvciAo aW50IGkgPSAwOyBpIDwgbnVtQXZhaWxhYmxlQ29uZmlnczsgKytpKSB7CisgICAgICAgICAgICBp ZiAobV92aXN1YWxJbmZvKQorICAgICAgICAgICAgICAgIFhGcmVlKG1fdmlzdWFsSW5mbyk7CisK ICAgICAgICAgICAgIG1fdmlzdWFsSW5mbyA9IGdsWEdldFZpc3VhbEZyb21GQkNvbmZpZyhtX3No YXJlZERpc3BsYXksIHRlbXBbaV0pOwogICAgICAgICAgICAgaWYgKCFtX3Zpc3VhbEluZm8pCiAg ICAgICAgICAgICAgICAgY29udGludWU7Cg==