106628 2013-01-10 19:28:49 -0800 Allow users to misspell the "sheriffs" command in sheriffbot 2013-01-14 01:28:05 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 106754 1 alancutter alancutter abarth dpranke eric noel.gordon webkit.review.bot oldest_to_newest 804885 0 alancutter 2013-01-10 19:28:49 -0800 Add aliases for the "sheriffs" command that cover the common misspellings that people make in sheriffbot. Misspellings: sherrifs, sherriffs, sherifs 806067 1 182503 alancutter 2013-01-13 21:26:39 -0800 Created attachment 182503 Patch 806070 2 noel.gordon 2013-01-13 21:29:58 -0800 GTLM :) Eric would say, "We might want to test this, but OK". Let's wait for his OK. 806072 3 noel.gordon 2013-01-13 21:31:49 -0800 Just saw https:bug 106754 806079 4 noel.gordon 2013-01-13 22:04:38 -0800 Ahem, bug 106754 so this LGTM. 806087 5 182503 eric 2013-01-13 22:30:56 -0800 Comment on attachment 182503 Patch This is possibly the best patch I've seen this year. I can't spell sherrrifs to save my life. 806089 6 182503 eric 2013-01-13 22:31:35 -0800 Comment on attachment 182503 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182503&action=review > Tools/Scripts/webkitpy/tool/bot/irc_command.py:299 > +# Enough people misspell "sheriffs" that they've requested aliases for the command. > +commands["sherriffs"] = Sheriffs > +commands["sherifs"] = Sheriffs > +commands["sherrifs"] = Sheriffs This is also just a crutch for a "did you mean" behavior, but that's fine. We'll do that in SB 2.0 :) 806090 7 182503 webkit.review.bot 2013-01-13 22:34:46 -0800 Comment on attachment 182503 Patch Clearing flags on attachment: 182503 Committed r139585: <http://trac.webkit.org/changeset/139585> 806091 8 webkit.review.bot 2013-01-13 22:34:50 -0800 All reviewed patches have been landed. Closing bug. 806157 9 alancutter 2013-01-14 01:28:05 -0800 (In reply to comment #5) > (From update of attachment 182503 [details]) > This is possibly the best patch I've seen this year. I can't spell sherrrifs to save my life. Hahaha. I'm very glad. (: 182503 2013-01-13 21:26:39 -0800 2013-01-13 22:34:46 -0800 Patch bug-106628-20130114162339.patch text/plain 1320 alancutter U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5NTgwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDU0MzYxN2JkNzY2ZjRiNGRhNTk0MjhlMmY4ZjgxOWE3 MzI4NzNiMy4uMzkyNDk0ZTIyNjY4ZTQ4NTZlNmY0MTMyMWYwYmQ0Nzk1YzhhYTNmOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE0 IEBACiAyMDEzLTAxLTEzICBBbGFuIEN1dHRlciAgPGFsYW5jdXR0ZXJAY2hyb21pdW0ub3JnPgog CisgICAgICAgIEFsbG93IHVzZXJzIHRvIG1pc3NwZWxsIHRoZSAic2hlcmlmZnMiIGNvbW1hbmQg aW4gc2hlcmlmZmJvdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTA2NjI4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L2lyY19jb21tYW5kLnB5OgorCisyMDEz LTAxLTEzICBBbGFuIEN1dHRlciAgPGFsYW5jdXR0ZXJAY2hyb21pdW0ub3JnPgorCiAgICAgICAg IE1ha2UgImdhcmRlbmVycyIgYW4gYWxpYXMgZm9yICJzaGVyaWZmcyIgaW4gc2hlcnJpZmJvdAog ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA2NjI3CiAK ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3QvaXJjX2NvbW1hbmQu cHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L2lyY19jb21tYW5kLnB5CmluZGV4 IDNjMmU5ZWM4NzhhMGU5MDFjNDc1YWRlNzI3NTY5ODY1MDk1YjMwODMuLmJjMTMyZGFlNGI5NjRi MjU1NzQ4ZGIyMDA5YWJjY2E2YzJhNjc5MTggMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvdG9vbC9ib3QvaXJjX2NvbW1hbmQucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS90b29sL2JvdC9pcmNfY29tbWFuZC5weQpAQCAtMjkzLDMgKzI5Myw3IEBAIHZpc2libGVfY29t bWFuZHMgPSB7CiBjb21tYW5kcyA9IHZpc2libGVfY29tbWFuZHMuY29weSgpCiBjb21tYW5kc1si cmV2ZXJ0Il0gPSBSb2xsb3V0CiBjb21tYW5kc1siZ2FyZGVuZXJzIl0gPSBTaGVyaWZmcworIyBF bm91Z2ggcGVvcGxlIG1pc3NwZWxsICJzaGVyaWZmcyIgdGhhdCB0aGV5J3ZlIHJlcXVlc3RlZCBh bGlhc2VzIGZvciB0aGUgY29tbWFuZC4KK2NvbW1hbmRzWyJzaGVycmlmZnMiXSA9IFNoZXJpZmZz Citjb21tYW5kc1sic2hlcmlmcyJdID0gU2hlcmlmZnMKK2NvbW1hbmRzWyJzaGVycmlmcyJdID0g U2hlcmlmZnMK