106619 2013-01-10 17:01:18 -0800 Plugin snapshot label should take device resolution and inset into account 2013-01-10 18:02:50 -0800 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino eric jonlee ojan.autocc simon.fraser webkit.review.bot oldest_to_newest 804825 0 dino 2013-01-10 17:01:18 -0800 The label image we draw for snapshotted plugins needs to be aware of device resolution. It also needs to take the inset of the image into account (say it has a drop shadow). 804826 1 dino 2013-01-10 17:02:03 -0800 <rdar://problem/12878149> 804829 2 182227 dino 2013-01-10 17:05:03 -0800 Created attachment 182227 Patch 804831 3 webkit.review.bot 2013-01-10 17:08:14 -0800 Attachment 182227 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp:184: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp:185: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp:186: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 804838 4 182227 simon.fraser 2013-01-10 17:37:40 -0800 Comment on attachment 182227 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182227&action=review > Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp:46 > +static const int startLabelInset = 20; // But the label is inset from its box also. FIXME: This will be removed when we go to a ShadowDOM approach. That type of comment isn't very future-proof! 804851 5 dino 2013-01-10 18:02:50 -0800 Committed r139392: <http://trac.webkit.org/changeset/139392> 182227 2013-01-10 17:05:03 -0800 2013-01-10 17:37:40 -0800 Patch bug-106619-20130111120206.patch text/plain 3657 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5MDY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGY4NDgwMWI0NjEyYWRk NGYwMTg1NTFmNGRhNjEzNGQ2MDJjYjA4ZC4uYTU1ZTgyN2E0OWNjZjk5Y2MwZjkyM2ZlOWMwYTFl NDZhMjE5ZjYzMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTAxLTEwICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBQbHVnaW4gc25hcHNob3QgbGFi ZWwgc2hvdWxkIHRha2UgZGV2aWNlIHJlc29sdXRpb24gYW5kIGluc2V0IGludG8gYWNjb3VudAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA2NjE5CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiByZW5kZXJp bmcvUmVuZGVyU25hcHNob3R0ZWRQbHVnSW4uY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVy U25hcHNob3R0ZWRQbHVnSW46OnBhaW50TGFiZWwpOiBUYWtlIGludG8gYWNjb3VudCB0aGUgaW5z ZXQgaW4gdGhlIGxhYmVsIGltYWdlLgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyU25hcHNob3R0 ZWRQbHVnSW46OnRyeVRvRml0U3RhcnRMYWJlbCk6IExvb2sgYXQgdGhlIHBhZ2UncyBkZXZpY2Ug c2NhbGUsIGFuZCBhZGp1c3QgdGhlIGxhYmVsIGltYWdlIGFjY29yZGluZ2x5LgorCiAyMDEzLTAx LTA4ICBIYWppbWUgTW9ycml0YSAgPG1vcnJpdGFAZ29vZ2xlLmNvbT4KIAogICAgICAgICBbU2hh ZG93IERPTV0gUmVmYWN0b3Jpbmc6IGludmFsaWRhdGVQYXJlbnREaXN0cmlidXRpb25JZk5lY2Vz c2FyeSgpIGNhbGxzIGFyZSB0b28gaW50cnVzaXZlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyU25hcHNob3R0ZWRQbHVnSW4uY3BwIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclNuYXBzaG90dGVkUGx1Z0luLmNwcAppbmRleCAyYjA1MDcwZWNhMDgz MTQzZDQzNjkzODJiNjQzZGM5YmIwMDk4NjY3Li5mNjI4MGJiNjg5MDZkNjI1MWY0OTQyNGQ1OTEz YzQ0NTMzNTZmNjBiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy U25hcHNob3R0ZWRQbHVnSW4uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJTbmFwc2hvdHRlZFBsdWdJbi5jcHAKQEAgLTQyLDcgKzQyLDggQEAgbmFtZXNwYWNlIFdlYkNv cmUgewogCiBzdGF0aWMgY29uc3QgaW50IGF1dG9TdGFydFBsdWdJblNpemVUaHJlc2hvbGRXaWR0 aCA9IDE7CiBzdGF0aWMgY29uc3QgaW50IGF1dG9TdGFydFBsdWdJblNpemVUaHJlc2hvbGRIZWln aHQgPSAxOwotc3RhdGljIGNvbnN0IGludCBzdGFydExhYmVsUGFkZGluZyA9IDA7CitzdGF0aWMg Y29uc3QgaW50IHN0YXJ0TGFiZWxQYWRkaW5nID0gMTA7IC8vIExhYmVsIHNob3VsZCBiZSAxMHB4 IGZyb20gZWRnZSBvZiBib3guCitzdGF0aWMgY29uc3QgaW50IHN0YXJ0TGFiZWxJbnNldCA9IDIw OyAvLyBCdXQgdGhlIGxhYmVsIGlzIGluc2V0IGZyb20gaXRzIGJveCBhbHNvLiBGSVhNRTogVGhp cyB3aWxsIGJlIHJlbW92ZWQgd2hlbiB3ZSBnbyB0byBhIFNoYWRvd0RPTSBhcHByb2FjaC4KIHN0 YXRpYyBjb25zdCBkb3VibGUgc2hvd0xhYmVsQWZ0ZXJNb3VzZU92ZXJEZWxheSA9IDE7CiBzdGF0 aWMgY29uc3QgZG91YmxlIHNob3dMYWJlbEF1dG9tYXRpY2FsbHlEZWxheSA9IDM7CiAKQEAgLTE3 OCw3ICsxNzksMTEgQEAgdm9pZCBSZW5kZXJTbmFwc2hvdHRlZFBsdWdJbjo6cGFpbnRMYWJlbChQ YWludEluZm8mIHBhaW50SW5mbywgY29uc3QgTGF5b3V0UG9pbnQKICAgICBpZiAoIWxhYmVsSW1h Z2UpCiAgICAgICAgIHJldHVybjsKIAotICAgIHBhaW50SW5mby5jb250ZXh0LT5kcmF3SW1hZ2Uo bGFiZWxJbWFnZSwgQ29sb3JTcGFjZURldmljZVJHQiwgcm91bmRlZEludFBvaW50KHBhaW50T2Zm c2V0ICsgbGFiZWxSZWN0LmxvY2F0aW9uKCkpLCBsYWJlbEltYWdlLT5yZWN0KCkpOworICAgIC8v IFJlbWVtYmVyIHRoYXQgdGhlIGxhYmVsUmVjdCBpbmNsdWRlcyB0aGUgbGFiZWwgaW5zZXQsIHNv IHdlIG5lZWQgdG8gYWRqdXN0IGZvciBpdC4KKyAgICBwYWludEluZm8uY29udGV4dC0+ZHJhd0lt YWdlKGxhYmVsSW1hZ2UsIENvbG9yU3BhY2VEZXZpY2VSR0IsCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBJbnRSZWN0KHJvdW5kZWRJbnRQb2ludChwYWludE9mZnNldCArIGxhYmVs UmVjdC5sb2NhdGlvbigpIC0gSW50U2l6ZShzdGFydExhYmVsSW5zZXQsIHN0YXJ0TGFiZWxJbnNl dCkpLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICByb3VuZGVkSW50 U2l6ZShsYWJlbFJlY3Quc2l6ZSgpICsgSW50U2l6ZSgyICogc3RhcnRMYWJlbEluc2V0LCAyICog c3RhcnRMYWJlbEluc2V0KSkpLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbGFi ZWxJbWFnZS0+cmVjdCgpKTsKIH0KIAogdm9pZCBSZW5kZXJTbmFwc2hvdHRlZFBsdWdJbjo6cmVw YWludExhYmVsKCkKQEAgLTI1OSw3ICsyNjQsMTQgQEAgTGF5b3V0UmVjdCBSZW5kZXJTbmFwc2hv dHRlZFBsdWdJbjo6dHJ5VG9GaXRTdGFydExhYmVsKExhYmVsU2l6ZSBzaXplLCBjb25zdCBMYXkK ICAgICBpZiAoIWxhYmVsSW1hZ2UpCiAgICAgICAgIHJldHVybiBMYXlvdXRSZWN0KCk7CiAKLSAg ICBMYXlvdXRTaXplIGxhYmVsU2l6ZSA9IGxhYmVsSW1hZ2UtPnNpemUoKTsKKyAgICAvLyBBc3N1 bWUgdGhhdCB0aGUgbGFiZWxJbWFnZSBoYXMgYmVlbiBwcm92aWRlZCB0byBtYXRjaCBvdXIgZGV2 aWNlIHNjYWxlLgorICAgIGZsb2F0IHNjYWxlRmFjdG9yID0gMTsKKyAgICBpZiAoZG9jdW1lbnQo KS0+cGFnZSgpKQorICAgICAgICBzY2FsZUZhY3RvciA9IGRvY3VtZW50KCktPnBhZ2UoKS0+ZGV2 aWNlU2NhbGVGYWN0b3IoKTsKKyAgICBJbnRTaXplIGxhYmVsSW1hZ2VTaXplID0gbGFiZWxJbWFn ZS0+c2l6ZSgpOworICAgIGxhYmVsSW1hZ2VTaXplLnNjYWxlKDEgLyAoc2NhbGVGYWN0b3IgPyBz Y2FsZUZhY3RvciA6IDEpKTsKKworICAgIExheW91dFNpemUgbGFiZWxTaXplID0gbGFiZWxJbWFn ZVNpemUgLSBMYXlvdXRTaXplKDIgKiBzdGFydExhYmVsSW5zZXQsIDIgKiBzdGFydExhYmVsSW5z ZXQpOwogICAgIExheW91dFJlY3QgY2FuZGlkYXRlUmVjdChjb250ZW50Qm94Lm1heFhNaW5ZQ29y bmVyKCkgKyBMYXlvdXRTaXplKC1zdGFydExhYmVsUGFkZGluZywgc3RhcnRMYWJlbFBhZGRpbmcp ICsgTGF5b3V0U2l6ZSgtbGFiZWxTaXplLndpZHRoKCksIDApLCBsYWJlbFNpemUpOwogICAgIC8v IFRoZSBtaW5pbXVtIGFsbG93ZWQgY29udGVudCBib3ggc2l6ZSBpcyB0aGUgbGFiZWwgaW1hZ2Ug cGxhY2VkIGluIHRoZSBjZW50ZXIgb2YgdGhlIGJveCwgc3Vycm91bmRlZCBieSBzdGFydExhYmVs UGFkZGluZy4KICAgICBpZiAoY2FuZGlkYXRlUmVjdC54KCkgPCBzdGFydExhYmVsUGFkZGluZyB8 fCBjYW5kaWRhdGVSZWN0Lm1heFkoKSA+IGNvbnRlbnRCb3guaGVpZ2h0KCkgLSBzdGFydExhYmVs UGFkZGluZykK