106604 2013-01-10 14:25:14 -0800 [chromium] Don't regenerate all bindings when any idl file changes 2013-01-11 14:09:59 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tony tony abarth haraken webkit.review.bot oldest_to_newest 804723 0 tony 2013-01-10 14:25:14 -0800 [chromium] Don't regenerate all bindings when any idl file changes 804738 1 182212 tony 2013-01-10 14:36:12 -0800 Created attachment 182212 Patch 804746 2 tony 2013-01-10 14:42:33 -0800 What do you two think of this approach? This is similar to https://bugs.webkit.org/show_bug.cgi?id=89125 but as Haraken mentions, most build systems can't generate dependencies while they are running like make can (evan says that ninja can't do this). This isn't quite as sophisticated (we still regenerate all the bindings sometimes), but not nearly as often. I'm not sure how to do this with qmake or cmake, although Maciej's patch could be applied to the GTK+ build since it uses make. 805023 3 182212 haraken 2013-01-11 00:20:06 -0800 Comment on attachment 182212 Patch I think this is a good approach to practically solving the all-idl-files-rebuild problem. Thanks for the great patch! 805604 4 182212 webkit.review.bot 2013-01-11 14:09:56 -0800 Comment on attachment 182212 Patch Clearing flags on attachment: 182212 Committed r139494: <http://trac.webkit.org/changeset/139494> 805605 5 webkit.review.bot 2013-01-11 14:09:59 -0800 All reviewed patches have been landed. Closing bug. 182212 2013-01-10 14:36:12 -0800 2013-01-11 14:09:56 -0800 Patch bug-106604-20130110143314.patch text/plain 6903 tony U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5MzQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzZiNjM3OTZkNjBiNTg2 YmYzMTQyMzgyZDlkNjkyMjBlNjhkMTZkYy4uMjdhMmQzOTY4YTI5ZDJhYWI5NzY1M2Q4NDAzYmM3 NTdkN2Y4NjVlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMzIEBACisyMDEzLTAxLTEwICBUb255 IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBEb24ndCBy ZWdlbmVyYXRlIGFsbCBiaW5kaW5ncyB3aGVuIGFueSBpZGwgZmlsZSBjaGFuZ2VzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDY2MDQKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDdXJyZW50bHksIGV2ZXJ5 IGlkbCBmaWxlIGlzIGEgZGVwZW5kZW5jeSBvZiBnZW5lcmF0aW5nIHRoZSBzdXBwbGVtZW50YWwg ZGVwZW5kZW5jeSBtYXAKKyAgICAgICAgYW5kIGdlbmVyYXRpbmcgYmluZGluZ3MgaXMgYSBkZXBl bmRlbmN5IG9mIHRoZSBtYXAuIFRoaXMgbWVhbnMgdGhhdCB0b3VjaGluZyBhbnkgaWRsIGZpbGUK KyAgICAgICAgY2F1c2VzIHVzIHRvIHJlZ2VuZXJhdGUgYWxsIHRoZSBiaW5kaW5ncy4KKworICAg ICAgICBDaGFuZ2UgaXQgc28gdGhhdCBnZW5lcmF0aW5nIGJpbmRpbmdzIG9ubHkgZGVwZW5kcyBv biB0aGUgaWRsIGZpbGVzIHRoYXQgaGF2ZSBTdXBwbGVtZW50YWw9IGluIHRoZW0uCisgICAgICAg IFdlIG9ubHkgaGF2ZSAyNCBpZGwgZmlsZXMgd2l0aCBTdXBwbGVtZW50YWwgKDMuNyUgb2YgdGhl IDYzOCBpZGwgZmlsZXMgaW4gV2ViQ29yZSkgc28gbW9kaWZ5aW5nCisgICAgICAgIGFueSBvZiB0 aG9zZSB3aWxsIGNhdXNlIGFsbCBiaW5kaW5ncyB0byBiZSByZWdlbmVyYXRlZC4KKworICAgICAg ICBJZiB5b3UgYWRkIG9yIHJlbW92ZSBhIG5ldyBpZGwgZmlsZSwgeW91IGhhdmUgdG8gcmVydW4g Z3lwIHdoaWNoIHdpbGwgZml4IHVwIGFueSBkZXBlbmRlbmNpZXMuCisgICAgICAgIElmIHlvdSBl ZGl0IGFuIGV4aXN0aW5nIGZpbGUgYW5kIGFkZCBTdXBwbGVtZW50YWw9IHRvIGl0LCB5b3Ugd2ls bCBub3cgbmVlZCB0byByZXJ1biBneXBfe3dlYmtpdCxjaHJvbWl1bX0uCisgICAgICAgIEkgdGhp bmsgdGhhdCdzIGEgcmVhc29uYWJsZSB0cmFkZW9mZiBzaW5jZSBpdCBzZWVtcyBoaWdobHkgdW5s aWtlbHkgdGhhdCB5b3Ugd291bGQgYWRkaW5nIFN1cHBsZW1lbnRhbD0KKyAgICAgICAgdG8gYW4g ZXhpc3RpbmcgZmlsZSB3aXRob3V0IHJlbmFtaW5nIGl0LiBUaGUgYm90cyB3aWxsIGFsd2F5cyBi ZSBmaW5lIGJlY2F1c2UgdGhleSBhbHdheXMgcnVuCisgICAgICAgIGd5cCBhZnRlciB1cGRhdGlu Zy4KKworICAgICAgICBObyBuZXcgdGVzdHMsIHRoaXMgaXMgYSBidWlsZCBvbmx5IGNoYW5nZS4K KworICAgICAgICAqIFdlYkNvcmUuZ3lwL1dlYkNvcmUuZ3lwOiBSZW1vdmUgPChTSEFSRURfSU5U RVJNRURJQVRFX0RJUikvc3VwcGxlbWVudGFsX2RlcGVuZGVuY3kudG1wLCB3aGljaCB3YXMgY2F1 c2luZworICAgICAgICB0aGUgZnVsbCByZWJ1aWxkLiBUaGUgc3RlcCB0byBnZW5lcmF0ZSB0aGlz IGZpbGUgaXMgc3RpbGwgYSBoYXJkIGRlcGVuZGVuY3kgc28gaXQgd2lsbCBzdGlsbCBiZSBnZW5l cmF0ZWQgYW5kCisgICAgICAgIHVzZWQgYnkgZ2VuZXJhdGUtYmluZGluZ3MucGwuIEFsc28gcmVt b3ZlIDxAKHdlYmNvcmVfdGVzdF9zdXBwb3J0X2lkbF9maWxlcykuIFRoaXMgd2FzIHNheWluZyB3 ZSBzaG91bGQgcmVnZW5lcmF0ZQorICAgICAgICBhbGwgYmluZGluZ3MgaWYgYSB0ZXN0IGlkbCBm aWxlIGNoYW5nZWQuIFRoYXQgZG9lc24ndCBtYWtlIHNlbnNlLgorICAgICAgICAqIFdlYkNvcmUu Z3lwL3NjcmlwdHMvc3VwcGxlbWVudGFsX2lkbF9maWxlcy5weTogQWRkZWQuCisgICAgICAgIChE b01haW4pOgorCiAyMDEzLTAxLTEwICBMZXZpIFdlaW50cmF1YiAgPGxldml3QGNocm9taXVtLm9y Zz4KIAogICAgICAgICBTY3JvbGxpbmdDb29yZGluYXRvciB0b3VjaCBldmVudCBoaXQgcmVjdHMg YXJlbid0IGNvbnZlcnRlZCB0byBwcm9wZXIgY29vcmRpbmF0ZXMgd2hlbiBpbiBuZXN0ZWQgdmll d3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNl L1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggMDUyYmI5N2EyNzA0ZGNmZDczNzNiZmJh NjQ3NmNkZWMwNDg3MjIzMy4uN2E5MDFkNzNhY2Q5YzE5MWJiNTFkMjk1ODQxNjQ1YTAyODhmYmQy MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMy0wMS0x MCAgVG9ueSBDaGFuZyAgPHRvbnlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0g RG9uJ3QgcmVnZW5lcmF0ZSBhbGwgYmluZGluZ3Mgd2hlbiBhbnkgaWRsIGZpbGUgY2hhbmdlcwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA2NjA0CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBneXBfd2Vi a2l0OiBBZGQgU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXAvc2NyaXB0cyB0byB0aGUgcHl0aG9u IGltcG9ydCBzZWFyY2ggcGF0aAorICAgICAgICBzbyB3ZSBjYW4gZ2VuZXJhdGUgaWRsIGRlcGVu ZGVuY2llcyBhdCBneXAgdGltZS4KKwogMjAxMy0wMS0xMCAgU2hlcmlmZiBCb3QgIDx3ZWJraXQu cmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gIFJvbGxlZCBERVBT LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXAvV2ViQ29yZS5neXAgYi9T b3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5cAppbmRleCBkNzllNGIyMzUxNGIw ZTNiY2Y5MDVlMjM0ZWU4NzA2NWNmZjVhOWViLi4zYTM3ODU1MTFjNzJjMjM1ZDZlMGZhYTMzZjZk NTBjNTI3YjhlYTBhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJD b3JlLmd5cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5cApAQCAt MTE2NSw4ICsxMTY1LDcgQEAKICAgICAgICAgICAgICcuLi9iaW5kaW5ncy9zY3JpcHRzL0lETFBh cnNlci5wbScsCiAgICAgICAgICAgICAnLi4vYmluZGluZ3Mvc2NyaXB0cy9JRExBdHRyaWJ1dGVz LnR4dCcsCiAgICAgICAgICAgICAnLi4vYmluZGluZ3Mvc2NyaXB0cy9wcmVwcm9jZXNzb3IucG0n LAotICAgICAgICAgICAgJzwoU0hBUkVEX0lOVEVSTUVESUFURV9ESVIpL3N1cHBsZW1lbnRhbF9k ZXBlbmRlbmN5LnRtcCcsCi0gICAgICAgICAgICAnPEAod2ViY29yZV90ZXN0X3N1cHBvcnRfaWRs X2ZpbGVzKScsCisgICAgICAgICAgICAnPCFAcHltb2RfZG9fbWFpbihzdXBwbGVtZW50YWxfaWRs X2ZpbGVzIDxAKGJpbmRpbmdzX2lkbF9maWxlcykpJywKICAgICAgICAgICBdLAogICAgICAgICAg ICdvdXRwdXRzJzogWwogICAgICAgICAgICAgIyBGSVhNRTogIFRoZSAuY3BwIGZpbGUgc2hvdWxk IGJlIGluIHdlYmtpdC9iaW5kaW5ncyBvbmNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9X ZWJDb3JlLmd5cC9zY3JpcHRzL3N1cHBsZW1lbnRhbF9pZGxfZmlsZXMucHkgYi9Tb3VyY2UvV2Vi Q29yZS9XZWJDb3JlLmd5cC9zY3JpcHRzL3N1cHBsZW1lbnRhbF9pZGxfZmlsZXMucHkKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMC4uNWY0NDk4ZjI1NTYzZjZiNjU0YzA5OWY4NzRlNWI3OGRkMWJhYzQ5NAotLS0gL2Rldi9u dWxsCisrKyBiL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZ3lwL3NjcmlwdHMvc3VwcGxlbWVudGFs X2lkbF9maWxlcy5weQpAQCAtMCwwICsxLDQ3IEBACisjIS91c3IvYmluL3B5dGhvbgorIworIyBD b3B5cmlnaHQgKEMpIDIwMTMgR29vZ2xlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyMKKyMg UmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBv ciB3aXRob3V0CisjIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRo ZSBmb2xsb3dpbmcgY29uZGl0aW9ucyBhcmUKKyMgbWV0OgorIworIyAgICAgKiBSZWRpc3RyaWJ1 dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAorIyBu b3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWlt ZXIuCisjICAgICAqIFJlZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVj ZSB0aGUgYWJvdmUKKyMgY29weXJpZ2h0IG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMg YW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lcgorIyBpbiB0aGUgZG9jdW1lbnRhdGlvbiBhbmQv b3Igb3RoZXIgbWF0ZXJpYWxzIHByb3ZpZGVkIHdpdGggdGhlCisjIGRpc3RyaWJ1dGlvbi4KKyMg ICAgICogTmVpdGhlciB0aGUgbmFtZSBvZiBHb29nbGUgSW5jLiBub3IgdGhlIG5hbWVzIG9mIGl0 cworIyBjb250cmlidXRvcnMgbWF5IGJlIHVzZWQgdG8gZW5kb3JzZSBvciBwcm9tb3RlIHByb2R1 Y3RzIGRlcml2ZWQgZnJvbQorIyB0aGlzIHNvZnR3YXJlIHdpdGhvdXQgc3BlY2lmaWMgcHJpb3Ig d3JpdHRlbiBwZXJtaXNzaW9uLgorIworIyBUSElTIFNPRlRXQVJFIElTIFBST1ZJREVEIEJZIFRI RSBDT1BZUklHSFQgSE9MREVSUyBBTkQgQ09OVFJJQlVUT1JTCisjICJBUyBJUyIgQU5EIEFOWSBF WFBSRVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UCisjIExJTUlU RUQgVE8sIFRIRSBJTVBMSUVEIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRO RVNTIEZPUgorIyBBIFBBUlRJQ1VMQVIgUFVSUE9TRSBBUkUgRElTQ0xBSU1FRC4gSU4gTk8gRVZF TlQgU0hBTEwgVEhFIENPUFlSSUdIVAorIyBPV05FUiBPUiBDT05UUklCVVRPUlMgQkUgTElBQkxF IEZPUiBBTlkgRElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwKKyMgU1BFQ0lBTCwgRVhFTVBM QVJZLCBPUiBDT05TRVFVRU5USUFMIERBTUFHRVMgKElOQ0xVRElORywgQlVUIE5PVAorIyBMSU1J VEVEIFRPLCBQUk9DVVJFTUVOVCBPRiBTVUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOyBMT1NT IE9GIFVTRSwKKyMgREFUQSwgT1IgUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBI T1dFVkVSIENBVVNFRCBBTkQgT04gQU5ZCisjIFRIRU9SWSBPRiBMSUFCSUxJVFksIFdIRVRIRVIg SU4gQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQKKyMgKElOQ0xVRElORyBORUdM SUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFCisj IE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0Yg U1VDSCBEQU1BR0UuCisKKyIiIlRoaXMgZmlsZSByZXR1cm5zIGEgbGlzdCBvZiBhbGwgdGhlIGZp bGVzIHRoYXQgaGF2ZSB0aGUKK1N1cHBsZW1lbnRhbCBhdHRyaWJ1dGUuIiIiCisKK2ltcG9ydCBy ZQoraW1wb3J0IHN5cworCitzdXBwbGVtZW50YWxfcmVnZXggPSByZS5jb21waWxlKHInXFsuK1N1 cHBsZW1lbnRhbD0oXHcrKS4rXF0nLCByZS5NIHwgcmUuUykKKworCitkZWYgRG9NYWluKGZpbGVu YW1lcyk6CisgICAgc3VwcGxlbWVudGFsX2ZpbGVzID0gc2V0KCkKKyAgICBmb3IgZmlsZW5hbWUg aW4gZmlsZW5hbWVzOgorICAgICAgICB3aXRoIG9wZW4oZmlsZW5hbWUpIGFzIGY6CisgICAgICAg ICAgICBtYXRjaCA9IHJlLnNlYXJjaChzdXBwbGVtZW50YWxfcmVnZXgsIGYucmVhZCgpKQorICAg ICAgICAgICAgaWYgbWF0Y2g6CisgICAgICAgICAgICAgICAgc3VwcGxlbWVudGFsX2ZpbGVzLmFk ZChmaWxlbmFtZSkKKyAgICByZXR1cm4gJ1xuJy5qb2luKHN1cHBsZW1lbnRhbF9maWxlcykKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vZ3lwX3dlYmtpdCBiL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vZ3lwX3dlYmtpdAppbmRleCA1MWVjOGQ0YWYyMzVhODIwOGNlMWRiYTVkNzYy MmI1OGEwYjNjZTRmLi5iNzgxZDhjODljYzkxNjIzZjNhZDdkZjA4MzRhZWFiODVmM2E4NzJiIDEw MDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL2d5cF93ZWJraXQKKysrIGIvU291cmNl L1dlYktpdC9jaHJvbWl1bS9neXBfd2Via2l0CkBAIC00Miw4ICs0MiwxMCBAQCBjaHJvbWVfc3Jj ID0gb3MucGF0aC5hYnNwYXRoKHNjcmlwdF9kaXIpCiBzeXMucGF0aC5pbnNlcnQoMCwgb3MucGF0 aC5qb2luKGNocm9tZV9zcmMsICd0b29scycsICdneXAnLCAncHlsaWInKSkKIGltcG9ydCBneXAK IAotIyBBZGQgdG9vbHMvZ3JpdCBzbyB0aGF0IHB5bW9kX2RvX21haW4oZ3JpdF9pbmZvIC4uLikg Y2FuIGZpbmQgZ3JpdF9pbmZvLnB5LgorIyBBZGQgcGF0aHMgc28gdGhhdCBweW1vZF9kb19tYWlu KC4uLikgY2FuIGltcG9ydCBmaWxlcy4KIHN5cy5wYXRoLmluc2VydCgxLCBvcy5wYXRoLmpvaW4o Y2hyb21lX3NyYywgJ3Rvb2xzJywgJ2dyaXQnKSkKK3N5cy5wYXRoLmluc2VydCgxLCBvcy5wYXRo LmpvaW4oY2hyb21lX3NyYywgJy4uJywgJy4uJywgJ1dlYkNvcmUnLAorICAnV2ViQ29yZS5neXAn LCAnc2NyaXB0cycpKQogCiBkZWYgYWRkaXRpb25hbF9pbmNsdWRlX2ZpbGVzKGFyZ3M9W10pOgog ICAiIiIK