106587 2013-01-10 11:44:13 -0800 HTMLMediaElement::resume() should schedule a load rather than load immediately 2013-01-10 14:33:18 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yong.li.webkit webkit-unassigned eric.carlson feature-media-reviews ojan.autocc webkit.review.bot oldest_to_newest 804592 0 yong.li.webkit 2013-01-10 11:44:13 -0800 Generally, those resume() methods should only schedule the resumed jobs by timers. This is because: 1) It is not always safe to start the jobs at the time resume() is called. That is why the jobs are suspended. For example, when ActiveDOMObjects are suspended for nested event loop, the sequence is like this: - The stack is on top of document parsing, javascript execution, so it is not safe to run some jobs in the nested event loop. - suspend all scheduled jobs so they won't run in the event loop - run the nested event loop - resume (re-schedule those jobs). However, it is still not safe at this point to run those jobs! ... - Stack unwinds back to main event loop .... - Timers fire and scheduled jobs get done. Another case is PageCache. ActiveDOMObjects are suspended while a document is in the page cache. When it is being restored, resume() is called upon every ActiveDOMObject. However I don't think the page is guaranteed ready at this point to start the resumed jobs immediately. 2) It is also good for performance, as the objects may be suspended again after being resumed. 804613 1 182186 yong.li.webkit 2013-01-10 12:00:37 -0800 Created attachment 182186 the proposed patch 804617 2 yong.li.webkit 2013-01-10 12:03:22 -0800 +Eric Carlson Does the patch make sense? 804623 3 182186 eric.carlson 2013-01-10 12:10:24 -0800 Comment on attachment 182186 the proposed patch This change looks good, but please wait until the bots have had a chance to exercise the change. 804624 4 yong.li.webkit 2013-01-10 12:10:43 -0800 (In reply to comment #3) > (From update of attachment 182186 [details]) > This change looks good, but please wait until the bots have had a chance to exercise the change. Sure. thanks! 804735 5 182186 webkit.review.bot 2013-01-10 14:33:14 -0800 Comment on attachment 182186 the proposed patch Clearing flags on attachment: 182186 Committed r139371: <http://trac.webkit.org/changeset/139371> 804736 6 webkit.review.bot 2013-01-10 14:33:18 -0800 All reviewed patches have been landed. Closing bug. 182186 2013-01-10 12:00:37 -0800 2013-01-10 14:33:14 -0800 the proposed patch 106587.diff text/plain 1779 yong.li.webkit ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzNmI2Mzc5Li5jM2JiMzEzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTMtMDEtMTAgIFlvbmcgTGkgIDx5b2xpQHJpbS5jb20+CisKKyAgICAgICAgSFRNTE1l ZGlhRWxlbWVudDo6cmVzdW1lKCkgc2hvdWxkIHNjaGVkdWxlIGEgbG9hZCByYXRoZXIgdGhhbiBs b2FkIGltbWVkaWF0ZWx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMDY1ODcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBJdCBpcyBub3QgYWx3YXlzIHNhZmUgdG8gc3RhcnQgdGhlIGpvYnMgYXQgdGhlIHRp bWUgcmVzdW1lKCkgaXMgY2FsbGVkLiBUaGF0IGlzIHdoeSB0aGUgam9icyBhcmUKKyAgICAgICAg c3VzcGVuZGVkLiBJdCBjYW4gYWxzbyBiZSBzdXNwZW5kZWQgYWdhaW4gcmlnaHQgYWZ0ZXIgYmVp bmcgcmVzdW1lZC4KKworICAgICAgICBObyBuZXcgdGVzdHMgYXMgdGhlcmUgaXMgbm8gdmlzaWJs ZSBmdW5jdGlvbmFsIGNoYW5nZSwgYWxzbyBpdCBpcyBhIHRoZW9yZXRpY2FsbHkgZ29vZC10by1o YXZlIGNoYW5nZQorICAgICAgICB0aGF0IGRvZXNuJ3QgZml4IGFueSBrbm93biBjcm9zcy1wbGF0 Zm9ybSBpc3N1ZS4KKworICAgICAgICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50OjpyZXN1bWUpOiBSZXBsYWNlIGxvYWQoKSB3 aXRoIHNjaGVkdWxlTG9hZCgpLgorCiAyMDEzLTAxLTEwICBMZXZpIFdlaW50cmF1YiAgPGxldml3 QGNocm9taXVtLm9yZz4KIAogICAgICAgICBTY3JvbGxpbmdDb29yZGluYXRvciB0b3VjaCBldmVu dCBoaXQgcmVjdHMgYXJlbid0IGNvbnZlcnRlZCB0byBwcm9wZXIgY29vcmRpbmF0ZXMgd2hlbiBp biBuZXN0ZWQgdmlld3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlh RWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCmlu ZGV4IDdhY2E3OWQuLmQ2YjYxNDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TE1lZGlhRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVt ZW50LmNwcApAQCAtMzg2Nyw3ICszODY3LDggQEAgdm9pZCBIVE1MTWVkaWFFbGVtZW50OjpyZXN1 bWUoKQogICAgICAgICAvLyBtX2Vycm9yIGlzIG9ubHkgbGVmdCBhdCBNRURJQV9FUlJfQUJPUlRF RCB3aGVuIHRoZSBkb2N1bWVudCBiZWNvbWVzIGluYWN0aXZlIChpdCBpcyBzZXQgdG8KICAgICAg ICAgLy8gIE1FRElBX0VSUl9BQk9SVEVEIHdoaWxlIHRoZSBhYm9ydEV2ZW50IGlzIGJlaW5nIHNl bnQsIGJ1dCBjbGVhcmVkIGltbWVkaWF0ZWx5IGFmdGVyd2FyZHMpLgogICAgICAgICAvLyBUaGlz IGJlaGF2aW9yIGlzIG5vdCBzcGVjaWZpZWQgYnV0IGl0IHNlZW1zIGxpa2UgYSBzZW5zaWJsZSB0 aGluZyB0byBkby4KLSAgICAgICAgbG9hZCgpOworICAgICAgICAvLyBBcyBpdCBpcyBub3Qgc2Fm ZSB0byBpbW1lZGF0ZWx5IHN0YXJ0IGxvYWRpbmcgbm93LCBsZXQncyBzY2hlZHVsZSBhIGxvYWQu CisgICAgICAgIHNjaGVkdWxlTG9hZChNZWRpYVJlc291cmNlKTsKICAgICB9CiAKICAgICBpZiAo cmVuZGVyZXIoKSkK