106559 2013-01-10 06:26:04 -0800 Serialization of Gradients fails when PlatformContextSkia is not bitmap backed 2013-01-10 08:50:05 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Other All RESOLVED FIXED P2 Normal --- 0 robertphillips webkit-unassigned dglazkov fmalita junov peter+ews robertphillips senorblanco webkit.review.bot oldest_to_newest 804319 0 robertphillips 2013-01-10 06:26:04 -0800 Chromium possesses the ability to serialize web pages when using the Skia backend. During serialization PlatformContextSkia is not bitmap backed. The prior code improperly digs into the Skia device object to determine the appropriate bitmap format. Since the Skia device is not bitmap backed it returns a kNo_Config flag. This causes a cascade of problems resulting in gradients not being serialized. 804329 1 182127 robertphillips 2013-01-10 06:44:17 -0800 Created attachment 182127 Patch 804331 2 182127 senorblanco 2013-01-10 06:46:18 -0800 Comment on attachment 182127 Patch Looks good, bots willing. r=me 804335 3 182127 webkit.review.bot 2013-01-10 06:53:36 -0800 Comment on attachment 182127 Patch Attachment 182127 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15758987 804345 4 182127 peter+ews 2013-01-10 07:06:46 -0800 Comment on attachment 182127 Patch Attachment 182127 did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/15766847 804377 5 182138 robertphillips 2013-01-10 07:56:49 -0800 Created attachment 182138 Patch 804379 6 robertphillips 2013-01-10 07:57:48 -0800 Made a dumb mistake copying the change from my Windows Chromium tree to my Mac Webkit tree. 804411 7 182138 senorblanco 2013-01-10 08:44:41 -0800 Comment on attachment 182138 Patch OK. r=me 804414 8 182138 webkit.review.bot 2013-01-10 08:50:02 -0800 Comment on attachment 182138 Patch Clearing flags on attachment: 182138 Committed r139322: <http://trac.webkit.org/changeset/139322> 804415 9 webkit.review.bot 2013-01-10 08:50:05 -0800 All reviewed patches have been landed. Closing bug. 182127 2013-01-10 06:44:17 -0800 2013-01-10 07:56:45 -0800 Patch bug-106559-20130110094120.patch text/plain 1838 robertphillips SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzOTMxNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAxLTEwICBSb2JlcnQg UGhpbGxpcHMgIDxyb2JlcnRwaGlsbGlwc0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgU2VyaWFs aXphdGlvbiBvZiBHcmFkaWVudHMgZmFpbHMgd2hlbiBQbGF0Zm9ybUNvbnRleHRTa2lhIGlzIG5v dCBiaXRtYXAgYmFja2VkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMDY1NTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUaGlzIHBhdGNoIHN3aXRjaGVzIG92ZXIgZnJvbSBoYXZpbmcgcGxhdGZvcm0vU2tp YSBpbXByb3Blcmx5CisgICAgICAgIGNyYWNrIG9wZW4gdGhlIGRldmljZSB0byBmaW5kIHRoZSBi aXRtYXAgY29uZmlndXJhdGlvbiB0byBqdXN0CisgICAgICAgIHNwZWNpZnlpbmcgaXQgZGlyZWN0 bHkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBUaGlzIGJ1ZyBpcyBDaHJvbWl1bSBzcGVjaWZp YyBhbmQgb25seSBvY2N1cnMgaW4gYQorICAgICAgICBkZWJ1Z2dpbmcgdG9vbCAod2hlbiBzZXJp YWxpemluZyB0byBhIFNraWEtc3BlY2lmaWMgZmlsZSBmb3JtYXQpLgorCisgICAgICAgICogcGxh dGZvcm0vZ3JhcGhpY3Mvc2tpYS9QbGF0Zm9ybUNvbnRleHRTa2lhLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlBsYXRmb3JtQ29udGV4dFNraWE6OmNyZWF0ZUNvbXBhdGlibGVEZXZpY2UpOgorCiAy MDEzLTAxLTEwICBBbGV4aXMgTWVuYXJkICA8YWxleGlzQHdlYmtpdC5vcmc+CiAKICAgICAgICAg QVNTRVJUX05PVF9SRUFDSEVEIGluIFN0eWxlUHJvcGVydHlTZXQ6OmZvbnRWYWx1ZSB3aGVuIGFj Y2Vzc2luZyBmb250IHN0eWxlIHByb3BlcnR5IHRocm91Z2ggSlMgYWZ0ZXIgc2V0dGluZyBzdHls ZSBmb250IHNpemUuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lh L1BsYXRmb3JtQ29udGV4dFNraWEuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3NraWEvUGxhdGZvcm1Db250ZXh0U2tpYS5jcHAJKHJldmlzaW9uIDEz OTMxMSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvUGxhdGZvcm1D b250ZXh0U2tpYS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIyNCw3ICsyMjQsNyBAQCB2b2lkIFBs YXRmb3JtQ29udGV4dFNraWE6OnNldERyYXdpbmdUb0ltCiAKIFNrRGV2aWNlKiBQbGF0Zm9ybUNv bnRleHRTa2lhOjpjcmVhdGVDb21wYXRpYmxlRGV2aWNlKGNvbnN0IEludFNpemUmIHNpemUsIGJv b2wgaGFzQWxwaGEpCiB7Ci0gICAgcmV0dXJuIG1fY2FudmFzLT5jcmVhdGVDb21wYXRpYmxlRGV2 aWNlKGJpdG1hcCgpLT5jb25maWcoKSwgc2l6ZS53aWR0aCgpLCBzaXplLmhlaWdodCgpLCAhaGFz QWxwaGEpOworICAgIHJldHVybiBtX2NhbnZhcy0+Y3JlYXRlQ29tcGF0aWJsZURldmljZShTa0Jp dG1hcDo6QVJHQl84ODg4X0NvbmZpZywgc2l6ZS53aWR0aCgpLCBzaXplLmhlaWdodCgpLCAhaGFz QWxwaGEpOwogfQogCiBib29sIFBsYXRmb3JtQ29udGV4dFNraWE6OmlzRHJhd2luZ1RvSW1hZ2VC dWZmZXIoKSBjb25zdAo= 182138 2013-01-10 07:56:49 -0800 2013-01-10 08:50:01 -0800 Patch bug-106559-20130110105352.patch text/plain 1839 robertphillips SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzOTMxNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAxLTEwICBSb2JlcnQg UGhpbGxpcHMgIDxyb2JlcnRwaGlsbGlwc0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgU2VyaWFs aXphdGlvbiBvZiBHcmFkaWVudHMgZmFpbHMgd2hlbiBQbGF0Zm9ybUNvbnRleHRTa2lhIGlzIG5v dCBiaXRtYXAgYmFja2VkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMDY1NTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUaGlzIHBhdGNoIHN3aXRjaGVzIG92ZXIgZnJvbSBoYXZpbmcgcGxhdGZvcm0vU2tp YSBpbXByb3Blcmx5CisgICAgICAgIGNyYWNrIG9wZW4gdGhlIGRldmljZSB0byBmaW5kIHRoZSBi aXRtYXAgY29uZmlndXJhdGlvbiB0byBqdXN0CisgICAgICAgIHNwZWNpZnlpbmcgaXQgZGlyZWN0 bHkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBUaGlzIGJ1ZyBpcyBDaHJvbWl1bSBzcGVjaWZp YyBhbmQgb25seSBvY2N1cnMgaW4gYQorICAgICAgICBkZWJ1Z2dpbmcgdG9vbCAod2hlbiBzZXJp YWxpemluZyB0byBhIFNraWEtc3BlY2lmaWMgZmlsZSBmb3JtYXQpLgorCisgICAgICAgICogcGxh dGZvcm0vZ3JhcGhpY3Mvc2tpYS9QbGF0Zm9ybUNvbnRleHRTa2lhLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlBsYXRmb3JtQ29udGV4dFNraWE6OmNyZWF0ZUNvbXBhdGlibGVEZXZpY2UpOgorCiAy MDEzLTAxLTEwICBBbGV4aXMgTWVuYXJkICA8YWxleGlzQHdlYmtpdC5vcmc+CiAKICAgICAgICAg QVNTRVJUX05PVF9SRUFDSEVEIGluIFN0eWxlUHJvcGVydHlTZXQ6OmZvbnRWYWx1ZSB3aGVuIGFj Y2Vzc2luZyBmb250IHN0eWxlIHByb3BlcnR5IHRocm91Z2ggSlMgYWZ0ZXIgc2V0dGluZyBzdHls ZSBmb250IHNpemUuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lh L1BsYXRmb3JtQ29udGV4dFNraWEuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3NraWEvUGxhdGZvcm1Db250ZXh0U2tpYS5jcHAJKHJldmlzaW9uIDEz OTMxMSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvUGxhdGZvcm1D b250ZXh0U2tpYS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIyNCw3ICsyMjQsNyBAQCB2b2lkIFBs YXRmb3JtQ29udGV4dFNraWE6OnNldERyYXdpbmdUb0ltCiAKIFNrRGV2aWNlKiBQbGF0Zm9ybUNv bnRleHRTa2lhOjpjcmVhdGVDb21wYXRpYmxlRGV2aWNlKGNvbnN0IEludFNpemUmIHNpemUsIGJv b2wgaGFzQWxwaGEpCiB7Ci0gICAgcmV0dXJuIG1fY2FudmFzLT5jcmVhdGVDb21wYXRpYmxlRGV2 aWNlKGJpdG1hcCgpLT5jb25maWcoKSwgc2l6ZS53aWR0aCgpLCBzaXplLmhlaWdodCgpLCAhaGFz QWxwaGEpOworICAgIHJldHVybiBtX2NhbnZhcy0+Y3JlYXRlQ29tcGF0aWJsZURldmljZShTa0Jp dG1hcDo6a0FSR0JfODg4OF9Db25maWcsIHNpemUud2lkdGgoKSwgc2l6ZS5oZWlnaHQoKSwgIWhh c0FscGhhKTsKIH0KIAogYm9vbCBQbGF0Zm9ybUNvbnRleHRTa2lhOjppc0RyYXdpbmdUb0ltYWdl QnVmZmVyKCkgY29uc3QK