106537 2013-01-10 01:00:15 -0800 [Qt][EFL] Rename from xxxContentsScale() to xxxScale() in PageViewportController. 2013-01-10 15:37:21 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 106499 1 dongseong.hwang dongseong.hwang abecsi benjamin cmarcelo kenneth menard webkit.review.bot oldest_to_newest 804142 0 dongseong.hwang 2013-01-10 01:00:15 -0800 Rename 3 methods to match the terms of ViewportAttributes. 804146 1 182083 dongseong.hwang 2013-01-10 01:02:01 -0800 Created attachment 182083 Patch 804535 2 182083 abecsi 2013-01-10 10:50:24 -0800 Comment on attachment 182083 Patch LGTM. 804788 3 182083 webkit.review.bot 2013-01-10 15:37:17 -0800 Comment on attachment 182083 Patch Clearing flags on attachment: 182083 Committed r139380: <http://trac.webkit.org/changeset/139380> 804789 4 webkit.review.bot 2013-01-10 15:37:21 -0800 All reviewed patches have been landed. Closing bug. 182083 2013-01-10 01:02:01 -0800 2013-01-10 15:37:17 -0800 Patch bug-106537-20130110175843.patch text/plain 4588 dongseong.hwang U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5MjkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZWUyNjQ3Y2UxZmQ4NTM2 ODhkY2NjY2M0NWZkOGRmYWE1ZmZkM2I0MC4uNzYzZjY2YWU0NWNlZWUzYjkzOWRlMzI2NDA2M2U2 YjE1M2E0NTMxOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTAxLTEwICBIdWFu ZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0PgorCisgICAgICAgIFtRdF1bRUZM XSBSZW5hbWUgZnJvbSB4eHhDb250ZW50c1NjYWxlKCkgdG8geHh4U2NhbGUoKSBpbiBQYWdlVmll d3BvcnRDb250cm9sbGVyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTA2NTM3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgUmVuYW1lIDMgbWV0aG9kcyB0byBtYXRjaCB0aGUgdGVybXMgb2YgVmlld3BvcnRB dHRyaWJ1dGVzLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC9xd2Via2l0dGVzdC5jcHA6 CisgICAgICAgIChRV2ViS2l0VGVzdDo6dmlld3BvcnQpOgorICAgICAgICAoUVdlYktpdFRlc3Q6 OmNvbnRlbnRzU2NhbGUpOgorICAgICAgICAqIFVJUHJvY2Vzcy9QYWdlVmlld3BvcnRDb250cm9s bGVyLmg6CisgICAgICAgIChXZWJLaXQ6OlBhZ2VWaWV3cG9ydENvbnRyb2xsZXI6Om1pbmltdW1T Y2FsZSk6CisgICAgICAgIChXZWJLaXQ6OlBhZ2VWaWV3cG9ydENvbnRyb2xsZXI6Om1heGltdW1T Y2FsZSk6CisgICAgICAgIChXZWJLaXQ6OlBhZ2VWaWV3cG9ydENvbnRyb2xsZXI6OmN1cnJlbnRT Y2FsZSk6CisgICAgICAgICogVUlQcm9jZXNzL3F0L1BhZ2VWaWV3cG9ydENvbnRyb2xsZXJDbGll bnRRdC5jcHA6CisgICAgICAgIChXZWJLaXQ6OlBhZ2VWaWV3cG9ydENvbnRyb2xsZXJDbGllbnRR dDo6em9vbVRvQXJlYUdlc3R1cmVFbmRlZCk6CisKIDIwMTMtMDEtMDkgIEh1YW5nIERvbmdzdW5n ICA8bHV4dGVsbGFAY29tcGFueTEwMC5uZXQ+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMTM5MTg5 KTogcGl4ZWwgYWxpZ25tZW50IG11c3QgYmUgcGVyZm9ybWVkIGluIGRldmljZSB1bml0cy4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXdlYmtpdHRlc3QuY3Bw IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xd2Via2l0dGVzdC5jcHAKaW5kZXgg NmEyNTA4YzM0OGIzZWM4YWNlYWFlNmJhZTk0NGJlZGNhZGQ2ZTA0My4uMjBjZmEzODhkZWMyMjUy YTQ2ZGYyZDU0ZmU0MWIwN2YwNWE2N2JmNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9xdC9xd2Via2l0dGVzdC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9xdC9xd2Via2l0dGVzdC5jcHAKQEAgLTE1MSw4ICsxNTEsOCBAQCBRSnNvbk9iamVj dCBRV2ViS2l0VGVzdDo6dmlld3BvcnQoKSBjb25zdAogICAgIGlmIChjb25zdCBQYWdlVmlld3Bv cnRDb250cm9sbGVyKiBjb25zdCB2aWV3cG9ydEhhbmRsZXIgPSBtX3dlYlZpZXdQcml2YXRlLT52 aWV3cG9ydENvbnRyb2xsZXIoKSkgewogICAgICAgICB2aWV3cG9ydERhdGEuaW5zZXJ0KFFMYXRp bjFTdHJpbmcoImxheW91dFNpemUiKSwgdG9Kc29uT2JqZWN0KHZpZXdwb3J0SGFuZGxlci0+Y29u dGVudHNMYXlvdXRTaXplKCkpKTsKICAgICAgICAgdmlld3BvcnREYXRhLmluc2VydChRTGF0aW4x U3RyaW5nKCJpc1NjYWxhYmxlIiksIHZpZXdwb3J0SGFuZGxlci0+YWxsb3dzVXNlclNjYWxpbmco KSk7Ci0gICAgICAgIHZpZXdwb3J0RGF0YS5pbnNlcnQoUUxhdGluMVN0cmluZygibWluaW11bVNj YWxlIiksIHZpZXdwb3J0SGFuZGxlci0+bWluaW11bUNvbnRlbnRzU2NhbGUoKSk7Ci0gICAgICAg IHZpZXdwb3J0RGF0YS5pbnNlcnQoUUxhdGluMVN0cmluZygibWF4aW11bVNjYWxlIiksIHZpZXdw b3J0SGFuZGxlci0+bWF4aW11bUNvbnRlbnRzU2NhbGUoKSk7CisgICAgICAgIHZpZXdwb3J0RGF0 YS5pbnNlcnQoUUxhdGluMVN0cmluZygibWluaW11bVNjYWxlIiksIHZpZXdwb3J0SGFuZGxlci0+ bWluaW11bVNjYWxlKCkpOworICAgICAgICB2aWV3cG9ydERhdGEuaW5zZXJ0KFFMYXRpbjFTdHJp bmcoIm1heGltdW1TY2FsZSIpLCB2aWV3cG9ydEhhbmRsZXItPm1heGltdW1TY2FsZSgpKTsKICAg ICB9IGVsc2UgewogICAgICAgICB2aWV3cG9ydERhdGEuaW5zZXJ0KFFMYXRpbjFTdHJpbmcoImlu aXRpYWxTY2FsZSIpLCAxLjApOwogICAgICAgICB2aWV3cG9ydERhdGEuaW5zZXJ0KFFMYXRpbjFT dHJpbmcoImxheW91dFNpemUiKSwgdG9Kc29uT2JqZWN0KFFTaXplRigpKSk7CkBAIC0xNzMsNiAr MTczLDYgQEAgUVZhcmlhbnQgUVdlYktpdFRlc3Q6OmRldmljZVBpeGVsUmF0aW8oKSBjb25zdAog UVZhcmlhbnQgUVdlYktpdFRlc3Q6OmNvbnRlbnRzU2NhbGUoKSBjb25zdAogewogICAgIGlmIChj b25zdCBQYWdlVmlld3BvcnRDb250cm9sbGVyKiBjb25zdCB2aWV3cG9ydCA9IG1fd2ViVmlld1By aXZhdGUtPnZpZXdwb3J0Q29udHJvbGxlcigpKQotICAgICAgICByZXR1cm4gdmlld3BvcnQtPmN1 cnJlbnRDb250ZW50c1NjYWxlKCk7CisgICAgICAgIHJldHVybiB2aWV3cG9ydC0+Y3VycmVudFNj YWxlKCk7CiAgICAgcmV0dXJuIDEuMDsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9QYWdlVmlld3BvcnRDb250cm9sbGVyLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvUGFnZVZpZXdwb3J0Q29udHJvbGxlci5oCmluZGV4IDJiNTk2MThlZjc3ZDgxMmUyM2M2ZmIx YWE2NDZmNGFmYmFiYWMxNDQuLjM1ZDRiNTMzZDIwNzAyZWIyOWEyYzIyZDczNDI5MGJkMjRiYmQ2 MDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9QYWdlVmlld3BvcnRDb250 cm9sbGVyLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1BhZ2VWaWV3cG9ydENvbnRy b2xsZXIuaApAQCAtNjYsOSArNjYsOSBAQCBwdWJsaWM6CiAKICAgICBXZWJDb3JlOjpGbG9hdFNp emUgY29udGVudHNMYXlvdXRTaXplKCkgY29uc3QgeyByZXR1cm4gbV9yYXdBdHRyaWJ1dGVzLmxh eW91dFNpemU7IH0KICAgICBmbG9hdCBkZXZpY2VTY2FsZUZhY3RvcigpIGNvbnN0OwotICAgIGZs b2F0IG1pbmltdW1Db250ZW50c1NjYWxlKCkgY29uc3QgeyByZXR1cm4gbV9taW5pbXVtU2NhbGVU b0ZpdDsgfQotICAgIGZsb2F0IG1heGltdW1Db250ZW50c1NjYWxlKCkgY29uc3QgeyByZXR1cm4g bV9yYXdBdHRyaWJ1dGVzLm1heGltdW1TY2FsZTsgfQotICAgIGZsb2F0IGN1cnJlbnRDb250ZW50 c1NjYWxlKCkgY29uc3QgeyByZXR1cm4gbV9wYWdlU2NhbGVGYWN0b3I7IH0KKyAgICBmbG9hdCBt aW5pbXVtU2NhbGUoKSBjb25zdCB7IHJldHVybiBtX21pbmltdW1TY2FsZVRvRml0OyB9CisgICAg ZmxvYXQgbWF4aW11bVNjYWxlKCkgY29uc3QgeyByZXR1cm4gbV9yYXdBdHRyaWJ1dGVzLm1heGlt dW1TY2FsZTsgfQorICAgIGZsb2F0IGN1cnJlbnRTY2FsZSgpIGNvbnN0IHsgcmV0dXJuIG1fcGFn ZVNjYWxlRmFjdG9yOyB9CiAKICAgICB2b2lkIHNldEhhZFVzZXJJbnRlcmFjdGlvbihib29sIGRp ZFVzZXJJbnRlcmFjdCkgeyBtX2hhZFVzZXJJbnRlcmFjdGlvbiA9IGRpZFVzZXJJbnRlcmFjdDsg fQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUGFnZVZpZXdwb3J0 Q29udHJvbGxlckNsaWVudFF0LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9QYWdl Vmlld3BvcnRDb250cm9sbGVyQ2xpZW50UXQuY3BwCmluZGV4IGY4NTc4ODJjNmRkOWI3ODg4YWUy MjkwYzY5ZTc1Njc2ZWJhMzNlM2YuLmNiNWM3NDNmNjQyNWFjODQwODBjODc5MWFmZDgwZDAwMmEy NTIxYzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9QYWdlVmlld3Bv cnRDb250cm9sbGVyQ2xpZW50UXQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9x dC9QYWdlVmlld3BvcnRDb250cm9sbGVyQ2xpZW50UXQuY3BwCkBAIC0yNjgsNyArMjY4LDcgQEAg dm9pZCBQYWdlVmlld3BvcnRDb250cm9sbGVyQ2xpZW50UXQ6Onpvb21Ub0FyZWFHZXN0dXJlRW5k ZWQoY29uc3QgUVBvaW50RiYgdG91Y2gKICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBab29tQmFj azogewogICAgICAgICBpZiAobV9zY2FsZVN0YWNrLmlzRW1wdHkoKSkgewotICAgICAgICAgICAg dGFyZ2V0U2NhbGUgPSBtX2NvbnRyb2xsZXItPm1pbmltdW1Db250ZW50c1NjYWxlKCk7CisgICAg ICAgICAgICB0YXJnZXRTY2FsZSA9IG1fY29udHJvbGxlci0+bWluaW11bVNjYWxlKCk7CiAgICAg ICAgICAgICBlbmRQb3NpdGlvbi5zZXRZKGhvdHNwb3QueSgpIC0gdmlld3BvcnRIb3RzcG90Lnko KSAvIHRhcmdldFNjYWxlKTsKICAgICAgICAgICAgIGVuZFBvc2l0aW9uLnNldFgoMCk7CiAgICAg ICAgICAgICBtX3pvb21PdXRTY2FsZSA9IDA7Cg==