106518 2013-01-09 18:55:39 -0800 [chromium] Store scrollable layer's contents size for coordinated scrollable layers 2013-01-10 16:08:40 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jamesr jamesr andersca dglazkov enne tonikitoo vollick wangxianzhu webkit.review.bot oldest_to_newest 803936 0 jamesr 2013-01-09 18:55:39 -0800 [chromium] Store scrollable layer's contents size for coordinated scrollable layers 803937 1 182044 jamesr 2013-01-09 18:59:30 -0800 Created attachment 182044 Patch 803983 2 182044 webkit.review.bot 2013-01-09 19:46:18 -0800 Comment on attachment 182044 Patch Attachment 182044 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15766657 New failing tests: platform/chromium/virtual/softwarecompositing/iframes/iframe-content-flipping.html compositing/iframes/iframe-content-flipping.html 804043 3 jamesr 2013-01-09 21:49:02 -0800 (In reply to comment #2) > (From update of attachment 182044 [details]) > Attachment 182044 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/15766657 > > New failing tests: > platform/chromium/virtual/softwarecompositing/iframes/iframe-content-flipping.html > compositing/iframes/iframe-content-flipping.html I think the property set is causing a different number of frames to be painted, so this test (since it's a repaint test) has different levels of grey. This test is marked as failing on lion / molo referencing https://bugs.webkit.org/show_bug.cgi?id=81145. Will confirm on linux tomorrow. 804790 4 jamesr 2013-01-10 15:38:01 -0800 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 182044 [details] [details]) > > Attachment 182044 [details] [details] did not pass chromium-ews (chromium-xvfb): > > Output: http://queues.webkit.org/results/15766657 > > > > New failing tests: > > platform/chromium/virtual/softwarecompositing/iframes/iframe-content-flipping.html > > compositing/iframes/iframe-content-flipping.html > > I think the property set is causing a different number of frames to be painted, so this test (since it's a repaint test) has different levels of grey. This test is marked as failing on lion / molo referencing https://bugs.webkit.org/show_bug.cgi?id=81145. Will confirm on linux tomorrow. That's exactly it. I think this is due mostly to testRunner.display() forcing us into the composite path synchronously, I doubt this has any impact on real users. I'll mark these as needing rebase when landing. 804797 5 182044 enne 2013-01-10 15:50:03 -0800 Comment on attachment 182044 Patch R=me. Thanks for investigating the test failures. 804805 6 jamesr 2013-01-10 16:08:40 -0800 Committed r139385: <http://trac.webkit.org/changeset/139385> 182044 2013-01-09 18:59:30 -0800 2013-01-10 15:50:03 -0800 Patch bug-106518-20130109185633.patch text/plain 2190 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5MTEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGJiM2NjYzI4Y2E0Nzg1 OWI5NDA0MjhjYjgyNmFlZWMwZjAxMWE1NC4uMTE0MmU5YzJkNGYyOWJkYWUyZDJkYzZkZThkMzcw NzY2Yzc4MGQ1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAxLTA5ICBKYW1l cyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBT dG9yZSBzY3JvbGxhYmxlIGxheWVyJ3MgY29udGVudHMgc2l6ZSBmb3IgY29vcmRpbmF0ZWQgc2Ny b2xsYWJsZSBsYXllcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEwNjUxOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRoaXMgc3RvcmVzIGEgc2Nyb2xsYWJsZSBsYXllcidzIGNvbnRlbnRzU2l6ZSBpbiB0 aGUgc2Nyb2xsIGxheWVyJ3MgYm91bmRzLCB3aGljaCBpcyBvdGhlcndpc2Ugbm90IHVzZWZ1bC4g VGhpcworICAgICAgICB2YWx1ZSBpcyBjdXJyZW50bHkgY2FsY3VsYXRlZCBiYXNlZCBvbiBmcmFn aWxlIGtub3dsZWRnZSBvZiB0aGUgdHJlZSBzdHJ1Y3R1cmUgaW1tZWRpYXRlbHkgYmVuZWF0aCBh IHNjcm9sbGFibGUKKyAgICAgICAgbGF5ZXIuCisKKyAgICAgICAgKiBwYWdlL3Njcm9sbGluZy9j aHJvbWl1bS9TY3JvbGxpbmdDb29yZGluYXRvckNocm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlNjcm9sbGluZ0Nvb3JkaW5hdG9yQ2hyb21pdW06OmZyYW1lVmlld0xheW91dFVwZGF0ZWQp OgorCiAyMDEzLTAxLTA4ICBUb20gU2VwZXogIDx0c2VwZXpAY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIENvcHktcGFzdGUgcHJlc2VydmVzIDxlbWJlZD4gdGFncyBjb250YWluaW5nIGFjdGl2ZSBj b250ZW50LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvY2hyb21p dW0vU2Nyb2xsaW5nQ29vcmRpbmF0b3JDaHJvbWl1bS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdl L3Njcm9sbGluZy9jaHJvbWl1bS9TY3JvbGxpbmdDb29yZGluYXRvckNocm9taXVtLmNwcAppbmRl eCBiNDNhOTA2OGE4NTA1ZDc4ZGYwZjI1NzVmYzU5NWZhZDIwNzZjMTg5Li5hNzQxZjhkMDdkYTk2 ODU3NzQ5MGFhYWI4MWU5Yzc4ODJjOWIwMDRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w YWdlL3Njcm9sbGluZy9jaHJvbWl1bS9TY3JvbGxpbmdDb29yZGluYXRvckNocm9taXVtLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9jaHJvbWl1bS9TY3JvbGxpbmdDb29y ZGluYXRvckNocm9taXVtLmNwcApAQCAtMTA2LDcgKzEwNiw3IEBAIFNjcm9sbGluZ0Nvb3JkaW5h dG9yQ2hyb21pdW06On5TY3JvbGxpbmdDb29yZGluYXRvckNocm9taXVtKCkKICAgICBkZWxldGUg bV9wcml2YXRlOwogfQogCi12b2lkIFNjcm9sbGluZ0Nvb3JkaW5hdG9yQ2hyb21pdW06OmZyYW1l Vmlld0xheW91dFVwZGF0ZWQoRnJhbWVWaWV3KikKK3ZvaWQgU2Nyb2xsaW5nQ29vcmRpbmF0b3JD aHJvbWl1bTo6ZnJhbWVWaWV3TGF5b3V0VXBkYXRlZChGcmFtZVZpZXcqIGZyYW1lVmlldykKIHsK ICAgICBBU1NFUlQobV9wYWdlKTsKIApAQCAtMTIxLDYgKzEyMSw4IEBAIHZvaWQgU2Nyb2xsaW5n Q29vcmRpbmF0b3JDaHJvbWl1bTo6ZnJhbWVWaWV3TGF5b3V0VXBkYXRlZChGcmFtZVZpZXcqKQog ICAgIGNvbXB1dGVBYnNvbHV0ZVRvdWNoRXZlbnRUYXJnZXRSZWN0cyhtX3BhZ2UtPm1haW5GcmFt ZSgpLT5kb2N1bWVudCgpLCB0b3VjaEV2ZW50VGFyZ2V0UmVjdHMpOwogICAgIHNldFRvdWNoRXZl bnRUYXJnZXRSZWN0cyh0b3VjaEV2ZW50VGFyZ2V0UmVjdHMpOwogI2VuZGlmCisgICAgaWYgKG1f cHJpdmF0ZS0+c2Nyb2xsTGF5ZXIoKSkKKyAgICAgICAgbV9wcml2YXRlLT5zY3JvbGxMYXllcigp LT5zZXRCb3VuZHMoZnJhbWVWaWV3LT5jb250ZW50c1NpemUoKSk7CiB9CiAKIHZvaWQgU2Nyb2xs aW5nQ29vcmRpbmF0b3JDaHJvbWl1bTo6dG91Y2hFdmVudFRhcmdldFJlY3RzRGlkQ2hhbmdlKGNv bnN0IERvY3VtZW50KiBkb2N1bWVudCkK