106504 2013-01-09 16:53:17 -0800 REGRESSION(r139189): pixel alignment must be performed in device units. 2013-01-10 02:01:13 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 106355 106499 1 dongseong.hwang dongseong.hwang abecsi kenneth webkit.review.bot oldest_to_newest 803836 0 dongseong.hwang 2013-01-09 16:53:17 -0800 After r139189, pixel alignment is performed in UI units. If deviceScaleFactor is fractional number, adjusted scroll position can blur non-composited layer. 803841 1 182016 dongseong.hwang 2013-01-09 16:59:19 -0800 Created attachment 182016 Patch 803952 2 182016 kenneth 2013-01-09 19:14:25 -0800 Comment on attachment 182016 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182016&action=review > Source/WebKit2/UIProcess/PageViewportController.cpp:98 > + float contentsScale = m_pageScaleFactor * deviceScaleFactor(); lets call this effectiveScale 804135 3 182082 dongseong.hwang 2013-01-10 00:52:55 -0800 Created attachment 182082 Patch 804182 4 182082 webkit.review.bot 2013-01-10 02:01:09 -0800 Comment on attachment 182082 Patch Clearing flags on attachment: 182082 Committed r139300: <http://trac.webkit.org/changeset/139300> 804183 5 webkit.review.bot 2013-01-10 02:01:13 -0800 All reviewed patches have been landed. Closing bug. 182016 2013-01-09 16:59:19 -0800 2013-01-10 00:53:08 -0800 Patch bug-106504-20130110095601.patch text/plain 2349 dongseong.hwang U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5MjQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggY2FkYTIxM2I2ZTMzMjJh M2UxNDcxYjIwNDQ1MTVkMGY1Y2UxMzEyOC4uZWI2MTQyZjRiYWExNGE5M2VjYWJiMGMyMmRmYzJh MTk1ZjU5N2ZlZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDEzLTAxLTA5ICBIdWFu ZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0PgogCisgICAgICAgIFJFR1JFU1NJ T04ocjEzOTE4OSk6IHBpeGVsIGFsaWdubWVudCBtdXN0IGJlIHBlcmZvcm1lZCBpbiBkZXZpY2Ug dW5pdHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MDY1MDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB ZnRlciByMTM5MTg5LCBwaXhlbCBhbGlnbm1lbnQgaXMgcGVyZm9ybWVkIGluIFVJIHVuaXRzLiBJ ZiBkZXZpY2VTY2FsZUZhY3RvciBpcworICAgICAgICBmcmFjdGlvbmFsIG51bWJlciwgYWRqdXN0 ZWQgc2Nyb2xsIHBvc2l0aW9uIGNhbiBibHVyIG5vbi1jb21wb3NpdGVkIGxheWVyLgorCisgICAg ICAgICogVUlQcm9jZXNzL1BhZ2VWaWV3cG9ydENvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV2Vi S2l0OjpQYWdlVmlld3BvcnRDb250cm9sbGVyOjpwaXhlbEFsaWduZWRGbG9hdFBvaW50KToKKwor MjAxMy0wMS0wOSAgSHVhbmcgRG9uZ3N1bmcgIDxsdXh0ZWxsYUBjb21wYW55MTAwLm5ldD4KKwog ICAgICAgICBSZW1vdmUgZGV2aWNlU2NhbGVGYWN0b3IgYXJndW1lbnQgaW4gY29tcHV0ZU1pbmlt dW1TY2FsZUZhY3RvckZvckNvbnRlbnRDb250YWluZWQoKS4KICAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNjUwMAogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvUGFnZVZpZXdwb3J0Q29udHJvbGxlci5jcHAgYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvUGFnZVZpZXdwb3J0Q29udHJvbGxlci5jcHAKaW5kZXggZTlmMTA4OTc0 ODNhOTA2MGMzYjJmYTQwYzM5ZjgzYTQyZjNkOGE3MS4uOGVlMmU3ZmMwYjc3NTY0YTljZDY2ODIz NzQxZDc3YmQ2ZmE5YTYyOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1Bh Z2VWaWV3cG9ydENvbnRyb2xsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Q YWdlVmlld3BvcnRDb250cm9sbGVyLmNwcApAQCAtOTUsMTggKzk1LDE5IEBAIHN0YXRpYyBpbmxp bmUgYm9vbCBpc0ludGVncmFsKGZsb2F0IHZhbHVlKQogRmxvYXRQb2ludCBQYWdlVmlld3BvcnRD b250cm9sbGVyOjpwaXhlbEFsaWduZWRGbG9hdFBvaW50KGNvbnN0IEZsb2F0UG9pbnQmIGZyYW1l UG9zaXRpb24pCiB7CiAjaWYgUExBVEZPUk0oRUZMKQotICAgIGlmICghaXNJbnRlZ3JhbChtX3Bh Z2VTY2FsZUZhY3RvcikpIHsKKyAgICBmbG9hdCBjb250ZW50c1NjYWxlID0gbV9wYWdlU2NhbGVG YWN0b3IgKiBkZXZpY2VTY2FsZUZhY3RvcigpOworICAgIGlmICghaXNJbnRlZ3JhbChjb250ZW50 c1NjYWxlKSkgewogICAgICAgICAvLyBUbyBhdm9pZCBibHVycnluZXNzLCBtb2RpZnkgdGhlIHBv c2l0aW9uIHNvIHRoYXQgaXQgbWFwcyBpbnRvIGEgZGlzY3JldGUgZGV2aWNlIHBvc2l0aW9uLgog ICAgICAgICBGbG9hdFBvaW50IHNjYWxlZFBvcyhmcmFtZVBvc2l0aW9uKTsKIAogICAgICAgICAv LyBTY2FsZSBieSB0aGUgZWZmZWN0aXZlIHNjYWxlIGZhY3RvciB0byBjb21wdXRlIHRoZSBzY3Jl ZW4tcmVsYXRpdmUgcG9zaXRpb24uCi0gICAgICAgIHNjYWxlZFBvcy5zY2FsZShtX3BhZ2VTY2Fs ZUZhY3RvciwgbV9wYWdlU2NhbGVGYWN0b3IpOworICAgICAgICBzY2FsZWRQb3Muc2NhbGUoY29u dGVudHNTY2FsZSwgY29udGVudHNTY2FsZSk7CiAKICAgICAgICAgLy8gUm91bmQgdG8gaW50ZWdl ciBib3VuZGFyaWVzLgogICAgICAgICBGbG9hdFBvaW50IGFsaWduZWRQb3MgPSByb3VuZGVkSW50 UG9pbnQoc2NhbGVkUG9zKTsKIAogICAgICAgICAvLyBDb252ZXJ0IGJhY2sgdG8gQ1NTIGNvb3Jk aW5hdGVzLgotICAgICAgICBhbGlnbmVkUG9zLnNjYWxlKDEgLyBtX3BhZ2VTY2FsZUZhY3Rvciwg MSAvIG1fcGFnZVNjYWxlRmFjdG9yKTsKKyAgICAgICAgYWxpZ25lZFBvcy5zY2FsZSgxIC8gY29u dGVudHNTY2FsZSwgMSAvIGNvbnRlbnRzU2NhbGUpOwogCiAgICAgICAgIHJldHVybiBhbGlnbmVk UG9zOwogICAgIH0K 182082 2013-01-10 00:52:55 -0800 2013-01-10 02:01:09 -0800 Patch bug-106504-20130110174937.patch text/plain 2267 dongseong.hwang U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5MjkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYTk2NTE2ZmFmODhjOTBk ZWM3NDI1ZWRjZjg1ZDE3NjQ3Y2JjYmIxMS4uZWUyNjQ3Y2UxZmQ4NTM2ODhkY2NjY2M0NWZkOGRm YWE1ZmZkM2I0MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAxLTA5ICBIdWFu ZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0PgorCisgICAgICAgIFJFR1JFU1NJ T04ocjEzOTE4OSk6IHBpeGVsIGFsaWdubWVudCBtdXN0IGJlIHBlcmZvcm1lZCBpbiBkZXZpY2Ug dW5pdHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MDY1MDQKKworICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbi4K KworICAgICAgICBBZnRlciByMTM5MTg5LCBwaXhlbCBhbGlnbm1lbnQgaXMgcGVyZm9ybWVkIGlu IFVJIHVuaXRzLiBJZiBkZXZpY2VTY2FsZUZhY3RvciBpcworICAgICAgICBmcmFjdGlvbmFsIG51 bWJlciwgYWRqdXN0ZWQgc2Nyb2xsIHBvc2l0aW9uIGNhbiBibHVyIG5vbi1jb21wb3NpdGVkIGxh eWVyLgorCisgICAgICAgICogVUlQcm9jZXNzL1BhZ2VWaWV3cG9ydENvbnRyb2xsZXIuY3BwOgor ICAgICAgICAoV2ViS2l0OjpQYWdlVmlld3BvcnRDb250cm9sbGVyOjpwaXhlbEFsaWduZWRGbG9h dFBvaW50KToKKwogMjAxMy0wMS0wOSAgU2Vva2p1IEt3b24gIDxzZW9ranUua3dvbkBnbWFpbC5j b20+CiAKICAgICAgICAgW1dLMl1bRUZMXSBBZGQgZ3VhcmQgYXJvdW5kIE5hdGl2ZVdlYlRvdWNo RXZlbnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9QYWdlVmlld3BvcnRD b250cm9sbGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9QYWdlVmlld3BvcnRDb250 cm9sbGVyLmNwcAppbmRleCBlOWYxMDg5NzQ4M2E5MDYwYzNiMmZhNDBjMzlmODNhNDJmM2Q4YTcx Li40NGQwMGJkMjliY2RkNzc5YzFlNjdiNDU3YTFkYzgwZjY0YjllZjFjIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGFnZVZpZXdwb3J0Q29udHJvbGxlci5jcHAKKysrIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1BhZ2VWaWV3cG9ydENvbnRyb2xsZXIuY3BwCkBAIC05 NSwxOCArOTUsMTkgQEAgc3RhdGljIGlubGluZSBib29sIGlzSW50ZWdyYWwoZmxvYXQgdmFsdWUp CiBGbG9hdFBvaW50IFBhZ2VWaWV3cG9ydENvbnRyb2xsZXI6OnBpeGVsQWxpZ25lZEZsb2F0UG9p bnQoY29uc3QgRmxvYXRQb2ludCYgZnJhbWVQb3NpdGlvbikKIHsKICNpZiBQTEFURk9STShFRkwp Ci0gICAgaWYgKCFpc0ludGVncmFsKG1fcGFnZVNjYWxlRmFjdG9yKSkgeworICAgIGZsb2F0IGVm ZmVjdGl2ZVNjYWxlID0gbV9wYWdlU2NhbGVGYWN0b3IgKiBkZXZpY2VTY2FsZUZhY3RvcigpOwor ICAgIGlmICghaXNJbnRlZ3JhbChlZmZlY3RpdmVTY2FsZSkpIHsKICAgICAgICAgLy8gVG8gYXZv aWQgYmx1cnJ5bmVzcywgbW9kaWZ5IHRoZSBwb3NpdGlvbiBzbyB0aGF0IGl0IG1hcHMgaW50byBh IGRpc2NyZXRlIGRldmljZSBwb3NpdGlvbi4KICAgICAgICAgRmxvYXRQb2ludCBzY2FsZWRQb3Mo ZnJhbWVQb3NpdGlvbik7CiAKICAgICAgICAgLy8gU2NhbGUgYnkgdGhlIGVmZmVjdGl2ZSBzY2Fs ZSBmYWN0b3IgdG8gY29tcHV0ZSB0aGUgc2NyZWVuLXJlbGF0aXZlIHBvc2l0aW9uLgotICAgICAg ICBzY2FsZWRQb3Muc2NhbGUobV9wYWdlU2NhbGVGYWN0b3IsIG1fcGFnZVNjYWxlRmFjdG9yKTsK KyAgICAgICAgc2NhbGVkUG9zLnNjYWxlKGVmZmVjdGl2ZVNjYWxlLCBlZmZlY3RpdmVTY2FsZSk7 CiAKICAgICAgICAgLy8gUm91bmQgdG8gaW50ZWdlciBib3VuZGFyaWVzLgogICAgICAgICBGbG9h dFBvaW50IGFsaWduZWRQb3MgPSByb3VuZGVkSW50UG9pbnQoc2NhbGVkUG9zKTsKIAogICAgICAg ICAvLyBDb252ZXJ0IGJhY2sgdG8gQ1NTIGNvb3JkaW5hdGVzLgotICAgICAgICBhbGlnbmVkUG9z LnNjYWxlKDEgLyBtX3BhZ2VTY2FsZUZhY3RvciwgMSAvIG1fcGFnZVNjYWxlRmFjdG9yKTsKKyAg ICAgICAgYWxpZ25lZFBvcy5zY2FsZSgxIC8gZWZmZWN0aXZlU2NhbGUsIDEgLyBlZmZlY3RpdmVT Y2FsZSk7CiAKICAgICAgICAgcmV0dXJuIGFsaWduZWRQb3M7CiAgICAgfQo=