106502 2013-01-09 16:39:53 -0800 Don't drop to huge tile mode if we're only slow-scrolling because of a page overlay 2013-01-09 16:52:00 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton webkit-unassigned andersca bdakin eric ojan.autocc simon.fraser webkit.review.bot oldest_to_newest 803817 0 thorton 2013-01-09 16:39:53 -0800 We only use the MainThreadScrollingReason "ForcedOnMainThread" if we install a page overlay (didInstallPageOverlay), which clients can do arbitrarily. We probably should still use tile-sized tiles in this case (this will also prevent us from falling into gigantic tiles for WebKit2 find-in-page, among other things). 803818 1 simon.fraser 2013-01-09 16:40:17 -0800 And the web inspector. 803822 2 182012 thorton 2013-01-09 16:42:06 -0800 Created attachment 182012 no giant tiles 803825 3 182012 andersca 2013-01-09 16:45:57 -0800 Comment on attachment 182012 no giant tiles View in context: https://bugs.webkit.org/attachment.cgi?id=182012&action=review > Source/WebCore/rendering/RenderLayerBacking.cpp:204 > - if (scrollingCoordinator->shouldUpdateScrollLayerPositionOnMainThread()) > + if (scrollingCoordinator->mainThreadScrollingReasons() & ~ScrollingCoordinator::ForcedOnMainThread) I think you should explain what this does with a comment. 803828 4 thorton 2013-01-09 16:46:43 -0800 (In reply to comment #3) > (From update of attachment 182012 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=182012&action=review > > > Source/WebCore/rendering/RenderLayerBacking.cpp:204 > > - if (scrollingCoordinator->shouldUpdateScrollLayerPositionOnMainThread()) > > + if (scrollingCoordinator->mainThreadScrollingReasons() & ~ScrollingCoordinator::ForcedOnMainThread) > > I think you should explain what this does with a comment. okiedokie. 803833 5 thorton 2013-01-09 16:51:52 -0800 <rdar://problem/12959143> 803834 6 thorton 2013-01-09 16:52:00 -0800 http://trac.webkit.org/changeset/139258 182012 2013-01-09 16:42:06 -0800 2013-01-09 16:45:57 -0800 no giant tiles no-giant-tiles.diff text/plain 1817 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmOGUzMTA0Li5lZDE5ZGJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTMtMDEtMDkgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgRG9uJ3QgZHJvcCB0byBodWdlIHRpbGUgbW9kZSBpZiB3ZSdyZSBvbmx5IHNsb3ct c2Nyb2xsaW5nIGJlY2F1c2Ugb2YgYSBwYWdlIG92ZXJsYXkKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNjUwMgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIG9ubHkgdXNlIHRoZSBNYWluVGhyZWFkU2Ny b2xsaW5nUmVhc29uICJGb3JjZWRPbk1haW5UaHJlYWQiIGlmIFdlYktpdDIgaW5zdGFsbHMKKyAg ICAgICAgYSBwYWdlIG92ZXJsYXkgKFRpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhOjpkaWRJ bnN0YWxsUGFnZU92ZXJsYXkpLCB3aGljaCBjbGllbnRzCisgICAgICAgIGNhbiBjYXVzZSBhcmJp dHJhcmlseS4KKworICAgICAgICBXZSBwcm9iYWJseSBzaG91bGQgc3RpbGwgdXNlIGRlZmF1bHQt c2l6ZWQgdGlsZXMgaW4gdGhpcyBjYXNlICh0aGlzIHdpbGwgYWxzbworICAgICAgICBwcmV2ZW50 IHVzIGZyb20gZmFsbGluZyBpbnRvIGdpZ2FudGljIHRpbGVzIGZvciBXZWJLaXQyIGZpbmQtaW4t cGFnZSwgYW1vbmcgb3RoZXIgdGhpbmdzKS4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJM YXllckJhY2tpbmcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXJCYWNraW5nOjph ZGp1c3RUaWxlQ2FjaGVDb3ZlcmFnZSk6CisKIDIwMTMtMDEtMDkgIERhbiBXaW5zaGlwICA8ZGFu d0Bnbm9tZS5vcmc+CiAKICAgICAgICAgW1NvdXBdIEhhbmRsZSByZWRpcmVjdGlvbiBpbnNpZGUg V2ViS2l0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJC YWNraW5nLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcu Y3BwCmluZGV4IGZiOGVhOGMuLjUzNDg2OWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwCkBAIC0yMDEsNyArMjAxLDcgQEAgdm9pZCBSZW5k ZXJMYXllckJhY2tpbmc6OmFkanVzdFRpbGVDYWNoZUNvdmVyYWdlKCkKICAgICAgICAgICAgIHRp bGVDb3ZlcmFnZSB8PSBUaWxlZEJhY2tpbmc6OkNvdmVyYWdlRm9yVmVydGljYWxTY3JvbGxpbmc7 CiAKICAgICAgICAgaWYgKFNjcm9sbGluZ0Nvb3JkaW5hdG9yKiBzY3JvbGxpbmdDb29yZGluYXRv ciA9IGZyYW1lLT5wYWdlKCktPnNjcm9sbGluZ0Nvb3JkaW5hdG9yKCkpIHsKLSAgICAgICAgICAg IGlmIChzY3JvbGxpbmdDb29yZGluYXRvci0+c2hvdWxkVXBkYXRlU2Nyb2xsTGF5ZXJQb3NpdGlv bk9uTWFpblRocmVhZCgpKQorICAgICAgICAgICAgaWYgKHNjcm9sbGluZ0Nvb3JkaW5hdG9yLT5t YWluVGhyZWFkU2Nyb2xsaW5nUmVhc29ucygpICYgflNjcm9sbGluZ0Nvb3JkaW5hdG9yOjpGb3Jj ZWRPbk1haW5UaHJlYWQpCiAgICAgICAgICAgICAgICAgdGlsZUNvdmVyYWdlIHw9IFRpbGVkQmFj a2luZzo6Q292ZXJhZ2VGb3JTbG93U2Nyb2xsaW5nOwogICAgICAgICB9CiAgICAgfQo=