106495 2013-01-09 14:49:33 -0800 [chromium] Add a notification when a WebWidget's WebLayerTreeView is about to go away 2013-01-09 16:19:43 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jamesr jamesr abarth dglazkov enne fishd tkent+wkapi webkit.review.bot oldest_to_newest 803735 0 jamesr 2013-01-09 14:49:33 -0800 [chromium] Add a notification when a WebWidget's WebLayerTreeView is about to go away 803752 1 181993 jamesr 2013-01-09 14:58:58 -0800 Created attachment 181993 Patch 803754 2 jamesr 2013-01-09 15:02:12 -0800 This fixes crashes caused by https://codereview.chromium.org/11575049/. I'm not super thrilled with it, but as the ChangeLog notes it is temporary (hah) 803758 3 webkit.review.bot 2013-01-09 15:03:32 -0800 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 803779 4 181993 enne 2013-01-09 15:22:09 -0800 Comment on attachment 181993 Patch R=me. 803800 5 181993 webkit.review.bot 2013-01-09 16:19:39 -0800 Comment on attachment 181993 Patch Clearing flags on attachment: 181993 Committed r139252: <http://trac.webkit.org/changeset/139252> 803801 6 webkit.review.bot 2013-01-09 16:19:43 -0800 All reviewed patches have been landed. Closing bug. 181993 2013-01-09 14:58:58 -0800 2013-01-09 16:19:39 -0800 Patch bug-106495-20130109145551.patch text/plain 3576 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5MTEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDRiN2I2Mzc1MTk3MDI3Y2U4ZjExYWRhZDY3NjQxNmMzZWJjY2YzZGEuLmRlZTdmZDdmZDQxYTdi YjE3Y2FmYmNhNGM4ZWUxZjNmYzUzMjU5ZTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjcgQEAKKzIwMTMtMDEtMDkgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9t aXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIEFkZCBhIG5vdGlmaWNhdGlvbiB3aGVuIGEg V2ViV2lkZ2V0J3MgV2ViTGF5ZXJUcmVlVmlldyBpcyBhYm91dCB0byBnbyBhd2F5CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDY0OTUKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgV2ViV2lkZ2V0IC8g V2ViTGF5ZXJUcmVlVmlldyBvd25lcnNoaXAgaXMgaW4gYSBzbGlnaHRseSBhd2t3YXJkIHBsYWNl LiBJJ20gbW92aW5nIHRoZSBvd25lcnNoaXAKKyAgICAgICAgb2YgdGhlIFdlYkxheWVyVHJlZVZp ZXcgdG8gdGhlIFdlYldpZGdldENsaWVudCwgYnV0IHRvIHN0YWdlIHRoaW5ncyBzYW5lbHkgdGhl IFdlYkxheWVyVHJlZVZpZXcncworICAgICAgICBjbGllbnQgaXMgc2lsbCBvd25lZCBieSB0aGUg V2ViV2lkZ2V0IGltcGxlbWVudGF0aW9uLiBUaHVzIHRvIHNodXQgZG93biBjbGVhbmx5IHdlIG5l ZWQgYW4gZXhwbGljaXQKKyAgICAgICAgbm90aWZpY2F0aW9uIHRvIHRoZSBXZWJXaWRnZXQgdGhh dCB0aGUgV2ViTGF5ZXJUcmVlVmlldyBpcyBnb2luZyB0byBnbyBhd2F5LgorCisgICAgICAgIFRo aXMgQVBJIGNhbiBnbyBhd2F5IG9uY2UgdGhlIFdlYldpZGdldCBpbXBsZW1lbnRhdGlvbiBkb2Vz IG5vdCBwcm92aWRlIHRoZSBXZWJMYXllclRyZWVWaWV3Q2xpZW50LAorICAgICAgICB3aGljaCB3 aWxsIHRha2UgYSBiaXQgbW9yZSByZWZhY3RvcmluZy4KKworICAgICAgICAqIHB1YmxpYy9XZWJX aWRnZXQuaDoKKyAgICAgICAgKFdlYldpZGdldCk6CisgICAgICAgIChXZWJLaXQ6OldlYldpZGdl dDo6d2lsbENsb3NlTGF5ZXJUcmVlVmlldyk6CisgICAgICAgICogc3JjL1dlYlZpZXdJbXBsLmNw cDoKKyAgICAgICAgKFdlYktpdDo6V2ViVmlld0ltcGw6OndpbGxDbG9zZUxheWVyVHJlZVZpZXcp OgorICAgICAgICAoV2ViS2l0KToKKyAgICAgICAgKiBzcmMvV2ViVmlld0ltcGwuaDoKKyAgICAg ICAgKFdlYlZpZXdJbXBsKToKKwogMjAxMy0wMS0wOCAgVG9tIFNlcGV6ICA8dHNlcGV6QGNocm9t aXVtLm9yZz4KIAogICAgICAgICBDb3B5LXBhc3RlIHByZXNlcnZlcyA8ZW1iZWQ+IHRhZ3MgY29u dGFpbmluZyBhY3RpdmUgY29udGVudC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vcHVibGljL1dlYldpZGdldC5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2Vi V2lkZ2V0LmgKaW5kZXggYTMzYzQ3MGM2ZjUwNjliYzgwNWEyZGJiMzM0ZmYxNDY5YjQ4NjMxNC4u ZTY4ZGY1NThiYjVkZmNjMjlmZmJlNDdmMTg3ZWQ5M2YzZmM5YTBkMSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViV2lkZ2V0LmgKKysrIGIvU291cmNlL1dlYktp dC9jaHJvbWl1bS9wdWJsaWMvV2ViV2lkZ2V0LmgKQEAgLTIyMyw2ICsyMjMsMTAgQEAgcHVibGlj OgogICAgIC8vIHRvIHJlbmRlciBpdHMgY29udGVudHMuCiAgICAgdmlydHVhbCBib29sIGlzQWNj ZWxlcmF0ZWRDb21wb3NpdGluZ0FjdGl2ZSgpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9CiAKKyAg ICAvLyBUaGUgV2ViTGF5ZXJUcmVlVmlldyBpbml0aWFsaXplZCBvbiB0aGlzIFdlYldpZGdldENs aWVudCB3aWxsIGJlIGdvaW5nIGF3YXkgYW5kCisgICAgLy8gaXMgbm8gbG9uZ2VyIHNhZmUgdG8g YWNjZXNzLgorICAgIHZpcnR1YWwgdm9pZCB3aWxsQ2xvc2VMYXllclRyZWVWaWV3KCkgeyB9CisK ICAgICAvLyBDYWxsaW5nIFdlYldpZGdldENsaWVudDo6cmVxdWVzdFBvaW50ZXJMb2NrKCkgd2ls bCByZXN1bHQgaW4gb25lCiAgICAgLy8gcmV0dXJuIGNhbGwgdG8gZGlkQWNxdWlyZVBvaW50ZXJM b2NrKCkgb3IgZGlkTm90QWNxdWlyZVBvaW50ZXJMb2NrKCkuCiAgICAgdmlydHVhbCB2b2lkIGRp ZEFjcXVpcmVQb2ludGVyTG9jaygpIHsgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2Vi Vmlld0ltcGwuY3BwCmluZGV4IDE1YzI1MjUwNWU5M2M1ZjJkNmEzMDgwMmZlM2M5NWE5MjJkZDA1 MmMuLmQ0OWJiNjExOGIyODU2NGM3NTM2YTc5ZjVlY2U0NTg0NTAzMzg5MTcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKQEAgLTI1MTgsNiArMjUxOCwxMiBA QCBib29sIFdlYlZpZXdJbXBsOjppc0FjY2VsZXJhdGVkQ29tcG9zaXRpbmdBY3RpdmUoKSBjb25z dAogI2VuZGlmCiB9CiAKK3ZvaWQgV2ViVmlld0ltcGw6OndpbGxDbG9zZUxheWVyVHJlZVZpZXco KQoreworICAgIHNldElzQWNjZWxlcmF0ZWRDb21wb3NpdGluZ0FjdGl2ZShmYWxzZSk7CisgICAg bV9sYXllclRyZWVWaWV3ID0gMDsKK30KKwogdm9pZCBXZWJWaWV3SW1wbDo6ZGlkQWNxdWlyZVBv aW50ZXJMb2NrKCkKIHsKICNpZiBFTkFCTEUoUE9JTlRFUl9MT0NLKQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuaCBiL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL1dlYlZpZXdJbXBsLmgKaW5kZXggYjVlMDIxMjNmNGI4NjVhMmMxZDhhZDNhZjlj MjcwOWZmMDMwNzdlMy4uNjc4ZDdkNWI5Y2Y2OWI4NTkxN2I3NzhlMTI0NWIxOWI0MjA2NjgxMyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuaAorKysg Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5oCkBAIC0xNzQsNiArMTc0 LDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgYm9vbCBjYXJldE9yU2VsZWN0aW9uUmFuZ2Uoc2l6 ZV90KiBsb2NhdGlvbiwgc2l6ZV90KiBsZW5ndGgpOwogICAgIHZpcnR1YWwgdm9pZCBzZXRUZXh0 RGlyZWN0aW9uKFdlYlRleHREaXJlY3Rpb24gZGlyZWN0aW9uKTsKICAgICB2aXJ0dWFsIGJvb2wg aXNBY2NlbGVyYXRlZENvbXBvc2l0aW5nQWN0aXZlKCkgY29uc3Q7CisgICAgdmlydHVhbCB2b2lk IHdpbGxDbG9zZUxheWVyVHJlZVZpZXcoKTsKICAgICB2aXJ0dWFsIHZvaWQgZGlkQWNxdWlyZVBv aW50ZXJMb2NrKCk7CiAgICAgdmlydHVhbCB2b2lkIGRpZE5vdEFjcXVpcmVQb2ludGVyTG9jaygp OwogICAgIHZpcnR1YWwgdm9pZCBkaWRMb3NlUG9pbnRlckxvY2soKTsK