106486 2013-01-09 13:23:14 -0800 [BlackBerry] Handle the case that start/end position is out of unclipped selection region 2013-01-10 01:16:35 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 yodai webkit-unassigned mifenton rwlbuis tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 803643 0 yodai 2013-01-09 13:23:14 -0800 Unclipped selection region should cover start/end position of the selection. Since we exclude hidden text when calculating unclipped selection region, the start/end position can be out of unclipped selection region if it is for hidden text. If that is the case, start/end handle will be invisible. To avoid invisible handle, we take unclipped selection region as reference rectangle in the case. 803652 1 181977 yodai 2013-01-09 13:40:08 -0800 Created attachment 181977 Patch 804156 2 181977 rwlbuis 2013-01-10 01:13:14 -0800 Comment on attachment 181977 Patch LGTM. 804158 3 181977 webkit.review.bot 2013-01-10 01:16:31 -0800 Comment on attachment 181977 Patch Clearing flags on attachment: 181977 Committed r139295: <http://trac.webkit.org/changeset/139295> 804159 4 webkit.review.bot 2013-01-10 01:16:35 -0800 All reviewed patches have been landed. Closing bug. 181977 2013-01-09 13:40:08 -0800 2013-01-10 01:16:31 -0800 Patch bug-106486-20130109163754.patch text/plain 2287 yodai U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5MjMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBmN2IyNWFjZjI5ZTQ0ZjgzNTU0YjkwZGQ3ZGYxNzQxMzczZjVjMTBjLi42MmRjMjMxZTlk YTA0NWRmOGNlM2M3ZGFjZTg3YmU4OGE5ZGUzZDQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMy0wMS0wOSAgWW9uZ3hpbiBEYWkgIDx5b2RhaUBy aW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBIYW5kbGUgdGhlIGNhc2UgdGhhdCBzdGFy dC9lbmQgcG9zaXRpb24gaXMgb3V0IG9mIHVuY2xpcHBlZCBzZWxlY3Rpb24gcmVnaW9uCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDY0ODYKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQUiAjMjcwNjI0Cisg ICAgICAgIFVuY2xpcHBlZCBzZWxlY3Rpb24gcmVnaW9uIHNob3VsZCBjb3ZlciBzdGFydC9lbmQg cG9zaXRpb24gb2YgdGhlIHNlbGVjdGlvbi4KKyAgICAgICAgU2luY2Ugd2UgZXhjbHVkZSBoaWRk ZW4gdGV4dCB3aGVuIGNhbGN1bGF0aW5nIHVuY2xpcHBlZCBzZWxlY3Rpb24gcmVnaW9uLCB0aGUK KyAgICAgICAgc3RhcnQvZW5kIHBvc2l0aW9uIGNhbiBiZSBvdXQgb2YgdW5jbGlwcGVkIHNlbGVj dGlvbiByZWdpb24gaWYgaXQgaXMgZm9yIGhpZGRlbgorICAgICAgICB0ZXh0LiBJZiB0aGF0IGlz IHRoZSBjYXNlLCBzdGFydC9lbmQgaGFuZGxlIHdpbGwgYmUgaW52aXNpYmxlLiBUbyBhdm9pZCBp bnZpc2libGUKKyAgICAgICAgaGFuZGxlLCB3ZSB0YWtlIHVuY2xpcHBlZCBzZWxlY3Rpb24gcmVn aW9uIGFzIHJlZmVyZW5jZSByZWN0YW5nbGUgaW4gdGhlIGNhc2UuCisKKyAgICAgICAgSW50ZXJu YWxseSByZXZpZXdlZCBieSBHZW5ldmlldmUgTWFrLCBNaWtlIEZlbnRvbgorCisgICAgICAgICog V2ViS2l0U3VwcG9ydC9TZWxlY3Rpb25IYW5kbGVyLmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6 OldlYktpdDo6cmVmZXJlbmNlUG9pbnQpOgorCiAyMDEzLTAxLTA5ICBHZW5ldmlldmUgTWFrICA8 Z21ha0ByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBVc2VsZXNzIGlmIHN0YXRlbWVu dCBjaGVjawpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBv cnQvU2VsZWN0aW9uSGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0 U3VwcG9ydC9TZWxlY3Rpb25IYW5kbGVyLmNwcAppbmRleCBlZThkMmExYmJlNzI4N2M0YzYyZGY1 ZTA5NzFjZTUxNjY2MDQ5NjhhLi44ODM3MGFkNDk4Zjk0ODQ3ZTcyNTAzNDdiZGUzN2RhNzYxYzJm ZDM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9T ZWxlY3Rpb25IYW5kbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0 U3VwcG9ydC9TZWxlY3Rpb25IYW5kbGVyLmNwcApAQCAtODU1LDEwICs4NTUsOSBAQCBzdGF0aWMg V2ViQ29yZTo6SW50UG9pbnQgcmVmZXJlbmNlUG9pbnQoY29uc3QgVmlzaWJsZVBvc2l0aW9uJiBw b3NpdGlvbiwgY29uc3QgVwogICAgIC8vIGVudGlyZSByZWdpb24gKHdoaWNoIGlzIGFscmVhZHkg aW4gZnJhbWUgY29vcmRpbmF0ZXMgc28gZG9lc24ndCBuZWVkCiAgICAgLy8gYWRqdXN0aW5nKS4K ICAgICBXZWJDb3JlOjpJbnRSZWN0IHN0YXJ0Q2FyZXRCb3VuZHMocG9zaXRpb24uYWJzb2x1dGVD YXJldEJvdW5kcygpKTsKLSAgICBpZiAoc3RhcnRDYXJldEJvdW5kcy5pc0VtcHR5KCkpCisgICAg c3RhcnRDYXJldEJvdW5kcy5tb3ZlKGZyYW1lUG9zaXRpb24ueCgpLCBmcmFtZVBvc2l0aW9uLnko KSk7CisgICAgaWYgKHN0YXJ0Q2FyZXRCb3VuZHMuaXNFbXB0eSgpIHx8ICFib3VuZGluZ1JlY3Qu Y29udGFpbnMoc3RhcnRDYXJldEJvdW5kcykpCiAgICAgICAgIHN0YXJ0Q2FyZXRCb3VuZHMgPSBi b3VuZGluZ1JlY3Q7Ci0gICAgZWxzZQotICAgICAgICBzdGFydENhcmV0Qm91bmRzLm1vdmUoZnJh bWVQb3NpdGlvbi54KCksIGZyYW1lUG9zaXRpb24ueSgpKTsKIAogICAgIHJldHVybiBjYXJldENv bXBhcmlzb25Qb2ludEZvclJlY3Qoc3RhcnRDYXJldEJvdW5kcywgaXNTdGFydENhcmV0LCBpc1JU TCk7CiB9Cg==