106482 2013-01-09 12:14:13 -0800 fast/forms/min-content-form-controls.html fails on some platforms 2013-01-09 15:02:18 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ojan ojan eric rniwa tony oldest_to_newest 803567 0 ojan 2013-01-09 12:14:13 -0800 fast/forms/min-content-form-controls.html fails on some platforms 803570 1 181965 ojan 2013-01-09 12:15:43 -0800 Created attachment 181965 Patch 803575 2 181965 eric 2013-01-09 12:19:27 -0800 Comment on attachment 181965 Patch rs=me. 803577 3 181965 tony 2013-01-09 12:19:41 -0800 Comment on attachment 181965 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181965&action=review > LayoutTests/ChangeLog:10 > + The text dump for some form controls (menulists?) is different > + on different platforms. Remove the form controls to avoid adding > + platform-specific expectations for this test. How are they different? > LayoutTests/fast/forms/min-content-form-controls.html:42 > + // Remove these elements since some of the text dumps are different platforms. What does "some of the text dumps are different platforms" mean? 803578 4 181965 rniwa 2013-01-09 12:20:16 -0800 Comment on attachment 181965 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181965&action=review > LayoutTests/fast/forms/min-content-form-controls.html:47 > +function remove(id) { > + var node = document.getElementById(id); > + node.parentNode.removeChild(node); > +} > + > +if (window.testRunner) { > + // Remove these elements since some of the text dumps are different platforms. > + ids.forEach(function(id) { > + remove(id + '-a'); > + remove(id + '-b'); > + }); > +} Why don’t we just delete all input and select elements or simply wrap them in div and set innerHTML on that? 803581 5 181965 rniwa 2013-01-09 12:20:52 -0800 Comment on attachment 181965 Patch Oops, I apparently overrode tony’s cq-. 803588 6 ojan 2013-01-09 12:25:23 -0800 Committed r139221: <http://trac.webkit.org/changeset/139221> 803625 7 181965 darin 2013-01-09 12:51:51 -0800 Comment on attachment 181965 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181965&action=review >> LayoutTests/ChangeLog:10 >> + The text dump for some form controls (menulists?) is different >> + on different platforms. Remove the form controls to avoid adding >> + platform-specific expectations for this test. > > How are they different? Why is the text dump for these form controls different on different platforms? This seems a fine workaround for that problem, but is it something we could easily fix in the form control code? >> LayoutTests/fast/forms/min-content-form-controls.html:42 >> + // Remove these elements since some of the text dumps are different platforms. > > What does "some of the text dumps are different platforms" mean? Missing words here. I think you mean "are different on different platforms". 803728 8 ojan 2013-01-09 14:46:25 -0800 (In reply to comment #7) > (From update of attachment 181965 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=181965&action=review > > >> LayoutTests/ChangeLog:10 > >> + The text dump for some form controls (menulists?) is different > >> + on different platforms. Remove the form controls to avoid adding > >> + platform-specific expectations for this test. > > > > How are they different? > > Why is the text dump for these form controls different on different platforms? This seems a fine workaround for that problem, but is it something we could easily fix in the form control code? Yeah, sorry, I was being overly lazy. Looking closer, I was confused about what was going on. The issue is that there was line wrapping on some platforms due to differently sized form controls, which lead to a different number of spaces in the innerText output. An alternate workaround for this test would have been to put a <br> after each form control. 803730 9 ojan 2013-01-09 14:47:32 -0800 In fact, I like the explicit break solution better since we don't then have to do something different for being in the test runner. I'll commit a followup patch with that change. Thanks for calling me out on this. 803755 10 ojan 2013-01-09 15:02:18 -0800 http://trac.webkit.org/changeset/139245 181965 2013-01-09 12:15:43 -0800 2013-01-09 12:51:51 -0800 Patch bug-106482-20130109201247.patch text/plain 3502 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5MjE2CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMjRhN2QwYmFjMzE2MDAyMWVmYjgy MWMzZmExODAzMGZhNDUyMDNhYS4uZTZhNDkwZTI0ZmJjZmU0YjEzODA3N2YxYmYxNWFkOWYzYWU1 ZjE0NyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAxLTA5ICBPamFuIFZhZmFpICA8b2ph bkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgZmFzdC9mb3Jtcy9taW4tY29udGVudC1mb3JtLWNv bnRyb2xzLmh0bWwgZmFpbHMgb24gc29tZSBwbGF0Zm9ybXMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNjQ4MgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSB0ZXh0IGR1bXAgZm9yIHNvbWUgZm9ybSBj b250cm9scyAobWVudWxpc3RzPykgaXMgZGlmZmVyZW50CisgICAgICAgIG9uIGRpZmZlcmVudCBw bGF0Zm9ybXMuIFJlbW92ZSB0aGUgZm9ybSBjb250cm9scyB0byBhdm9pZCBhZGRpbmcKKyAgICAg ICAgcGxhdGZvcm0tc3BlY2lmaWMgZXhwZWN0YXRpb25zIGZvciB0aGlzIHRlc3QuCisKKyAgICAg ICAgKiBmYXN0L2Zvcm1zL21pbi1jb250ZW50LWZvcm0tY29udHJvbHMtZXhwZWN0ZWQudHh0Ogor ICAgICAgICAqIGZhc3QvZm9ybXMvbWluLWNvbnRlbnQtZm9ybS1jb250cm9scy5odG1sOgorICAg ICAgICAqIHBsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDEzLTAxLTA4ICBPamFu IFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgbWluLWNvbnRlbnQgZ2V0cyB0 aGUgd3JvbmcgdmFsdWUgaWYgbWluLXdpZHRoIGlzIHNldCBvbiBzb21lIGZvcm0gY29udHJvbHMK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvbWluLWNvbnRlbnQtZm9ybS1jb250 cm9scy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL21pbi1jb250ZW50LWZv cm0tY29udHJvbHMtZXhwZWN0ZWQudHh0CmluZGV4IDEyMWJkMjVkYjkwMWFmMmUwOTU0YzZmOTkx NjJkNjZmZWM0ZDY0YjYuLjFjNGQzZDg2MWZhZmFhODBlOWVlZWE1YjRhYTZlYzcwZTk5ZjFmN2Ig MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvbWluLWNvbnRlbnQtZm9ybS1jb250 cm9scy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9taW4tY29udGVu dC1mb3JtLWNvbnRyb2xzLWV4cGVjdGVkLnR4dApAQCAtOCw0ICs4LDQgQEAgUEFTUyBzdWNjZXNz ZnVsbHlQYXJzZWQgaXMgdHJ1ZQogVEVTVCBDT01QTEVURQogVGhlIGZvcm0gY29udHJvbHMgb2Yg dGhlIHNhbWUgdHlwZSBiZWxvdyBzaG91bGQgYmUgdGhlIHNhbWUgd2lkdGguCiAKLSAgICAgICAg ICAgICAKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9taW4tY29udGVudC1m b3JtLWNvbnRyb2xzLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL21pbi1jb250ZW50LWZv cm0tY29udHJvbHMuaHRtbAppbmRleCAxZTc2N2IxMWU2Yzk3NGIzYWQwMWQ5MTI3NDA3ZjNlNTI5 NzFhZWJiLi44OTgwNDFjODYyMWE1ZTdlMzJiNWNmNjI3OTk1ZTllYjAyZThkMWIwIDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL21pbi1jb250ZW50LWZvcm0tY29udHJvbHMuaHRt bAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL21pbi1jb250ZW50LWZvcm0tY29udHJvbHMu aHRtbApAQCAtMzEsNiArMzEsMTkgQEAKIHZhciBpZHMgPSBbJ3RleHQnLCAnZmlsZScsICdyYW5n ZScsICdzZWxlY3QnLCAnbXVsdGlwbGUnXTsKIGlkcy5mb3JFYWNoKGZ1bmN0aW9uKGlkKSB7CiAg ICAgc2hvdWxkQmUoJ2RvY3VtZW50LmdldEVsZW1lbnRCeUlkKCInICsgaWQgKyAnLWEiKS5vZmZz ZXRXaWR0aCcsICdkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiJyArIGlkICsgJy1iIikub2Zmc2V0 V2lkdGgnKTsKLX0pCit9KTsKKworZnVuY3Rpb24gcmVtb3ZlKGlkKSB7CisgICAgdmFyIG5vZGUg PSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZChpZCk7CisgICAgbm9kZS5wYXJlbnROb2RlLnJlbW92 ZUNoaWxkKG5vZGUpOworfQorCitpZiAod2luZG93LnRlc3RSdW5uZXIpIHsKKyAgICAvLyBSZW1v dmUgdGhlc2UgZWxlbWVudHMgc2luY2Ugc29tZSBvZiB0aGUgdGV4dCBkdW1wcyBhcmUgZGlmZmVy ZW50IHBsYXRmb3Jtcy4KKyAgICBpZHMuZm9yRWFjaChmdW5jdGlvbihpZCkgeworICAgICAgICBy ZW1vdmUoaWQgKyAnLWEnKTsKKyAgICAgICAgcmVtb3ZlKGlkICsgJy1iJyk7CisgICAgfSk7Cit9 CiA8L3NjcmlwdD4KIDxzY3JpcHQgc3JjPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0Lmpz Ij48L3NjcmlwdD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhw ZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMKaW5k ZXggYzQzNDA2YWU5NGIwNTY4NTNlYjQwYWI5NGRkYzllZTRjNzBiZmEzNi4uYWQxZDc4ZGRhZTEw MjlhY2Y2NWEyYTZmMTVlNGI5YjAyM2FiZWVkMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxh dGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFj L1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTEyNDQsMTAgKzEyNDQsNiBAQCB3ZWJraXQub3JnL2IvMTA1 Nzc3IHBsYXRmb3JtL21hYy9lZGl0aW5nL3NwZWxsaW5nL2F1dG9jb3JyZWN0aW9uLWluLXRleHRh cmVhLmh0bQogCiB3ZWJraXQub3JnL2IvMTA1OTMyIFsgTW91bnRhaW5MaW9uIERlYnVnIF0gaHR0 cC90ZXN0cy9pbnNwZWN0b3IvcmVzb3VyY2UtaGFyLXBhZ2VzLmh0bWwgWyBDcmFzaCBdCiAKLSMg TmVlZCB0byBzZWUgdGhpcyBydW4gb24gdGhlIGJvdHMgdG8gc2VlIHdoYXQncyB3cm9uZy4gVGhl IGNvZGUgY2hhbmdlIGluIAotIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTA2Mzg5IGlzIG9ubHkgdG91Y2hpbmcgY3Jvc3MtcGxhdGZvcm0gY29kZS4KLUJ1ZyhvamFu KSBmYXN0L2Zvcm1zL21pbi1jb250ZW50LWZvcm0tY29udHJvbHMuaHRtbCBbIEZhaWx1cmUgXQot CiB3ZWJraXQub3JnL2IvMTA1OTg2IFsgRGVidWcgXSB0cmFuc2l0aW9ucy9oYW5nLXdpdGgtYmFk LXRyYW5zaXRpb24tbGlzdC5odG1sIFsgUGFzcyBDcmFzaCBdCiB3ZWJraXQub3JnL2IvMTA1OTg2 IFsgRGVidWcgXSBzdmcvZHluYW1pYy11cGRhdGVzL1NWR0ZFTW9ycGhvbG9neUVsZW1lbnQtZG9t LWluLWF0dHIuaHRtbCBbIFBhc3MgQ3Jhc2ggXQogd2Via2l0Lm9yZy9iLzEwNTk4NiBbIERlYnVn IF0gc3ZnL2R5bmFtaWMtdXBkYXRlcy9TVkdGRU1vcnBob2xvZ3lFbGVtZW50LWRvbS1yYWRpdXMt YXR0ci5odG1sIFsgUGFzcyBDcmFzaCBdCg==