106472 2013-01-09 10:43:59 -0800 IndexedDB: Remove unnecessary tests from storage/indexeddb/key-type-array.html 2013-01-09 12:13:27 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 michael webkit-unassigned alecflett benjamin jsbell tony webkit.review.bot oldest_to_newest 803477 0 michael 2013-01-09 10:43:59 -0800 The tests in storage/indexeddb/key-type-array.html which verify that JSON.stringify() throws an exception for cyclic objects are unnecessary and differ between JSC and V8. The error message regarding serializing cyclic structures in JSC is "JSON.stringify cannot serialize cyclic structures." (Source/JavaScriptCore/runtime/JSONObject.cpp line 412) while the comparable error message in V8 is "Converting circular structure to JSON" (v8/src/messages.js line 116). The error messages relating to serializing cyclic structures are rather incidental to the functionality being tested: shouldThrow("JSON.stringify(cyclic_array)"); These tests should be removed. 803487 1 181949 michael 2013-01-09 10:49:14 -0800 Created attachment 181949 Patch 803493 2 181949 jsbell 2013-01-09 10:54:42 -0800 Comment on attachment 181949 Patch lgtm 803565 3 181949 webkit.review.bot 2013-01-09 12:13:24 -0800 Comment on attachment 181949 Patch Clearing flags on attachment: 181949 Committed r139219: <http://trac.webkit.org/changeset/139219> 803566 4 webkit.review.bot 2013-01-09 12:13:27 -0800 All reviewed patches have been landed. Closing bug. 181949 2013-01-09 10:49:14 -0800 2013-01-09 12:13:24 -0800 Patch idb-remove-unnecessary-tests.patch text/plain 3794 michael RnJvbTogTWljaGFlbCBQcnVldHQgPG1pY2hhZWxANjhrLm9yZz4KRGF0ZTogV2VkLCA5IEphbiAy MDEzIDEwOjMzOjM1IC0wODAwClN1YmplY3Q6IEluZGV4ZWREQjogUmVtb3ZlIHVubmVjZXNzYXJ5 IHRlc3RzIGZyb20ga2V5LXR5cGUtYXJyYXkuaHRtbAoKLS0tCiBMYXlvdXRUZXN0cy9DaGFuZ2VM b2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTUgKysrKysrKysrKysrKysrCiAu Li4vc3RvcmFnZS9pbmRleGVkZGIva2V5LXR5cGUtYXJyYXktZXhwZWN0ZWQudHh0ICB8ICAgIDUg LS0tLS0KIC4uLi9zdG9yYWdlL2luZGV4ZWRkYi9yZXNvdXJjZXMva2V5LXR5cGUtYXJyYXkuanMg IHwgICAgNSAtLS0tLQogMyBmaWxlcyBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspLCAxMCBkZWxl dGlvbnMoLSkKCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKaW5kZXggYmE5MmZiYS4uYjIyZTkwNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBA CisyMDEzLTAxLTA5ICBNaWNoYWVsIFBydWV0dCAgPG1pY2hhZWxANjhrLm9yZz4KKworICAgICAg ICBJbmRleGVkREI6IFJlbW92ZSB1bm5lY2Vzc2FyeSB0ZXN0cyBmcm9tIHN0b3JhZ2UvaW5kZXhl ZGRiL2tleS10eXBlLWFycmF5Lmh0bWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEwNjQ3MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRoZSB0ZXN0cyB3aGljaCB2ZXJpZnkgdGhhdCBKU09OLnN0cmluZ2lm eSgpIHRocm93cyBhbiBleGNlcHRpb24KKyAgICAgICAgZm9yIGN5Y2xpYyBvYmplY3RzIHByb2R1 Y2UgZGlmZmVyZW50IGVycm9yIG1lc3NhZ2VzIG9uIEpTQyBhbmQKKyAgICAgICAgVjggYW5kIGRv IG5vdGhpbmcgdG8gdGVzdCBJbmRleGVkREIgZnVuY3Rpb25hbGl0eS4gVGhlc2UgdGVzdHMKKyAg ICAgICAgc2hvdWxkIGJlIHJlbW92ZWQuCisKKyAgICAgICAgKiBzdG9yYWdlL2luZGV4ZWRkYi9r ZXktdHlwZS1hcnJheS1leHBlY3RlZC50eHQ6CisgICAgICAgICogc3RvcmFnZS9pbmRleGVkZGIv cmVzb3VyY2VzL2tleS10eXBlLWFycmF5LmpzOgorCiAyMDEzLTAxLTA4ICBEaW1pdHJpIEdsYXpr b3YgIDxkZ2xhemtvdkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgT3JnYW5pemUgc29tZSBzdmcv Z3luYW1pYy11cGRhdGVzIGV4cGVjdGF0aW9ucy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N0 b3JhZ2UvaW5kZXhlZGRiL2tleS10eXBlLWFycmF5LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3Rz L3N0b3JhZ2UvaW5kZXhlZGRiL2tleS10eXBlLWFycmF5LWV4cGVjdGVkLnR4dAppbmRleCAxODJk ZDE2Li4zMjI0NTI1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9r ZXktdHlwZS1hcnJheS1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRl eGVkZGIva2V5LXR5cGUtYXJyYXktZXhwZWN0ZWQudHh0CkBAIC0xNTgsMTcgKzE1OCwxMiBAQCBz dG9yZSA9IHRyYW5zLm9iamVjdFN0b3JlKCdzdG9yZScpCiAKIGFycmF5IHRoYXQgY29udGFpbnMg aXRzZWxmOiBhcnJheSA9IFsgYXJyYXkgXQogY3ljbGljX2FycmF5ID0gW107IGN5Y2xpY19hcnJh eS5wdXNoKGN5Y2xpY19hcnJheSkKLVBBU1MgSlNPTi5zdHJpbmdpZnkoY3ljbGljX2FycmF5KSB0 aHJldyBleGNlcHRpb24gVHlwZUVycm9yOiBDb252ZXJ0aW5nIGNpcmN1bGFyIHN0cnVjdHVyZSB0 byBKU09OLgogYXJyYXkgdGhhdCBjb250YWlucyBpdHNlbGYsIG9uZSBsZXZlbCBkb3duOiBhcnJh eSA9IFsgWyBhcnJheSBdIF0KIGN5Y2xpY19hcnJheTIgPSBbXTsgY3ljbGljX2FycmF5Mi5wdXNo KFtjeWNsaWNfYXJyYXkyXSkKLVBBU1MgSlNPTi5zdHJpbmdpZnkoY3ljbGljX2FycmF5MikgdGhy ZXcgZXhjZXB0aW9uIFR5cGVFcnJvcjogQ29udmVydGluZyBjaXJjdWxhciBzdHJ1Y3R1cmUgdG8g SlNPTi4KIGFycmF5IHRoYXQgY29udGFpbnMgaXRzZWxmLCBub3QgYXMgZmlyc3QgZWxlbWVudDog YXJyYXkgPSBbMSwgJ2InLCBbXSwgYXJyYXldCiBjeWNsaWNfYXJyYXkzID0gWzEsICdiJywgW11d OyBjeWNsaWNfYXJyYXkzLnB1c2goY3ljbGljX2FycmF5MykKLVBBU1MgSlNPTi5zdHJpbmdpZnko Y3ljbGljX2FycmF5MykgdGhyZXcgZXhjZXB0aW9uIFR5cGVFcnJvcjogQ29udmVydGluZyBjaXJj dWxhciBzdHJ1Y3R1cmUgdG8gSlNPTi4KLQogYXJyYXkgdGhhdCBjb250YWlucyBhcnJheSB0aGF0 IGNvbnRhaW5zIGl0c2VsZgogY3ljbGljX2FycmF5NCA9IFtjeWNsaWNfYXJyYXldOwotUEFTUyBK U09OLnN0cmluZ2lmeShjeWNsaWNfYXJyYXk0KSB0aHJldyBleGNlcHRpb24gVHlwZUVycm9yOiBD b252ZXJ0aW5nIGNpcmN1bGFyIHN0cnVjdHVyZSB0byBKU09OLgogCiB0ZXN0aW5nIGludmFsaWQg YXJyYXkga2V5OiBbIHZvaWQgMCBdCiBFeHBlY3RpbmcgZXhjZXB0aW9uIGZyb20gc3RvcmUucHV0 KCd2YWx1ZScsIFsgdm9pZCAwIF0pOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvc3RvcmFnZS9p bmRleGVkZGIvcmVzb3VyY2VzL2tleS10eXBlLWFycmF5LmpzIGIvTGF5b3V0VGVzdHMvc3RvcmFn ZS9pbmRleGVkZGIvcmVzb3VyY2VzL2tleS10eXBlLWFycmF5LmpzCmluZGV4IDEyZGZiYmIuLjVh M2Q2MzggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL3Jlc291cmNl cy9rZXktdHlwZS1hcnJheS5qcworKysgYi9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9y ZXNvdXJjZXMva2V5LXR5cGUtYXJyYXkuanMKQEAgLTEwNSwyMCArMTA1LDE1IEBAIGZ1bmN0aW9u IHRlc3RJbnZhbGlkQXJyYXlLZXlzKCkKIAogICAgIGRlYnVnKCJhcnJheSB0aGF0IGNvbnRhaW5z IGl0c2VsZjogYXJyYXkgPSBbIGFycmF5IF0iKTsKICAgICBldmFsQW5kTG9nKCJjeWNsaWNfYXJy YXkgPSBbXTsgY3ljbGljX2FycmF5LnB1c2goY3ljbGljX2FycmF5KSIpOwotICAgIHNob3VsZFRo cm93KCJKU09OLnN0cmluZ2lmeShjeWNsaWNfYXJyYXkpIik7CiAKICAgICBkZWJ1ZygiYXJyYXkg dGhhdCBjb250YWlucyBpdHNlbGYsIG9uZSBsZXZlbCBkb3duOiBhcnJheSA9IFsgWyBhcnJheSBd IF0iKTsKICAgICBldmFsQW5kTG9nKCJjeWNsaWNfYXJyYXkyID0gW107IGN5Y2xpY19hcnJheTIu cHVzaChbY3ljbGljX2FycmF5Ml0pIik7Ci0gICAgc2hvdWxkVGhyb3coIkpTT04uc3RyaW5naWZ5 KGN5Y2xpY19hcnJheTIpIik7CiAKICAgICBkZWJ1ZygiYXJyYXkgdGhhdCBjb250YWlucyBpdHNl bGYsIG5vdCBhcyBmaXJzdCBlbGVtZW50OiBhcnJheSA9IFsxLCAnYicsIFtdLCBhcnJheV0iKTsK ICAgICBldmFsQW5kTG9nKCJjeWNsaWNfYXJyYXkzID0gWzEsICdiJywgW11dOyBjeWNsaWNfYXJy YXkzLnB1c2goY3ljbGljX2FycmF5MykiKTsKLSAgICBzaG91bGRUaHJvdygiSlNPTi5zdHJpbmdp ZnkoY3ljbGljX2FycmF5MykiKTsKLSAgICBkZWJ1ZygiIik7CiAKICAgICBkZWJ1ZygiYXJyYXkg dGhhdCBjb250YWlucyBhcnJheSB0aGF0IGNvbnRhaW5zIGl0c2VsZiIpOwogICAgIGV2YWxBbmRM b2coImN5Y2xpY19hcnJheTQgPSBbY3ljbGljX2FycmF5XTsiKTsKLSAgICBzaG91bGRUaHJvdygi SlNPTi5zdHJpbmdpZnkoY3ljbGljX2FycmF5NCkiKTsKICAgICBkZWJ1ZygiIik7CiAKICAgICB2 YXIgaW52YWxpZEtleXMgPSBbCi0tIAoxLjcuOS41Cgo=