106468 2013-01-09 10:20:54 -0800 Add WebPreferences for Seamless IFrames on Windows port. 2013-01-09 13:57:27 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 roger_fong webkit-unassigned eric mkwst roger_fong webkit.review.bot oldest_to_newest 803448 0 roger_fong 2013-01-09 10:20:54 -0800 Need to add WebPreferences for seamless iframes feature on Windows port in order for seamless iframes to work. 803459 1 roger_fong 2013-01-09 10:28:29 -0800 This arose from https://bugs.webkit.org/show_bug.cgi?id=106213 803473 2 181945 roger_fong 2013-01-09 10:42:11 -0800 Created attachment 181945 patch 803479 3 webkit.review.bot 2013-01-09 10:45:39 -0800 Attachment 181945 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/win/ChangeLog', u'Source/Web..." exit_code: 1 Source/WebKit/win/WebPreferences.h:173: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/win/WebPreferences.h:176: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style. 803488 4 roger_fong 2013-01-09 10:49:49 -0800 (In reply to comment #3) > Attachment 181945 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/win/ChangeLog', u'Source/Web..." exit_code: 1 > Source/WebKit/win/WebPreferences.h:173: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] > Source/WebKit/win/WebPreferences.h:176: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] > Total errors found: 2 in 6 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. Just the standard way of declaring the method in WebPreferences.h, not a valid error. 803526 5 181945 eric 2013-01-09 11:29:49 -0800 Comment on attachment 181945 patch View in context: https://bugs.webkit.org/attachment.cgi?id=181945&action=review rs=me. Sorry for the trouble. > Source/WebKit/win/WebPreferenceKeysPrivate.h:116 > +#define SeamlessIFramesPreferenceKey "SeamlessIFramesPreferenceKey" // default: false I'm not sure if you want these off by default or not. 803614 6 roger_fong 2013-01-09 12:41:26 -0800 (In reply to comment #5) > (From update of attachment 181945 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=181945&action=review > > rs=me. Sorry for the trouble. No worries :) > > Source/WebKit/win/WebPreferenceKeysPrivate.h:116 > > +#define SeamlessIFramesPreferenceKey "SeamlessIFramesPreferenceKey" // default: false > > I'm not sure if you want these off by default or not. Hmm me neither, just went with the flow on this one. The flag in RunTimeEnabledFeatures was intialized to false so I just went with it... 803666 7 roger_fong 2013-01-09 13:57:27 -0800 http://trac.webkit.org/changeset/139237 181945 2013-01-09 10:42:11 -0800 2013-01-09 11:29:49 -0800 patch seamless_patch.txt text/plain 4188 roger_fong SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzOTIwMykKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAxLTA5 ICBSb2dlciBGb25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIFdlYlBy ZWZlcmVuY2VzIGZvciBTZWFtbGVzcyBJRnJhbWVzIG9uIFdpbmRvd3MgcG9ydC4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNjQ2OC4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEludGVyZmFjZXMvSVdl YlByZWZlcmVuY2VzLmlkbDoKKyAgICAgICAgKiBXZWJQcmVmZXJlbmNlS2V5c1ByaXZhdGUuaDoK KyAgICAgICAgKiBXZWJQcmVmZXJlbmNlcy5jcHA6CisgICAgICAgIChXZWJQcmVmZXJlbmNlczo6 YXJlU2VhbWxlc3NJRnJhbWVzRW5hYmxlZCk6CisgICAgICAgIChXZWJQcmVmZXJlbmNlczo6c2V0 U2VhbWxlc3NJRnJhbWVzRW5hYmxlZCk6CisgICAgICAgICogV2ViUHJlZmVyZW5jZXMuaDoKKyAg ICAgICAgKFdlYlByZWZlcmVuY2VzKToKKyAgICAgICAgKiBXZWJWaWV3LmNwcDoKKyAgICAgICAg KFdlYlZpZXc6Om5vdGlmeVByZWZlcmVuY2VzQ2hhbmdlZCk6CisKIDIwMTMtMDEtMDkgIHBlYXZv QG91dGxvb2suY29tICA8cGVhdm9Ab3V0bG9vay5jb20+CiAKICAgICAgICAgW1dpbkNhaXJvXSBM aW5rIGZpeCBhZnRlciByMTM4NzU5CkluZGV4OiBTb3VyY2UvV2ViS2l0L3dpbi9XZWJQcmVmZXJl bmNlS2V5c1ByaXZhdGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L3dpbi9XZWJQcmVm ZXJlbmNlS2V5c1ByaXZhdGUuaAkocmV2aXNpb24gMTM5MTI5KQorKysgU291cmNlL1dlYktpdC93 aW4vV2ViUHJlZmVyZW5jZUtleXNQcml2YXRlLmgJKHdvcmtpbmcgY29weSkKQEAgLTExMyw2ICsx MTMsOCBAQAogCiAjZGVmaW5lIEFsbG93Q29udGludW91c1NwZWxsQ2hlY2tpbmdQcmVmZXJlbmNl S2V5ICJBbGxvd0NvbnRpbnVvdXNTcGVsbENoZWNraW5nUHJlZmVyZW5jZUtleSIgLy8gZGVmYXVs dDogdHJ1ZQogCisjZGVmaW5lIFNlYW1sZXNzSUZyYW1lc1ByZWZlcmVuY2VLZXkgIlNlYW1sZXNz SUZyYW1lc1ByZWZlcmVuY2VLZXkiIC8vIGRlZmF1bHQ6IGZhbHNlCisKICNkZWZpbmUgV2ViS2l0 RE9NUGFzdGVBbGxvd2VkUHJlZmVyZW5jZUtleSAiV2ViS2l0RE9NUGFzdGVBbGxvd2VkUHJlZmVy ZW5jZUtleSIgLy8gZGVmYXVsdDogZmFsc2UKIAogI2RlZmluZSBXZWJLaXRBcHBsaWNhdGlvbkNo cm9tZU1vZGVQcmVmZXJlbmNlS2V5ICJXZWJLaXRBcHBsaWNhdGlvbkNocm9tZU1vZGUiIC8vIGRl ZmF1bHQ6IGZhbHNlCkluZGV4OiBTb3VyY2UvV2ViS2l0L3dpbi9XZWJQcmVmZXJlbmNlcy5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC93aW4vV2ViUHJlZmVyZW5jZXMuY3BwCShyZXZp c2lvbiAxMzkxMjkpCisrKyBTb3VyY2UvV2ViS2l0L3dpbi9XZWJQcmVmZXJlbmNlcy5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTEzMDcsNiArMTMwNywxOCBAQCBIUkVTVUxUIFdlYlByZWZlcmVuY2Vz OjpzZXRBbGxvd0NvbnRpbnVvCiAgICAgcmV0dXJuIFNfT0s7CiB9CiAKK0hSRVNVTFQgV2ViUHJl ZmVyZW5jZXM6OmFyZVNlYW1sZXNzSUZyYW1lc0VuYWJsZWQoQk9PTCogZW5hYmxlZCkKK3sKKyAg ICAqZW5hYmxlZCA9IGJvb2xWYWx1ZUZvcktleShDRlNUUihTZWFtbGVzc0lGcmFtZXNQcmVmZXJl bmNlS2V5KSk7CisgICAgcmV0dXJuIFNfT0s7Cit9CisKK0hSRVNVTFQgV2ViUHJlZmVyZW5jZXM6 OnNldFNlYW1sZXNzSUZyYW1lc0VuYWJsZWQoQk9PTCBlbmFibGVkKQoreworICAgIHNldEJvb2xW YWx1ZShDRlNUUihTZWFtbGVzc0lGcmFtZXNQcmVmZXJlbmNlS2V5KSwgZW5hYmxlZCk7CisgICAg cmV0dXJuIFNfT0s7Cit9CisKIEhSRVNVTFQgV2ViUHJlZmVyZW5jZXM6OmlzRE9NUGFzdGVBbGxv d2VkKEJPT0wqIGVuYWJsZWQpCiB7CiAgICAgKmVuYWJsZWQgPSBib29sVmFsdWVGb3JLZXkoQ0ZT VFIoV2ViS2l0RE9NUGFzdGVBbGxvd2VkUHJlZmVyZW5jZUtleSkpOwpJbmRleDogU291cmNlL1dl YktpdC93aW4vV2ViUHJlZmVyZW5jZXMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L3dp bi9XZWJQcmVmZXJlbmNlcy5oCShyZXZpc2lvbiAxMzkxMjkpCisrKyBTb3VyY2UvV2ViS2l0L3dp bi9XZWJQcmVmZXJlbmNlcy5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNjksNiArMTY5LDEyIEBAIHB1 YmxpYzoKICAgICB2aXJ0dWFsIEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgc2V0Q1NTUmVnaW9u c0VuYWJsZWQoCiAgICAgICAgIC8qIFtpbl0gKi8gQk9PTCk7CiAgICAgCisgICAgdmlydHVhbCBI UkVTVUxUIFNURE1FVEhPRENBTExUWVBFIGFyZVNlYW1sZXNzSUZyYW1lc0VuYWJsZWQoCisgICAg ICAgIC8qIFtyZXR2YWxdW291dF0gKi8gQk9PTCogZW5hYmxlZCk7CisgICAgCisgICAgdmlydHVh bCBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIHNldFNlYW1sZXNzSUZyYW1lc0VuYWJsZWQoCisg ICAgICAgIC8qIFtpbl0gKi8gQk9PTCk7CisgICAgCiAgICAgdmlydHVhbCBIUkVTVUxUIFNURE1F VEhPRENBTExUWVBFIGFsbG93c0FuaW1hdGVkSW1hZ2VzKCAKICAgICAgICAgLyogW3JldHZhbF1b b3V0XSAqLyBCT09MKiBlbmFibGVkKTsKICAgICAKSW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL1dl YlZpZXcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvd2luL1dlYlZpZXcuY3BwCShy ZXZpc2lvbiAxMzkxMjkpCisrKyBTb3VyY2UvV2ViS2l0L3dpbi9XZWJWaWV3LmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtNDY3Nyw2ICs0Njc3LDExIEBAIEhSRVNVTFQgV2ViVmlldzo6bm90aWZ5UHJl ZmVyZW5jZXNDaGFuZ2UKICAgICAgICAgcmV0dXJuIGhyOwogICAgIFJ1bnRpbWVFbmFibGVkRmVh dHVyZXM6OnNldENTU1JlZ2lvbnNFbmFibGVkKCEhZW5hYmxlZCk7CiAKKyAgICBociA9IHByZWZl cmVuY2VzLT5hcmVTZWFtbGVzc0lGcmFtZXNFbmFibGVkKCZlbmFibGVkKTsKKyAgICBpZiAoRkFJ TEVEKGhyKSkKKyAgICAgICAgcmV0dXJuIGhyOworICAgIFJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6 OnNldFNlYW1sZXNzSUZyYW1lc0VuYWJsZWQoISFlbmFibGVkKTsKKwogICAgIGhyID0gcHJlZmVy ZW5jZXMtPnByaXZhdGVCcm93c2luZ0VuYWJsZWQoJmVuYWJsZWQpOwogICAgIGlmIChGQUlMRUQo aHIpKQogICAgICAgICByZXR1cm4gaHI7CkluZGV4OiBTb3VyY2UvV2ViS2l0L3dpbi9JbnRlcmZh Y2VzL0lXZWJQcmVmZXJlbmNlcy5pZGwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC93aW4v SW50ZXJmYWNlcy9JV2ViUHJlZmVyZW5jZXMuaWRsCShyZXZpc2lvbiAxMzkxMjkpCisrKyBTb3Vy Y2UvV2ViS2l0L3dpbi9JbnRlcmZhY2VzL0lXZWJQcmVmZXJlbmNlcy5pZGwJKHdvcmtpbmcgY29w eSkKQEAgLTIxMCw0ICsyMTAsNyBAQCBpbnRlcmZhY2UgSVdlYlByZWZlcmVuY2VzIDogSVVua25v d24KIAogICAgIEhSRVNVTFQgaXNDU1NSZWdpb25zRW5hYmxlZChbb3V0LCByZXR2YWxdIEJPT0wq IGVuYWJsZWQpOwogICAgIEhSRVNVTFQgc2V0Q1NTUmVnaW9uc0VuYWJsZWQoW2luXSBCT09MIGVu YWJsZWQpOworCisgICAgSFJFU1VMVCBhcmVTZWFtbGVzc0lGcmFtZXNFbmFibGVkKFtvdXQsIHJl dHZhbF0gQk9PTCogZW5hYmxlZCk7CisgICAgSFJFU1VMVCBzZXRTZWFtbGVzc0lGcmFtZXNFbmFi bGVkKFtpbl0gQk9PTCBlbmFibGVkKTsKIH0K