106463 2013-01-09 09:26:56 -0800 PluginPackage::freeLibraryTimerFired asserts if plugin got loaded again meanwhile 2013-01-10 07:32:39 -0800 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 106140 0 faure webkit-unassigned andersca beidson webkit.review.bot oldest_to_newest 803389 0 faure 2013-01-09 09:26:56 -0800 When debugging why the patch in bug 106140 asserts in PluginPackage::freeLibraryTimerFired, it turns out that this is happening: PluginPackage::load libTestNetscapePlugIn.so m_loadCount=1 PluginPackage::unload libTestNetscapePlugIn.so m_loadCount now 0 PluginPackage::unloadWithoutShutdown libTestNetscapePlugIn.so m_loadCount=0 PluginPackage::freeLibrarySoon libTestNetscapePlugIn.so m_loadCount=0 (should be 0) PluginPackage::load libTestNetscapePlugIn.so m_loadCount=1 PluginPackage::freeLibraryTimerFired: unloading libTestNetscapePlugIn.so m_loadCount=1 (should be 0) If another webpage is loaded after the "scheduled unloading of the plugin via the timer", then we need to skip unloading the plugin. 803392 1 181936 faure 2013-01-09 09:30:02 -0800 Created attachment 181936 patch 803397 2 webkit.review.bot 2013-01-09 09:32:37 -0800 Attachment 181936 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/plugins/PluginPackage.cpp:71: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 803840 3 181936 ap 2013-01-09 16:57:22 -0800 Comment on attachment 181936 patch View in context: https://bugs.webkit.org/attachment.cgi?id=181936&action=review Looks reasonable. >> Source/WebCore/plugins/PluginPackage.cpp:71 >> + if (m_loadCount == 0) { > > Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] This is correct, please fix. 804164 4 182085 faure 2013-01-10 01:31:20 -0800 Created attachment 182085 patch with style fix 804366 5 182085 webkit.review.bot 2013-01-10 07:32:36 -0800 Comment on attachment 182085 patch with style fix Clearing flags on attachment: 182085 Committed r139318: <http://trac.webkit.org/changeset/139318> 804367 6 webkit.review.bot 2013-01-10 07:32:39 -0800 All reviewed patches have been landed. Closing bug. 181936 2013-01-09 09:30:02 -0800 2013-01-10 01:31:20 -0800 patch PluginPackage_unloadfix.diff text/plain 1364 faure ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3ZTBhNGExLi4xMzI4ZDM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTMtMDEtMDkgIERhdmlkIEZhdXJlICA8ZmF1cmVAa2RlLm9yZz4KKworICAgICAgICBQ bHVnaW5QYWNrYWdlOjpmcmVlTGlicmFyeVRpbWVyRmlyZWQgYXNzZXJ0cyBpZiBwbHVnaW4gZ290 IGxvYWRlZCBhZ2FpbiBtZWFud2hpbGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEwNjQ2MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgdGhpcyBjb2RlIHBhdGggd2lsbCBiZSB0ZXN0 ZWQgYnkgYnVnIDEwNjE0MC4KKworICAgICAgICAqIHBsdWdpbnMvUGx1Z2luUGFja2FnZS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpQbHVnaW5QYWNrYWdlOjpmcmVlTGlicmFyeVRpbWVyRmlyZWQp OiBza2lwIHVubG9hZGluZyBpZiBsb2FkZWQgYWdhaW4gbWVhbndoaWxlLgorCiAyMDEzLTAxLTA0 ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgSFRNTFRyZWVCdWls ZGVyIHNob3VsZCBBU1NFUlQgdGhhdCBpdCBpcyBvbiB0aGUgbWFpbiB0aHJlYWQgYmVmb3JlIHRv dWNoaW5nIGVsZW1lbnRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5zL1BsdWdp blBhY2thZ2UuY3BwIGIvU291cmNlL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5QYWNrYWdlLmNwcApp bmRleCAwNWIzZWI2Li44OTdjZmNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5z L1BsdWdpblBhY2thZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luUGFj a2FnZS5jcHAKQEAgLTY3LDEwICs2NywxMSBAQCB2b2lkIFBsdWdpblBhY2thZ2U6OmZyZWVMaWJy YXJ5U29vbigpCiB2b2lkIFBsdWdpblBhY2thZ2U6OmZyZWVMaWJyYXJ5VGltZXJGaXJlZChUaW1l cjxQbHVnaW5QYWNrYWdlPiopCiB7CiAgICAgQVNTRVJUKG1fbW9kdWxlKTsKLSAgICBBU1NFUlQo IW1fbG9hZENvdW50KTsKLQotICAgIHVubG9hZE1vZHVsZShtX21vZHVsZSk7Ci0gICAgbV9tb2R1 bGUgPSAwOworICAgIC8vIERvIG5vdGhpbmcgaWYgdGhlIG1vZHVsZSBnb3QgbG9hZGVkIGFnYWlu IG1lYW53aGlsZQorICAgIGlmIChtX2xvYWRDb3VudCA9PSAwKSB7CisgICAgICAgIHVubG9hZE1v ZHVsZShtX21vZHVsZSk7CisgICAgICAgIG1fbW9kdWxlID0gMDsKKyAgICB9CiB9CiAKIAo= 182085 2013-01-10 01:31:20 -0800 2013-01-10 07:32:36 -0800 patch with style fix PluginPackage_unloadfix.diff text/plain 1360 faure ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3ZTBhNGExLi4xMzI4ZDM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTMtMDEtMDkgIERhdmlkIEZhdXJlICA8ZmF1cmVAa2RlLm9yZz4KKworICAgICAgICBQ bHVnaW5QYWNrYWdlOjpmcmVlTGlicmFyeVRpbWVyRmlyZWQgYXNzZXJ0cyBpZiBwbHVnaW4gZ290 IGxvYWRlZCBhZ2FpbiBtZWFud2hpbGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEwNjQ2MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgdGhpcyBjb2RlIHBhdGggd2lsbCBiZSB0ZXN0 ZWQgYnkgYnVnIDEwNjE0MC4KKworICAgICAgICAqIHBsdWdpbnMvUGx1Z2luUGFja2FnZS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpQbHVnaW5QYWNrYWdlOjpmcmVlTGlicmFyeVRpbWVyRmlyZWQp OiBza2lwIHVubG9hZGluZyBpZiBsb2FkZWQgYWdhaW4gbWVhbndoaWxlLgorCiAyMDEzLTAxLTA0 ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgSFRNTFRyZWVCdWls ZGVyIHNob3VsZCBBU1NFUlQgdGhhdCBpdCBpcyBvbiB0aGUgbWFpbiB0aHJlYWQgYmVmb3JlIHRv dWNoaW5nIGVsZW1lbnRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5zL1BsdWdp blBhY2thZ2UuY3BwIGIvU291cmNlL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5QYWNrYWdlLmNwcApp bmRleCAwNWIzZWI2Li40ZDM3MmY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5z L1BsdWdpblBhY2thZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luUGFj a2FnZS5jcHAKQEAgLTY3LDEwICs2NywxMSBAQCB2b2lkIFBsdWdpblBhY2thZ2U6OmZyZWVMaWJy YXJ5U29vbigpCiB2b2lkIFBsdWdpblBhY2thZ2U6OmZyZWVMaWJyYXJ5VGltZXJGaXJlZChUaW1l cjxQbHVnaW5QYWNrYWdlPiopCiB7CiAgICAgQVNTRVJUKG1fbW9kdWxlKTsKLSAgICBBU1NFUlQo IW1fbG9hZENvdW50KTsKLQotICAgIHVubG9hZE1vZHVsZShtX21vZHVsZSk7Ci0gICAgbV9tb2R1 bGUgPSAwOworICAgIC8vIERvIG5vdGhpbmcgaWYgdGhlIG1vZHVsZSBnb3QgbG9hZGVkIGFnYWlu IG1lYW53aGlsZQorICAgIGlmICghbV9sb2FkQ291bnQpIHsKKyAgICAgICAgdW5sb2FkTW9kdWxl KG1fbW9kdWxlKTsKKyAgICAgICAgbV9tb2R1bGUgPSAwOworICAgIH0KIH0KIAogCg==