<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>106448</bug_id>
          
          <creation_ts>2013-01-09 06:07:01 -0800</creation_ts>
          <short_desc>Regression(r138681) : Add HAVE(ACCESSIBILITY) guard to atk files, fix for a fix.</short_desc>
          <delta_ts>2013-01-09 09:02:13 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Accessibility</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>103162</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Hugo Parente Lima">hugo.lima</reporter>
          <assigned_to name="Hugo Parente Lima">hugo.lima</assigned_to>
          <cc>aboxhall</cc>
    
    <cc>apinheiro</cc>
    
    <cc>cfleizach</cc>
    
    <cc>dmazzoni</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>jdiggs</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>803274</commentid>
    <comment_count>0</comment_count>
    <who name="Hugo Parente Lima">hugo.lima</who>
    <bug_when>2013-01-09 06:07:01 -0800</bug_when>
    <thetext>Some atk files don&apos;t use HAVE(ACCESSIBILITY). It may makes build errors when the macro isn&apos;t enabled, this was partially fixed by bug 106290, but in some files the include &quot;atk.h&quot; was left outside the guard.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>803285</commentid>
    <comment_count>1</comment_count>
      <attachid>181911</attachid>
    <who name="Hugo Parente Lima">hugo.lima</who>
    <bug_when>2013-01-09 06:19:17 -0800</bug_when>
    <thetext>Created attachment 181911
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>803288</commentid>
    <comment_count>2</comment_count>
      <attachid>181911</attachid>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2013-01-09 06:23:51 -0800</bug_when>
    <thetext>Comment on attachment 181911
Patch

I missed this. Thanks.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>803368</commentid>
    <comment_count>3</comment_count>
      <attachid>181911</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-01-09 09:02:08 -0800</bug_when>
    <thetext>Comment on attachment 181911
Patch

Clearing flags on attachment: 181911

Committed r139196: &lt;http://trac.webkit.org/changeset/139196&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>803369</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-01-09 09:02:13 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>181911</attachid>
            <date>2013-01-09 06:19:17 -0800</date>
            <delta_ts>2013-01-09 09:02:08 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-106448-20130109111506.patch</filename>
            <type>text/plain</type>
            <size>3615</size>
            <attacher name="Hugo Parente Lima">hugo.lima</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5MTg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWQ4MjNiZGE1OWE0YTc4
MDU3MzE0NDcyMzMxZjVlY2RmN2RlZjA3Yy4uNGU4ZDg5NzEzM2RiNGUwZjAzYzgxMGEwOTUzY2Iy
ZWRjNjEzY2Y5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAxLTA5ICBIdWdv
IFBhcmVudGUgTGltYSAgPGh1Z28ubGltYUBvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIFJlZ3Jl
c3Npb24ocjEzODY4MSkgOiBBZGQgSEFWRShBQ0NFU1NJQklMSVRZKSBndWFyZCB0byBhdGsgZmls
ZXMsIGZpeCBmb3IgYSBmaXguCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df
YnVnLmNnaT9pZD0xMDY0NDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K
KworICAgICAgICBTb21lIGF0ayBmaWxlcyBkb24ndCB1c2UgSEFWRShBQ0NFU1NJQklMSVRZKS4g
SXQgbWlnaHQgbWFrZSBidWlsZCBlcnJvcnMgd2hlbgorICAgICAgICB0aGUgbWFjcm8gaXNuJ3Qg
ZW5hYmxlZC4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVI
eXBlcmxpbmsuaDoKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRBY2Nlc3NpYmxl
SW50ZXJmYWNlQWN0aW9uLmg6CisgICAgICAgICogYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNj
ZXNzaWJsZUludGVyZmFjZUNvbXBvbmVudC5oOgorICAgICAgICAqIGFjY2Vzc2liaWxpdHkvYXRr
L1dlYktpdEFjY2Vzc2libGVJbnRlcmZhY2VIeXBlcnRleHQuaDoKKwogMjAxMy0wMS0wOSAgQ2Fy
bG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZp
ZXdlZC4gRml4IG1ha2UgZGlzdGNoZWNrLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYWNj
ZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZUh5cGVybGluay5oIGIvU291cmNlL1dlYkNv
cmUvYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZUh5cGVybGluay5oCmluZGV4IDhj
NWRiZWJiNjA5NjZhYzZkMGU4ZjM4ZDY4ZDY1YTViZjQ3NmYyNmMuLjU5Y2E3M2NlYTcwMzQ2OWI5
MjRlMjk3MjhlOWQ4YTNmMDZmYWI4NzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vz
c2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVIeXBlcmxpbmsuaAorKysgYi9Tb3VyY2UvV2Vi
Q29yZS9hY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRBY2Nlc3NpYmxlSHlwZXJsaW5rLmgKQEAgLTIw
LDEwICsyMCwxMCBAQAogI2lmbmRlZiBXZWJLaXRBY2Nlc3NpYmxlSHlwZXJsaW5rX2gKICNkZWZp
bmUgV2ViS2l0QWNjZXNzaWJsZUh5cGVybGlua19oCiAKLSNpbmNsdWRlIDxhdGsvYXRrLmg+Ci0K
ICNpZiBIQVZFKEFDQ0VTU0lCSUxJVFkpCiAKKyNpbmNsdWRlIDxhdGsvYXRrLmg+CisKIG5hbWVz
cGFjZSBXZWJDb3JlIHsKIGNsYXNzIEFjY2Vzc2liaWxpdHlPYmplY3Q7CiB9CmRpZmYgLS1naXQg
YS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRBY2Nlc3NpYmxlSW50ZXJm
YWNlQWN0aW9uLmggYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRBY2Nl
c3NpYmxlSW50ZXJmYWNlQWN0aW9uLmgKaW5kZXggNzY2YzQzZTljZTZhYzBlYzk3ZGZmZmRkN2M3
ZmNhYWMzMjM3ZWQzNy4uYTBkZTYzZmQ3NWM0NWQ5Y2Y4MmJhYjUyODE3MTM4MjkwNzA0ODljNiAx
MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNz
aWJsZUludGVyZmFjZUFjdGlvbi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkv
YXRrL1dlYktpdEFjY2Vzc2libGVJbnRlcmZhY2VBY3Rpb24uaApAQCAtMjIsMTAgKzIyLDEwIEBA
CiAjaWZuZGVmIFdlYktpdEFjY2Vzc2libGVJbnRlcmZhY2VBY3Rpb25faAogI2RlZmluZSBXZWJL
aXRBY2Nlc3NpYmxlSW50ZXJmYWNlQWN0aW9uX2gKIAotI2luY2x1ZGUgPGF0ay9hdGsuaD4KLQog
I2lmIEhBVkUoQUNDRVNTSUJJTElUWSkKIAorI2luY2x1ZGUgPGF0ay9hdGsuaD4KKwogdm9pZCB3
ZWJraXRBY2Nlc3NpYmxlQWN0aW9uSW50ZXJmYWNlSW5pdChBdGtBY3Rpb25JZmFjZSopOwogCiAj
ZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRrL1dlYktp
dEFjY2Vzc2libGVJbnRlcmZhY2VDb21wb25lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2li
aWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVJbnRlcmZhY2VDb21wb25lbnQuaAppbmRleCAwMTM2
MmFiZDI2MDQ2ODlmMjIwMzUwNDM4NTI3MTg5NzUwZmQ3YjdkLi40Y2NmZDk3YTRiOTA5YmQzOTQ2
NmUwMGQ5NmIxZjAzNjdmOTgyYzRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3Np
YmlsaXR5L2F0ay9XZWJLaXRBY2Nlc3NpYmxlSW50ZXJmYWNlQ29tcG9uZW50LmgKKysrIGIvU291
cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZUludGVyZmFjZUNv
bXBvbmVudC5oCkBAIC0yMiw4ICsyMiwxMiBAQAogI2lmbmRlZiBXZWJLaXRBY2Nlc3NpYmxlSW50
ZXJmYWNlQ29tcG9uZW50X2gKICNkZWZpbmUgV2ViS2l0QWNjZXNzaWJsZUludGVyZmFjZUNvbXBv
bmVudF9oCiAKKyNpZiBIQVZFKEFDQ0VTU0lCSUxJVFkpCisKICNpbmNsdWRlIDxhdGsvYXRrLmg+
CiAKIHZvaWQgd2Via2l0QWNjZXNzaWJsZUNvbXBvbmVudEludGVyZmFjZUluaXQoQXRrQ29tcG9u
ZW50SWZhY2UqKTsKIAorI2VuZGlmCisKICNlbmRpZiAvLyBXZWJLaXRBY2Nlc3NpYmxlSW50ZXJm
YWNlQ29tcG9uZW50X2gKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkv
YXRrL1dlYktpdEFjY2Vzc2libGVJbnRlcmZhY2VIeXBlcnRleHQuaCBiL1NvdXJjZS9XZWJDb3Jl
L2FjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVJbnRlcmZhY2VIeXBlcnRleHQuaApp
bmRleCAyYWIyMzYwYzUzNzc5ODE5NDYxZDE0YTYyZTA5NzI1YjNmNzUyNzZjLi43YTNhMDg5MmFj
MGJhZmVmZGU2YTJhZTI5ZGU2NTIwYWU5NTI1ZjY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9hY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRBY2Nlc3NpYmxlSW50ZXJmYWNlSHlwZXJ0ZXh0LmgK
KysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZUlu
dGVyZmFjZUh5cGVydGV4dC5oCkBAIC0yMCw4ICsyMCwxMiBAQAogI2lmbmRlZiBXZWJLaXRBY2Nl
c3NpYmxlSW50ZXJmYWNlSHlwZXJ0ZXh0X2gKICNkZWZpbmUgV2ViS2l0QWNjZXNzaWJsZUludGVy
ZmFjZUh5cGVydGV4dF9oCiAKKyNpZiBIQVZFKEFDQ0VTU0lCSUxJVFkpCisKICNpbmNsdWRlIDxh
dGsvYXRrLmg+CiAKIHZvaWQgd2Via2l0QWNjZXNzaWJsZUh5cGVydGV4dEludGVyZmFjZUluaXQo
QXRrSHlwZXJ0ZXh0SWZhY2UqKTsKIAorI2VuZGlmCisKICNlbmRpZiAvLyBXZWJLaXRBY2Nlc3Np
YmxlSW50ZXJmYWNlSHlwZXJ0ZXh0X2gK
</data>

          </attachment>
      

    </bug>

</bugzilla>