106442 2013-01-09 04:32:32 -0800 IndexedDB: Remove ASSERTs that can't assert but result in compiler warnings 2013-01-09 07:39:40 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jussi.kukkonen jussi.kukkonen alecflett cdumez haraken jsbell jussi.kukkonen webkit.review.bot oldest_to_newest 803227 0 jussi.kukkonen 2013-01-09 04:32:32 -0800 IDBLevelDBCoding::m_metaDataType has been changed to unsigned so ASSERT(m_metaDataType >= 0) is not useful: it does create build problems at least with EFL. Attaching patch. 803229 1 181896 jussi.kukkonen 2013-01-09 04:40:39 -0800 Created attachment 181896 Patch 803231 2 cdumez 2013-01-09 04:45:09 -0800 How about this? > ObjectStoreMetaDataKey::ObjectStoreMetaDataKey() > : m_objectStoreId(-1) > , m_metaDataType(-1) > { > } 803236 3 181896 haraken 2013-01-09 04:57:28 -0800 Comment on attachment 181896 Patch OK 803247 4 jussi.kukkonen 2013-01-09 05:19:03 -0800 (In reply to comment #2) > How about this? > > > ObjectStoreMetaDataKey::ObjectStoreMetaDataKey() > > : m_objectStoreId(-1) > > , m_metaDataType(-1) > > { > > } Good that you mentioned, I was planning to but forgot. It's ugly but should work, assuming that presents a metadatatype that does not exist: see "enum MetaDataType" in the header for the 'good' values of metadatatype. We could add a unsetObjectStoreMetaDataType but that shouldn't be part of this patch I guess. 803308 5 181896 haraken 2013-01-09 06:59:06 -0800 Comment on attachment 181896 Patch Please fix the issue Christophe pointed out in a follow-up patch. 803334 6 181896 webkit.review.bot 2013-01-09 07:39:36 -0800 Comment on attachment 181896 Patch Clearing flags on attachment: 181896 Committed r139193: <http://trac.webkit.org/changeset/139193> 803335 7 webkit.review.bot 2013-01-09 07:39:40 -0800 All reviewed patches have been landed. Closing bug. 181896 2013-01-09 04:40:39 -0800 2013-01-09 07:39:36 -0800 Patch bug-106442-20130109143742.patch text/plain 1896 jussi.kukkonen U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4OTM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODFlMWE4MTZjN2UwNzEy YzAxYWI5M2I5MDM0YjQ3NDgwNGExOTUzMS4uNzk3Mjk3YmJlNTVkNGIwMDJmYTA2ZWUwNzk3Y2Rl MDk1Mzg0ZWQzMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAxLTA5ICBKdXNz aSBLdWtrb25lbiAgPGp1c3NpLmt1a2tvbmVuQGludGVsLmNvbT4KKworICAgICAgICBJbmRleGVk REI6IFJlbW92ZSBBU1NFUlRzIHRoYXQgY2FuJ3QgYXNzZXJ0IGJ1dCByZXN1bHQgaW4gY29tcGls ZXIgd2FybmluZ3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEwNjQ0MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIElEQkxldmVsREJDb2Rpbmc6Om1fbWV0YURhdGFUeXBlIGhhcyBiZWVuIGNoYW5nZWQgdG8g dW5zaWduZWQKKyAgICAgICAgc28gQVNTRVJUKG1fbWV0YURhdGFUeXBlID49IDApIGlzIG5vIGxv bmdlciB1c2VmdWw6IHRoZSBjb21waWxlcgorICAgICAgICB3YXJuaW5ncyBob3dldmVyIGNyZWF0 ZSBidWlsZCBkaWZmaWN1bHRpZXMgYXQgbGVhc3Qgd2l0aCBFRkwuCisKKyAgICAgICAgKiBNb2R1 bGVzL2luZGV4ZWRkYi9JREJMZXZlbERCQ29kaW5nLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OklE QkxldmVsREJDb2Rpbmc6Ok9iamVjdFN0b3JlTWV0YURhdGFLZXk6Om1ldGFEYXRhVHlwZSk6Cisg ICAgICAgIChXZWJDb3JlOjpJREJMZXZlbERCQ29kaW5nOjpPYmplY3RTdG9yZU1ldGFEYXRhS2V5 Ojpjb21wYXJlKToKKwogMjAxMy0wMS0wNyAgSGF5YXRvIEl0byAgPGhheWF0b0BjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgQ2Fubm90IGNvbXBpbGUgd2l0aCBFTkFCTEVfU0hBRE9XX0RPTT0wIGFu ZCBFTkFCTEVfU1RZTEVfU0NPUEVEPTEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVs ZXMvaW5kZXhlZGRiL0lEQkxldmVsREJDb2RpbmcuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxl cy9pbmRleGVkZGIvSURCTGV2ZWxEQkNvZGluZy5jcHAKaW5kZXggMWRhZWRiMGFlNzhiZmIwN2Vl ZTc3MDNkODhiYjk4MWQ0ODFhZDViYy4uZGFjZDU0MWQyNWNiNDYzOTkwNWU1OGRiM2RjOGQ4YmE0 NDUyNThjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURC TGV2ZWxEQkNvZGluZy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIv SURCTGV2ZWxEQkNvZGluZy5jcHAKQEAgLTEyMjMsMTQgKzEyMjMsMTIgQEAgaW50NjRfdCBPYmpl Y3RTdG9yZU1ldGFEYXRhS2V5OjpvYmplY3RTdG9yZUlkKCkgY29uc3QKIH0KIHVuc2lnbmVkIGNo YXIgT2JqZWN0U3RvcmVNZXRhRGF0YUtleTo6bWV0YURhdGFUeXBlKCkgY29uc3QKIHsKLSAgICBB U1NFUlQobV9tZXRhRGF0YVR5cGUgPj0gMCk7CiAgICAgcmV0dXJuIG1fbWV0YURhdGFUeXBlOwog fQogCiBpbnQgT2JqZWN0U3RvcmVNZXRhRGF0YUtleTo6Y29tcGFyZShjb25zdCBPYmplY3RTdG9y ZU1ldGFEYXRhS2V5JiBvdGhlcikKIHsKICAgICBBU1NFUlQobV9vYmplY3RTdG9yZUlkID49IDAp OwotICAgIEFTU0VSVChtX21ldGFEYXRhVHlwZSA+PSAwKTsKICAgICBpZiAoaW50IHggPSBjb21w YXJlSW50cyhtX29iamVjdFN0b3JlSWQsIG90aGVyLm1fb2JqZWN0U3RvcmVJZCkpCiAgICAgICAg IHJldHVybiB4OwogICAgIGludDY0X3QgcmVzdWx0ID0gbV9tZXRhRGF0YVR5cGUgLSBvdGhlci5t X21ldGFEYXRhVHlwZTsK