106437 2013-01-09 03:12:42 -0800 Document::setActiveNode() should be Document::setActiveElement() 2013-01-09 09:42:35 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 morrita morrita eric ojan.autocc rniwa webkit.review.bot oldest_to_newest 803189 0 morrita 2013-01-09 03:12:42 -0800 This is a follow up patch of Bug 106193. 803238 1 181898 morrita 2013-01-09 04:59:13 -0800 Created attachment 181898 Patch 803410 2 181898 webkit.review.bot 2013-01-09 09:42:32 -0800 Comment on attachment 181898 Patch Clearing flags on attachment: 181898 Committed r139199: <http://trac.webkit.org/changeset/139199> 803411 3 webkit.review.bot 2013-01-09 09:42:35 -0800 All reviewed patches have been landed. Closing bug. 181898 2013-01-09 04:59:13 -0800 2013-01-09 09:42:32 -0800 Patch bug-106437-20130109215617.patch text/plain 6818 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5MTgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODVhYjU0M2UxYjE1ZGYy MzkyYzdjZDlmNDI1ODhlODU3N2NmYmIyMy4uNDYzNDk2OGViM2VhNWQxZGY4NDI4MGY2NTJlMDNh NGQzMDc2MjE3YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEzLTAxLTA5ICBIYWpp bWUgTW9ycml0YSAgPG1vcnJpdGFAZ29vZ2xlLmNvbT4KKworICAgICAgICBEb2N1bWVudDo6c2V0 QWN0aXZlTm9kZSgpIHNob3VsZCBiZSBEb2N1bWVudDo6c2V0QWN0aXZlRWxlbWVudCgpCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDY0MzcKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMu IE5vIGZ1bmN0b2luYWwgY2hhbmdlLgorCisgICAgICAgICogZG9tL0RvY3VtZW50LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkRvY3VtZW50OjpzZXRBY3RpdmVFbGVtZW50KToKKyAgICAgICAgKFdl YkNvcmU6OkRvY3VtZW50Ojp1cGRhdGVIb3ZlckFjdGl2ZVN0YXRlKToKKyAgICAgICAgKiBkb20v RG9jdW1lbnQuaDoKKyAgICAgICAgKERvY3VtZW50KToKKyAgICAgICAgKiByZW5kZXJpbmcvSGl0 VGVzdFJlc3VsdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIaXRUZXN0UmVzdWx0Ojppbm5lckVs ZW1lbnQpOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgICogcmVuZGVyaW5nL0hpdFRlc3RS ZXN1bHQuaDoKKyAgICAgICAgKEhpdFRlc3RSZXN1bHQpOgorCiAyMDEzLTAxLTA5ICBLdW5paGlr byBTYWthbW90byAgPGtzYWthbW90b0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgSU5QVVRfTVVM VElQTEVfRklFTERTX1VJOiBtaW4vbWF4IGF0dHJpYnV0ZXMgc2hvdWxkIG5vdCBtYWtlIGFsbCBm aWVsZHMgcmVhZC1vbmx5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQu Y3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAppbmRleCA2YWQwNmYyMTE3NTZj ODYzYjg0NDFjNDFkOGY1OGE2ZDEwY2M0ZmJjLi40OWJmZGU5ZWI0ZmExMzg5ODUyMTNiNTJlMjE1 MGNhNjA3NjA0ZWQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKQEAgLTMyMzQsMTQgKzMyMzQs MTQgQEAgdm9pZCBEb2N1bWVudDo6c2V0SG92ZXJOb2RlKFBhc3NSZWZQdHI8Tm9kZT4gbmV3SG92 ZXJOb2RlKQogICAgIG1faG92ZXJOb2RlID0gbmV3SG92ZXJOb2RlOwogfQogCi12b2lkIERvY3Vt ZW50OjpzZXRBY3RpdmVOb2RlKFBhc3NSZWZQdHI8Tm9kZT4gbmV3QWN0aXZlTm9kZSkKK3ZvaWQg RG9jdW1lbnQ6OnNldEFjdGl2ZUVsZW1lbnQoUGFzc1JlZlB0cjxFbGVtZW50PiBuZXdBY3RpdmVF bGVtZW50KQogewotICAgIGlmICghbmV3QWN0aXZlTm9kZSkgeworICAgIGlmICghbmV3QWN0aXZl RWxlbWVudCkgewogICAgICAgICBtX2FjdGl2ZUVsZW1lbnQuY2xlYXIoKTsKICAgICAgICAgcmV0 dXJuOwogICAgIH0KIAotICAgIG1fYWN0aXZlRWxlbWVudCA9IG5ld0FjdGl2ZU5vZGUtPmlzRWxl bWVudE5vZGUoKSA/IHRvRWxlbWVudChuZXdBY3RpdmVOb2RlLmdldCgpKSA6IG5ld0FjdGl2ZU5v ZGUtPnBhcmVudEVsZW1lbnQoKTsKKyAgICBtX2FjdGl2ZUVsZW1lbnQgPSBuZXdBY3RpdmVFbGVt ZW50OwogfQogCiB2b2lkIERvY3VtZW50Ojpmb2N1c2VkTm9kZVJlbW92ZWQoKQpAQCAtNTgwOCwz NSArNTgwOCwzNiBAQCB2b2lkIERvY3VtZW50Ojp1cGRhdGVIb3ZlckFjdGl2ZVN0YXRlKGNvbnN0 IEhpdFRlc3RSZXF1ZXN0JiByZXF1ZXN0LCBIaXRUZXN0UmVzdQogICAgIGlmIChyZXF1ZXN0LnJl YWRPbmx5KCkpCiAgICAgICAgIHJldHVybjsKIAotICAgIE5vZGUqIGlubmVyTm9kZUluRG9jdW1l bnQgPSByZXN1bHQuaW5uZXJOb2RlKCk7Ci0gICAgQVNTRVJUKCFpbm5lck5vZGVJbkRvY3VtZW50 IHx8IGlubmVyTm9kZUluRG9jdW1lbnQtPmRvY3VtZW50KCkgPT0gdGhpcyk7CisgICAgRWxlbWVu dCogaW5uZXJFbGVtZW50SW5Eb2N1bWVudCA9IHJlc3VsdC5pbm5lckVsZW1lbnQoKTsKKyAgICBB U1NFUlQoIWlubmVyRWxlbWVudEluRG9jdW1lbnQgfHwgaW5uZXJFbGVtZW50SW5Eb2N1bWVudC0+ ZG9jdW1lbnQoKSA9PSB0aGlzKTsKIAotICAgIE5vZGUqIG9sZEFjdGl2ZU5vZGUgPSBhY3RpdmVF bGVtZW50KCk7Ci0gICAgaWYgKG9sZEFjdGl2ZU5vZGUgJiYgIXJlcXVlc3QuYWN0aXZlKCkpIHsK KyAgICBFbGVtZW50KiBvbGRBY3RpdmVFbGVtZW50ID0gYWN0aXZlRWxlbWVudCgpOworICAgIGlm IChvbGRBY3RpdmVFbGVtZW50ICYmICFyZXF1ZXN0LmFjdGl2ZSgpKSB7CiAgICAgICAgIC8vIFdl IGFyZSBjbGVhcmluZyB0aGUgOmFjdGl2ZSBjaGFpbiBiZWNhdXNlIHRoZSBtb3VzZSBoYXMgYmVl biByZWxlYXNlZC4KLSAgICAgICAgZm9yIChSZW5kZXJPYmplY3QqIGN1cnIgPSBvbGRBY3RpdmVO b2RlLT5yZW5kZXJlcigpOyBjdXJyOyBjdXJyID0gY3Vyci0+cGFyZW50KCkpIHsKLSAgICAgICAg ICAgIGlmIChjdXJyLT5ub2RlKCkgJiYgIWN1cnItPmlzVGV4dCgpKSB7CisgICAgICAgIGZvciAo UmVuZGVyT2JqZWN0KiBjdXJyID0gb2xkQWN0aXZlRWxlbWVudC0+cmVuZGVyZXIoKTsgY3Vycjsg Y3VyciA9IGN1cnItPnBhcmVudCgpKSB7CisgICAgICAgICAgICBpZiAoY3Vyci0+bm9kZSgpKSB7 CisgICAgICAgICAgICAgICAgQVNTRVJUKCFjdXJyLT5ub2RlKCktPmlzVGV4dE5vZGUoKSk7CiAg ICAgICAgICAgICAgICAgY3Vyci0+bm9kZSgpLT5zZXRBY3RpdmUoZmFsc2UpOwogICAgICAgICAg ICAgICAgIG1fdXNlckFjdGlvbkVsZW1lbnRzLnNldEluQWN0aXZlQ2hhaW4oY3Vyci0+bm9kZSgp LCBmYWxzZSk7CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KLSAgICAgICAgc2V0QWN0aXZlTm9k ZSgwKTsKKyAgICAgICAgc2V0QWN0aXZlRWxlbWVudCgwKTsKICAgICB9IGVsc2UgewotICAgICAg ICBOb2RlKiBuZXdBY3RpdmVOb2RlID0gaW5uZXJOb2RlSW5Eb2N1bWVudDsKLSAgICAgICAgaWYg KCFvbGRBY3RpdmVOb2RlICYmIG5ld0FjdGl2ZU5vZGUgJiYgcmVxdWVzdC5hY3RpdmUoKSAmJiAh cmVxdWVzdC50b3VjaE1vdmUoKSkgeworICAgICAgICBFbGVtZW50KiBuZXdBY3RpdmVFbGVtZW50 ID0gaW5uZXJFbGVtZW50SW5Eb2N1bWVudDsKKyAgICAgICAgaWYgKCFvbGRBY3RpdmVFbGVtZW50 ICYmIG5ld0FjdGl2ZUVsZW1lbnQgJiYgcmVxdWVzdC5hY3RpdmUoKSAmJiAhcmVxdWVzdC50b3Vj aE1vdmUoKSkgewogICAgICAgICAgICAgLy8gV2UgYXJlIHNldHRpbmcgdGhlIDphY3RpdmUgY2hh aW4gYW5kIGZyZWV6aW5nIGl0LiBJZiBmdXR1cmUgbW92ZXMgaGFwcGVuLCB0aGV5CiAgICAgICAg ICAgICAvLyB3aWxsIG5lZWQgdG8gcmVmZXJlbmNlIHRoaXMgY2hhaW4uCi0gICAgICAgICAgICBm b3IgKFJlbmRlck9iamVjdCogY3VyciA9IG5ld0FjdGl2ZU5vZGUtPnJlbmRlcmVyKCk7IGN1cnI7 IGN1cnIgPSBjdXJyLT5wYXJlbnQoKSkgeworICAgICAgICAgICAgZm9yIChSZW5kZXJPYmplY3Qq IGN1cnIgPSBuZXdBY3RpdmVFbGVtZW50LT5yZW5kZXJlcigpOyBjdXJyOyBjdXJyID0gY3Vyci0+ cGFyZW50KCkpIHsKICAgICAgICAgICAgICAgICBpZiAoY3Vyci0+bm9kZSgpICYmICFjdXJyLT5p c1RleHQoKSkKICAgICAgICAgICAgICAgICAgICAgbV91c2VyQWN0aW9uRWxlbWVudHMuc2V0SW5B Y3RpdmVDaGFpbihjdXJyLT5ub2RlKCksIHRydWUpOwogICAgICAgICAgICAgfQogCi0gICAgICAg ICAgICBzZXRBY3RpdmVOb2RlKG5ld0FjdGl2ZU5vZGUpOworICAgICAgICAgICAgc2V0QWN0aXZl RWxlbWVudChuZXdBY3RpdmVFbGVtZW50KTsKICAgICAgICAgfQogICAgIH0KICAgICAvLyBJZiB0 aGUgbW91c2UgaGFzIGp1c3QgYmVlbiBwcmVzc2VkLCBzZXQgOmFjdGl2ZSBvbiB0aGUgY2hhaW4u IFRob3NlIChhbmQgb25seSB0aG9zZSkKICAgICAvLyBub2RlcyBzaG91bGQgcmVtYWluIDphY3Rp dmUgdW50aWwgdGhlIG1vdXNlIGlzIHJlbGVhc2VkLgotICAgIGJvb2wgYWxsb3dBY3RpdmVDaGFu Z2VzID0gIW9sZEFjdGl2ZU5vZGUgJiYgYWN0aXZlRWxlbWVudCgpOworICAgIGJvb2wgYWxsb3dB Y3RpdmVDaGFuZ2VzID0gIW9sZEFjdGl2ZUVsZW1lbnQgJiYgYWN0aXZlRWxlbWVudCgpOwogCiAg ICAgLy8gSWYgdGhlIG1vdXNlIGlzIGRvd24gYW5kIGlmIHRoaXMgaXMgYSBtb3VzZSBtb3ZlIGV2 ZW50LCB3ZSB3YW50IHRvIHJlc3RyaWN0IGNoYW5nZXMgaW4KICAgICAvLyA6aG92ZXIvOmFjdGl2 ZSB0byBvbmx5IGFwcGx5IHRvIGVsZW1lbnRzIHRoYXQgYXJlIGluIHRoZSA6YWN0aXZlIGNoYWlu IHRoYXQgd2UgZnJvemUKQEAgLTU4NTksNyArNTg2MCw3IEBAIHZvaWQgRG9jdW1lbnQ6OnVwZGF0 ZUhvdmVyQWN0aXZlU3RhdGUoY29uc3QgSGl0VGVzdFJlcXVlc3QmIHJlcXVlc3QsIEhpdFRlc3RS ZXN1CiAKICAgICAvLyBDaGVjayB0byBzZWUgaWYgdGhlIGhvdmVyZWQgbm9kZSBoYXMgY2hhbmdl ZC4KICAgICAvLyBJZiBpdCBoYXNuJ3QsIHdlIGRvIG5vdCBuZWVkIHRvIGRvIGFueXRoaW5nLgot ICAgIE5vZGUqIG5ld0hvdmVyTm9kZSA9IGlubmVyTm9kZUluRG9jdW1lbnQ7CisgICAgTm9kZSog bmV3SG92ZXJOb2RlID0gaW5uZXJFbGVtZW50SW5Eb2N1bWVudDsKICAgICB3aGlsZSAobmV3SG92 ZXJOb2RlICYmICFuZXdIb3Zlck5vZGUtPnJlbmRlcmVyKCkpCiAgICAgICAgIG5ld0hvdmVyTm9k ZSA9IG5ld0hvdmVyTm9kZS0+cGFyZW50T3JIb3N0Tm9kZSgpOwogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5o CmluZGV4IDI4ZDQ2YTEyNTc2OTEyM2NhYzZjMGJkOWU4NTU5MTA5YTVmMGQ5NTUuLmE5YzU5ODY2 NTQ4OGJiNDkwNWYyYjM3N2ZlNjM2YThhODdlYTQwYzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2RvbS9Eb2N1bWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oCkBA IC02OTksNyArNjk5LDcgQEAgcHVibGljOgogICAgIHZvaWQgc2V0SG92ZXJOb2RlKFBhc3NSZWZQ dHI8Tm9kZT4pOwogICAgIE5vZGUqIGhvdmVyTm9kZSgpIGNvbnN0IHsgcmV0dXJuIG1faG92ZXJO b2RlLmdldCgpOyB9CiAKLSAgICB2b2lkIHNldEFjdGl2ZU5vZGUoUGFzc1JlZlB0cjxOb2RlPik7 CisgICAgdm9pZCBzZXRBY3RpdmVFbGVtZW50KFBhc3NSZWZQdHI8RWxlbWVudD4pOwogICAgIEVs ZW1lbnQqIGFjdGl2ZUVsZW1lbnQoKSBjb25zdCB7IHJldHVybiBtX2FjdGl2ZUVsZW1lbnQuZ2V0 KCk7IH0KIAogICAgIHZvaWQgZm9jdXNlZE5vZGVSZW1vdmVkKCk7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvSGl0VGVzdFJlc3VsdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvSGl0VGVzdFJlc3VsdC5jcHAKaW5kZXggY2ZmZGY3ODA2OGNiNzdkNzZjYzIzMWU1 NWZjNzhmMTlkZDU4ZTdiNi4uNjMzYmRkZjNlY2U4ZDdiMjljYjZjOGNmOWFhNmQwOWY1NWE2NzJh NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0hpdFRlc3RSZXN1bHQuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9IaXRUZXN0UmVzdWx0LmNwcApAQCAtNzk0 LDQgKzc5NCwxNCBAQCBOb2RlKiBIaXRUZXN0UmVzdWx0Ojp0YXJnZXROb2RlKCkgY29uc3QKICAg ICByZXR1cm4gbm9kZTsKIH0KIAorRWxlbWVudCogSGl0VGVzdFJlc3VsdDo6aW5uZXJFbGVtZW50 KCkgY29uc3QKK3sKKyAgICBmb3IgKE5vZGUqIG5vZGUgPSBtX2lubmVyTm9kZS5nZXQoKTsgbm9k ZTsgbm9kZSA9IG5vZGUtPnBhcmVudE5vZGUoKSkgeworICAgICAgICBpZiAobm9kZS0+aXNFbGVt ZW50Tm9kZSgpKQorICAgICAgICAgICAgcmV0dXJuIHRvRWxlbWVudChub2RlKTsKKyAgICB9CisK KyAgICByZXR1cm4gMDsKK30KKwogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0hpdFRlc3RSZXN1bHQuaCBiL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9IaXRUZXN0UmVzdWx0LmgKaW5kZXggNTdhNDFkYWI1OTg4NjIzYjE5NjU1MThh ZjIzMWRjYTM2Y2JiOTE1Yi4uYzJlMGJmMmE3OTU5ZTBmZjI4NWVlNzUyOTEyZmFhOWQ3YzliZDQ1 OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0hpdFRlc3RSZXN1bHQuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvSGl0VGVzdFJlc3VsdC5oCkBAIC0xMTUsNiAr MTE1LDcgQEAgcHVibGljOgogICAgIEhpdFRlc3RSZXN1bHQmIG9wZXJhdG9yPShjb25zdCBIaXRU ZXN0UmVzdWx0Jik7CiAKICAgICBOb2RlKiBpbm5lck5vZGUoKSBjb25zdCB7IHJldHVybiBtX2lu bmVyTm9kZS5nZXQoKTsgfQorICAgIEVsZW1lbnQqIGlubmVyRWxlbWVudCgpIGNvbnN0OwogICAg IE5vZGUqIGlubmVyTm9uU2hhcmVkTm9kZSgpIGNvbnN0IHsgcmV0dXJuIG1faW5uZXJOb25TaGFy ZWROb2RlLmdldCgpOyB9CiAgICAgRWxlbWVudCogVVJMRWxlbWVudCgpIGNvbnN0IHsgcmV0dXJu IG1faW5uZXJVUkxFbGVtZW50LmdldCgpOyB9CiAgICAgU2Nyb2xsYmFyKiBzY3JvbGxiYXIoKSBj b25zdCB7IHJldHVybiBtX3Njcm9sbGJhci5nZXQoKTsgfQo=