106419 2013-01-08 23:08:52 -0800 Assertion Failure in WebCore::RenderLayerCompositor::updateCompositingLayers 2013-01-10 01:04:40 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac Unspecified RESOLVED FIXED P2 Normal --- 1 slewis achicu achicu eric ggaren mikhail.pozdnyakov ojan.autocc simon.fraser slewis webkit.review.bot oldest_to_newest 803060 0 slewis 2013-01-08 23:08:52 -0800 Due to http://trac.webkit.org/projects/webkit/changeset/139146 Failing on Mountain Lion and Lion, WK1 and Wk2. Flaky. http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r139161%20(5589)/results.html +dom/html/level2/html/HTMLDocument11.html +dom/html/level2/html/HTMLDocument01.html +dom/html/level2/html/HTMLBodyElement09.html http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r139161%20(5589)/dom/html/level2/html/HTMLDocument11-crash-log.txt Exception Type: EXC_BAD_ACCESS (SIGSEGV) Exception Codes: KERN_INVALID_ADDRESS at 0x00000000bbadbeef VM Regions Near 0xbbadbeef: --> __TEXT 000000010ccce000-000000010cccf000 [ 4K] r-x/rwx SM=COW /Volumes/VOLUME/*/WebKit2.framework/WebProcess.app/Contents/MacOS/WebProcess Application Specific Information: CRASHING TEST: dom/html/level2/html/HTMLDocument11.html Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.WebCore 0x00000001104f4f42 WebCore::RenderLayerCompositor::updateCompositingLayers(WebCore::CompositingUpdateType, WebCore::RenderLayer*) + 258 (RenderLayerCompositor.cpp:411) 1 com.apple.WebCore 0x00000001104f2d5a WebCore::RenderLayerCompositor::updateCompositingLayersTimerFired(WebCore::Timer<WebCore::RenderLayerCompositor>*) + 42 (RenderLayerCompositor.cpp:390) 2 com.apple.WebCore 0x0000000110504ba3 WebCore::Timer<WebCore::RenderLayerCompositor>::fired() + 115 (Timer.h:106) 3 com.apple.WebCore 0x0000000110a71006 WebCore::ThreadTimers::sharedTimerFiredInternal() + 294 (ThreadTimers.cpp:119) 4 com.apple.WebCore 0x0000000110a70d99 WebCore::ThreadTimers::sharedTimerFired() + 25 (ThreadTimers.cpp:94) 5 com.apple.WebCore 0x00000001107a0383 WebCore::timerFired(__CFRunLoopTimer*, void*) + 67 (SharedTimerMac.mm:167) 6 com.apple.CoreFoundation 0x00007fff91020da4 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ + 20 7 com.apple.CoreFoundation 0x00007fff910208bd __CFRunLoopDoTimer + 557 8 com.apple.CoreFoundation 0x00007fff91006099 __CFRunLoopRun + 1513 9 com.apple.CoreFoundation 0x00007fff910056b2 CFRunLoopRunSpecific + 290 10 com.apple.HIToolbox 0x00007fff927520a4 RunCurrentEventLoopInMode + 209 11 com.apple.HIToolbox 0x00007fff92751e42 ReceiveNextEventCommon + 356 12 com.apple.HIToolbox 0x00007fff92751cd3 BlockUntilNextEventMatchingListInMode + 62 13 com.apple.AppKit 0x00007fff96821613 _DPSNextEvent + 685 14 com.apple.AppKit 0x00007fff96820ed2 -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 128 15 com.apple.AppKit 0x00007fff96818283 -[NSApplication run] + 517 16 com.apple.WebCore 0x00000001106cce0c WebCore::RunLoop::run() + 92 (RunLoopMac.mm:37) 17 com.apple.WebKit2 0x000000010d0bc69f int WebKit::ChildProcessMain<WebKit::WebProcess, WebKit::WebProcessMainDelegate>(WebKit::CommandLine const&) + 815 (ChildProcessMain.h:106) 18 com.apple.WebKit2 0x000000010d0bc365 WebKit::WebProcessMain(WebKit::CommandLine const&) + 21 (WebProcessMainMac.mm:152) 19 com.apple.WebKit2 0x000000010cfa9419 WebKitMain(WebKit::CommandLine const&) + 201 (WebKitMain.cpp:56) 20 com.apple.WebKit2 0x000000010cfa9329 WebKitMain + 153 (WebKitMain.cpp:86) 21 com.apple.WebProcess 0x000000010ccceda2 main + 274 22 libdyld.dylib 0x00007fff981737e1 start + 1 803063 1 slewis 2013-01-08 23:13:48 -0800 Updated expectations in http://trac.webkit.org/projects/webkit/changeset/139168 803441 2 achicu 2013-01-09 10:11:03 -0800 (In reply to comment #20 from 106068) > Or maybe the compositor update should just bail if layout is dirty (as long as it will happen after the next layout). Ok. I will replace the assert with a return. I cannot reproduce any of the crashes in local, so I'm trying to build a test to always reproduce the issue. It looks like the common pattern is the java applet that triggers the scheduled compositor update. 803505 3 ggaren 2013-01-09 11:02:48 -0800 I don't think it's right to use expectations / skipping to fix new failures with a known cause. A better approach is to contact the author and/or roll out the offending patch. 803519 4 achicu 2013-01-09 11:20:30 -0800 (In reply to comment #3) > I don't think it's right to use expectations / skipping to fix new failures with a known cause. A better approach is to contact the author and/or roll out the offending patch. I'm working on it. Will post a patch in a bit. 803541 5 181961 achicu 2013-01-09 11:40:58 -0800 Created attachment 181961 Patch V1 803620 6 181961 webkit.review.bot 2013-01-09 12:47:40 -0800 Comment on attachment 181961 Patch V1 Clearing flags on attachment: 181961 Committed r139229: <http://trac.webkit.org/changeset/139229> 803621 7 webkit.review.bot 2013-01-09 12:47:44 -0800 All reviewed patches have been landed. Closing bug. 804150 8 mikhail.pozdnyakov 2013-01-10 01:04:40 -0800 *** Bug 106453 has been marked as a duplicate of this bug. *** 181961 2013-01-09 11:40:58 -0800 2013-01-09 12:47:40 -0800 Patch V1 bug106419.patch text/plain 3676 achicu ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAzMjQxZjk5Li40ZGM2N2Q0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTMtMDEt MDkgIEFsZXhhbmRydSBDaGljdWxpdGEgIDxhY2hpY3VAYWRvYmUuY29tPgorCisgICAgICAgIEFz c2VydGlvbiBGYWlsdXJlIGluIFdlYkNvcmU6OlJlbmRlckxheWVyQ29tcG9zaXRvcjo6dXBkYXRl Q29tcG9zaXRpbmdMYXllcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEwNjQxOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFJlLWFkZGVkIHNraXBwZWQgdGVzdHMgYXMgdGhpcyBwYXRjaCByZXNvbHZlcyB0 aGUgZmxha2luZXNzLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnM6 CisKIDIwMTMtMDEtMDkgIERpbWl0cmkgR2xhemtvdiAgPGRnbGF6a292QGNocm9taXVtLm9yZz4K IAogICAgICAgICBbQ2hyb21pdW1dIFJlYmFzZWxpbmUgYSBmZXcgdGVzdHMgYWZ0ZXIgcjEzOTIw MS4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25z IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggYWQxZDc4 ZC4uY2Q5NjE5MyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBl Y3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMK QEAgLTEyNzUsNyArMTI3NSwzIEBAIHdlYmtpdC5vcmcvYi8xMDY0MTUgZmFzdC93b3JrZXJzL3dv cmtlci1jbG9zZS1tb3JlLmh0bWwgWyBQYXNzIEZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzEwNjQx NSBmYXN0L3dvcmtlcnMvd29ya2VyLWRvY3VtZW50LWxlYWsuaHRtbCBbIFBhc3MgRmFpbHVyZSBd CiB3ZWJraXQub3JnL2IvMTA2NDE1IGZhc3Qvd29ya2Vycy93b3JrZXItbGlmZWN5Y2xlLmh0bWwg WyBQYXNzIEZhaWx1cmUgXQogCi13ZWJraXQub3JnL2IvMTA2NDE5IFsgRGVidWcgXSBkb20vaHRt bC9sZXZlbDIvaHRtbC9IVE1MRG9jdW1lbnQxMS5odG1sIFsgQ3Jhc2ggRmFpbHVyZSBdCi13ZWJr aXQub3JnL2IvMTA2NDE5IFsgRGVidWcgXSBkb20vaHRtbC9sZXZlbDIvaHRtbC9IVE1MRG9jdW1l bnQwMS5odG1sIFsgQ3Jhc2ggRmFpbHVyZSBdCi13ZWJraXQub3JnL2IvMTA2NDE5IFsgRGVidWcg XSBkb20vaHRtbC9sZXZlbDIvaHRtbC9IVE1MQm9keUVsZW1lbnQwOS5odG1sIFsgQ3Jhc2ggRmFp bHVyZSBdCi0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZwppbmRleCAyMzk2NTVkLi43YzY0YzA0IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMjAgQEAKKzIwMTMtMDEtMDkgIEFsZXhhbmRydSBDaGljdWxpdGEgIDxhY2hpY3VAYWRv YmUuY29tPgorCisgICAgICAgIEFzc2VydGlvbiBGYWlsdXJlIGluIFdlYkNvcmU6OlJlbmRlckxh eWVyQ29tcG9zaXRvcjo6dXBkYXRlQ29tcG9zaXRpbmdMYXllcnMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNjQxOQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBhZGRlZCwganVzdCB1 bi1za2lwcGVkIDMgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgUmVuZGVyTGF5ZXJDb21wb3Np dG9yOjp1cGRhdGVDb21wb3NpdGluZ0xheWVycyBpcyBiZWluZyBjYWxsZWQgd2l0aCBhIHBlbmRp bmcgbGF5b3V0LCBzbyBjb21wdXRpbmcgdGhlCisgICAgICAgIGxheWVycyBhdCB0aGF0IHBvaW50 IHdvdWxkIGJlIHVzZWxlc3MgJiBlcnJvci1wcm9uZSBhcyB0aGV5IHdpbGwgYmUgdXNpbmcgaW5j b3JyZWN0IGxheW91dCB2YWx1ZXMuIElmIGEgbGF5b3V0IGlzIHBlbmRpbmcgaXQgbWVhbnMgdGhh dCAKKyAgICAgICAgUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjp1cGRhdGVDb21wb3NpdGluZ0xheWVy cyB3b3VsZCBnZXQgY2FsbGVkIGFnYWluIGFmdGVyIHRoZSBwZW5kaW5nIGxheW91dCBlbmRzLCBz byBhbnkgdmFsdWVzIGNhbGN1bGF0ZWQgYXQgdGhhdCBwb2ludCB3b3VsZCBiZQorICAgICAgICBv dmVyd3JpdHRlbiBpbW1lZGlhdGVseS4gVGhpcyBwYXRjaCByZW1vdmVzIHRoZSBvbGQgQVNTRVJU IGFuZCBtYWtlcyBpdCBhIHJldHVybiBpbnN0ZWFkLgorCisgICAgICAgICogcmVuZGVyaW5nL1Jl bmRlckxheWVyQ29tcG9zaXRvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllckNv bXBvc2l0b3I6OnVwZGF0ZUNvbXBvc2l0aW5nTGF5ZXJzKToKKwogMjAxMy0wMS0wOSAgWW9uZ2p1 biBaaGFuZyAgPHlvbmdqdW5femhhbmdAYXBwbGUuY29tPgogCiAgICAgICAgIElmIEltYWdlTG9h ZGVyJ3MgbG9hZEV2ZW50U2VuZGVyIG9yIGVycm9yRXZlbnRTZW5kZXIgZmlyZXMgYWZ0ZXIgZG9j dW1lbnQgaXMgZGV0YWNoZWQsIHRoZSBkb2N1bWVudCB3aWxsIGJlIGxlYWtlZC4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAKaW5kZXgg MWE0YTI1Ny4uZmRlMzI5NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckxheWVyQ29tcG9zaXRvci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckxheWVyQ29tcG9zaXRvci5jcHAKQEAgLTQwMiwxNCArNDAyLDE2IEBAIHZvaWQgUmVuZGVy TGF5ZXJDb21wb3NpdG9yOjp1cGRhdGVDb21wb3NpdGluZ0xheWVycyhDb21wb3NpdGluZ1VwZGF0 ZVR5cGUgdXBkYXRlCiAgICAgaWYgKCFtX3JlbmRlclZpZXctPmRvY3VtZW50KCktPnZpc3VhbFVw ZGF0ZXNBbGxvd2VkKCkpCiAgICAgICAgIHJldHVybjsKIAorICAgIC8vIEF2b2lkIHVwZGF0aW5n IHRoZSBsYXllcnMgd2l0aCBvbGQgdmFsdWVzLiBDb21wb3NpdGluZyBsYXllcnMgd2lsbCBiZSB1 cGRhdGVkIGFmdGVyIHRoZSBsYXlvdXQgaXMgZmluaXNoZWQuCisgICAgaWYgKG1fcmVuZGVyVmll dy0+bmVlZHNMYXlvdXQoKSkKKyAgICAgICAgcmV0dXJuOworCiAgICAgaWYgKG1fZm9yY2VDb21w b3NpdGluZ01vZGUgJiYgIW1fY29tcG9zaXRpbmcpCiAgICAgICAgIGVuYWJsZUNvbXBvc2l0aW5n TW9kZSh0cnVlKTsKIAogICAgIGlmICghbV9yZWV2YWx1YXRlQ29tcG9zaXRpbmdBZnRlckxheW91 dCAmJiAhbV9jb21wb3NpdGluZykKICAgICAgICAgcmV0dXJuOwogCi0gICAgQVNTRVJUKCFtX3Jl bmRlclZpZXctPm5lZWRzTGF5b3V0KCkpOwotCiAgICAgQW5pbWF0aW9uVXBkYXRlQmxvY2sgYW5p bWF0aW9uVXBkYXRlQmxvY2sobV9yZW5kZXJWaWV3LT5mcmFtZVZpZXcoKS0+ZnJhbWUoKS0+YW5p bWF0aW9uKCkpOwogCiAgICAgYm9vbCBjaGVja0ZvckhpZXJhcmNoeVVwZGF0ZSA9IG1fcmVldmFs dWF0ZUNvbXBvc2l0aW5nQWZ0ZXJMYXlvdXQ7Cg==