106417 2013-01-08 22:06:01 -0800 Ruby base oddly justify its text when the text is ideograph and it contains <br> on Mac. 2014-02-05 13:10:55 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.7 RESOLVED FIXED P2 Normal --- 0 yuki.sekiguchi webkit-unassigned commit-queue eric ojan.autocc webkit.review.bot oldest_to_newest 803023 0 181844 yuki.sekiguchi 2013-01-08 22:06:01 -0800 Created attachment 181844 Reproduced content. In attached content, 1st line of ruby base have two Japanese characters, and 2nd line also have two characters. However, the character position of 1st line is different from 2nd line. This problem is only occurred on Mac, because other platforms don't justify inter ideograph. This behavior becomes also problem when WebKit implement text-align-last: justify. 803036 1 181849 yuki.sekiguchi 2013-01-08 22:27:54 -0800 Created attachment 181849 Patch 977040 2 181849 hyatt 2014-02-05 12:38:56 -0800 Comment on attachment 181849 Patch r=me, although someday we should just get rid of the trailing space. 977051 3 181849 commit-queue 2014-02-05 13:10:52 -0800 Comment on attachment 181849 Patch Clearing flags on attachment: 181849 Committed r163469: <http://trac.webkit.org/changeset/163469> 977052 4 commit-queue 2014-02-05 13:10:55 -0800 All reviewed patches have been landed. Closing bug. 181844 2013-01-08 22:06:01 -0800 2013-01-08 22:06:01 -0800 Reproduced content. ruby-justification-br.html text/html 120 yuki.sekiguchi PCFET0NUWVBFIGh0bWw+DQo8aHRtbD4NCjxydWJ5PiYjeDMwNDI7JiN4MzA0Mjs8YnI+JiN4MzA0 MjsmI3gzMDQyOzxydD5hYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWE8L3J1Ynk+PGJyPg0KPC9o dG1sPg0K 181849 2013-01-08 22:27:54 -0800 2014-02-05 13:10:52 -0800 Patch bug-106417-20130109152457.patch text/plain 3675 yuki.sekiguchi U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5MTQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWE4ZTMxM2E2MzIyNzZj Y2ZlNDg1ZDk0NGRiYWRkZGM3YWQ4OWM1NC4uZGUyY2JmMzc0YWI3YjIwZmM3OTA5ZjQxYmFmNGE4 YmNmZWQ1MmFmMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAxLTA4ICBZdWtp IFNla2lndWNoaSAgPHl1a2kuc2VraWd1Y2hpQGFjY2Vzcy1jb21wYW55LmNvbT4KKworICAgICAg ICBSdWJ5IGJhc2Ugb2RkbHkganVzdGlmeSBpdHMgdGV4dCB3aGVuIHRoZSB0ZXh0IGlzIGlkZW9n cmFwaCBhbmQgaXQgY29udGFpbnMgPGJyPiBvbiBNYWMuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDY0MTcKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSdWJ5IGJhc2UgYWx3YXlzIGp1c3RpZnkgZXZlbiBp ZiBhIGxpbmUgaGF2ZSBoYXJkIGJyZWFrLgorICAgICAgICBFdmVuIGlmIG5leHQgbGVhZiBjaGls ZCBpcyBsaW5lIGJyZWFrLCBJbmxpbmVUZXh0Qm94IGFsbG93IHRyYWlsaW5nIGV4cGFuc2lvbi4K KyAgICAgICAgVGhpcyBtYWtlIDxicj4gZXhwYW5kZWQsIGFuZCB0aGVyZSBpcyBvZGQgc3BhY2Ug YXQgdGhlIGVuZCBvZiB0aGUgbGluZS4KKworICAgICAgICBUZXN0OiBmYXN0L3RleHQvcnVieS1q dXN0aWZpY2F0aW9uLWJyLmh0bWwKKworICAgICAgICAqIHJlbmRlcmluZy9JbmxpbmVUZXh0Qm94 Lmg6CisgICAgICAgIChXZWJDb3JlOjpJbmxpbmVUZXh0Qm94OjpleHBhbnNpb25CZWhhdmlvcik6 CisgICAgICAgICAtIElmIG5leHQgbGVhZiBjaGlsZCBpcyBsaW5lIGJyZWFrLCB3ZSBzaG91bGQg Zm9yYmlkIHRyYWlsaW5nIGV4cGFuc2lvbi4KKwogMjAxMy0wMS0wOCAgSnVzdGluIE5vdm9zYWQg IDxqdW5vdkBnb29nbGUuY29tPgogCiAgICAgICAgIENhbnZhc1JlbmRlcmluZ0NvbnRleHQyRDo6 c2V0Rm9udCBhcmd1bWVudCBtYXkgcmVmZXJlbmNlIGRlc3Ryb3llZCBvYmplY3QKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVUZXh0Qm94LmggYi9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvSW5saW5lVGV4dEJveC5oCmluZGV4IGY1YmZiMTBlZDUwOTkwMTQzN2M3 Nzc3MjY4MDUwNGZjNmZhOGVhN2EuLjcyZTUwYTQ5ODg4M2Y0NDg0YWZlMjIzMDVmMTk4YzkzYjZi OTk1OGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVUZXh0Qm94 LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0lubGluZVRleHRCb3guaApAQCAtMTk1 LDcgKzE5NSw3IEBAIHByaXZhdGU6CiAgICAgVGV4dFJ1bjo6RXhwYW5zaW9uQmVoYXZpb3IgZXhw YW5zaW9uQmVoYXZpb3IoKSBjb25zdAogICAgIHsKICAgICAgICAgcmV0dXJuIChjYW5IYXZlTGVh ZGluZ0V4cGFuc2lvbigpID8gVGV4dFJ1bjo6QWxsb3dMZWFkaW5nRXhwYW5zaW9uIDogVGV4dFJ1 bjo6Rm9yYmlkTGVhZGluZ0V4cGFuc2lvbikKLSAgICAgICAgICAgIHwgKGV4cGFuc2lvbigpICYm IG5leHRMZWFmQ2hpbGQoKSA/IFRleHRSdW46OkFsbG93VHJhaWxpbmdFeHBhbnNpb24gOiBUZXh0 UnVuOjpGb3JiaWRUcmFpbGluZ0V4cGFuc2lvbik7CisgICAgICAgICAgICB8IChleHBhbnNpb24o KSAmJiBuZXh0TGVhZkNoaWxkKCkgJiYgIW5leHRMZWFmQ2hpbGQoKS0+aXNMaW5lQnJlYWsoKSA/ IFRleHRSdW46OkFsbG93VHJhaWxpbmdFeHBhbnNpb24gOiBUZXh0UnVuOjpGb3JiaWRUcmFpbGlu Z0V4cGFuc2lvbik7CiAgICAgfQogfTsKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDc4Y2IxNTY0NDRiNTEyN2Q5ZTQyNjk5 MGE3MjMzMTY4YTc3MzRkYjMuLjg3NGIyYzYzZmRmOWU1MjNiMDkyOTY3ZjYzNDBmMjlkMWE4Mzdh YjQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMy0wMS0wOCAgWXVraSBTZWtpZ3VjaGkgIDx5 dWtpLnNla2lndWNoaUBhY2Nlc3MtY29tcGFueS5jb20+CisKKyAgICAgICAgUnVieSBiYXNlIG9k ZGx5IGp1c3RpZnkgaXRzIHRleHQgd2hlbiB0aGUgdGV4dCBpcyBpZGVvZ3JhcGggYW5kIGl0IGNv bnRhaW5zIDxicj4gb24gTWFjLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTA2NDE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVGVzdCB0aGF0IDxicj4gZG9uJ3QgY2hhbmdlIGp1c3RpZmljYXRpb24gYmVo YXZpb3IgaW4gcnVieSBiYXNlLgorCisgICAgICAgICogZmFzdC90ZXh0L3J1YnktanVzdGlmaWNh dGlvbi1ici1leHBlY3RlZC5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L3RleHQvcnVieS1q dXN0aWZpY2F0aW9uLWJyLmh0bWw6IEFkZGVkLgorCiAyMDEzLTAxLTA4ICBCcmFuZG9uIEpvbmVz ICA8YmFqb25lc0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgTWFrZSBXZWJHTFJlbmRlcmluZ0Nv bnRleHQgaW5oZXJpdCBmcm9tIEFjdGl2ZURPTU9iamVjdApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvZmFzdC90ZXh0L3J1YnktanVzdGlmaWNhdGlvbi1ici1leHBlY3RlZC5odG1sIGIvTGF5b3V0 VGVzdHMvZmFzdC90ZXh0L3J1YnktanVzdGlmaWNhdGlvbi1ici1leHBlY3RlZC5odG1sCm5ldyBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAuLjI3OTg4ZDkwMGFhZjAzZjk0OTZmZTg5MGI1NmIxM2Y0N2ViM2RiNTgKLS0tIC9kZXYv bnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3RleHQvcnVieS1qdXN0aWZpY2F0aW9uLWJyLWV4 cGVjdGVkLmh0bWwKQEAgLTAsMCArMSw3IEBACis8IURPQ1RZUEUgaHRtbD4NCis8aHRtbD4NCis8 aGVhZD48bWV0YSBjaGFyc2V0PSJVVEYtOCI+PC9oZWFkPg0KKzxib2R5Pg0KKzxydWJ5PiYjeDMw NDI7JiN4MzA0Mjs8cnQ+YWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhPC9ydWJ5Pg0KKzwvYm9k eT4NCis8L2h0bWw+DQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC90ZXh0L3J1YnktanVz dGlmaWNhdGlvbi1ici5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC90ZXh0L3J1YnktanVzdGlmaWNh dGlvbi1ici5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmU3ZjU4ZGFmYzY5YTVlOGVjNjQ2NWRhNmEyM2MyNGVk ZDU0M2Y0ZWUKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3RleHQvcnVieS1q dXN0aWZpY2F0aW9uLWJyLmh0bWwKQEAgLTAsMCArMSw3IEBACis8IURPQ1RZUEUgaHRtbD4NCis8 aHRtbD4NCis8aGVhZD48bWV0YSBjaGFyc2V0PSJVVEYtOCI+PC9oZWFkPg0KKzxib2R5Pg0KKzxy dWJ5PiYjeDMwNDI7JiN4MzA0Mjs8YnI+PHJ0PmFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYTwv cnVieT4NCis8L2JvZHk+DQorPC9odG1sPg0K