106415 2013-01-08 21:23:35 -0800 REGRESSION(r139145): Multiple fast/workers tests fail 2015-08-29 21:14:56 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac Unspecified RESOLVED WORKSFORME InRadar P1 Critical --- 79668 98898 1 slewis oliver abarth fpizlo mark.lam oliver ossy rniwa slewis timothy oldest_to_newest 802995 0 slewis 2013-01-08 21:23:35 -0800 Due to http://trac.webkit.org/projects/webkit/changeset/139145 Failing on Mac WK1 and WK2, Release and Debug, Mountain Lion and Lion. The tests are timing out waiting for notifyDone and flaky. Every once in awhile they'll pass. [1/3] fast/workers/worker-close-more.html failed unexpectedly (text diff) [2/3] fast/workers/worker-document-leak.html failed unexpectedly (text diff) [3/3] fast/workers/worker-lifecycle.html failed unexpectedly (text diff) 803005 1 slewis 2013-01-08 21:32:01 -0800 Updated Expectations in http://trac.webkit.org/projects/webkit/changeset/139160 803031 2 rniwa 2013-01-08 22:16:48 -0800 Also see http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=fast%2Fworkers%2Fworker-close-more.html%2Cfast%2Fworkers%2Fworker-document-leak.html%2Cfast%2Fworkers%2Fworker-lifecycle.html 803037 3 ossy 2013-01-08 22:32:14 -0800 Similar flakiness on EFL, GTK and Qt. :-/ 803039 4 ossy 2013-01-08 22:42:22 -0800 I skipped them on Qt - r139164 to paint the bots green. Please unskip them with the proper fix. (It is P1/critical bug, because it is a regression and tests fail with timeout) 803424 5 ap 2013-01-09 10:00:02 -0800 <rdar://problem/12981718> 805953 6 ossy 2013-01-13 01:44:24 -0800 Are you working on fixing this serious regression? 807148 7 ossy 2013-01-15 02:37:52 -0800 ping? 807373 8 oliver 2013-01-15 09:21:05 -0800 (In reply to comment #7) > ping? Eventually. I'm side tracked with other more important bugs for a couple of days. Could you do some analysis yourself? Maybe you'll find some obvious cause of the problem. Otherwise causing two layout tests to hang, but not having real world site breakage means that this can wait a few more days. 814773 9 ossy 2013-01-23 16:07:10 -0800 I checked this bug, it seems it isn't valid on ToT with Qt 64 bit release. I have no idea which revision fixed it and don't have time to bisect 1000+ revision. Unfortunately it's hard to reproduce, because these tests passed if you ran only fast/workers tests, but failed if you ran all fast tests. (on r139145) 814779 10 oliver 2013-01-23 16:11:58 -0800 (In reply to comment #9) > I checked this bug, it seems it isn't valid on ToT with Qt 64 bit release. > I have no idea which revision fixed it and don't have time to bisect 1000+ > revision. Unfortunately it's hard to reproduce, because these tests passed > if you ran only fast/workers tests, but failed if you ran all fast tests. (on r139145) Thanks for checking. I'll look around and see if there's anything obviously stupid happening. It's possible that this was just a temporary thing before i fixed the massive gc bug i had introduced :-/ 817903 11 185020 oliver 2013-01-28 11:20:53 -0800 Created attachment 185020 Patch 817905 12 oliver 2013-01-28 11:21:17 -0800 Committed r140981: <http://trac.webkit.org/changeset/140981> 818403 13 185020 ap 2013-01-28 19:31:45 -0800 Comment on attachment 185020 Patch Clearing review flag from a landed patch. 818425 14 rniwa 2013-01-28 20:04:58 -0800 These tests are still failing :( See http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20(Tests)/r141034%20(5309)/results.html 818455 15 oliver 2013-01-28 20:56:49 -0800 (In reply to comment #14) > These tests are still failing :( See http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20(Tests)/r141034%20(5309)/results.html goddammit 818491 16 ossy 2013-01-28 21:41:01 -0800 (In reply to comment #14) > These tests are still failing :( See http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20(Tests)/r141034%20(5309)/results.html Reopen, because it seems it is still valid bug. 818517 17 rniwa 2013-01-28 22:04:25 -0800 *** Bug 108144 has been marked as a duplicate of this bug. *** 818518 18 rniwa 2013-01-28 22:05:38 -0800 I think we need to add these failing expectations back. 818989 19 oliver 2013-01-29 08:51:39 -0800 (In reply to comment #18) > I think we need to add these failing expectations back. yup. this makes no sense. 819063 20 rniwa 2013-01-29 10:21:05 -0800 This bug is causing Mac EWS bots to erroneously reject patches. 819064 21 oliver 2013-01-29 10:22:04 -0800 (In reply to comment #20) > This bug is causing Mac EWS bots to erroneously reject patches. Sorry, i thought you'd said you were going to revert the patch, i'll be able to do so in half an hour 819065 22 oliver 2013-01-29 10:22:28 -0800 (patch being the expectation patch) 819068 23 rniwa 2013-01-29 10:23:45 -0800 (In reply to comment #21) > (In reply to comment #20) > > This bug is causing Mac EWS bots to erroneously reject patches. > > Sorry, i thought you'd said you were going to revert the patch, i'll be able to do so in half an hour Done that in r141133. 819069 24 rniwa 2013-01-29 10:26:42 -0800 In the future, I recommend using http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=fast%2Fworkers%2Fworker-close-more.html%2Cfast%2Fworkers%2Fworker-document-leak.html%2Cfast%2Fworkers%2Fworker-lifecycle.html It shows historical actual failure / pass status of these tests reported by bots. As you can see, these tests occasionally pass. 819257 25 rniwa 2013-01-29 13:10:34 -0800 *** Bug 108217 has been marked as a duplicate of this bug. *** 866272 26 timothy 2013-03-29 11:56:24 -0700 These are also failing most of the time on Windows. I marked them as flaky in https://trac.webkit.org/r147232. 933786 27 ap 2013-09-26 17:02:25 -0700 Still timing out. 1121982 28 ap 2015-08-29 00:21:21 -0700 Looks like r189009 took care of fast/workers/worker-close-more.html fast/workers/worker-document-leak.html has been passing for a long time now and fast/workers/worker-lifecycle.html too. 185020 2013-01-28 11:20:53 -0800 2013-01-28 19:31:44 -0800 Patch bug-106415-20130128111740.patch text/plain 1514 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwOTgwCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYjU5ZDFmZjk2Mzg1MDYwZTdjMjYw YzVhN2M4YzkwMTZiMDJmZTg1NC4uMjcwZGVhNTI4ZWQ2YWM3NGExZGMxNjY4Yjg3N2Y0NDhhOGRj ZDJjMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEzLTAxLTI4ICBPbGl2ZXIgSHVudCAgPG9s aXZlckBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMTM5MTQ1KTogQSBjb3VwbGUg b2YgZmFzdC93b3JrZXJzIHRlc3RzIGZhaWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEwNjQxNQorCisgICAgICAgIFRoZXNlIHRlc3RzIGFyZSBzdGFi bGUgbm93LgorCisgICAgICAgICogcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnM6CisKIDIw MTMtMDEtMjggIFpvbHRhbiBBcnZhaSAgPHphcnZhaUBpbmYudS1zemVnZWQuaHU+CiAKICAgICAg ICAgW1F0XSBVbnJldmlld2VkIGdhcmRlbmluZy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3Bs YXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rl c3RFeHBlY3RhdGlvbnMKaW5kZXggNGQ0M2Y4ZGVhZTA0NDczOGQ4NzQ3NWJlMzE0MjY0ZTUwM2M2 Mzg1NC4uMzRhMGQxMDhhNDM5NGU5ZDIyMDAzY2U3ZDc5Nzk5NGQ4M2UyNjE3MSAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTEyNjMsMTAgKzEyNjMsNiBA QCB3ZWJraXQub3JnL2IvMTA2NDEyIFsgRGVidWcgXSBlZGl0aW5nL2V4ZWNDb21tYW5kL2luc2Vy dC1saXN0LXhtbC54aHRtbCBbIENyYXNoCiB3ZWJraXQub3JnL2IvMTA2NDEyIFsgRGVidWcgXSBl ZGl0aW5nL3Bhc3RlYm9hcmQvcGFzdGUtbm9zY3JpcHQteGh0bWwueGh0bWwgWyBDcmFzaCBdCiB3 ZWJraXQub3JnL2IvMTA2NDEyIFsgRGVidWcgXSBlZGl0aW5nL3Bhc3RlYm9hcmQvcGFzdGUteG1s LnhodG1sIFsgQ3Jhc2ggXQogCi13ZWJraXQub3JnL2IvMTA2NDE1IGZhc3Qvd29ya2Vycy93b3Jr ZXItY2xvc2UtbW9yZS5odG1sIFsgUGFzcyBGYWlsdXJlIF0KLXdlYmtpdC5vcmcvYi8xMDY0MTUg ZmFzdC93b3JrZXJzL3dvcmtlci1kb2N1bWVudC1sZWFrLmh0bWwgWyBQYXNzIEZhaWx1cmUgXQot d2Via2l0Lm9yZy9iLzEwNjQxNSBmYXN0L3dvcmtlcnMvd29ya2VyLWxpZmVjeWNsZS5odG1sIFsg UGFzcyBGYWlsdXJlIF0KLQogd2Via2l0Lm9yZy9iLzEwNjk1NyBzdmcvZG9tL1NWR1ZpZXdTcGVj LWludmFsaWQtcmVmLWNyYXNoLmh0bWwgWyBGYWlsdXJlIF0KIAogIyBFbmFibGUgd2hlbiBzdXBw b3J0IGRyYWctYW5kLWRyb3AgYXV0b3Njcm9sbGluZwo=