106399 2013-01-08 16:49:33 -0800 Remove unused/deprecated render() method in chromium WebKit API 2013-01-08 22:44:21 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 crogers crogers abarth dglazkov eric.carlson feature-media-reviews fishd jamesr kbr tkent+wkapi webkit.review.bot oldest_to_newest 802811 0 crogers 2013-01-08 16:49:33 -0800 Remove unused/deprecated render() method in chromium WebKit API 802812 1 181804 crogers 2013-01-08 16:50:55 -0800 Created attachment 181804 Patch 802814 2 webkit.review.bot 2013-01-08 16:52:16 -0800 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 802845 3 181804 tkent 2013-01-08 17:35:32 -0800 Comment on attachment 181804 Patch ok 803041 4 181804 webkit.review.bot 2013-01-08 22:44:17 -0800 Comment on attachment 181804 Patch Clearing flags on attachment: 181804 Committed r139165: <http://trac.webkit.org/changeset/139165> 803042 5 webkit.review.bot 2013-01-08 22:44:21 -0800 All reviewed patches have been landed. Closing bug. 181804 2013-01-08 16:50:55 -0800 2013-01-08 22:44:17 -0800 Patch bug-106399-20130108164759.patch text/plain 4318 crogers U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5MDg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCAwM2I3NDI4M2JmYTI2 NDdiNWI0MTIzMjFjOTJlMTFkNmI4ZWVkNDczLi5kNWNhMzhlYjI5YTQ0Y2YxODNjOWQxMjlkZGQz YTQyODc0ODU5MTAzIDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMy0wMS0wOCAg Q2hyaXMgUm9nZXJzICA8Y3JvZ2Vyc0Bnb29nbGUuY29tPgorCisgICAgICAgIFJlbW92ZSB1bnVz ZWQvZGVwcmVjYXRlZCByZW5kZXIoKSBtZXRob2QgaW4gY2hyb21pdW0gV2ViS2l0IEFQSQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA2Mzk5CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBjaHJvbWl1bS9w dWJsaWMvV2ViQXVkaW9EZXZpY2UuaDoKKwogMjAxMy0wMS0wNSAgQ2hyaXMgUm9nZXJzICA8Y3Jv Z2Vyc0Bnb29nbGUuY29tPgogCiAgICAgICAgIEltcGxlbWVudCBNZWRpYVN0cmVhbVNvdXJjZTo6 c2V0QXVkaW9Gb3JtYXQoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFu Z2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwppbmRleCAwMGM4MDM1ZjVm ZGQ1MDAwODhkNjE3YTI1NDUxNzkwZDk4NTQ2N2I1Li5hY2RmYzliZjliZWI4ODFkNDJhNGFhZDU1 YmE1YWI4MGFlNTNkNTg4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5n ZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDEzLTAxLTA4ICBDaHJpcyBSb2dlcnMgIDxjcm9nZXJzQGdvb2dsZS5jb20+CisKKyAg ICAgICAgUmVtb3ZlIHVudXNlZC9kZXByZWNhdGVkIHJlbmRlcigpIG1ldGhvZCBpbiBjaHJvbWl1 bSBXZWJLaXQgQVBJCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMDYzOTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIHNyYy9BdWRpb0Rlc3RpbmF0aW9uQ2hyb21pdW0uY3BwOgorICAgICAgICAqIHNyYy9B dWRpb0Rlc3RpbmF0aW9uQ2hyb21pdW0uaDoKKyAgICAgICAgKEF1ZGlvRGVzdGluYXRpb25DaHJv bWl1bSk6CisKIDIwMTMtMDEtMDggIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAg ICAgICAgIFJlbW92ZWQgdGhlIG5lZWQgZm9yIHRoZSBQcm9wb3NlZERhdGFiYXNlIG1lY2hhbmlz bS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2ViQXVkaW9E ZXZpY2UuaCBiL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2ViQXVkaW9EZXZpY2Uu aAppbmRleCBhYjNlNTg3NWIwMzc5ZDE4ZTAyMWM1NTU1OTkyMTE3NmYzNjBkMDZmLi5lYmRmODA0 MmJmMDhmMWEyZjlhOGMzMzViMTY4ZDBkOWI5ZjBhYzRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxh dGZvcm0vY2hyb21pdW0vcHVibGljL1dlYkF1ZGlvRGV2aWNlLmgKKysrIGIvU291cmNlL1BsYXRm b3JtL2Nocm9taXVtL3B1YmxpYy9XZWJBdWRpb0RldmljZS5oCkBAIC00MSw5ICs0MSw2IEBAIHB1 YmxpYzoKICAgICBwdWJsaWM6CiAgICAgICAgIHZpcnR1YWwgdm9pZCByZW5kZXIoY29uc3QgV2Vi VmVjdG9yPGZsb2F0Kj4mIHNvdXJjZURhdGEsIGNvbnN0IFdlYlZlY3RvcjxmbG9hdCo+JiBkZXN0 aW5hdGlvbkRhdGEsIHNpemVfdCBudW1iZXJPZkZyYW1lcykgeyB9OwogCi0gICAgICAgIC8vIEZJ WE1FOiB0byBiZSByZW1vdmVkIG9uY2Ugd2Ugc3dpdGNoIG92ZXIgdG8gbmV3ZXIgcmVuZGVyKCkg bWV0aG9kIGhhbmRsaW5nIGJvdGggYXVkaW8gb3V0cHV0IGFuZCAob3B0aW9uYWwpIGlucHV0Lgot ICAgICAgICB2aXJ0dWFsIHZvaWQgcmVuZGVyKGNvbnN0IFdlYlZlY3RvcjxmbG9hdCo+JiBhdWRp b0RhdGEsIHNpemVfdCBudW1iZXJPZkZyYW1lcykgPSAwOwotCiAgICAgcHJvdGVjdGVkOgogICAg ICAgICB2aXJ0dWFsIH5SZW5kZXJDYWxsYmFjaygpIHsgfQogICAgIH07CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9BdWRpb0Rlc3RpbmF0aW9uQ2hyb21pdW0uY3BwIGIv U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQXVkaW9EZXN0aW5hdGlvbkNocm9taXVtLmNwcApp bmRleCAxMmRiYmE3NDI2MDgwZWM3ODI4ODQ0YmI0MTgxZDQwZWVjOWRlNjc5Li4yNmI0MTgyZWNj NjNlZWFiMDY3MzI3MDk2ZWVlNTA2MTBlNjdlMTI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3NyYy9BdWRpb0Rlc3RpbmF0aW9uQ2hyb21pdW0uY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vc3JjL0F1ZGlvRGVzdGluYXRpb25DaHJvbWl1bS5jcHAKQEAgLTE0NSwy NyArMTQ1LDYgQEAgdm9pZCBBdWRpb0Rlc3RpbmF0aW9uQ2hyb21pdW06OnJlbmRlcihjb25zdCBX ZWJWZWN0b3I8ZmxvYXQqPiYgc291cmNlRGF0YSwgY29uc3QKICAgICBtX2ZpZm8tPmNvbnN1bWUo Jm1fcmVuZGVyQnVzLCBudW1iZXJPZkZyYW1lcyk7CiB9CiAKLS8vIFB1bGxzIG9uIG91ciBwcm92 aWRlciB0byBnZXQgdGhlIHJlbmRlcmVkIGF1ZGlvIHN0cmVhbS4KLS8vIEZJWE1FOiByZW1vdmUg dGhpcyBtZXRob2Qgd2hlbiB0aGUgY2hyb21pdW0tc2lkZSBzd2l0Y2hlcyBvdmVyIHRvIHRoZSBz eW5jaHJvbml6ZWQgSS9PIHJlbmRlcigpIG1ldGhvZCAoYWJvdmUpLgotdm9pZCBBdWRpb0Rlc3Rp bmF0aW9uQ2hyb21pdW06OnJlbmRlcihjb25zdCBXZWJWZWN0b3I8ZmxvYXQqPiYgYXVkaW9EYXRh LCBzaXplX3QgbnVtYmVyT2ZGcmFtZXMpCi17Ci0gICAgYm9vbCBpc051bWJlck9mQ2hhbm5lbHNH b29kID0gYXVkaW9EYXRhLnNpemUoKSA9PSBudW1iZXJPZkNoYW5uZWxzOwotICAgIGlmICghaXNO dW1iZXJPZkNoYW5uZWxzR29vZCkgewotICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKLSAg ICAgICAgcmV0dXJuOwotICAgIH0KLQotICAgIGJvb2wgaXNCdWZmZXJTaXplR29vZCA9IG51bWJl ck9mRnJhbWVzID09IG1fY2FsbGJhY2tCdWZmZXJTaXplOwotICAgIGlmICghaXNCdWZmZXJTaXpl R29vZCkgewotICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKLSAgICAgICAgcmV0dXJuOwot ICAgIH0KLQotICAgIG1fcmVuZGVyQnVzLnNldENoYW5uZWxNZW1vcnkoMCwgYXVkaW9EYXRhWzBd LCBudW1iZXJPZkZyYW1lcyk7Ci0gICAgbV9yZW5kZXJCdXMuc2V0Q2hhbm5lbE1lbW9yeSgxLCBh dWRpb0RhdGFbMV0sIG51bWJlck9mRnJhbWVzKTsKLSAgICBtX2ZpZm8tPmNvbnN1bWUoJm1fcmVu ZGVyQnVzLCBudW1iZXJPZkZyYW1lcyk7Ci19Ci0KIHZvaWQgQXVkaW9EZXN0aW5hdGlvbkNocm9t aXVtOjpwcm92aWRlSW5wdXQoQXVkaW9CdXMqIGJ1cywgc2l6ZV90IGZyYW1lc1RvUHJvY2VzcykK IHsKICAgICBBdWRpb0J1cyogc291cmNlQnVzID0gMDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL0F1ZGlvRGVzdGluYXRpb25DaHJvbWl1bS5oIGIvU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvQXVkaW9EZXN0aW5hdGlvbkNocm9taXVtLmgKaW5kZXggN2IxNDhjNDY0 ODgyYTY5ZGRlYzlkMjVkYjZjNjE4NDlmMTQ3OGVjNy4uOGVkNDY2NWU0NjMwZjY2NjRjMWQyYzAx YWI0ZDBmZDUzZDY1YWU1YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMv QXVkaW9EZXN0aW5hdGlvbkNocm9taXVtLmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvQXVkaW9EZXN0aW5hdGlvbkNocm9taXVtLmgKQEAgLTU4LDcgKzU4LDYgQEAgcHVibGljOgog CiAgICAgLy8gV2ViS2l0OjpXZWJBdWRpb0RldmljZTo6UmVuZGVyQ2FsbGJhY2sKICAgICB2aXJ0 dWFsIHZvaWQgcmVuZGVyKGNvbnN0IFdlYktpdDo6V2ViVmVjdG9yPGZsb2F0Kj4mIHNvdXJjZURh dGEsIGNvbnN0IFdlYktpdDo6V2ViVmVjdG9yPGZsb2F0Kj4mIGF1ZGlvRGF0YSwgc2l6ZV90IG51 bWJlck9mRnJhbWVzKTsKLSAgICB2aXJ0dWFsIHZvaWQgcmVuZGVyKGNvbnN0IFdlYktpdDo6V2Vi VmVjdG9yPGZsb2F0Kj4mIGF1ZGlvRGF0YSwgc2l6ZV90IG51bWJlck9mRnJhbWVzKTsKIAogICAg IC8vIFdlYkNvcmU6OkF1ZGlvU291cmNlUHJvdmlkZXIKICAgICB2aXJ0dWFsIHZvaWQgcHJvdmlk ZUlucHV0KEF1ZGlvQnVzKiwgc2l6ZV90IGZyYW1lc1RvUHJvY2Vzcyk7Cg==