106394 2013-01-08 16:11:32 -0800 If ImageLoader's loadEventSender or errorEventSender fires after document is detached, the document will be leaked. 2013-01-09 10:53:38 -0800 1 1 1 Unclassified WebKit Images 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 yongjun_zhang webkit-unassigned ddkilzer japhet webkit.review.bot yongjun_zhang oldest_to_newest 802765 0 yongjun_zhang 2013-01-08 16:11:32 -0800 If load the following HTML into OS X Safari and use heap to count the number of HTMLDocuments, you will see the number keeps growing, which indicates HTMLDocuments are not released. <html> <script type="text/javascript"> window.addEventListener('DOMContentLoaded', function () { setTimeout(function() {location.reload();}, 100); for (var k=0; k<2000; k++) { setTimeout(function () { for (var i=0; i<20; i++) { var bubble = document.createElement('img'); bubble.src = "http://www.myfakeserver.com/fake_image.png"; document.getElementById('map_439582365').appendChild(bubble); } }, k*25/10); } }, false); </script> <div id="map_439582365"> </div> </body></html> 802767 1 yongjun_zhang 2013-01-08 16:13:53 -0800 rdar://problem/12910603 802842 2 181811 yongjun_zhang 2013-01-08 17:22:54 -0800 Created attachment 181811 Also deref the element in dispatchPendingLoadEvent and dispatchPendingErrorEvent if the document was detached. 803433 3 181811 ap 2013-01-09 10:05:32 -0800 Comment on attachment 181811 Also deref the element in dispatchPendingLoadEvent and dispatchPendingErrorEvent if the document was detached. Great catch! 803437 4 ddkilzer 2013-01-09 10:07:07 -0800 <rdar://problem/12910603> 803464 5 181811 yongjun_zhang 2013-01-09 10:33:31 -0800 Comment on attachment 181811 Also deref the element in dispatchPendingLoadEvent and dispatchPendingErrorEvent if the document was detached. thanks ap! 803491 6 181811 webkit.review.bot 2013-01-09 10:53:34 -0800 Comment on attachment 181811 Also deref the element in dispatchPendingLoadEvent and dispatchPendingErrorEvent if the document was detached. Clearing flags on attachment: 181811 Committed r139209: <http://trac.webkit.org/changeset/139209> 803492 7 webkit.review.bot 2013-01-09 10:53:38 -0800 All reviewed patches have been landed. Closing bug. 181811 2013-01-08 17:22:54 -0800 2013-01-09 10:53:34 -0800 Also deref the element in dispatchPendingLoadEvent and dispatchPendingErrorEvent if the document was detached. imageloader_leak_document.patch text/plain 2825 yongjun_zhang SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzOTEzMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDEzLTAxLTA4ICBZb25nanVu IFpoYW5nICA8eW9uZ2p1bl96aGFuZ0BhcHBsZS5jb20+CisKKyAgICAgICAgSWYgSW1hZ2VMb2Fk ZXIncyBsb2FkRXZlbnRTZW5kZXIgb3IgZXJyb3JFdmVudFNlbmRlciBmaXJlcyBhZnRlciBkb2N1 bWVudCBpcyBkZXRhY2hlZCwgdGhlIGRvY3VtZW50IHdpbGwgYmUgbGVha2VkLgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDYzOTQKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbWFnZUxvYWRlcidzIGxv YWRFdmVudFNlbmRlciBhbmQgZXJyb3JFdmVudFNlbmRlciBzY2hlZHVsZSBldmVudCBkaXNwYXRj aGluZyBpbiBzZXBhcmF0ZSB0aW1lcnMgYW5kIHJlZnMKKyAgICAgICAgdGhlIEVsZW1lbnQgaW4g dXBkYXRlZEhhc1BlbmRpbmdFdmVudC4gIElmIHRoZSBEb2N1bWVudCBpcyBkZXRhY2hlZCBiZWZv cmUgZWl0aGVyIGV2ZW50U2VuZGVyIGRpc3BhdGNoZXMsCisgICAgICAgIHdlIHdvdWxkIGxlYWsg dGhlIERvY3VtZW50IHNpbmNlIHdlIGJhaWwgb3V0IGVhcmx5IGluIGRpc3BhdGNoUGVuZGluZ0xv YWRFdmVudCBvciBkaXNwYXRjaFBlbmRpbmdFcnJvckV2ZW50LAorICAgICAgICB3aXRob3V0IGRl cmVmLWluZyB0aGUgRWxlbWVudCBpdHNlbGYuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiAgVmVy aWZpZWQgbWFudWFsbHkgYnkgdXNpbmcgaGVhcCB0b29sIHRvIGNvdW50IHRoZSBsaXZpbmcgSFRN TERvY3VtZW50cy4KKworICAgICAgICAqIGxvYWRlci9JbWFnZUxvYWRlci5jcHA6CisgICAgICAg IChXZWJDb3JlOjpJbWFnZUxvYWRlcjo6ZGlzcGF0Y2hQZW5kaW5nTG9hZEV2ZW50KTogYWxzbyBj YWxsIHVwZGF0ZWRIYXNQZW5kaW5nRXZlbnQgdG8gZGVyZWYgdGhlIEVsZW1lbnQgaWYKKyAgICAg ICAgICAgICAgICAgICAgdGhlIGRvY3VtZW50IGlzIGRldGFjaGVkLgorICAgICAgICAoV2ViQ29y ZTo6SW1hZ2VMb2FkZXI6OmRpc3BhdGNoUGVuZGluZ0Vycm9yRXZlbnQpOiBkaXR0by4KKwogMjAx My0wMS0wOCAgSGFqaW1lIE1vcnJpdGEgIDxtb3JyaXRhQGdvb2dsZS5jb20+CiAKICAgICAgICAg W1NoYWRvdyBET01dIERpc3RyaWJ1dGlvbiByZWxhdGVkIGNvZGUgb24gU2hhZG93Um9vdCBzaG91 bGQgYmUgbWluaW1pemVkLgpJbmRleDogU291cmNlL1dlYkNvcmUvbG9hZGVyL0ltYWdlTG9hZGVy LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvSW1hZ2VMb2FkZXIuY3Bw CShyZXZpc2lvbiAxMzkwNzYpCisrKyBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvSW1hZ2VMb2FkZXIu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MTQsMTAgKzQxNCw5IEBAIHZvaWQgSW1hZ2VMb2FkZXI6 OmRpc3BhdGNoUGVuZGluZ0xvYWRFdmUKICAgICAgICAgcmV0dXJuOwogICAgIGlmICghbV9pbWFn ZSkKICAgICAgICAgcmV0dXJuOwotICAgIGlmICghZG9jdW1lbnQoKS0+YXR0YWNoZWQoKSkKLSAg ICAgICAgcmV0dXJuOwogICAgIG1faGFzUGVuZGluZ0xvYWRFdmVudCA9IGZhbHNlOwotICAgIGRp c3BhdGNoTG9hZEV2ZW50KCk7CisgICAgaWYgKGRvY3VtZW50KCktPmF0dGFjaGVkKCkpCisgICAg ICAgIGRpc3BhdGNoTG9hZEV2ZW50KCk7CiAKICAgICAvLyBPbmx5IGNvbnNpZGVyIHVwZGF0aW5n IHRoZSBwcm90ZWN0aW9uIHJlZi1jb3VudCBvZiB0aGUgRWxlbWVudCBpbW1lZGlhdGVseSBiZWZv cmUgcmV0dXJuaW5nCiAgICAgLy8gZnJvbSB0aGlzIGZ1bmN0aW9uIGFzIGRvaW5nIHNvIG1pZ2h0 IHJlc3VsdCBpbiB0aGUgZGVzdHJ1Y3Rpb24gb2YgdGhpcyBJbWFnZUxvYWRlci4KQEAgLTQyOCwx MCArNDI3LDEzIEBAIHZvaWQgSW1hZ2VMb2FkZXI6OmRpc3BhdGNoUGVuZGluZ0Vycm9yRXYKIHsK ICAgICBpZiAoIW1faGFzUGVuZGluZ0Vycm9yRXZlbnQpCiAgICAgICAgIHJldHVybjsKLSAgICBp ZiAoIWRvY3VtZW50KCktPmF0dGFjaGVkKCkpCi0gICAgICAgIHJldHVybjsKICAgICBtX2hhc1Bl bmRpbmdFcnJvckV2ZW50ID0gZmFsc2U7Ci0gICAgY2xpZW50KCktPmltYWdlRWxlbWVudCgpLT5k aXNwYXRjaEV2ZW50KEV2ZW50OjpjcmVhdGUoZXZlbnROYW1lcygpLmVycm9yRXZlbnQsIGZhbHNl LCBmYWxzZSkpOworICAgIGlmIChkb2N1bWVudCgpLT5hdHRhY2hlZCgpKQorICAgICAgICBjbGll bnQoKS0+aW1hZ2VFbGVtZW50KCktPmRpc3BhdGNoRXZlbnQoRXZlbnQ6OmNyZWF0ZShldmVudE5h bWVzKCkuZXJyb3JFdmVudCwgZmFsc2UsIGZhbHNlKSk7CisKKyAgICAvLyBPbmx5IGNvbnNpZGVy IHVwZGF0aW5nIHRoZSBwcm90ZWN0aW9uIHJlZi1jb3VudCBvZiB0aGUgRWxlbWVudCBpbW1lZGlh dGVseSBiZWZvcmUgcmV0dXJuaW5nCisgICAgLy8gZnJvbSB0aGlzIGZ1bmN0aW9uIGFzIGRvaW5n IHNvIG1pZ2h0IHJlc3VsdCBpbiB0aGUgZGVzdHJ1Y3Rpb24gb2YgdGhpcyBJbWFnZUxvYWRlci4K KyAgICB1cGRhdGVkSGFzUGVuZGluZ0V2ZW50KCk7CiB9CiAKIHZvaWQgSW1hZ2VMb2FkZXI6OmRp c3BhdGNoUGVuZGluZ0JlZm9yZUxvYWRFdmVudHMoKQo=