106383 2013-01-08 14:28:00 -0800 ScrollingCoordinator touch event hit rects aren't converted to proper coordinates when in nested views 2013-01-10 11:42:04 -0800 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://code.google.com/p/chromium/issues/detail?id=168001 P2 Normal --- 1 leviw leviw andersca jamesr simon.fraser tonikitoo webkit.review.bot oldest_to_newest 802651 0 leviw 2013-01-08 14:28:00 -0800 We need to rects from nested views through convertToContainingView. 802677 1 181771 leviw 2013-01-08 14:48:05 -0800 Created attachment 181771 Patch 804048 2 181771 jamesr 2013-01-09 21:58:18 -0800 Comment on attachment 181771 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181771&action=review > Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:188 > + if (!r.isEmpty()) { whole lotta' indentation here. can we get some early returns? 804491 3 181771 leviw 2013-01-10 10:07:43 -0800 Comment on attachment 181771 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181771&action=review >> Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:188 >> + if (!r.isEmpty()) { > > whole lotta' indentation here. can we get some early returns? Good point. Done. 804591 4 leviw 2013-01-10 11:42:04 -0800 Committed in http://trac.webkit.org/changeset/139346. 181771 2013-01-08 14:48:05 -0800 2013-01-10 11:41:48 -0800 Patch bug-106383-20130108144509.patch text/plain 6623 leviw SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzOTExNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAxLTA4ICBMZXZpIFdl aW50cmF1YiAgPGxldml3QGNocm9taXVtLm9yZz4KKworICAgICAgICBTY3JvbGxpbmdDb29yZGlu YXRvciB0b3VjaCBldmVudCBoaXQgcmVjdHMgYXJlbid0IGNvbnZlcnRlZCB0byBwcm9wZXIgY29v cmRpbmF0ZXMgd2hlbiBpbiBuZXN0ZWQgdmlld3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNjM4MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFNjcm9sbGluZ0Nvb3JkaW5hdG9yIHVzZXMgY2xpcHBlZE92 ZXJmbG93UmVjdEZvclJlcGFpbnQoMCkgdG8gZ2VuZXJhdGUgdGhlIGJvdW5kcyBmb3IgYSByZW5k ZXJlcidzIGhpdAorICAgICAgICB0ZXN0aW5nIHJlY3QuIFRoZSByZWN0IHRoaXMgcmV0dXJucyBp cyBpbiB0aGUgY29vcmRpbmF0ZXMgb2YgaXRzIGRvY3VtZW50LiBUaGlzIGNoYW5nZSBjb252ZXJ0 cyB0aGUKKyAgICAgICAgcmVjdCB0byB0aGUgb3V0ZXJtb3N0IHZpZXcncyBjb29yZGluYXRlIHN5 c3RlbSB1c2luZyBjb252ZXJ0VG9Db250YWluaW5nVmlldy4KKworICAgICAgICBUZXN0czogcGxh dGZvcm0vY2hyb21pdW0vZmFzdC9ldmVudHMvdG91Y2gvdG91Y2gtaGl0LXJlY3RzLWluLWlmcmFt ZS5odG1sCisKKyAgICAgICAgKiBwYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdDb29yZGluYXRvci5j cHA6CisgICAgICAgIChXZWJDb3JlOjphY2N1bXVsYXRlUmVuZGVyZXJUb3VjaEV2ZW50VGFyZ2V0 UmVjdHMpOgorCiAyMDEzLTAxLTA4ICBUb20gU2VwZXogIDx0c2VwZXpAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIENvcHktcGFzdGUgcHJlc2VydmVzIDxlbWJlZD4gdGFncyBjb250YWluaW5nIGFj dGl2ZSBjb250ZW50LgpJbmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xs aW5nQ29vcmRpbmF0b3IuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Ny b2xsaW5nL1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmNwcAkocmV2aXNpb24gMTM5MDAxKQorKysgU291 cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nQ29vcmRpbmF0b3IuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0xODUsOSArMTg1LDE2IEBAIHN0YXRpYyB2b2lkIGFjY3VtdWxhdGVSZW5k ZXJlclRvdWNoRXZlbnQKICAgICBpZiAocGFyZW50UmVjdC5pc0VtcHR5KCkgfHwgcmVuZGVyZXIt PmlzRmxvYXRpbmcoKSB8fCByZW5kZXJlci0+aXNQb3NpdGlvbmVkKCkgfHwgcmVuZGVyZXItPmhh c1RyYW5zZm9ybSgpKSB7CiAgICAgICAgIC8vIEZJWE1FOiBUaGlzIG1ldGhvZCBpcyBPKE5eMikg YXMgaXQgd2Fsa3MgdGhlIHRyZWUgdG8gdGhlIHJvb3QgZm9yIGV2ZXJ5IHJlbmRlcmVyLiBSZW5k ZXJHZW9tZXRyeU1hcCB3b3VsZCBmaXggdGhpcy4KICAgICAgICAgSW50UmVjdCByID0gZW5jbG9z aW5nSW50UmVjdChyZW5kZXJlci0+Y2xpcHBlZE92ZXJmbG93UmVjdEZvclJlcGFpbnQoMCkpOwot ICAgICAgICBpZiAoIXIuaXNFbXB0eSgpICYmICFwYXJlbnRSZWN0LmNvbnRhaW5zKHIpKSB7Ci0g ICAgICAgICAgICByZWN0cy5hcHBlbmQocik7Ci0gICAgICAgICAgICBhZGp1c3RlZFBhcmVudFJl Y3QgPSByOworICAgICAgICBpZiAoIXIuaXNFbXB0eSgpKSB7CisgICAgICAgICAgICAvLyBDb252 ZXJ0IHRvIHRoZSB0b3AtbGV2ZWwgdmlldydzIGNvb3JkaW5hdGVzLgorICAgICAgICAgICAgQVNT RVJUKHJlbmRlcmVyLT5kb2N1bWVudCgpLT52aWV3KCkpOworICAgICAgICAgICAgZm9yIChTY3Jv bGxWaWV3KiB2aWV3ID0gcmVuZGVyZXItPmRvY3VtZW50KCktPnZpZXcoKTsgdmlldyAmJiB2aWV3 LT5wYXJlbnQoKTsgdmlldyA9IHZpZXctPnBhcmVudCgpKQorICAgICAgICAgICAgICAgIHIgPSB2 aWV3LT5jb252ZXJ0VG9Db250YWluaW5nVmlldyhyKTsKKworICAgICAgICAgICAgaWYgKCFwYXJl bnRSZWN0LmNvbnRhaW5zKHIpKSB7CisgICAgICAgICAgICAgICAgcmVjdHMuYXBwZW5kKHIpOwor ICAgICAgICAgICAgICAgIGFkanVzdGVkUGFyZW50UmVjdCA9IHI7CisgICAgICAgICAgICB9CiAg ICAgICAgIH0KICAgICB9CiAKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzOTExNCkKKysrIExheW91dFRl c3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAxLTA4 ICBMZXZpIFdlaW50cmF1YiAgPGxldml3QGNocm9taXVtLm9yZz4KKworICAgICAgICBTY3JvbGxp bmdDb29yZGluYXRvciB0b3VjaCBldmVudCBoaXQgcmVjdHMgYXJlbid0IGNvbnZlcnRlZCB0byBw cm9wZXIgY29vcmRpbmF0ZXMgd2hlbiBpbiBuZXN0ZWQgdmlld3MKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNjM4MworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vZmFzdC9l dmVudHMvdG91Y2gvcmVzb3VyY2VzOiBBZGRlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1 bS9mYXN0L2V2ZW50cy90b3VjaC9yZXNvdXJjZXMvZnJhbWUtd2l0aC10b3VjaC1oYW5kbGVyLmh0 bWw6IEFkZGVkLgorICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL2Zhc3QvZXZlbnRzL3RvdWNo L3RvdWNoLWhpdC1yZWN0cy1pbi1pZnJhbWUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAg KiBwbGF0Zm9ybS9jaHJvbWl1bS9mYXN0L2V2ZW50cy90b3VjaC90b3VjaC1oaXQtcmVjdHMtaW4t aWZyYW1lLmh0bWw6IEFkZGVkLgorCiAyMDEzLTAxLTA4ICBEaW1pdHJpIEdsYXprb3YgIDxkZ2xh emtvdkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Nocm9taXVtXSBBIGJ1bmNoIG9mIGZhc3Qv Y3NzLWdyaWQtbGF5b3V0IHRlc3RzIHN0YXJ0ZWQgdGltaW5nIG91dCBhZnRlciByMTM5MDI1LgpJ bmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vZmFzdC9ldmVudHMvdG91Y2gvdG91 Y2gtaGl0LXJlY3RzLWluLWlmcmFtZS1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vZmFzdC9ldmVudHMvdG91Y2gvdG91Y2gtaGl0LXJlY3Rz LWluLWlmcmFtZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9wbGF0 Zm9ybS9jaHJvbWl1bS9mYXN0L2V2ZW50cy90b3VjaC90b3VjaC1oaXQtcmVjdHMtaW4taWZyYW1l LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw0IEBACitUaGlzIHRlc3QgdmFs aWRhdGVzIHRoYXQgdG91Y2ggaGl0IHRlc3RzIHJlY3RzIGFyZSBjcmVhdGVkIGluIHRoZSBjb29y ZGluYXRlcyBvZiB0aGUgb3V0ZXJtb3N0IHZpZXcsIG5vdCB0aGVpciBjb250YWluaW5nIHZpZXcu IFRoaXMgdGVzdCBvbmx5IHdvcmtzIGluIER1bXBSZW5kZXJUcmVlLgorWzBdOiAoNjAsIDExMCwg NTAsIDUwKQorWzFdOiAoNDIwLCAxNzAsIDUwLCA1MCkKKwpJbmRleDogTGF5b3V0VGVzdHMvcGxh dGZvcm0vY2hyb21pdW0vZmFzdC9ldmVudHMvdG91Y2gvdG91Y2gtaGl0LXJlY3RzLWluLWlmcmFt ZS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL2Zhc3Qv ZXZlbnRzL3RvdWNoL3RvdWNoLWhpdC1yZWN0cy1pbi1pZnJhbWUuaHRtbAkocmV2aXNpb24gMCkK KysrIExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL2Zhc3QvZXZlbnRzL3RvdWNoL3RvdWNo LWhpdC1yZWN0cy1pbi1pZnJhbWUuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw1NyBAQAor PCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorPHN0eWxlPgorI2lmcmFtZTEgeworCXBv c2l0aW9uOiBhYnNvbHV0ZTsKKwl0b3A6IDEwMHB4OworCWxlZnQ6IDUwcHg7CisJd2lkdGg6IDIw MHB4OworCWhlaWdodDogMjAwcHg7Cit9CisjaWZyYW1lMiB7CisJcG9zaXRpb246IGFic29sdXRl OworCXRvcDogMTAwcHg7CisJbGVmdDogNDAwcHg7CisJd2lkdGg6IDIwMHB4OworCWhlaWdodDog MjAwcHg7Cit9Cis8L3N0eWxlPgorPGJvZHkgb25sb2FkPSJydW5UZXN0KCk7Ij4KKzxkaXY+VGhp cyB0ZXN0IHZhbGlkYXRlcyB0aGF0IHRvdWNoIGhpdCB0ZXN0cyByZWN0cyBhcmUgY3JlYXRlZCBp biB0aGUgY29vcmRpbmF0ZXMgb2YgdGhlIG91dGVybW9zdCB2aWV3LCBub3QgdGhlaXIgY29udGFp bmluZyB2aWV3LgorVGhpcyB0ZXN0IG9ubHkgd29ya3MgaW4gRHVtcFJlbmRlclRyZWUuPC9kaXY+ Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxpZnJhbWUgaWQ9ImlmcmFtZTEiIHNyYz0icmVz b3VyY2VzL2ZyYW1lLXdpdGgtdG91Y2gtaGFuZGxlci5odG1sIj48L2lmcmFtZT4KKzxpZnJhbWUg aWQ9ImlmcmFtZTIiPjwvaWZyYW1lPgorPHNjcmlwdD4KKwordmFyIGlmcmFtZURvY3VtZW50ID0g ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImlmcmFtZTIiKS5jb250ZW50V2luZG93LmRvY3VtZW50 OworaWZyYW1lRG9jdW1lbnQub3BlbigndGV4dC9odG1sJywgJ3JlcGxhY2UnKTsKK2lmcmFtZURv Y3VtZW50LndyaXRlKCI8IURPQ1RZUEUgaHRtbD5cbjxodG1sPjxib2R5PjxpZnJhbWUgc3JjPVwi cmVzb3VyY2VzL2ZyYW1lLXdpdGgtdG91Y2gtaGFuZGxlci5odG1sXCIgc3R5bGU9XCJwb3NpdGlv bjogcmVsYXRpdmU7IHRvcDogNTBweDtcIj48L2lmcmFtZT48L2JvZHk+Iik7CitpZnJhbWVEb2N1 bWVudC5jbG9zZSgpOworCitmdW5jdGlvbiBsb2cobXNnKSB7CisJdmFyIHNwYW4gPSBkb2N1bWVu dC5jcmVhdGVFbGVtZW50KCJzcGFuIik7CisJZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImNvbnNv bGUiKS5hcHBlbmRDaGlsZChzcGFuKTsKKyAgICBzcGFuLmlubmVySFRNTCA9IG1zZyArICc8YnIg Lz4nOworfQorCitmdW5jdGlvbiBzb3J0UmVjdHMoYSwgYikgeworCXJldHVybiBhLnRvcCAtIGIu dG9wOworfQorCitmdW5jdGlvbiBydW5UZXN0KCkgeworCWlmICghd2luZG93LnRlc3RSdW5uZXIp CisJCXJldHVybjsKKwl3aW5kb3cudGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7CisKKwlyZWN0cyA9 IHdpbmRvdy5pbnRlcm5hbHMudG91Y2hFdmVudFRhcmdldENsaWVudFJlY3RzKGRvY3VtZW50KTsK Kwl2YXIgc29ydGVkUmVjdHMgPSBuZXcgQXJyYXkoKTsKKwlmb3IgKHZhciBpID0gMDsgaSA8IHJl Y3RzLmxlbmd0aDsgKytpKQorCQlzb3J0ZWRSZWN0c1tpXSA9IHJlY3RzW2ldOworCXNvcnRlZFJl Y3RzLnNvcnQoc29ydFJlY3RzKTsKKwlmb3IgKHZhciBpID0gMDsgaSA8IHJlY3RzLmxlbmd0aDsg KytpKQorCQlsb2coIlsiICsgaSArICJdOiAoIiArIHNvcnRlZFJlY3RzW2ldLmxlZnQgKyAiLCAi ICsgc29ydGVkUmVjdHNbaV0udG9wICsgIiwgIiArIHNvcnRlZFJlY3RzW2ldLndpZHRoICsgIiwg IiArIHNvcnRlZFJlY3RzW2ldLmhlaWdodCArICIpIik7Cit9Cis8L3NjcmlwdD4KKzwvYm9keT4K SW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL2Zhc3QvZXZlbnRzL3RvdWNoL3Jl c291cmNlcy9mcmFtZS13aXRoLXRvdWNoLWhhbmRsZXIuaHRtbAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9mYXN0L2V2ZW50cy90b3VjaC9yZXNvdXJjZXMvZnJh bWUtd2l0aC10b3VjaC1oYW5kbGVyLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9w bGF0Zm9ybS9jaHJvbWl1bS9mYXN0L2V2ZW50cy90b3VjaC9yZXNvdXJjZXMvZnJhbWUtd2l0aC10 b3VjaC1oYW5kbGVyLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsOCBAQAorPCFkb2N0eXBl IGh0bWw+Cis8aHRtbD4KKzxib2R5PgorPGRpdiBpZD0idG91Y2hUYXJnZXQiIHN0eWxlPSJ3aWR0 aDogNTBweDsgaGVpZ2h0OiA1MHB4OyBiYWNrZ3JvdW5kLWNvbG9yOiBibHVlOyIgb250b3VjaHN0 YXJ0PSJmdW5jdGlvbigpIHsgfTsiPjwvZGl2PgorPHNjcmlwdD4KK2RvY3VtZW50LmdldEVsZW1l bnRCeUlkKCJ0b3VjaFRhcmdldCIpLmFkZEV2ZW50TGlzdGVuZXIoInRvdWNoc3RhcnQiLCBmdW5j dGlvbigpIHsgfSwgZmFsc2UpOworPC9zY3JpcHQ+Cis8L2JvZHk+ClwgTm8gbmV3bGluZSBhdCBl bmQgb2YgZmlsZQo=