106380 2013-01-08 14:21:28 -0800 Add an Autoconf macro that checks whether a given feature is enabled 2013-01-08 16:32:07 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan mrobinson webkit.review.bot oldest_to_newest 802628 0 zan 2013-01-08 14:21:28 -0800 Add an Autoconf macro that checks whether a given feature is enabled 802634 1 181763 zan 2013-01-08 14:24:56 -0800 Created attachment 181763 Patch 802656 2 181763 zan 2013-01-08 14:28:44 -0800 Comment on attachment 181763 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181763&action=review > Source/autotools/webkitfeature.m4:23 > + m4_ifvaln([$3],[else $3])dnl The 'dnl's at the end of this and the previous line are meaningless, should be removed. 802660 3 181763 mrobinson 2013-01-08 14:30:14 -0800 Comment on attachment 181763 Patch Thanks! 802661 4 181769 zan 2013-01-08 14:30:55 -0800 Created attachment 181769 Patch 802667 5 181769 zan 2013-01-08 14:34:38 -0800 Comment on attachment 181769 Patch Interesting collision :> The first patch is in the commit queue, I'll just obsolete this one, clear the flags and wait for the landing, will remove the unnecessary 'dnl' line endings later. 802669 6 181769 zan 2013-01-08 14:36:33 -0800 Comment on attachment 181769 Patch The whole thing went bananas, the first patch is now out of the queue. Martin, could you please repeat the reviewing magic on this patch? 802792 7 181769 webkit.review.bot 2013-01-08 16:32:04 -0800 Comment on attachment 181769 Patch Clearing flags on attachment: 181769 Committed r139130: <http://trac.webkit.org/changeset/139130> 802793 8 webkit.review.bot 2013-01-08 16:32:07 -0800 All reviewed patches have been landed. Closing bug. 181763 2013-01-08 14:24:56 -0800 2013-01-08 14:30:51 -0800 Patch bug-106380-20130108232201.patch text/plain 1880 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5MTExCmRpZmYgLS1naXQgYS9Tb3VyY2UvYXV0b3Rvb2xz L3dlYmtpdGZlYXR1cmUubTQgYi9Tb3VyY2UvYXV0b3Rvb2xzL3dlYmtpdGZlYXR1cmUubTQKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMC4uMzg1NWU2N2IyZDgxOTdhMjc0MzI3NWI1ZjhmZTJiNzQwMDY5MWEzZgotLS0gL2Rl di9udWxsCisrKyBiL1NvdXJjZS9hdXRvdG9vbHMvd2Via2l0ZmVhdHVyZS5tNApAQCAtMCwwICsx LDI1IEBACitkbmwgQUNfQ0hFQ0tfV0VCS0lUX0ZFQVRVUkVfRU5BQkxFRAorZG5sIENoZWNrcyB3 aGV0aGVyIHRoZSBnaXZlbiBmZWF0dXJlIGlzIGVuYWJsZWQgaW4gdGhlCitkbmwgYnVpbGQgdGhh dCBpcyBiZWluZyBjb25maWd1cmVkLgorZG5sCitkbmwgVXNhZ2U6CitkbmwgQUNfQ0hFQ0tfV0VC S0lUX0ZFQVRVUkVfRU5BQkxFRChbRkVBVFVSRV0sIFtBQ1RJT05fSUZfRU5BQkxFRF0sIFtBQ1RJ T05fSUZfRElTQUJMRURdKQorCitBQ19ERUZVTihbQUNfQ0hFQ0tfV0VCS0lUX0ZFQVRVUkVfRU5B QkxFRF0sIFsKKyAgQUNfUFJPR19BV0sKKworICBkbmwgR3JlcCB0aGUgZ2VuZXJhdGVkIEdOVW1h a2VmaWxlLmZlYXR1cmVzLmFtCisgIGRubCB0byBkZXRlcm1pbmUgaWYgdGhlIHNwZWNpZmllZCBm ZWF0dXJlIGlzIGVuYWJsZWQuCisgIGdyZXAgLXFFICIoJDE9MSkiIFNvdXJjZS9XZWJDb3JlL0dO VW1ha2VmaWxlLmZlYXR1cmVzLmFtCisgIGlmIHRlc3QgJD8gLWVxIDA7IHRoZW4KKyAgICBmZWF0 dXJlX2VuYWJsZWQ9InRydWUiOworICBlbHNlCisgICAgZmVhdHVyZV9lbmFibGVkPSJmYWxzZSI7 CisgIGZpCisKKyAgZG5sIEV4ZWN1dGUgQUNUSU9OX0lGX0VOQUJMRUQgLyBBQ1RJT05fSUZfRElT QUJMRUQuCisgIGlmIHRlc3QgIiRmZWF0dXJlX2VuYWJsZWQiID0gInRydWUiIDsgdGhlbgorICAg IG00X2lmdmFsbihbJDJdLFskMl0sWzpdKWRubAorICAgIG00X2lmdmFsbihbJDNdLFtlbHNlICQz XSlkbmwKKyAgZmkKK10pIGRubCBBQ19DSEVDS19XRUJLSVRfRkVBVFVSRV9FTkFCTEVECmRpZmYg LS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggNDMzNDM0NDcxNmQ3MjY5N2UwZmRh MGVmNThmOGJmNzY3YTYyMWMzYi4uYTA3ZjIyZDFjMWMyZTdmNWUzMTc0N2M4OGUyODBlZWNiNzg1 ZDAxMSAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEzLTAxLTA4ICBaYW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CisK KyAgICAgICAgQWRkIGFuIEF1dG9jb25mIG1hY3JvIHRoYXQgY2hlY2tzIHdoZXRoZXIgYSBnaXZl biBmZWF0dXJlIGlzIGVuYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEwNjM4MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEFkZCB0aGUgQUNfQ0hFQ0tfV0VCS0lUX0ZFQVRVUkVfRU5BQkxFRCBtYWNy by4gSXQgY2hlY2tzIHRoZSBnZW5lcmF0ZWQKKyAgICAgICAgU291cmNlL1dlYkNvcmUvR05VbWFr ZWZpbGUuZmVhdHVyZXMuYW0gZmlsZSB0byBkZXRlcm1pbmUgd2hldGhlciB0aGUKKyAgICAgICAg Z2l2ZW4gZmVhdHVyZSBpcyBlbmFibGVkIG9yIGRpc2FibGVkIGluIHRoZSBidWlsZCB0aGF0J3Mg YmVpbmcgY29uZmlndXJlZC4KKworICAgICAgICAqIFNvdXJjZS9hdXRvdG9vbHMvd2Via2l0ZmVh dHVyZS5tNDogQWRkZWQuCisKIDIwMTMtMDEtMDMgIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmls bGFyQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gQWRkIFdlYlAgaW1hZ2Ugc3VwcG9ydAo= 181769 2013-01-08 14:30:55 -0800 2013-01-08 16:32:04 -0800 Patch bug-106380-20130108232800.patch text/plain 1874 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5MTExCmRpZmYgLS1naXQgYS9Tb3VyY2UvYXV0b3Rvb2xz L3dlYmtpdGZlYXR1cmUubTQgYi9Tb3VyY2UvYXV0b3Rvb2xzL3dlYmtpdGZlYXR1cmUubTQKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMC4uZmViMTI0NjZhNGIzNmE0MDU5MDdkZDNlN2NlNGZmMDk3ZjIzOGRmYQotLS0gL2Rl di9udWxsCisrKyBiL1NvdXJjZS9hdXRvdG9vbHMvd2Via2l0ZmVhdHVyZS5tNApAQCAtMCwwICsx LDI1IEBACitkbmwgQUNfQ0hFQ0tfV0VCS0lUX0ZFQVRVUkVfRU5BQkxFRAorZG5sIENoZWNrcyB3 aGV0aGVyIHRoZSBnaXZlbiBmZWF0dXJlIGlzIGVuYWJsZWQgaW4gdGhlCitkbmwgYnVpbGQgdGhh dCBpcyBiZWluZyBjb25maWd1cmVkLgorZG5sCitkbmwgVXNhZ2U6CitkbmwgQUNfQ0hFQ0tfV0VC S0lUX0ZFQVRVUkVfRU5BQkxFRChbRkVBVFVSRV0sIFtBQ1RJT05fSUZfRU5BQkxFRF0sIFtBQ1RJ T05fSUZfRElTQUJMRURdKQorCitBQ19ERUZVTihbQUNfQ0hFQ0tfV0VCS0lUX0ZFQVRVUkVfRU5B QkxFRF0sIFsKKyAgQUNfUFJPR19BV0sKKworICBkbmwgR3JlcCB0aGUgZ2VuZXJhdGVkIEdOVW1h a2VmaWxlLmZlYXR1cmVzLmFtCisgIGRubCB0byBkZXRlcm1pbmUgaWYgdGhlIHNwZWNpZmllZCBm ZWF0dXJlIGlzIGVuYWJsZWQuCisgIGdyZXAgLXFFICIoJDE9MSkiIFNvdXJjZS9XZWJDb3JlL0dO VW1ha2VmaWxlLmZlYXR1cmVzLmFtCisgIGlmIHRlc3QgJD8gLWVxIDA7IHRoZW4KKyAgICBmZWF0 dXJlX2VuYWJsZWQ9InRydWUiOworICBlbHNlCisgICAgZmVhdHVyZV9lbmFibGVkPSJmYWxzZSI7 CisgIGZpCisKKyAgZG5sIEV4ZWN1dGUgQUNUSU9OX0lGX0VOQUJMRUQgLyBBQ1RJT05fSUZfRElT QUJMRUQuCisgIGlmIHRlc3QgIiRmZWF0dXJlX2VuYWJsZWQiID0gInRydWUiIDsgdGhlbgorICAg IG00X2lmdmFsbihbJDJdLFskMl0sWzpdKQorICAgIG00X2lmdmFsbihbJDNdLFtlbHNlICQzXSkK KyAgZmkKK10pIGRubCBBQ19DSEVDS19XRUJLSVRfRkVBVFVSRV9FTkFCTEVECmRpZmYgLS1naXQg YS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggNDMzNDM0NDcxNmQ3MjY5N2UwZmRhMGVmNThm OGJmNzY3YTYyMWMzYi4uYTA3ZjIyZDFjMWMyZTdmNWUzMTc0N2M4OGUyODBlZWNiNzg1ZDAxMSAx MDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisy MDEzLTAxLTA4ICBaYW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CisKKyAgICAg ICAgQWRkIGFuIEF1dG9jb25mIG1hY3JvIHRoYXQgY2hlY2tzIHdoZXRoZXIgYSBnaXZlbiBmZWF0 dXJlIGlzIGVuYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEwNjM4MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEFkZCB0aGUgQUNfQ0hFQ0tfV0VCS0lUX0ZFQVRVUkVfRU5BQkxFRCBtYWNyby4gSXQg Y2hlY2tzIHRoZSBnZW5lcmF0ZWQKKyAgICAgICAgU291cmNlL1dlYkNvcmUvR05VbWFrZWZpbGUu ZmVhdHVyZXMuYW0gZmlsZSB0byBkZXRlcm1pbmUgd2hldGhlciB0aGUKKyAgICAgICAgZ2l2ZW4g ZmVhdHVyZSBpcyBlbmFibGVkIG9yIGRpc2FibGVkIGluIHRoZSBidWlsZCB0aGF0J3MgYmVpbmcg Y29uZmlndXJlZC4KKworICAgICAgICAqIFNvdXJjZS9hdXRvdG9vbHMvd2Via2l0ZmVhdHVyZS5t NDogQWRkZWQuCisKIDIwMTMtMDEtMDMgIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGln YWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gQWRkIFdlYlAgaW1hZ2Ugc3VwcG9ydAo=