106370 2013-01-08 13:14:43 -0800 [BlackBerry] Removing the totalusage variable in ChromeClientBB::exceededDatabaseQuota 2013-01-08 15:54:58 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 otcheung webkit-unassigned mifenton rwlbuis tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 802560 0 otcheung 2013-01-08 13:14:43 -0800 We no longer use that variable. 802563 1 181743 otcheung 2013-01-08 13:19:08 -0800 Created attachment 181743 Patch 802577 2 181743 yong.li.webkit 2013-01-08 13:30:29 -0800 Comment on attachment 181743 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181743&action=review > Source/WebKit/blackberry/ChangeLog:9 > + Removing totalUsage in ChromeClientBlackBerry as we no longer use that variable. > + > + [BlackBerry] Removing the totalusage variable in ChromeClientBB::exceededDatabaseQuota > + https://bugs.webkit.org/show_bug.cgi?id=106370 > + > + Reviewed by NOBODY (OOPS!). > + Line 3 should be moved to line 10? 802580 3 181748 otcheung 2013-01-08 13:32:03 -0800 Created attachment 181748 Patch 802755 4 181748 webkit.review.bot 2013-01-08 15:54:55 -0800 Comment on attachment 181748 Patch Clearing flags on attachment: 181748 Committed r139126: <http://trac.webkit.org/changeset/139126> 802756 5 webkit.review.bot 2013-01-08 15:54:58 -0800 All reviewed patches have been landed. Closing bug. 181743 2013-01-08 13:19:08 -0800 2013-01-08 13:31:59 -0800 Patch bug-106370-20130108161612.patch text/plain 1643 otcheung U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5MDk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCAxMDk4YTlkMzliNTU4NWU2OTg3Y2M2OTU2ZDNlOTBiNWE4NWVlYjY5Li4yMTFhMTkyZDVj NGZlMjFkNTg0MTczODBiNmQ2MTBlNGYzZjg3NTBjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMy0wMS0wOCAgT3R0byBEZXJlayBDaGV1bmcgIDxv dGNoZXVuZ0ByaW0uY29tPgorCisgICAgICAgIFJlbW92aW5nIHRvdGFsVXNhZ2UgaW4gQ2hyb21l Q2xpZW50QmxhY2tCZXJyeSBhcyB3ZSBubyBsb25nZXIgdXNlIHRoYXQgdmFyaWFibGUuCisKKyAg ICAgICAgW0JsYWNrQmVycnldIFJlbW92aW5nIHRoZSB0b3RhbHVzYWdlIHZhcmlhYmxlIGluIENo cm9tZUNsaWVudEJCOjpleGNlZWRlZERhdGFiYXNlUXVvdGEKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNjM3MAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50 QmxhY2tCZXJyeS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDaHJvbWVDbGllbnRCbGFja0JlcnJ5 OjpleGNlZWRlZERhdGFiYXNlUXVvdGEpOgorCiAyMDEzLTAxLTA4ICBNYXJrIExhbSAgPG1hcmsu bGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmVkIHRoZSBuZWVkIGZvciB0aGUgUHJvcG9z ZWREYXRhYmFzZSBtZWNoYW5pc20uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVy cnkvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50QmxhY2tCZXJyeS5jcHAgYi9Tb3VyY2UvV2Vi S2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50QmxhY2tCZXJyeS5jcHAK aW5kZXggNTgyYzRhODcxZTdmNGNmZTExOTI4ZTExNWNhZmM2MzA0OGVjNWQ0OS4uZmU1Yzg3M2U5 Y2M4YzJkMTMxZWY3Zjc0Mjg1MTg4YjBkMWZlZjhiMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEJsYWNrQmVycnkuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRC bGFja0JlcnJ5LmNwcApAQCAtNDk4LDcgKzQ5OCw2IEBAIHZvaWQgQ2hyb21lQ2xpZW50QmxhY2tC ZXJyeTo6ZXhjZWVkZWREYXRhYmFzZVF1b3RhKEZyYW1lKiBmcmFtZSwgY29uc3QgU3RyaW5nJiBu CiAKICAgICBEYXRhYmFzZU1hbmFnZXImIG1hbmFnZXIgPSBEYXRhYmFzZU1hbmFnZXI6Om1hbmFn ZXIoKTsKIAotICAgIHVuc2lnbmVkIGxvbmcgbG9uZyB0b3RhbFVzYWdlID0gdHJhY2tlci50b3Rh bERhdGFiYXNlVXNhZ2UoKTsKICAgICB1bnNpZ25lZCBsb25nIGxvbmcgb3JpZ2luVXNhZ2UgPSB0 cmFja2VyLnVzYWdlRm9yT3JpZ2luKG9yaWdpbik7CiAgICAgdW5zaWduZWQgbG9uZyBsb25nIGN1 cnJlbnRRdW90YSA9IHRyYWNrZXIucXVvdGFGb3JPcmlnaW4ob3JpZ2luKTsKIAo= 181748 2013-01-08 13:32:03 -0800 2013-01-08 15:54:55 -0800 Patch bug-106370-20130108162907.patch text/plain 1643 otcheung U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5MDk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCAxMDk4YTlkMzliNTU4NWU2OTg3Y2M2OTU2ZDNlOTBiNWE4NWVlYjY5Li4xMmJhMGI5YWI2 ODA1OThkNzAyZTQzMzBiMzM2YzMyMzEwOTI5MDVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMy0wMS0wOCAgT3R0byBEZXJlayBDaGV1bmcgIDxv dGNoZXVuZ0ByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBSZW1vdmluZyB0aGUgdG90 YWx1c2FnZSB2YXJpYWJsZSBpbiBDaHJvbWVDbGllbnRCQjo6ZXhjZWVkZWREYXRhYmFzZVF1b3Rh CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDYzNzAK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmlu ZyB0b3RhbFVzYWdlIGluIENocm9tZUNsaWVudEJsYWNrQmVycnkgYXMgd2Ugbm8gbG9uZ2VyIHVz ZSB0aGF0IHZhcmlhYmxlLgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50 QmxhY2tCZXJyeS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDaHJvbWVDbGllbnRCbGFja0JlcnJ5 OjpleGNlZWRlZERhdGFiYXNlUXVvdGEpOgorCiAyMDEzLTAxLTA4ICBNYXJrIExhbSAgPG1hcmsu bGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmVkIHRoZSBuZWVkIGZvciB0aGUgUHJvcG9z ZWREYXRhYmFzZSBtZWNoYW5pc20uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVy cnkvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50QmxhY2tCZXJyeS5jcHAgYi9Tb3VyY2UvV2Vi S2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50QmxhY2tCZXJyeS5jcHAK aW5kZXggNTgyYzRhODcxZTdmNGNmZTExOTI4ZTExNWNhZmM2MzA0OGVjNWQ0OS4uZmU1Yzg3M2U5 Y2M4YzJkMTMxZWY3Zjc0Mjg1MTg4YjBkMWZlZjhiMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEJsYWNrQmVycnkuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRC bGFja0JlcnJ5LmNwcApAQCAtNDk4LDcgKzQ5OCw2IEBAIHZvaWQgQ2hyb21lQ2xpZW50QmxhY2tC ZXJyeTo6ZXhjZWVkZWREYXRhYmFzZVF1b3RhKEZyYW1lKiBmcmFtZSwgY29uc3QgU3RyaW5nJiBu CiAKICAgICBEYXRhYmFzZU1hbmFnZXImIG1hbmFnZXIgPSBEYXRhYmFzZU1hbmFnZXI6Om1hbmFn ZXIoKTsKIAotICAgIHVuc2lnbmVkIGxvbmcgbG9uZyB0b3RhbFVzYWdlID0gdHJhY2tlci50b3Rh bERhdGFiYXNlVXNhZ2UoKTsKICAgICB1bnNpZ25lZCBsb25nIGxvbmcgb3JpZ2luVXNhZ2UgPSB0 cmFja2VyLnVzYWdlRm9yT3JpZ2luKG9yaWdpbik7CiAgICAgdW5zaWduZWQgbG9uZyBsb25nIGN1 cnJlbnRRdW90YSA9IHRyYWNrZXIucXVvdGFGb3JPcmlnaW4ob3JpZ2luKTsKIAo=